From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 391F1C77B78 for ; Wed, 3 May 2023 18:55:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 907C46B0078; Wed, 3 May 2023 14:55:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8B7BA6B007B; Wed, 3 May 2023 14:55:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7A6046B007D; Wed, 3 May 2023 14:55:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by kanga.kvack.org (Postfix) with ESMTP id 61FC06B0078 for ; Wed, 3 May 2023 14:55:13 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683140113; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0wQvdyQB5pPdHshJ2DLccYdmYWvyKpPO5JRJ2uuF8Xo=; b=K+N01InUp3y/bJWtd0WgpC/2JIq+T8RTqof2PLNj2LjIpAOxbwWEMKh78YAOW6XZRaVwug 1RDSarxgl1p0AI50Hyg32Fz//KoimU8aN4i1wlsG1ImPN/2mMSlXEaQlMCNIF80rv86bae zQNIw3CnmUKAp1hjRp9D2moFuNpxCmE= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-132-8tND3QyKMRCvOu967A9VsQ-1; Wed, 03 May 2023 14:55:06 -0400 X-MC-Unique: 8tND3QyKMRCvOu967A9VsQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 179CA800B35; Wed, 3 May 2023 18:55:06 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.191]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9C9ECC15BAE; Wed, 3 May 2023 18:55:04 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20230503154526.1223095-2-hch@lst.de> References: <20230503154526.1223095-2-hch@lst.de> <20230503154526.1223095-1-hch@lst.de> To: Christoph Hellwig Cc: dhowells@redhat.com, akpm@linux-foundation.org, jack@suse.cz, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, marc.dionne@auristor.com, linux-afs@lists.infradead.org Subject: Re: [PATCH 2/2] afs: fix the afs_dir_get_folio return value MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1916966.1683140103.1@warthog.procyon.org.uk> Date: Wed, 03 May 2023 19:55:03 +0100 Message-ID: <1916967.1683140103@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Christoph Hellwig wrote: > Keep returning NULL on failure instead of letting an ERR_PTR escape to > callers that don't expect it. > > Fixes: 66dabbb65d67 ("mm: return an ERR_PTR from __filemap_get_folio") > Reported-by: Jan Kara > Signed-off-by: Christoph Hellwig Reviewed-by: David Howells Tested-by: David Howells