From: David Howells <dhowells@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: dhowells@redhat.com, akpm@linux-foundation.org, jack@suse.cz,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
marc.dionne@auristor.com, linux-afs@lists.infradead.org
Subject: Re: [PATCH 2/2] afs: fix the afs_dir_get_folio return value
Date: Wed, 03 May 2023 19:55:03 +0100 [thread overview]
Message-ID: <1916967.1683140103@warthog.procyon.org.uk> (raw)
In-Reply-To: <20230503154526.1223095-2-hch@lst.de>
Christoph Hellwig <hch@lst.de> wrote:
> Keep returning NULL on failure instead of letting an ERR_PTR escape to
> callers that don't expect it.
>
> Fixes: 66dabbb65d67 ("mm: return an ERR_PTR from __filemap_get_folio")
> Reported-by: Jan Kara <jack@suse.cz>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: David Howells <dhowells@redhat.com>
Tested-by: David Howells <dhowells@redhat.com>
prev parent reply other threads:[~2023-05-03 18:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-03 15:45 [PATCH 1/2] filemap: fix the conditional folio_put in filemap_fault Christoph Hellwig
2023-05-03 15:45 ` [PATCH 2/2] afs: fix the afs_dir_get_folio return value Christoph Hellwig
2023-05-03 15:54 ` Jan Kara
2023-05-03 15:48 ` [PATCH 1/2] filemap: fix the conditional folio_put in filemap_fault Matthew Wilcox
2023-05-03 15:49 ` Christoph Hellwig
2023-05-04 3:34 ` Matthew Wilcox
2023-05-03 15:57 ` Jan Kara
2023-05-03 18:55 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1916967.1683140103@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=linux-afs@lists.infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=marc.dionne@auristor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox