From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2CF1C00140 for ; Thu, 18 Aug 2022 21:15:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4FD548D0003; Thu, 18 Aug 2022 17:15:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 485AD8D0002; Thu, 18 Aug 2022 17:15:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 327D88D0003; Thu, 18 Aug 2022 17:15:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 24A788D0002 for ; Thu, 18 Aug 2022 17:15:09 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id EADC5824DF for ; Thu, 18 Aug 2022 21:15:08 +0000 (UTC) X-FDA: 79813968696.06.5ABDB2E Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by imf03.hostedemail.com (Postfix) with ESMTP id BE64E20D21 for ; Thu, 18 Aug 2022 21:08:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1660856941; x=1692392941; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=GmkbBbjW1HbR2hnXSAPeOB4FglG3wvlQRjoDRd8WvxM=; b=FwV7FQD54+GbPqNtUhakLvXweFiRyi5YwyrYBUizUNGvOGfjVQM917kP WN1tZEFGxcs4Rt2k30noTz4P2l7gVaAuxvcQOvItafflJrb4VRUGDGYST JgY3Uj1xEDdFQgpyTDQvwC/MlZdVSQGpYG0P2W2VLW6ZBoX2kaUTbFuTS qQAnZUntmDTFKS3rDdBrH3OmG8f5wENpuGgOt5ylUazLCEizudW3nwk50 tBpKdIXssDVTD5Uq13kqIov3j0C3lG+IyYoGV9W89O/Y5TJ76Ucd1nuRV MfvYOYgx5eFGdg7xYlZCH9pGYoUuyBkFybVZ8JPnBAwEbQftrm0wpeALN g==; X-IronPort-AV: E=McAfee;i="6500,9779,10443"; a="354609704" X-IronPort-AV: E=Sophos;i="5.93,247,1654585200"; d="scan'208";a="354609704" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Aug 2022 14:07:46 -0700 X-IronPort-AV: E=Sophos;i="5.93,247,1654585200"; d="scan'208";a="853552702" Received: from tathomp-mobl.amr.corp.intel.com (HELO [10.212.238.171]) ([10.212.238.171]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Aug 2022 14:07:46 -0700 Message-ID: <19144f97-2b00-fed6-5395-0221bbc60802@intel.com> Date: Thu, 18 Aug 2022 14:07:45 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH RFC] mm, proc: add PcpFree to meminfo Content-Language: en-US To: Kefeng Wang , Andrew Morton , Greg Kroah-Hartman , linux-mm@kvack.org, Aaron Lu , Michal Hocko , Jesper Dangaard Brouer , Vlastimil Babka , Kemi Wang Cc: linux-kernel@vger.kernel.org, Liu Shixin References: <20220816084426.135528-1-wangkefeng.wang@huawei.com> <99556483-9f22-4597-8270-b4414cc97e64@huawei.com> From: Dave Hansen In-Reply-To: <99556483-9f22-4597-8270-b4414cc97e64@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660856941; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nkZ8p6YDWW1S0yUBn7ao/dO9TekM9Bwoz3aylwCyQl4=; b=dDMsNOMrQFT7k/fEK0n4VwvVB5bnyDf4Z4hcRknBcUtA/Amv3oIniwoAAiVzXJDsgmw3HT ShriGXtfCOUW7Bfy/YsT9ml2fm6u5z0UGysqDGW6a/iMM83DapE+GSbAZw9V82dSiBFLjK IJzN0bEXovLyga+HUyeV4hdCGY/wBTk= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=FwV7FQD5; spf=pass (imf03.hostedemail.com: domain of dave.hansen@intel.com designates 134.134.136.31 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660856941; a=rsa-sha256; cv=none; b=LLW1fzfOqxkHsLbZM+/M76iERPvmMfthkX5xb5WaJ3+SP1yqD/ew1+ef0uhpQh5/YW4uLZ kKimM1JHHCJcHPGgcf7W3/RlGOACgZcgDcz2VgnrDETp+Zsr6xL/j8atD4a2Z2pw3ih3aO 7F5C5HcBPCTYQWz2BL6a6vzSOLvySRY= X-Rspam-User: Authentication-Results: imf03.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=FwV7FQD5; spf=pass (imf03.hostedemail.com: domain of dave.hansen@intel.com designates 134.134.136.31 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com X-Stat-Signature: trtjpjmn3fcjzk9obkpe3taxrfmsxeta X-Rspamd-Queue-Id: BE64E20D21 X-Rspamd-Server: rspam05 X-HE-Tag: 1660856939-372993 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 8/17/22 00:16, Kefeng Wang wrote: > On 2022/8/16 16:44, Kefeng Wang wrote: >> From: Liu Shixin >> >> The page on pcplist could be used, but not counted into memory free or >> avaliable, and pcp_free is only showed by show_mem(). Since commit >> d8a759b57035 ("mm, page_alloc: double zone's batchsize"), there is a >> significant decrease in the display of free memory, with a large number >> of cpus and nodes, the number of pages in the percpu list can be very >> large, so it is better to let user to know the pcp count. > Add more experts according to commit d8a759b57035， > any advice would be much appreciated，thanks. Adding a new meminfo field seems like overkill. I'd just make this a part of MemFree if anything. Also, some actual data would be nice here. Like: Before commit d8a759b57035, the maximum amount of pages in the pcp lists was theoretically $FOO MB. After the patch, the lists can hold $BAR MB. It has been observed to be $BAZ MB in practice. This was all on a system with $X memory NUMA nodes and $Y CPUs.