linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Dave Hansen <dave.hansen@intel.com>
To: Kefeng Wang <wangkefeng.wang@huawei.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-mm@kvack.org, Aaron Lu <aaron.lu@intel.com>,
	Michal Hocko <mhocko@suse.com>,
	Jesper Dangaard Brouer <brouer@redhat.com>,
	Vlastimil Babka <vbabka@suse.cz>, Kemi Wang <kemi.wang@intel.com>
Cc: linux-kernel@vger.kernel.org, Liu Shixin <liushixin2@huawei.com>
Subject: Re: [PATCH RFC] mm, proc: add PcpFree to meminfo
Date: Thu, 18 Aug 2022 14:07:45 -0700	[thread overview]
Message-ID: <19144f97-2b00-fed6-5395-0221bbc60802@intel.com> (raw)
In-Reply-To: <99556483-9f22-4597-8270-b4414cc97e64@huawei.com>

On 8/17/22 00:16, Kefeng Wang wrote:
> On 2022/8/16 16:44, Kefeng Wang wrote:
>> From: Liu Shixin <liushixin2@huawei.com>
>>
>> The page on pcplist could be used, but not counted into memory free or
>> avaliable, and pcp_free is only showed by show_mem(). Since commit
>> d8a759b57035 ("mm, page_alloc: double zone's batchsize"), there is a
>> significant decrease in the display of free memory, with a large number
>> of cpus and nodes, the number of pages in the percpu list can be very
>> large, so it is better to let user to know the pcp count.
> Add more experts according to commit d8a759b57035,
> any advice would be much appreciated,thanks.

Adding a new meminfo field seems like overkill.  I'd just make this a
part of MemFree if anything.

Also, some actual data would be nice here.  Like:

	Before commit d8a759b57035, the maximum amount of pages in the
	pcp lists was theoretically $FOO MB.  After the patch, the lists
	can hold $BAR MB.  It has been observed to be $BAZ MB in
	practice.

	This was all on a system with $X memory NUMA nodes and $Y CPUs.



  reply	other threads:[~2022-08-18 21:15 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-16  8:44 Kefeng Wang
2022-08-16  8:48 ` huang ying
2022-08-16  9:24   ` Kefeng Wang
2022-08-19  7:40     ` Aaron Lu
2022-08-19  9:53       ` Liu Shixin
2022-08-19 10:02         ` Aaron Lu
2022-08-22  7:27         ` Michal Hocko
2022-08-16  9:16 ` Greg Kroah-Hartman
2022-08-16 10:11   ` Kefeng Wang
2022-08-16 10:50     ` Greg Kroah-Hartman
2022-08-16 12:03       ` Kefeng Wang
2022-08-17  7:16 ` Kefeng Wang
2022-08-18 21:07   ` Dave Hansen [this message]
2022-08-19  1:06     ` Kefeng Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19144f97-2b00-fed6-5395-0221bbc60802@intel.com \
    --to=dave.hansen@intel.com \
    --cc=aaron.lu@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=brouer@redhat.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kemi.wang@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=liushixin2@huawei.com \
    --cc=mhocko@suse.com \
    --cc=vbabka@suse.cz \
    --cc=wangkefeng.wang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox