From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53162C77B78 for ; Wed, 26 Apr 2023 11:43:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8BA066B00C9; Wed, 26 Apr 2023 07:43:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 841336B00CA; Wed, 26 Apr 2023 07:43:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6BA9D6B00CB; Wed, 26 Apr 2023 07:43:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 592D96B00C9 for ; Wed, 26 Apr 2023 07:43:56 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 262FE40283 for ; Wed, 26 Apr 2023 11:43:56 +0000 (UTC) X-FDA: 80723358072.11.4E6C030 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by imf09.hostedemail.com (Postfix) with ESMTP id CBB08140017 for ; Wed, 26 Apr 2023 11:43:52 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=aiKsoFcu; spf=pass (imf09.hostedemail.com: domain of zhangpeng.00@bytedance.com designates 209.85.214.177 as permitted sender) smtp.mailfrom=zhangpeng.00@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682509434; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SffcOdPFYwFBhUJALuYvbVJpxK8qpMoV7ZnXznDGJxU=; b=LOQjXkcaK+VGQHPBenvvluBYU3AyEOQXlRfbdFADVl27ByqWxT60gHdmGmkUbNR2X+p8A8 SCtHVJorOc6KMkW3WQxrqrmU7cLTSpdNX/s2iJ8Nm+DfTQXH7myNXx6aw1J0ClnQ16n7UK sgBcNGu7tDbEBoZZ6a+YNOJEVYbyuAY= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=aiKsoFcu; spf=pass (imf09.hostedemail.com: domain of zhangpeng.00@bytedance.com designates 209.85.214.177 as permitted sender) smtp.mailfrom=zhangpeng.00@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682509434; a=rsa-sha256; cv=none; b=4WOFAxr7Qj/4atHDK2HH+wg+UIXfIXC4/Dwkd6fZnIIzmQ76psw9csNwxTrs3wmJbqURTj lKli+OsRX0oG/4IFp5MRkviCM6wjcySWh3HhnHf7Ml8ef0B1Zkhn7OADlWUDQQ/sz8L1iJ 0AFdT4XZvBcEeOaCV9aCRQeQGeKFML0= Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-1a6ebc66ca4so53147555ad.3 for ; Wed, 26 Apr 2023 04:43:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1682509431; x=1685101431; h=content-transfer-encoding:in-reply-to:from:references:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=SffcOdPFYwFBhUJALuYvbVJpxK8qpMoV7ZnXznDGJxU=; b=aiKsoFcuQ3/rvu7ijYNZLVivEeqZwES90MiJVM7/pm+XuKpyc1P/K36Nyz8bphEPuD f47kr6cdI0l5OTvvxLNoZdd6L47KyPEbUmcLnAom/60XFqhoFa12cmt9m8Rr5ePJFTbD G+5Y4IxsaEPUTCKVu+/0nVVFfRQhLU26MuT16euC3Gq5+d5Genz6rJuv3I0cPxDjkDrZ lMnUMpTlvBGxQIGy/kyHTzbL3NJ81OWq1hqFid1JRDsc35WRaAmiWR0Dz/TveRolN/gO 64Z5A+xhhrSfjJ0SJROlPh7yS6C0MUoKbWCwzfYoR/s2EzVjBoW7SPnizZSE5jhVL7rI 9A1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682509431; x=1685101431; h=content-transfer-encoding:in-reply-to:from:references:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=SffcOdPFYwFBhUJALuYvbVJpxK8qpMoV7ZnXznDGJxU=; b=RbACkJx2evbSI0Gw/TGdL1c8EoKh0F+wJoQ6apE65Z+yzROceoYGUTzFsRebfy9If6 ps8WURep+czavnXSSWXithMm6b2+MTBYfdXSTV5AGlStFxB7FldgQNmoS6R13K7K8AcH R3XvdW6ba4gri/6aN39AzyimqlcKbPmBVDf+oR+deBqVhVKyXNw13MxydhMpGTRHRSEU uLVTjgcDfYz1MxbCN4BVv9JyywzU4XYm5mSbNHMjsSWQKNwfBxhVWm/UwhptdD1DOOFu yMhv5S7gwe1A431QSmBZvxmZMnWxXlwc+zgWf3zMGYCEYB+VXCpPelDQihVVnPrzwmCR lJ0g== X-Gm-Message-State: AC+VfDwVxeiyzdx+Wo/96TtUgbwNjAgychxCwmKAlhqJDb85FVYu27hU x8I8xFBjCe6dFdVF3BKRk9jBdw== X-Google-Smtp-Source: ACHHUZ48IbgMVJXJeGs36QJMmIaB7yhNYon5UCBibgZxmSqy/qWbJ58UNy97GbLoop2nzlqpHuPfvg== X-Received: by 2002:a17:902:ea02:b0:1a9:7bf4:17c0 with SMTP id s2-20020a170902ea0200b001a97bf417c0mr11250862plg.4.1682509431419; Wed, 26 Apr 2023 04:43:51 -0700 (PDT) Received: from [10.200.11.252] ([139.177.225.236]) by smtp.gmail.com with ESMTPSA id a13-20020a170902ee8d00b001a66bf1406bsm9814008pld.144.2023.04.26.04.43.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Apr 2023 04:43:51 -0700 (PDT) Message-ID: <19049997-7971-f39c-a466-dd4ba498a902@bytedance.com> Date: Wed, 26 Apr 2023 19:43:46 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH 7/9] maple_tree: Delete redundant code in mas_next_node() To: "Liam R. Howlett" , Peng Zhang , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org References: <20230425110511.11680-1-zhangpeng.00@bytedance.com> <20230425110511.11680-8-zhangpeng.00@bytedance.com> <20230425164507.dulntzwtkm5mp4ia@revolver> From: Peng Zhang In-Reply-To: <20230425164507.dulntzwtkm5mp4ia@revolver> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: CBB08140017 X-Stat-Signature: j9555a5fbs688bfjc3o7b9433wqbx8jx X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1682509432-940248 X-HE-Meta: U2FsdGVkX1821qhs6H4f2xZdNIkfxTqlmwJ9PU+pDH+eSZNfAHX85s78iETaAd9SeFymYjQpUXIsFt9uacWm51QaBnfVm4niJdsWxYgwaFXuc/T+U9yTf+cU6qfIf8WwNoCf5RkZN22BTLczcI9kJrWVcc/N6+glW+JD611ASpiY5upzM5ncF0oohHlE1Blj3aZfdWMyHeXS56o238ovtWsZfWSZlp4oox09FHy+XPo2UXcuDBhZ/bnOU7G8a1ZKbOMsJ75bcsvrGZeEx2OM161/pGoeaAL2x/jm9I0UC7U+YjeNPCUJ7TB9yHd9O71eCpIpQ+MJd7pZUQyzxoLTcwq0JssvsKa3h7fRtYbqnti/NBLOnjsCZNLyHXawWY+0a7tjOAts23U2cd/rRLtWyEyRpriWuRolAgIYq2eMtNJb4Nv2jglmCdBumXSWgFCHbesU2L9EqGYINxAS8pp19txTq/dJ8fbIIi4oX10ziP2EaOVDoVHF1JA7r0m1PUx0PjAqt481s+jGbAkDSwGTaFRtCPM1jXt7PfhrlJ0NS+TPK6drnFMWO9g3tNNGjHSKrF+lOxgt+1WtCMfimiIsyI4SVZEPc/9k/jUDn1gypEdOR+B3n220sGX6DXAQV7t4Z+3zSnpVnfFGA/OB3Ssu69v+SAhAX9TsPe2FbwNGJQ9mm27rfbNyZzuyNPvZfxlMhAwe+MUfblrS/s/TA0OEuKFHlzep/triab4Hcb0vK/RoK869HQvWcTpWqivgSJ9WIBnW0kgdgCqCaRTMfCbECd6MNIMrxHUsM3z5zitoJ1oLHooW2M8c4sSaAjTBJWO10tlEbWoWYrKVFZNFvO/kFVW7u3xf077NSs/9mvUxbmJzKE8JCmz+hWeKYOaUKZ1i8YWGshXlxDFJ1874WTxD3H/aViTpsU9y865X1JiSPIOMo+pIcqYpuv0hcGpiVrv+tVktDSBTmZXWbbucgBD bFbAMPlI Lh50AFM+Fz9kgbSx23pzX+olyXvevtl1udOvvlW4CuYDq/nCuT3Q1pKReJwROeM/Ehw9E6XKHQNYxUGJ1M/c5QxszOLKBy8jXdrl9xLDrPRhSioTrWCdUF1wxUavO7dBE/W6PXAAhx2dZv8LkliMvjUhnCGYN5NJ8vSQ7DE+igGHa909lk5GEWpPboH8rGb5nUWYtuGfyuf3D2JSrBn8xlRmp6ZAaIj0habuPhvD/GmMGKAWdG3mAy2DaBMmf5Cho3+9EyXt4d47zEfd+SzjVa32T4H4jzo/k8RnYEw4+bSTrdjAOZ/n2Q1GliB3ME8fz9m2C6gLFwxpoHYMIXV5x43pBemKDhob3N72NjI1twAO7GV1dNgNgfeRMljd+CmrVp39mMzoXzRt5VvA5R1YZqC4XgI0aarpAygBJBq5fNgFhz4v6sU1m0MyvddddOM5Dp3Vbv05rUMP2OtU4SwLYHFT239ZrYqvzGerMTBFghbNLDOteqGSf6kMegSBszEpNZIImk7+ENf6uMnEB+MieL+eiW/MR8nVmF/TOnH4PEADCLjI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 在 2023/4/26 00:45, Liam R. Howlett 写道: > * Peng Zhang [230425 07:05]: > > The title of the patch seems wrong. > > This isn't redundant code and you aren't deleting it.. you are moving a > block of code outside a loop. You did modify the check though, is that > the redundant code? > >> When offset == node_end is satisfied, go to the parent node, mas->max >> will not change. So there is no need to update min on the move. > Please try not to state the code in your commit message. > > I have moved this block of code in patch 27/34 [1] > >> Signed-off-by: Peng Zhang >> --- >> lib/maple_tree.c | 7 ++----- >> 1 file changed, 2 insertions(+), 5 deletions(-) >> >> diff --git a/lib/maple_tree.c b/lib/maple_tree.c >> index 83441ef2e1f57..8bfa837b7b752 100644 >> --- a/lib/maple_tree.c >> +++ b/lib/maple_tree.c >> @@ -4616,7 +4616,8 @@ static inline int mas_next_node(struct ma_state *mas, struct maple_node *node, >> enum maple_type mt; >> void __rcu **slots; >> >> - if (mas->max >= max) >> + min = mas->max + 1; >> + if (min > max) >> goto no_entry; > What happens on overflow? Yes, I made a mistake. I will drop this patch since you have updated the code in patch 27/34. > >> >> level = 0; >> @@ -4624,10 +4625,6 @@ static inline int mas_next_node(struct ma_state *mas, struct maple_node *node, >> if (ma_is_root(node)) >> goto no_entry; >> >> - min = mas->max + 1; >> - if (min > max) >> - goto no_entry; >> - >> if (unlikely(mas_ascend(mas))) >> return 1; >> >> -- >> 2.20.1 >> > [1] https://lore.kernel.org/linux-mm/20230425140955.3834476-28-Liam.Howlett@oracle.com/