linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Chuck Lever <chuck.lever@oracle.com>
To: "Jeff Layton" <jlayton@kernel.org>,
	"Alexander Viro" <viro@zeniv.linux.org.uk>,
	"Christian Brauner" <brauner@kernel.org>,
	"Jan Kara" <jack@suse.cz>, "Steven Rostedt" <rostedt@goodmis.org>,
	"Masami Hiramatsu" <mhiramat@kernel.org>,
	"Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>,
	"Dan Williams" <dan.j.williams@intel.com>,
	"Eric Biggers" <ebiggers@kernel.org>,
	"Theodore Y. Ts'o" <tytso@mit.edu>,
	"Muchun Song" <muchun.song@linux.dev>,
	"Oscar Salvador" <osalvador@suse.de>,
	"David Hildenbrand" <david@kernel.org>,
	"David Howells" <dhowells@redhat.com>,
	"Paulo Alcantara" <pc@manguebit.org>,
	"Andreas Dilger" <adilger.kernel@dilger.ca>,
	"Jan Kara" <jack@suse.com>, "Jaegeuk Kim" <jaegeuk@kernel.org>,
	"Chao Yu" <chao@kernel.org>,
	"Trond Myklebust" <trondmy@kernel.org>,
	"Anna Schumaker" <anna@kernel.org>, NeilBrown <neil@brown.name>,
	"Olga Kornievskaia" <okorniev@redhat.com>,
	"Dai Ngo" <Dai.Ngo@oracle.com>, "Tom Talpey" <tom@talpey.com>,
	"Steve French" <sfrench@samba.org>,
	"Ronnie Sahlberg" <ronniesahlberg@gmail.com>,
	"Shyam Prasad N" <sprasad@microsoft.com>,
	"Bharath SM" <bharathsm@microsoft.com>,
	"Alexander Aring" <alex.aring@gmail.com>,
	"Ryusuke Konishi" <konishi.ryusuke@gmail.com>,
	"Viacheslav Dubeyko" <slava@dubeyko.com>,
	"Eric Van Hensbergen" <ericvh@kernel.org>,
	"Latchesar Ionkov" <lucho@ionkov.net>,
	"Dominique Martinet" <asmadeus@codewreck.org>,
	"Christian Schoenebeck" <linux_oss@crudebyte.com>,
	"David Sterba" <dsterba@suse.com>,
	"Marc Dionne" <marc.dionne@auristor.com>,
	"Ian Kent" <raven@themaw.net>,
	"Luis de Bethencourt" <luisbg@kernel.org>,
	"Salah Triki" <salah.triki@gmail.com>,
	"Tigran A. Aivazian" <aivazian.tigran@gmail.com>,
	"Ilya Dryomov" <idryomov@gmail.com>,
	"Alex Markuze" <amarkuze@redhat.com>,
	"Jan Harkes" <jaharkes@cs.cmu.edu>,
	coda@cs.cmu.edu, "Nicolas Pitre" <nico@fluxnic.net>,
	"Tyler Hicks" <code@tyhicks.com>,
	"Amir Goldstein" <amir73il@gmail.com>,
	"Christoph Hellwig" <hch@infradead.org>,
	"John Paul Adrian Glaubitz" <glaubitz@physik.fu-berlin.de>,
	"Yangtao Li" <frank.li@vivo.com>,
	"Mikulas Patocka" <mikulas@artax.karlin.mff.cuni.cz>,
	"David Woodhouse" <dwmw2@infradead.org>,
	"Richard Weinberger" <richard@nod.at>,
	"Dave Kleikamp" <shaggy@kernel.org>,
	"Konstantin Komarov" <almaz.alexandrovich@paragon-software.com>,
	"Mark Fasheh" <mark@fasheh.com>,
	"Joel Becker" <jlbec@evilplan.org>,
	"Joseph Qi" <joseph.qi@linux.alibaba.com>,
	"Mike Marshall" <hubcap@omnibond.com>,
	"Martin Brandenburg" <martin@omnibond.com>,
	"Miklos Szeredi" <miklos@szeredi.hu>,
	"Anders Larsen" <al@alarsen.net>,
	"Zhihao Cheng" <chengzhihao1@huawei.com>,
	"Damien Le Moal" <dlemoal@kernel.org>,
	"Naohiro Aota" <naohiro.aota@wdc.com>,
	"Johannes Thumshirn" <jth@kernel.org>,
	"John Johansen" <john.johansen@canonical.com>,
	"Paul Moore" <paul@paul-moore.com>,
	"James Morris" <jmorris@namei.org>,
	"Serge E. Hallyn" <serge@hallyn.com>,
	"Mimi Zohar" <zohar@linux.ibm.com>,
	"Roberto Sassu" <roberto.sassu@huawei.com>,
	"Dmitry Kasatkin" <dmitry.kasatkin@gmail.com>,
	"Eric Snowberg" <eric.snowberg@oracle.com>,
	"Fan Wu" <wufan@kernel.org>,
	"Stephen Smalley" <stephen.smalley.work@gmail.com>,
	"Ondrej Mosnacek" <omosnace@redhat.com>,
	"Casey Schaufler" <casey@schaufler-ca.com>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	"David Airlie" <airlied@gmail.com>,
	"Simona Vetter" <simona@ffwll.ch>,
	"Sumit Semwal" <sumit.semwal@linaro.org>,
	"Eric Dumazet" <edumazet@google.com>,
	"Kuniyuki Iwashima" <kuniyu@google.com>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Willem de Bruijn" <willemb@google.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Simon Horman" <horms@kernel.org>,
	"Oleg Nesterov" <oleg@redhat.com>,
	"Peter Zijlstra" <peterz@infradead.org>,
	"Ingo Molnar" <mingo@redhat.com>,
	"Arnaldo Carvalho de Melo" <acme@kernel.org>,
	"Namhyung Kim" <namhyung@kernel.org>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
	"Jiri Olsa" <jolsa@kernel.org>, "Ian Rogers" <irogers@google.com>,
	"Adrian Hunter" <adrian.hunter@intel.com>,
	"James Clark" <james.clark@linaro.org>,
	"Darrick J. Wong" <djwong@kernel.org>,
	"Martin Schiller" <ms@dev.tdt.de>,
	"Eric Paris" <eparis@redhat.com>,
	"Joerg Reuter" <jreuter@yaina.de>,
	"Marcel Holtmann" <marcel@holtmann.org>,
	"Johan Hedberg" <johan.hedberg@gmail.com>,
	"Luiz Augusto von Dentz" <luiz.dentz@gmail.com>,
	"Oliver Hartkopp" <socketcan@hartkopp.net>,
	"Marc Kleine-Budde" <mkl@pengutronix.de>,
	"David Ahern" <dsahern@kernel.org>,
	"Neal Cardwell" <ncardwell@google.com>,
	"Steffen Klassert" <steffen.klassert@secunet.com>,
	"Herbert Xu" <herbert@gondor.apana.org.au>,
	"Remi Denis-Courmont" <courmisch@gmail.com>,
	"Marcelo Ricardo Leitner" <marcelo.leitner@gmail.com>,
	"Xin Long" <lucien.xin@gmail.com>,
	"Magnus Karlsson" <magnus.karlsson@intel.com>,
	"Maciej Fijalkowski" <maciej.fijalkowski@intel.com>,
	"Stanislav Fomichev" <sdf@fomichev.me>,
	"Alexei Starovoitov" <ast@kernel.org>,
	"Daniel Borkmann" <daniel@iogearbox.net>,
	"Jesper Dangaard Brouer" <hawk@kernel.org>,
	"John Fastabend" <john.fastabend@gmail.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-trace-kernel@vger.kernel.org, nvdimm@lists.linux.dev,
	fsverity@lists.linux.dev, linux-mm@kvack.org,
	netfs@lists.linux.dev, linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org,
	samba-technical@lists.samba.org, linux-nilfs@vger.kernel.org,
	v9fs@lists.linux.dev, linux-afs@lists.infradead.org,
	autofs@vger.kernel.org, ceph-devel@vger.kernel.org,
	codalist@coda.cs.cmu.edu, ecryptfs@vger.kernel.org,
	linux-mtd@lists.infradead.org,
	jfs-discussion@lists.sourceforge.net, ntfs3@lists.linux.dev,
	ocfs2-devel@lists.linux.dev, devel@lists.orangefs.org,
	linux-unionfs@vger.kernel.org, apparmor@lists.ubuntu.com,
	linux-security-module@vger.kernel.org,
	linux-integrity@vger.kernel.org, selinux@vger.kernel.org,
	amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org,
	netdev@vger.kernel.org, linux-perf-users@vger.kernel.org,
	linux-fscrypt@vger.kernel.org, linux-xfs@vger.kernel.org,
	linux-hams@vger.kernel.org, linux-x25@vger.kernel.org,
	audit@vger.kernel.org, linux-bluetooth@vger.kernel.org,
	linux-can@vger.kernel.org, linux-sctp@vger.kernel.org,
	bpf@vger.kernel.org
Subject: Re: [PATCH v3 12/12] treewide: change inode->i_ino from unsigned long to u64
Date: Wed, 4 Mar 2026 10:49:09 -0500	[thread overview]
Message-ID: <1902b6ed-b5f8-4ab6-9bc6-5c9b0209f5d6@oracle.com> (raw)
In-Reply-To: <20260304-iino-u64-v3-12-2257ad83d372@kernel.org>

On 3/4/26 10:32 AM, Jeff Layton wrote:
> On 32-bit architectures, unsigned long is only 32 bits wide, which
> causes 64-bit inode numbers to be silently truncated. Several
> filesystems (NFS, XFS, BTRFS, etc.) can generate inode numbers that
> exceed 32 bits, and this truncation can lead to inode number collisions
> and other subtle bugs on 32-bit systems.
> 
> Change the type of inode->i_ino from unsigned long to u64 to ensure that
> inode numbers are always represented as 64-bit values regardless of
> architecture. Update all format specifiers treewide from %lu/%lx to
> %llu/%llx to match the new type, along with corresponding local variable
> types.
> 
> This is the bulk treewide conversion. Earlier patches in this series
> handled trace events separately to allow trace field reordering for
> better struct packing on 32-bit.
> 
> Signed-off-by: Jeff Layton <jlayton@kernel.org>
> ---
>  drivers/dma-buf/dma-buf.c                  |  2 +-
>  drivers/gpu/drm/amd/amdgpu/amdgpu_object.c |  4 +--
>  fs/9p/vfs_addr.c                           |  4 +--
>  fs/9p/vfs_inode.c                          |  6 ++--
>  fs/9p/vfs_inode_dotl.c                     |  6 ++--
>  fs/affs/amigaffs.c                         | 10 +++----
>  fs/affs/bitmap.c                           |  2 +-
>  fs/affs/dir.c                              |  2 +-
>  fs/affs/file.c                             | 20 ++++++-------
>  fs/affs/inode.c                            | 12 ++++----
>  fs/affs/namei.c                            | 14 ++++-----
>  fs/affs/symlink.c                          |  2 +-
>  fs/afs/dir.c                               | 10 +++----
>  fs/afs/dir_search.c                        |  2 +-
>  fs/afs/dynroot.c                           |  2 +-
>  fs/afs/inode.c                             |  2 +-
>  fs/autofs/inode.c                          |  2 +-
>  fs/befs/linuxvfs.c                         | 28 ++++++++---------
>  fs/bfs/dir.c                               |  4 +--
>  fs/cachefiles/io.c                         |  6 ++--
>  fs/cachefiles/namei.c                      | 12 ++++----
>  fs/cachefiles/xattr.c                      |  2 +-
>  fs/ceph/crypto.c                           |  4 +--
>  fs/coda/dir.c                              |  2 +-
>  fs/coda/inode.c                            |  2 +-
>  fs/cramfs/inode.c                          |  2 +-
>  fs/crypto/crypto.c                         |  2 +-
>  fs/crypto/hooks.c                          |  2 +-
>  fs/crypto/keyring.c                        |  4 +--
>  fs/crypto/keysetup.c                       |  2 +-
>  fs/dcache.c                                |  4 +--
>  fs/ecryptfs/crypto.c                       |  6 ++--
>  fs/ecryptfs/file.c                         |  2 +-
>  fs/efs/inode.c                             |  6 ++--
>  fs/eventpoll.c                             |  2 +-
>  fs/exportfs/expfs.c                        |  4 +--
>  fs/ext2/dir.c                              | 10 +++----
>  fs/ext2/ialloc.c                           |  9 +++---
>  fs/ext2/inode.c                            |  2 +-
>  fs/ext2/xattr.c                            | 14 ++++-----
>  fs/ext4/dir.c                              |  2 +-
>  fs/ext4/ext4.h                             |  4 +--
>  fs/ext4/extents.c                          |  8 ++---
>  fs/ext4/extents_status.c                   | 28 ++++++++---------
>  fs/ext4/fast_commit.c                      |  8 ++---
>  fs/ext4/ialloc.c                           | 10 +++----
>  fs/ext4/indirect.c                         |  2 +-
>  fs/ext4/inline.c                           | 14 ++++-----
>  fs/ext4/inode.c                            | 22 +++++++-------
>  fs/ext4/ioctl.c                            |  4 +--
>  fs/ext4/mballoc.c                          |  6 ++--
>  fs/ext4/migrate.c                          |  2 +-
>  fs/ext4/move_extent.c                      | 20 ++++++-------
>  fs/ext4/namei.c                            | 10 +++----
>  fs/ext4/orphan.c                           | 16 +++++-----
>  fs/ext4/page-io.c                          | 10 +++----
>  fs/ext4/super.c                            | 22 +++++++-------
>  fs/ext4/xattr.c                            | 10 +++----
>  fs/f2fs/compress.c                         |  4 +--
>  fs/f2fs/dir.c                              |  2 +-
>  fs/f2fs/extent_cache.c                     |  8 ++---
>  fs/f2fs/f2fs.h                             |  6 ++--
>  fs/f2fs/file.c                             | 12 ++++----
>  fs/f2fs/gc.c                               |  2 +-
>  fs/f2fs/inline.c                           |  4 +--
>  fs/f2fs/inode.c                            | 48 +++++++++++++++---------------
>  fs/f2fs/namei.c                            |  8 ++---
>  fs/f2fs/node.c                             | 10 +++----
>  fs/f2fs/recovery.c                         | 10 +++----
>  fs/f2fs/xattr.c                            | 10 +++----
>  fs/freevxfs/vxfs_bmap.c                    |  4 +--
>  fs/fserror.c                               |  2 +-
>  fs/hfs/catalog.c                           |  2 +-
>  fs/hfs/extent.c                            |  4 +--
>  fs/hfs/inode.c                             |  4 +--
>  fs/hfsplus/attributes.c                    | 10 +++----
>  fs/hfsplus/catalog.c                       |  2 +-
>  fs/hfsplus/dir.c                           |  6 ++--
>  fs/hfsplus/extents.c                       |  6 ++--
>  fs/hfsplus/inode.c                         |  8 ++---
>  fs/hfsplus/super.c                         |  6 ++--
>  fs/hfsplus/xattr.c                         | 10 +++----
>  fs/hpfs/dir.c                              |  4 +--
>  fs/hpfs/dnode.c                            |  4 +--
>  fs/hpfs/ea.c                               |  4 +--
>  fs/hpfs/inode.c                            |  4 +--
>  fs/inode.c                                 | 13 ++++----
>  fs/iomap/ioend.c                           |  2 +-
>  fs/isofs/compress.c                        |  2 +-
>  fs/isofs/dir.c                             |  2 +-
>  fs/isofs/inode.c                           |  6 ++--
>  fs/isofs/namei.c                           |  2 +-
>  fs/jbd2/journal.c                          |  4 +--
>  fs/jbd2/transaction.c                      |  2 +-
>  fs/jffs2/dir.c                             |  4 +--
>  fs/jffs2/file.c                            |  4 +--
>  fs/jffs2/fs.c                              | 18 +++++------
>  fs/jfs/inode.c                             |  2 +-
>  fs/jfs/jfs_imap.c                          |  2 +-
>  fs/jfs/jfs_metapage.c                      |  2 +-
>  fs/lockd/svclock.c                         |  8 ++---
>  fs/lockd/svcsubs.c                         |  2 +-
>  fs/locks.c                                 |  6 ++--
>  fs/minix/inode.c                           | 10 +++----
>  fs/nfs/dir.c                               | 20 ++++++-------
>  fs/nfs/file.c                              |  8 ++---
>  fs/nfs/filelayout/filelayout.c             |  8 ++---
>  fs/nfs/flexfilelayout/flexfilelayout.c     |  8 ++---
>  fs/nfs/inode.c                             |  6 ++--
>  fs/nfs/nfs4proc.c                          |  4 +--
>  fs/nfs/pnfs.c                              | 12 ++++----
>  fs/nfsd/export.c                           |  2 +-
>  fs/nfsd/nfs4state.c                        |  4 +--
>  fs/nfsd/nfsfh.c                            |  4 +--
>  fs/nfsd/vfs.c                              |  2 +-
>  fs/nilfs2/alloc.c                          | 10 +++----
>  fs/nilfs2/bmap.c                           |  2 +-
>  fs/nilfs2/btnode.c                         |  2 +-
>  fs/nilfs2/btree.c                          | 12 ++++----
>  fs/nilfs2/dir.c                            | 12 ++++----
>  fs/nilfs2/direct.c                         |  4 +--
>  fs/nilfs2/gcinode.c                        |  2 +-
>  fs/nilfs2/inode.c                          |  8 ++---
>  fs/nilfs2/mdt.c                            |  2 +-
>  fs/nilfs2/namei.c                          |  2 +-
>  fs/nilfs2/segment.c                        |  2 +-
>  fs/notify/fdinfo.c                         |  4 +--
>  fs/nsfs.c                                  |  4 +--
>  fs/ntfs3/super.c                           |  2 +-
>  fs/ocfs2/alloc.c                           |  2 +-
>  fs/ocfs2/aops.c                            |  4 +--
>  fs/ocfs2/dir.c                             |  8 ++---
>  fs/ocfs2/dlmfs/dlmfs.c                     | 10 +++----
>  fs/ocfs2/extent_map.c                      | 12 ++++----
>  fs/ocfs2/inode.c                           |  2 +-
>  fs/ocfs2/quota_local.c                     |  2 +-
>  fs/ocfs2/refcounttree.c                    | 10 +++----
>  fs/ocfs2/xattr.c                           |  4 +--
>  fs/orangefs/inode.c                        |  2 +-
>  fs/overlayfs/export.c                      |  2 +-
>  fs/overlayfs/namei.c                       |  4 +--
>  fs/overlayfs/util.c                        |  2 +-
>  fs/pipe.c                                  |  2 +-
>  fs/proc/fd.c                               |  2 +-
>  fs/proc/task_mmu.c                         |  4 +--
>  fs/qnx4/inode.c                            |  4 +--
>  fs/qnx6/inode.c                            |  2 +-
>  fs/ubifs/debug.c                           |  8 ++---
>  fs/ubifs/dir.c                             | 28 ++++++++---------
>  fs/ubifs/file.c                            | 28 ++++++++---------
>  fs/ubifs/journal.c                         |  6 ++--
>  fs/ubifs/super.c                           | 16 +++++-----
>  fs/ubifs/tnc.c                             |  4 +--
>  fs/ubifs/xattr.c                           | 14 ++++-----
>  fs/udf/directory.c                         | 18 +++++------
>  fs/udf/file.c                              |  2 +-
>  fs/udf/inode.c                             | 12 ++++----
>  fs/udf/namei.c                             |  8 ++---
>  fs/udf/super.c                             |  2 +-
>  fs/ufs/balloc.c                            |  6 ++--
>  fs/ufs/dir.c                               | 10 +++----
>  fs/ufs/ialloc.c                            |  6 ++--
>  fs/ufs/inode.c                             | 18 +++++------
>  fs/ufs/ufs_fs.h                            |  6 ++--
>  fs/ufs/util.c                              |  2 +-
>  fs/verity/init.c                           |  2 +-
>  fs/zonefs/super.c                          |  8 ++---
>  include/linux/fs.h                         |  2 +-
>  kernel/events/uprobes.c                    |  4 +--
>  net/netrom/af_netrom.c                     |  4 +--
>  net/rose/af_rose.c                         |  4 +--
>  net/socket.c                               |  2 +-
>  net/x25/x25_proc.c                         |  4 +--
>  security/apparmor/apparmorfs.c             |  4 +--
>  security/integrity/integrity_audit.c       |  2 +-
>  security/ipe/audit.c                       |  2 +-
>  security/lsm_audit.c                       | 10 +++----
>  security/selinux/hooks.c                   | 10 +++----
>  security/smack/smack_lsm.c                 | 12 ++++----
>  179 files changed, 607 insertions(+), 607 deletions(-)

> diff --git a/fs/nfsd/export.c b/fs/nfsd/export.c
> index 8fdbba7cad96443d92cc7fdeea6158c4cc681be1..d2259d948cc33e1c192531d34679123b826cf4dc 100644
> --- a/fs/nfsd/export.c
> +++ b/fs/nfsd/export.c
> @@ -1039,7 +1039,7 @@ exp_rootfh(struct net *net, struct auth_domain *clp, char *name,
>  	}
>  	inode = d_inode(path.dentry);
>  
> -	dprintk("nfsd: exp_rootfh(%s [%p] %s:%s/%ld)\n",
> +	dprintk("nfsd: exp_rootfh(%s [%p] %s:%s/%llu)\n",
>  		 name, path.dentry, clp->name,
>  		 inode->i_sb->s_id, inode->i_ino);
>  	exp = exp_parent(cd, clp, &path);
> diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
> index 6b9c399b89dfb71a52b9c97f0efe9a1dea0558a6..a569d89ac9123d66bb47e7d74c7c98610de21da2 100644
> --- a/fs/nfsd/nfs4state.c
> +++ b/fs/nfsd/nfs4state.c
> @@ -1253,7 +1253,7 @@ static void nfsd4_finalize_deleg_timestamps(struct nfs4_delegation *dp, struct f
>  	if (ret) {
>  		struct inode *inode = file_inode(f);
>  
> -		pr_notice_ratelimited("nfsd: Unable to update timestamps on inode %02x:%02x:%lu: %d\n",
> +		pr_notice_ratelimited("nfsd: Unable to update timestamps on inode %02x:%02x:%llu: %d\n",
>  					MAJOR(inode->i_sb->s_dev),
>  					MINOR(inode->i_sb->s_dev),
>  					inode->i_ino, ret);
> @@ -2888,7 +2888,7 @@ static void nfs4_show_superblock(struct seq_file *s, struct nfsd_file *f)
>  {
>  	struct inode *inode = file_inode(f->nf_file);
>  
> -	seq_printf(s, "superblock: \"%02x:%02x:%ld\"",
> +	seq_printf(s, "superblock: \"%02x:%02x:%llu\"",
>  					MAJOR(inode->i_sb->s_dev),
>  					 MINOR(inode->i_sb->s_dev),
>  					 inode->i_ino);
> diff --git a/fs/nfsd/nfsfh.c b/fs/nfsd/nfsfh.c
> index ed85dd43da18e6d4c4667ff14dc035f2eacff1d6..ee72c9565e4fe85356674b22b4505d3d531dbe40 100644
> --- a/fs/nfsd/nfsfh.c
> +++ b/fs/nfsd/nfsfh.c
> @@ -601,9 +601,9 @@ fh_compose(struct svc_fh *fhp, struct svc_export *exp, struct dentry *dentry,
>  	struct inode * inode = d_inode(dentry);
>  	dev_t ex_dev = exp_sb(exp)->s_dev;
>  
> -	dprintk("nfsd: fh_compose(exp %02x:%02x/%ld %pd2, ino=%ld)\n",
> +	dprintk("nfsd: fh_compose(exp %02x:%02x/%llu %pd2, ino=%llu)\n",
>  		MAJOR(ex_dev), MINOR(ex_dev),
> -		(long) d_inode(exp->ex_path.dentry)->i_ino,
> +		d_inode(exp->ex_path.dentry)->i_ino,
>  		dentry,
>  		(inode ? inode->i_ino : 0));
>  
> diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c
> index c884c3f34afb044ee5cacc962a04a97de2f7fd88..eafdf7b7890fdee55ddf802d040363f33a7be628 100644
> --- a/fs/nfsd/vfs.c
> +++ b/fs/nfsd/vfs.c
> @@ -1163,7 +1163,7 @@ nfsd_direct_read(struct svc_rqst *rqstp, struct svc_fh *fhp,
>  	} else if (unlikely(host_err == -EINVAL)) {
>  		struct inode *inode = d_inode(fhp->fh_dentry);
>  
> -		pr_info_ratelimited("nfsd: Direct I/O alignment failure on %s/%ld\n",
> +		pr_info_ratelimited("nfsd: Direct I/O alignment failure on %s/%llu\n",
>  				    inode->i_sb->s_id, inode->i_ino);
>  		host_err = -ESERVERFAULT;
>  	}
For the NFSD hunks:

Reviewed-by: Chuck Lever <chuck.lever@oracle.com>


-- 
Chuck Lever


      reply	other threads:[~2026-03-04 15:50 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-04 15:32 [PATCH v3 00/12] vfs: " Jeff Layton
2026-03-04 15:32 ` [PATCH v3 01/12] vfs: widen inode hash/lookup functions " Jeff Layton
2026-03-04 15:32 ` [PATCH v3 02/12] audit: widen ino fields " Jeff Layton
2026-03-04 15:32 ` [PATCH v3 03/12] net: change sock.sk_ino and sock_i_ino() " Jeff Layton
2026-03-04 15:32 ` [PATCH v3 04/12] vfs: widen trace event i_ino fields " Jeff Layton
2026-03-04 15:32 ` [PATCH v3 05/12] cachefiles: " Jeff Layton
2026-03-04 15:32 ` [PATCH v3 06/12] ext2: " Jeff Layton
2026-03-04 15:32 ` [PATCH v3 07/12] hugetlbfs: " Jeff Layton
2026-03-04 15:32 ` [PATCH v3 08/12] zonefs: " Jeff Layton
2026-03-04 15:32 ` [PATCH v3 09/12] ext4: " Jeff Layton
2026-03-04 15:32 ` [PATCH v3 10/12] f2fs: " Jeff Layton
2026-03-04 15:32 ` [PATCH v3 11/12] nilfs2: " Jeff Layton
2026-03-04 15:32 ` [PATCH v3 12/12] treewide: change inode->i_ino from unsigned long " Jeff Layton
2026-03-04 15:49   ` Chuck Lever [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1902b6ed-b5f8-4ab6-9bc6-5c9b0209f5d6@oracle.com \
    --to=chuck.lever@oracle.com \
    --cc=Dai.Ngo@oracle.com \
    --cc=acme@kernel.org \
    --cc=adilger.kernel@dilger.ca \
    --cc=adrian.hunter@intel.com \
    --cc=airlied@gmail.com \
    --cc=aivazian.tigran@gmail.com \
    --cc=al@alarsen.net \
    --cc=alex.aring@gmail.com \
    --cc=alexander.deucher@amd.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=almaz.alexandrovich@paragon-software.com \
    --cc=amarkuze@redhat.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=amir73il@gmail.com \
    --cc=anna@kernel.org \
    --cc=apparmor@lists.ubuntu.com \
    --cc=asmadeus@codewreck.org \
    --cc=ast@kernel.org \
    --cc=audit@vger.kernel.org \
    --cc=autofs@vger.kernel.org \
    --cc=bharathsm@microsoft.com \
    --cc=bpf@vger.kernel.org \
    --cc=brauner@kernel.org \
    --cc=casey@schaufler-ca.com \
    --cc=ceph-devel@vger.kernel.org \
    --cc=chao@kernel.org \
    --cc=chengzhihao1@huawei.com \
    --cc=christian.koenig@amd.com \
    --cc=coda@cs.cmu.edu \
    --cc=codalist@coda.cs.cmu.edu \
    --cc=code@tyhicks.com \
    --cc=courmisch@gmail.com \
    --cc=dan.j.williams@intel.com \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=david@kernel.org \
    --cc=devel@lists.orangefs.org \
    --cc=dhowells@redhat.com \
    --cc=djwong@kernel.org \
    --cc=dlemoal@kernel.org \
    --cc=dmitry.kasatkin@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=dsahern@kernel.org \
    --cc=dsterba@suse.com \
    --cc=dwmw2@infradead.org \
    --cc=ebiggers@kernel.org \
    --cc=ecryptfs@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=eparis@redhat.com \
    --cc=eric.snowberg@oracle.com \
    --cc=ericvh@kernel.org \
    --cc=frank.li@vivo.com \
    --cc=fsverity@lists.linux.dev \
    --cc=glaubitz@physik.fu-berlin.de \
    --cc=hawk@kernel.org \
    --cc=hch@infradead.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=horms@kernel.org \
    --cc=hubcap@omnibond.com \
    --cc=idryomov@gmail.com \
    --cc=irogers@google.com \
    --cc=jack@suse.com \
    --cc=jack@suse.cz \
    --cc=jaegeuk@kernel.org \
    --cc=jaharkes@cs.cmu.edu \
    --cc=james.clark@linaro.org \
    --cc=jfs-discussion@lists.sourceforge.net \
    --cc=jlayton@kernel.org \
    --cc=jlbec@evilplan.org \
    --cc=jmorris@namei.org \
    --cc=johan.hedberg@gmail.com \
    --cc=john.fastabend@gmail.com \
    --cc=john.johansen@canonical.com \
    --cc=jolsa@kernel.org \
    --cc=joseph.qi@linux.alibaba.com \
    --cc=jreuter@yaina.de \
    --cc=jth@kernel.org \
    --cc=konishi.ryusuke@gmail.com \
    --cc=kuba@kernel.org \
    --cc=kuniyu@google.com \
    --cc=linaro-mm-sig@lists.linaro.org \
    --cc=linux-afs@lists.infradead.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-cifs@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-fscrypt@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-hams@vger.kernel.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux-nilfs@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=linux-sctp@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=linux-x25@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=linux_oss@crudebyte.com \
    --cc=lucho@ionkov.net \
    --cc=lucien.xin@gmail.com \
    --cc=luisbg@kernel.org \
    --cc=luiz.dentz@gmail.com \
    --cc=maciej.fijalkowski@intel.com \
    --cc=magnus.karlsson@intel.com \
    --cc=marc.dionne@auristor.com \
    --cc=marcel@holtmann.org \
    --cc=marcelo.leitner@gmail.com \
    --cc=mark.rutland@arm.com \
    --cc=mark@fasheh.com \
    --cc=martin@omnibond.com \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=mikulas@artax.karlin.mff.cuni.cz \
    --cc=mingo@redhat.com \
    --cc=mkl@pengutronix.de \
    --cc=ms@dev.tdt.de \
    --cc=muchun.song@linux.dev \
    --cc=namhyung@kernel.org \
    --cc=naohiro.aota@wdc.com \
    --cc=ncardwell@google.com \
    --cc=neil@brown.name \
    --cc=netdev@vger.kernel.org \
    --cc=netfs@lists.linux.dev \
    --cc=nico@fluxnic.net \
    --cc=ntfs3@lists.linux.dev \
    --cc=nvdimm@lists.linux.dev \
    --cc=ocfs2-devel@lists.linux.dev \
    --cc=okorniev@redhat.com \
    --cc=oleg@redhat.com \
    --cc=omosnace@redhat.com \
    --cc=osalvador@suse.de \
    --cc=pabeni@redhat.com \
    --cc=paul@paul-moore.com \
    --cc=pc@manguebit.org \
    --cc=peterz@infradead.org \
    --cc=raven@themaw.net \
    --cc=richard@nod.at \
    --cc=roberto.sassu@huawei.com \
    --cc=ronniesahlberg@gmail.com \
    --cc=rostedt@goodmis.org \
    --cc=salah.triki@gmail.com \
    --cc=samba-technical@lists.samba.org \
    --cc=sdf@fomichev.me \
    --cc=selinux@vger.kernel.org \
    --cc=serge@hallyn.com \
    --cc=sfrench@samba.org \
    --cc=shaggy@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=slava@dubeyko.com \
    --cc=socketcan@hartkopp.net \
    --cc=sprasad@microsoft.com \
    --cc=steffen.klassert@secunet.com \
    --cc=stephen.smalley.work@gmail.com \
    --cc=sumit.semwal@linaro.org \
    --cc=tom@talpey.com \
    --cc=trondmy@kernel.org \
    --cc=tytso@mit.edu \
    --cc=v9fs@lists.linux.dev \
    --cc=viro@zeniv.linux.org.uk \
    --cc=willemb@google.com \
    --cc=wufan@kernel.org \
    --cc=zohar@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox