From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56E92C433FE for ; Wed, 10 Nov 2021 12:58:46 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A33A86103C for ; Wed, 10 Nov 2021 12:58:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A33A86103C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 4115B6B0072; Wed, 10 Nov 2021 07:58:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3BE736B0073; Wed, 10 Nov 2021 07:58:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 286BE6B0074; Wed, 10 Nov 2021 07:58:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0118.hostedemail.com [216.40.44.118]) by kanga.kvack.org (Postfix) with ESMTP id 1B5976B0072 for ; Wed, 10 Nov 2021 07:58:45 -0500 (EST) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id D73B27CB4E for ; Wed, 10 Nov 2021 12:58:44 +0000 (UTC) X-FDA: 78793024968.04.D408A8E Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) by imf20.hostedemail.com (Postfix) with ESMTP id 5D15DD0000B9 for ; Wed, 10 Nov 2021 12:58:32 +0000 (UTC) Received: by mail-pg1-f179.google.com with SMTP id s136so2202317pgs.4 for ; Wed, 10 Nov 2021 04:58:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:to:cc:references :from:in-reply-to:content-transfer-encoding; bh=bYJCDmXhbZdwQcqQV6p0qfHrLLCZuMTTGmF8KIZ2ebg=; b=0Qj3WziVPa6/9jW1dnkM0js30+i48RZdsL8Xr/KA/YP6GLcSd+4iDZ8d/hdjQ+QcSU M8tFdlfYx5DT9eFjBgBgX7wvdySyiUT9yMOii2gUfVN7Vv786Jo8n1ZQKGoQfLnrfzJn kMgCMuI8xZSKKQlHTzYYmwz4+QugGvdqrpEtRr5n8XEjx8U8wfFrwqOfsoMyKoTGZEPV XRghj6fVtEnWuGAMGy4rAqXylpKvDJsxJFvTlcRDQX/x3u17FhglF+aADpjYSkShkleA n8FYpYmuiyTdm9uJcgJVQIbN9ugR1fXEb0+HnKgzmL8CrG3jk/y35V85ws19b9PJfZTg V8lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :to:cc:references:from:in-reply-to:content-transfer-encoding; bh=bYJCDmXhbZdwQcqQV6p0qfHrLLCZuMTTGmF8KIZ2ebg=; b=PNEK1fN2a6c3tAzyoPJtmzYv/MKkBWJ0d0TBx22dmCHeo1eu7gqoyA4uR7JTV1YkKp A/C0D916Xu+Enkldsl/HOe3wWQZkW9SqeQRplhs69XdkqIAi0hWFASp0GF9wktmmL+cx zpmxN31Jv7tmxJHMKQcKytiQDHnKgrQL/qmkzfWWdm35bDLn3sPayiTinThNLVKV9Ike j0cwLEczSom/vaQYxPttz3j3OLGXDsPFxC8h6PDV/ej0Qo9xg85YBDm8aBXl0E+pv5SX 1r0Gl8QYjuzjC0V2rnEmX+oxeaIFTiGRRHtzcIUuMoiFfi9tapaXSbcJU3xD35QJKQ5P WoXA== X-Gm-Message-State: AOAM531oUnqBBX+to/wFkVtKYh33MdzraNFZGHzwpWFVMnOP0kSowBVG 6mWBxAUIgSEV6qngP6nAR+PPhg== X-Google-Smtp-Source: ABdhPJwbusrzbHVv2OyW13KKKsVbVhQcdBFFWjiyo9LwLOH9xHto26AgH0kSAvdXoNk3nAGUeFZf9A== X-Received: by 2002:a05:6a00:844:b0:49f:dbe4:b911 with SMTP id q4-20020a056a00084400b0049fdbe4b911mr16603220pfk.6.1636549122022; Wed, 10 Nov 2021 04:58:42 -0800 (PST) Received: from [10.254.189.129] ([139.177.225.251]) by smtp.gmail.com with ESMTPSA id t4sm23081243pfj.166.2021.11.10.04.58.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Nov 2021 04:58:41 -0800 (PST) Message-ID: <18fa08bf-847b-1c47-10ee-01c92caeb0cc@bytedance.com> Date: Wed, 10 Nov 2021 20:58:35 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PATCH v3 02/15] mm: introduce is_huge_pmd() helper To: Jason Gunthorpe Cc: akpm@linux-foundation.org, tglx@linutronix.de, kirill.shutemov@linux.intel.com, mika.penttila@nextfour.com, david@redhat.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, songmuchun@bytedance.com, zhouchengming@bytedance.com References: <20211110084057.27676-1-zhengqi.arch@bytedance.com> <20211110084057.27676-3-zhengqi.arch@bytedance.com> <20211110122945.GO1740502@nvidia.com> From: Qi Zheng In-Reply-To: <20211110122945.GO1740502@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=0Qj3WziV; spf=pass (imf20.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.215.179 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 5D15DD0000B9 X-Stat-Signature: 5aacor3xomewg9idi73qs53q7q5bk5q5 X-HE-Tag: 1636549112-432218 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11/10/21 8:29 PM, Jason Gunthorpe wrote: > On Wed, Nov 10, 2021 at 04:40:44PM +0800, Qi Zheng wrote: >> Currently we have some times the following judgments repeated in the >> code: >> >> is_swap_pmd(*pmd) || pmd_trans_huge(*pmd) || pmd_devmap(*pmd) >> >> which is to determine whether the *pmd is a huge pmd, so introduce >> is_huge_pmd() helper to deduplicate them. > > Isn't this pmd_leaf() ? Currently, the implementation of pmd_leaf() does not include pmd_devmap() checks. But considering the semantics of pmd_leaf(), the "devmap" pmd should also belong to "leaf" pmd. Maybe we should modify pmd_leaf() to make it more semantically consistent? By the way, something went wrong when sending this patchset, and I have re-sent the complete patchset, please comment over there. Thanks, Qi > > Jason >