Re: [PATCH v3 1/3] tools/testing/vma/vma_internal.h: provide fatal_signal_pending

[Lorenzo Stoakes <lorenzo.stoakes@oracle.com>]

On Sun, Jan 04, 2026 at 10:15:36PM +0100, Mikulas Patocka wrote:
> Provide a dummy function fatal_signal_pending, because it will be used in
> the following patch in the function mm_take_all_locks.
>
> This commit avoids a test failure when the following patch will be apllied.
>
> Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
> Cc: stable@vger.kernel.org

No, please don't cc stable. Also don't cc stable without a Fixes tag.

This isn't backportable given you now need to backport to 5.10, 5.15, 6.1, 6.6,
6.12, 6.17.

I'm not sure how Andrew deals with a mix of Cc: stable and not-cc-stable patches
in a series, think he generally doesn't like, but I'm not sure how exactly we
are supposed to express order here otherwise. Andrew?

>
> ---
>  tools/testing/vma/vma_internal.h |    5 +++++
>  1 file changed, 5 insertions(+)
>
> Index: mm/tools/testing/vma/vma_internal.h
> ===================================================================
> --- mm.orig/tools/testing/vma/vma_internal.h	2026-01-04 21:19:10.000000000 +0100
> +++ mm/tools/testing/vma/vma_internal.h	2026-01-04 21:19:10.000000000 +0100
> @@ -1364,6 +1364,11 @@ static inline bool signal_pending(void *
>  	return false;
>  }
>
> +static inline bool fatal_signal_pending(void *p)
> +{
> +	return false;
> +}
> +
>  static inline bool is_file_hugepages(struct file *file)
>  {
>  	return false;
>
>

Thanks, Lorenzo