From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5A85C433C1 for ; Wed, 24 Mar 2021 19:43:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4D85A61923 for ; Wed, 24 Mar 2021 19:43:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4D85A61923 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B94326B02DC; Wed, 24 Mar 2021 15:43:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B448C6B02F0; Wed, 24 Mar 2021 15:43:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9BE5C6B02F2; Wed, 24 Mar 2021 15:43:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0052.hostedemail.com [216.40.44.52]) by kanga.kvack.org (Postfix) with ESMTP id 82F9D6B02DC for ; Wed, 24 Mar 2021 15:43:52 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 4495F824999B for ; Wed, 24 Mar 2021 19:43:52 +0000 (UTC) X-FDA: 77955793104.03.EA37C8A Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) by imf17.hostedemail.com (Postfix) with ESMTP id 9667E40001FE for ; Wed, 24 Mar 2021 19:43:50 +0000 (UTC) Received: by mail-lj1-f170.google.com with SMTP id a1so170248ljp.2 for ; Wed, 24 Mar 2021 12:43:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ZsxM/2Ykxu5IttmOH8Blmg3qxt7HyUyyxyppNU8QMfk=; b=ihxR+uuzlP8ImCNG5ItmyIu3OCF9ZqN+bhsDpuiXtnlULfrpsGDJ6o0uDVE6K55vfB tyeM6kuAnyaPydWXKw8UAUZ1gX4Fk75FT/KcAWmRqaD28DG6q4y947NKu3KOHIQVt4gF iqLGiIm5nT2/YS4MVpKtzgdHFoJU7S96XEN6asm6tss9c4ljJ66SpOqOx8BanzkzjT0e 1BU3ICeVSotxvziA/gerpRD2Pqv3TSnZeKaXLwohHksUuAIybX7KN1rO4BrkmTAZBOOY bj0JKJ55mhC6Xj772qk9NX1ULSwyRivGUW2zGJQT8FvHY6vizgFp6OVT05KYfNbL3uIm RScA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ZsxM/2Ykxu5IttmOH8Blmg3qxt7HyUyyxyppNU8QMfk=; b=pRSo0jQgqtt+GV9Exb7vmSO0UpkH3HyrGhioQ99CrSxHO8wILANG3QkZiN2HRGhB2R jDSdn4ZQkKJJMX99p1ZzDiuOwBSc/I/+aT/7TuhQRGOSPMbfJzsLOGCiWvFu/QHOgMVl hFSX5KioNn3970Caux/5NJH+gMhIdI7DCZZvJp7gEeLVDeKQfCmk3ZebWdoGnRyYL9Sx Rmb/ZSPEtvGxtJWQAb0qhvSYkVVeemG6jQryRJCo9ht9u6pIv9hR/9Z7eVWhnviyzAgd ytkJKd5+qt8DOr/vBPW04PR6yeQSxFsda3zJaBmrmiovNbAN/4nbK84qKUMXy1DPeAJB 1lwQ== X-Gm-Message-State: AOAM533Il9JTrxu3DLygklK3IngDjuqf8P2NqEE0yME1MkeZbnoZkv0W AyKbPW5Z7Ut+TBQAsKI5QAg= X-Google-Smtp-Source: ABdhPJy0XoQsm08/P+H2D3PRFBIwy3RkMDUTgI0q5lcOl/QqmGK6ktXvEobzb8/NWdIkAbHt3rYz3Q== X-Received: by 2002:a2e:a481:: with SMTP id h1mr3052315lji.143.1616615030303; Wed, 24 Mar 2021 12:43:50 -0700 (PDT) Received: from [192.168.2.145] (109-252-193-60.dynamic.spd-mgts.ru. [109.252.193.60]) by smtp.googlemail.com with ESMTPSA id f4sm408695lja.69.2021.03.24.12.43.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Mar 2021 12:43:49 -0700 (PDT) Subject: Re: [PATCH] mm: cma: fix corruption cma_sysfs_alloc_pages_count To: Minchan Kim , Andrew Morton Cc: linux-mm , LKML , gregkh@linuxfoundation.org, surenb@google.com, joaodias@google.com, jhubbard@nvidia.com, willy@infradead.org References: <20210324192044.1505747-1-minchan@kernel.org> From: Dmitry Osipenko Message-ID: <18ee5c3e-fba2-0d8d-bd93-5fb8d0dd7a01@gmail.com> Date: Wed, 24 Mar 2021 22:43:49 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210324192044.1505747-1-minchan@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 9667E40001FE X-Stat-Signature: m4pnn3yooci38ph5p6k8xyuti96thh5z Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf17; identity=mailfrom; envelope-from=""; helo=mail-lj1-f170.google.com; client-ip=209.85.208.170 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616615030-825358 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 24.03.2021 22:20, Minchan Kim =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > static int __init cma_sysfs_init(void) > { > - int i =3D 0; > + struct kobject *cma_kobj_root; > + struct cma_kobject *cma_kobj; > struct cma *cma; > + unsigned int i; > while (--i >=3D 0) { Do you realize that this doesn't work anymore? > cma =3D &cma_areas[i]; > - kobject_put(&cma->stat->kobj); > - } > =20 > - kfree(cma_stats); > - kobject_put(cma_kobj); > + kobject_put(&cma->cma_kobj->kobj); > + kfree(cma->cma_kobj); Freeing a null pointer? > + cma->cma_kobj =3D NULL; > + } > + kobject_put(cma_kobj_root);