From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5901C7115A for ; Thu, 19 Jun 2025 09:55:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 778636B00B4; Thu, 19 Jun 2025 05:55:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 728FC6B00BB; Thu, 19 Jun 2025 05:55:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5F1446B00BC; Thu, 19 Jun 2025 05:55:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4B16A6B00B4 for ; Thu, 19 Jun 2025 05:55:08 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E07821209D1 for ; Thu, 19 Jun 2025 09:55:07 +0000 (UTC) X-FDA: 83571691854.06.B38890F Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf15.hostedemail.com (Postfix) with ESMTP id 9F01DA000D for ; Thu, 19 Jun 2025 09:55:05 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ADh+dPY6; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=YxVpmbzD; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ADh+dPY6; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=YxVpmbzD; dmarc=none; spf=pass (imf15.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750326905; a=rsa-sha256; cv=none; b=MShBvtSIzrsFz8vQj7L9/6xn/o8ClCtIQTxfGgjNqI5cetfy8EHnxpswMcuISzgzVia6yb Bxwm2l8FqEqMOfef7rXGr7Q7Ut7S2wnsqd0PMfHbgrPGhf1j3a1+/BPJmnMUnc0oZKAW4s wWcwsqv3Q7dUm33vNvz4hv1G9epOJVg= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ADh+dPY6; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=YxVpmbzD; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ADh+dPY6; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=YxVpmbzD; dmarc=none; spf=pass (imf15.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750326905; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=i+0T+q0bb2710wKeHXWXgXh7BI0Kqd4Of4/WVTVwyys=; b=sFo2MWUbJDrW1YM/aeQXbjtOVqXbX2APjaPGIitFG3x3T6DBfHBKzbFNaoi/vD9PnQ5Xjj oXLaY4nc1BB7KLB7VonN/mFx2hN7riKLGUra0Ma94vtK5gOjER3t9rsGMYCeVwH3gvR++q rC0VlVW3/6ApfLZJn25tTUw8HmRjb2o= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id EF9531F38D; Thu, 19 Jun 2025 09:55:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1750326904; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=i+0T+q0bb2710wKeHXWXgXh7BI0Kqd4Of4/WVTVwyys=; b=ADh+dPY6MgrjNm/watZxFLcrEQun7YS8g8bXwWPVvyKPYm7+XQDr3N2bYqBzss23gWyAEG NX/NnNKd2S3tzKXu01o/JyIqjTbA6/XZQlxuuEWi0ea3pw/Lcfi3dORRVN6SdGl2yTJudo hElwYFNU4u4M5zNLo25zj7PJK1CkvZw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1750326904; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=i+0T+q0bb2710wKeHXWXgXh7BI0Kqd4Of4/WVTVwyys=; b=YxVpmbzDAO40SdPP4Z5Ppjcnk8PLe4d6Y/yDH+gtjKAelGODLia23ptxzySWaq7N6Ednet IXz1TEbras4eKxBg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1750326904; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=i+0T+q0bb2710wKeHXWXgXh7BI0Kqd4Of4/WVTVwyys=; b=ADh+dPY6MgrjNm/watZxFLcrEQun7YS8g8bXwWPVvyKPYm7+XQDr3N2bYqBzss23gWyAEG NX/NnNKd2S3tzKXu01o/JyIqjTbA6/XZQlxuuEWi0ea3pw/Lcfi3dORRVN6SdGl2yTJudo hElwYFNU4u4M5zNLo25zj7PJK1CkvZw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1750326904; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=i+0T+q0bb2710wKeHXWXgXh7BI0Kqd4Of4/WVTVwyys=; b=YxVpmbzDAO40SdPP4Z5Ppjcnk8PLe4d6Y/yDH+gtjKAelGODLia23ptxzySWaq7N6Ednet IXz1TEbras4eKxBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id A86A5136CC; Thu, 19 Jun 2025 09:55:03 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id HLWGKHfeU2gEUAAAD6G6ig (envelope-from ); Thu, 19 Jun 2025 09:55:03 +0000 Message-ID: <18ee4f16-0885-45f4-bea6-c025a1a0b969@suse.cz> Date: Thu, 19 Jun 2025 11:55:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 9/9] page_pool: access ->pp_magic through struct netmem_desc in page_pool_page_is_pp() Content-Language: en-US To: Byungchul Park , willy@infradead.org, netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, kuba@kernel.org, almasrymina@google.com, ilias.apalodimas@linaro.org, harry.yoo@oracle.com, hawk@kernel.org, akpm@linux-foundation.org, davem@davemloft.net, john.fastabend@gmail.com, andrew+netdev@lunn.ch, asml.silence@gmail.com, toke@redhat.com, tariqt@nvidia.com, edumazet@google.com, pabeni@redhat.com, saeedm@nvidia.com, leon@kernel.org, ast@kernel.org, daniel@iogearbox.net, david@redhat.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, rppt@kernel.org, surenb@google.com, mhocko@suse.com, horms@kernel.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, vishal.moola@gmail.com References: <20250609043225.77229-1-byungchul@sk.com> <20250609043225.77229-10-byungchul@sk.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJnyBr8BQka0IFQAAoJECJPp+fMgqZkqmMQ AIbGN95ptUMUvo6aAdhxaOCHXp1DfIBuIOK/zpx8ylY4pOwu3GRe4dQ8u4XS9gaZ96Gj4bC+ jwWcSmn+TjtKW3rH1dRKopvC07tSJIGGVyw7ieV/5cbFffA8NL0ILowzVg8w1ipnz1VTkWDr 2zcfslxJsJ6vhXw5/npcY0ldeC1E8f6UUoa4eyoskd70vO0wOAoGd02ZkJoox3F5ODM0kjHu Y97VLOa3GG66lh+ZEelVZEujHfKceCw9G3PMvEzyLFbXvSOigZQMdKzQ8D/OChwqig8wFBmV QCPS4yDdmZP3oeDHRjJ9jvMUKoYODiNKsl2F+xXwyRM2qoKRqFlhCn4usVd1+wmv9iLV8nPs 2Db1ZIa49fJet3Sk3PN4bV1rAPuWvtbuTBN39Q/6MgkLTYHb84HyFKw14Rqe5YorrBLbF3rl M51Dpf6Egu1yTJDHCTEwePWug4XI11FT8lK0LNnHNpbhTCYRjX73iWOnFraJNcURld1jL1nV r/LRD+/e2gNtSTPK0Qkon6HcOBZnxRoqtazTU6YQRmGlT0v+rukj/cn5sToYibWLn+RoV1CE Qj6tApOiHBkpEsCzHGu+iDQ1WT0Idtdynst738f/uCeCMkdRu4WMZjteQaqvARFwCy3P/jpK uvzMtves5HvZw33ZwOtMCgbpce00DaET4y/UzsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZ8gcVAUJFhTonwAKCRAiT6fnzIKmZLY8D/9uo3Ut9yi2YCuASWxr7QQZ lJCViArjymbxYB5NdOeC50/0gnhK4pgdHlE2MdwF6o34x7TPFGpjNFvycZqccSQPJ/gibwNA zx3q9vJT4Vw+YbiyS53iSBLXMweeVV1Jd9IjAoL+EqB0cbxoFXvnjkvP1foiiF5r73jCd4PR rD+GoX5BZ7AZmFYmuJYBm28STM2NA6LhT0X+2su16f/HtummENKcMwom0hNu3MBNPUOrujtW khQrWcJNAAsy4yMoJ2Lw51T/5X5Hc7jQ9da9fyqu+phqlVtn70qpPvgWy4HRhr25fCAEXZDp xG4RNmTm+pqorHOqhBkI7wA7P/nyPo7ZEc3L+ZkQ37u0nlOyrjbNUniPGxPxv1imVq8IyycG AN5FaFxtiELK22gvudghLJaDiRBhn8/AhXc642/Z/yIpizE2xG4KU4AXzb6C+o7LX/WmmsWP Ly6jamSg6tvrdo4/e87lUedEqCtrp2o1xpn5zongf6cQkaLZKQcBQnPmgHO5OG8+50u88D9I rywqgzTUhHFKKF6/9L/lYtrNcHU8Z6Y4Ju/MLUiNYkmtrGIMnkjKCiRqlRrZE/v5YFHbayRD dJKXobXTtCBYpLJM4ZYRpGZXne/FAtWNe4KbNJJqxMvrTOrnIatPj8NhBVI0RSJRsbilh6TE m6M14QORSWTLRg== In-Reply-To: <20250609043225.77229-10-byungchul@sk.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 9F01DA000D X-Stat-Signature: spktsgmkeddzwqbz5jsnc4aswug355mt X-Rspam-User: X-HE-Tag: 1750326905-84654 X-HE-Meta: U2FsdGVkX1/4awlj1pTRMQ4Yaw5Rk4uva3hDf+8f4xdwvrz8LOAsk5Tu6qbVZzQ2Fuh78Pw4eMPjdOYBE8aHbN6OqaD9tEb/Dklgd1ufLyBrkCTqpm+8TmDCeG4ZksbrOwKxaNfzchdXfRDL8Qa48R6DzxcWPJsfU4Hg/ILevbU0aMk89zmHwmoz4CP7W16nZtaNbHZNDKG2dn3YC4ctgASel1qxZYM1VivyKpg+46jfcydWOytzS527VNMEDXXvFhlo1ngYwIIEF8lpHpnQpycRcCvglIrc1B4owlf+UcfIihVM6yCpHePUYRo0JLlwNgl64kk3l+K2+z7ygMmGRpN4w8ROMEU3EK2Z8p1DYkEeSn/Qek5CnyUw6JqNbNSSkI2Dsgd9ufim4efzP+/QYEH8oRj0e3y7t371/GwQwOejzqwR4VEAfNY13HfojGTXUROspROmIrJsaPE5YtWvv2sWcau6lU16YYZhOEuTl+rozhZaLmUGazxCxMPf8a5xh5sMbkyLOabjFrHZvcSo6ALMTjjPyKB2YfNWZVzLdO6SHmTJB12leprWLHrojkM7U2OpmbD9hNBx90VH+t8pMww4VnQWlPN+N0PJevVNfGSIJ32kCu1YK0e8hck6nQInKQsdtMlH/DSWtVw7/g1shRRuCSGOcNVq8Xz+lXTK1nO3qcQq6L3LjMy+snmkphDJOC1g7cek0LwZUJcHC/nOkv5AnTSKJSxpvUwZR16eX7Z/tsmZlJ3hWSpxzotatPc4ne8uNnf0TMBAM6uEorDt9BQ2X+kKdQksJha6uCixdqJYLnfRostYghPd6ejykFHZBJkowyutJLRvZwy65l2m1RThmRgf2TTwOxD/LNpmA93a3rysDn/e2uuY0aOp8qF/85hKyTNPn6cxhBG+sjkedlWX9v/vQFhpm4bF+FQYbjFPgMB7Cu9GLRs76Rcm0hCvRuPcKklWyFihmhUoLcZ t1PY3QOZ 2qwTSkg6YIx7vHtECK08NFt6HZAxtGKIxf1j8lcuoZEjY2SSjLL3miIch6uMnsX9pdEVWBKsaj5aI+vVoEPfwj11jPNVy2CTZ3f5f1MHoAWj+VyFpAehXoxKYfVkZx36qb9a1vwadvou6NCAiS5CC8jVAJqD3vdfbgjZoR+isHYFYwCOa+2Tt7ubb5rLrmGlj5UuN5ZMDGF1dzh9NuJ0CpvokIl0Z6iN34t4ryH/FdtJQzt3g7MXMv8pIBPaksq9yqZqJEqmcZqxR61k+7vsFV6/tiKXusuB/f2rlBTPmtiFWYSLWXGjJOLJQdScd6UpooKUzc1PvKLLMDUqWtTEUoy3QkXb7NUeNq1CG1nMp76rtHi4tJxHuzNyzhC+DraXt7grZIi1vGoNLzZS7WCChbryrD8oWD1WoCV7YV+HlRrkNFNfEECeBSMKlJMmA7NeZXgpA+56okvniy3Ds6Gh0kxqalKHGNbrLCglt9eALhwvcORysEe+14ywy4zr5gn7aFWigj424YTVuujY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/9/25 06:32, Byungchul Park wrote: > To simplify struct page, the effort to separate its own descriptor from > struct page is required and the work for page pool is on going. > > To achieve that, all the code should avoid directly accessing page pool > members of struct page. > > Access ->pp_magic through struct netmem_desc instead of directly > accessing it through struct page in page_pool_page_is_pp(). Plus, move > page_pool_page_is_pp() from mm.h to netmem.h to use struct netmem_desc > without header dependency issue. > > Signed-off-by: Byungchul Park > Reviewed-by: Toke Høiland-Jørgensen Reviewed-by: Vlastimil Babka I'm not that worried about the new include as it's for a .c file and not between .h files. > --- > include/linux/mm.h | 12 ------------ > include/net/netmem.h | 14 ++++++++++++++ > mm/page_alloc.c | 1 + > 3 files changed, 15 insertions(+), 12 deletions(-) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index e51dba8398f7..f23560853447 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -4311,16 +4311,4 @@ int arch_lock_shadow_stack_status(struct task_struct *t, unsigned long status); > */ > #define PP_MAGIC_MASK ~(PP_DMA_INDEX_MASK | 0x3UL) Do you plan to move also all these PP_ constants/macros (bunch more above this one) to a net header? Thanks, Vlastimil