From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31BB2C001DE for ; Wed, 9 Aug 2023 02:32:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9DF226B0071; Tue, 8 Aug 2023 22:32:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 98EAB6B0074; Tue, 8 Aug 2023 22:32:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 82F918D0001; Tue, 8 Aug 2023 22:32:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 70EC76B0071 for ; Tue, 8 Aug 2023 22:32:17 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 419211A081F for ; Wed, 9 Aug 2023 02:32:17 +0000 (UTC) X-FDA: 81102991914.25.A59024F Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2054.outbound.protection.outlook.com [40.107.243.54]) by imf20.hostedemail.com (Postfix) with ESMTP id 20BE31C001A for ; Wed, 9 Aug 2023 02:32:13 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=LSjlTfo2; dmarc=pass (policy=reject) header.from=nvidia.com; spf=pass (imf20.hostedemail.com: domain of jhubbard@nvidia.com designates 40.107.243.54 as permitted sender) smtp.mailfrom=jhubbard@nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691548334; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ar7Ve3Hr+DhVl9pPMkro5sLxbkFxoDGq+tMtFYS9sGo=; b=D5GaPXSfa/mAdH3buJXPtMSUAD6QjbCGDfKWQ+xovigxPW7AAJ8TOH77nTidPcYNtWzKK+ 70FBJA0ZzvFsWo9a5DaomC2E55YTNKTxHRsOwy5QTZZ5aVBd8E92omxM5wcqM9NhuwuMjM 0dTApvW2tMdOkhTErRAwGNRubjeNoyQ= ARC-Authentication-Results: i=2; imf20.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=LSjlTfo2; dmarc=pass (policy=reject) header.from=nvidia.com; spf=pass (imf20.hostedemail.com: domain of jhubbard@nvidia.com designates 40.107.243.54 as permitted sender) smtp.mailfrom=jhubbard@nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1691548334; a=rsa-sha256; cv=pass; b=8RuDdKgDp1eCrNbTUmMs27SRgETFBfz0Q6Z7Gzd+SfQDdLH7MjGr40DzZiMzP7ycLWBsi1 abFFAFxvh/95MGsi1aADYfT+Yvjhgg4frB2yjMzqXaCSmJgs3jnlt9hdQyABS7oQbE+MxK qsqEZJcwu5X6SWiXwBH1mcrtfmLEzLA= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=obDRgcmNq8BmfSmMr8+hAKiyB/JOKtn2IPCQ0jjmMgp+Uow48gRK7363xWQ10Wz1rd2Y+CdZY2b7+XpcJxNugZlWzumTshIfWUCWooKBkyFNuxC9mzwpYpsXx19dbzLGN0v+gwjxXz7uGP41RdAn+p62wzJR3OBVwCaogG4FHiKnoFPz/bf3elbcLkAP2heY/k00gHc+1pRYMV6o1l2R9lw+JaQcNTFJiw1wWQu+1Wmu3ZufK7alzf80P89pGVex/D9IFNmalhbIUUuZ4aEsNR1yaHOdt0hANPao2Umg/CI3UGgJXd6QZftbDhBA10STcyc4xs1Oz9zR/Gs+CVyLuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ar7Ve3Hr+DhVl9pPMkro5sLxbkFxoDGq+tMtFYS9sGo=; b=bPZV1T1/lfxyeaw0+gca/QkwYTYkr7jQSAK96KbL8v6hb6edUUC75TX4JyW4S+dNLkcQ/SoDf/PpHUNucSb0eNxKGfp2jGuhJviAVz8qPG+pQY+KixHOAlHOb+kpI6mjyWSDPDO/MvVS6Ov+c1aaHNqHl2KFP422sFGV6t5UusxMAU8zuwVrNDozpk3rOwBH/EaGxojjiPNcoFFj+5hR9eI+C6utmfY9AXIozA0G7KlOdI/eJBqwdQwK6GeUWq3hF0XIAEP5MfVqQOSBGYR5BYTlZYyKfea0Xwz8H1AIRCjLQjRwOowD0qGqMQQAJuwCxRMkg1IBwVd6uK8iCW1hGw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=amd.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ar7Ve3Hr+DhVl9pPMkro5sLxbkFxoDGq+tMtFYS9sGo=; b=LSjlTfo2DzD6VMty9y++21mZ7wVN0DspH41tOx+AxWBf8LXiYWSsgX9PBGSiO6MXSWERQCwVp5ymTj8M4oTg9kmA+MCl/l1IQOjP/8BSCPB+o/V+mApV+9RpsTx/Ee0nuvaMF3RU80ThEV5B65muouUUX6BTaoTGWHlqFMxwvS8bLPdX6fYuNDnEuG9/kN/tomo1OAQn+i6FbKuyBAFYysrMZ/96zNgYQKMI/uog9OcNFJXCJTDSZs4TN6TN8+VFfIIxq2nrPZwLV4QeFDb+4bKTRletswd1Lom6fgK5zktU3RtT4CNWCQykUyL5pPndCbq5spxZLqOMRLoArz55bg== Received: from DM6PR07CA0124.namprd07.prod.outlook.com (2603:10b6:5:330::34) by BL3PR12MB6450.namprd12.prod.outlook.com (2603:10b6:208:3b9::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Wed, 9 Aug 2023 02:32:11 +0000 Received: from DM6NAM11FT098.eop-nam11.prod.protection.outlook.com (2603:10b6:5:330:cafe::c2) by DM6PR07CA0124.outlook.office365.com (2603:10b6:5:330::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27 via Frontend Transport; Wed, 9 Aug 2023 02:32:11 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by DM6NAM11FT098.mail.protection.outlook.com (10.13.173.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.42 via Frontend Transport; Wed, 9 Aug 2023 02:32:10 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Tue, 8 Aug 2023 19:31:56 -0700 Received: from [10.110.48.28] (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Tue, 8 Aug 2023 19:31:55 -0700 Message-ID: <18ed929a-ab19-4bcc-a871-1c74c8b2d559@nvidia.com> Date: Tue, 8 Aug 2023 19:31:55 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftests/mm: FOLL_LONGTERM need to be updated to 0x100 To: Ayush Jain , , , CC: , , , , , , Raghavendra K T References: <20230808124347.79163-1-ayush.jain3@amd.com> Content-Language: en-US From: John Hubbard In-Reply-To: <20230808124347.79163-1-ayush.jain3@amd.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT098:EE_|BL3PR12MB6450:EE_ X-MS-Office365-Filtering-Correlation-Id: add18a82-8714-4d9f-3cd7-08db9880d5a0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VSw6RD9EogtyoJo98njNaJod3L0uUHSCYsWW15ZieuJIxAAB/bc/I+0XJuOTqtoEVX8VoyIg2yVFBoI2XXLr9f4w+TqVfGpvpq6wGKD5uUCgL/H8Nb/Hkg9MnGRqw7IiC0/a8LqU1mqjrCq8tuRmi1NSju1xx0AaYNJyTDCe/8tuxZW93XHPdiQLUa5jYEqLIM0PrBy5HJPXo9rrbujUwUXcY0GNpeTfpiVgr3YQItq1on1ozjQr14NFnPCXnl9CYViZqMNQaX8jImqKhIIsvURiOII8nljVg8usuCUqc14VatfTEm4dWrZX2U9YaijXUwq8HxAtWud1TtjrPx98i51JAdZzZ6OyyXfaX4iNs/r4wTgfMPz/gr5bya+Q1hAeGqKGlfsArrS5O+FdyjwO3UeQ9WUWToGPwa2C/g5waV0RUwETF+a2NPNI59jfG+b+ecz7kQFaSZa4fqFXf++DuZGg4xuP950HoGOJwF2aN5qsUtVN98ETfr8lgxcGB2RWnOXGWpvR6e6xERAtat0N9XcWmvKuEhyJf0nnThYoE9F3q7mk9GexIISzUhLTPm2pPsvodc8FqhQwGrk2ARpq2r7imzkW/8tAuvtfmUkyQGPR7gaCCk1st1w5twttBn/QNv8IR9ea/uxGzmaIYV5itS4uH5Eo0t30zEfmuRQNfAF2umH/HRLJr+NWMK+r691/0SWPSUr3XoLl0jsDd9OgK+28nfoIPJdCfXqKVmnC/5a0TQpWUvW30wMWrvOmLTNozFCWRYy/lid2hrAdKA6FUA== X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230028)(4636009)(346002)(396003)(376002)(39860400002)(136003)(82310400008)(1800799006)(186006)(451199021)(40470700004)(36840700001)(46966006)(4744005)(2906002)(40480700001)(47076005)(426003)(40460700003)(41300700001)(5660300002)(8676002)(8936002)(7416002)(36756003)(31696002)(36860700001)(86362001)(54906003)(31686004)(110136005)(7636003)(16526019)(356005)(336012)(478600001)(82740400003)(26005)(53546011)(16576012)(316002)(4326008)(70586007)(70206006)(2616005)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2023 02:32:10.8778 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: add18a82-8714-4d9f-3cd7-08db9880d5a0 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT098.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR12MB6450 X-Rspamd-Queue-Id: 20BE31C001A X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: r65t6n7pusjj6sx55o1yomkoz5srf1ah X-HE-Tag: 1691548333-394493 X-HE-Meta: U2FsdGVkX1/i4hTq9dEM9UoPPuFVDoWcLm4oldepsvrh6iuJP3QbQUgl2uiZYh1/ohWp9lPfXaC0emexbk/wpk3nPgIqZm+p7JUFJW72SX0+bTFBOaSvZdISZk4FUJFKNbfIobWgWaX+duifiprqMjhYp2L934nxehcXyHG1gZkZ+oe9SbdVxxyzqCy4WLimt8QN9rp1xMB/CnWVQUUG31AqIXhg3ObXuggR9xHDI4qcgknYJ2xo7igMp9rDc1srgASBnIJ8g3ksiZ4Y513prxM72XBswgGQiXtDaMpuRfuNN/AA2qFbn1hnqVbFm1HkN5A6vOzmiZyNwc3oSa8FRcWF7MaJ6T8ZP0n6EX+oeJM1IL9zUhfZjjLAukTM4ocPehuWknxE2GjujmHzi5DgEMAG5ZfGPZyprFRQONI8pl03stqB/bV2npbIBZ/KigxsDEcgO84sZepKACvgQTutOleH0O+iw6kpWqAdZzgSeRzvCNW7p//4ulu6lqG2KchLLDw8omOAhmzVZQ8URgnhtrakX7WlOHE4Cx6dtDUe9rtTrU23jt+eOKqaf1KjHT/Jdjyu39sletfo3NUR7Nbd3JCZbPesNpu9sDdGG+9tOLi+HupFQ5QIQrNf37ehwHrLpHWhQmosWmLQobGdk1Xzkn3GSNIMRMwR5lQRuD3qQ+n59QGRz7Lf4qzBeEU96Pfv9zHcxQe7MRXyMbbG9yPCwhSfBUMMxGsl6CBSLdahbLZYeXJHlNoLkarP9Nt9U6q+2wz9wifwQwTJNfYBhhtZ8z8ygtwbIUbSSP5EGirJZbb+ZH6bNzrxkYeSH94bIbdrhjp5zjzR3bAXYSWU+gtuifRkNs8UL/NPAanwA4K9BTwg/FUwQsRJUpqc+hSL4jsON0NVRfv5q5nRneQ/2N8kNZDXpmRl1Jpoj00W+6OzeOFR9ccCzK4B0TJ0Rljka3dubeuJ6hP6jqQ67VQiOdu MItVDnbC zYRvV+YIyitorNnnwODx95nYUUMc1uEVIUAblp4ZdmDCqE9RmE+Xwse7h4kUKuLMwSBNa5kV4069i4rVOB6XGYC49WBavFEFZXLcggNxENfFfu6TVo9fJlEjEG9htIFYO1XngmNQQw4ZIEc/FzSzyTRlIkrDCENfdM9uDGApY3KEm4F5Fr29aWNpZgytftZfeqsD7UDXxWJVznQXw/DUEdK+WvdP5WW7DcMjqJFY8HPKKt8AtxwYg57vZXErdv+wUIUujG+EOWtM1b+napmskCwgSleq/v4yd+h2X9HsBmUooVwXQlh0f/LWgIkxZCGP5tU2Ox9boUVwHTURCWwLU5ztOdfxBNfpH/C3+iOGrkUrCUilCBowqNF6emq/8a1WYt5x4 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 8/8/23 05:43, Ayush Jain wrote: ... > diff --git a/tools/testing/selftests/mm/hmm-tests.c b/tools/testing/selftests/mm/hmm-tests.c > index 4adaad1b822f..20294553a5dd 100644 > --- a/tools/testing/selftests/mm/hmm-tests.c > +++ b/tools/testing/selftests/mm/hmm-tests.c > @@ -57,9 +57,14 @@ enum { > > #define ALIGN(x, a) (((x) + (a - 1)) & (~((a) - 1))) > /* Just the flags we need, copied from mm.h: */ > + > +#ifndef FOLL_WRITE > #define FOLL_WRITE 0x01 /* check pte is writable */ > -#define FOLL_LONGTERM 0x10000 /* mapping lifetime is indefinite */ > +#endif > > +#ifndef FOLL_LONGTERM > +#define FOLL_LONGTERM 0x100 /* mapping lifetime is indefinite */ > +#endif > FIXTURE(hmm) > { > int fd; Yes, it's unfortunate that this selftest framework prevents easily including those FOLL_* flags directly. Anyway, thanks for fixing this, Reviewed-by: John Hubbard thanks, -- John Hubbard NVIDIA