From: John Hubbard <jhubbard@nvidia.com>
To: Ayush Jain <ayush.jain3@amd.com>, <jglisse@redhat.com>,
<akpm@linux-foundation.org>, <shuah@kernel.org>
Cc: <linux-mm@kvack.org>, <linux-kselftest@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <bharata@amd.com>,
<kalpana.shetty@amd.com>, <santosh.shukla@amd.com>,
Raghavendra K T <raghavendra.kt@amd.com>
Subject: Re: [PATCH] selftests/mm: FOLL_LONGTERM need to be updated to 0x100
Date: Tue, 8 Aug 2023 19:31:55 -0700 [thread overview]
Message-ID: <18ed929a-ab19-4bcc-a871-1c74c8b2d559@nvidia.com> (raw)
In-Reply-To: <20230808124347.79163-1-ayush.jain3@amd.com>
On 8/8/23 05:43, Ayush Jain wrote:
...
> diff --git a/tools/testing/selftests/mm/hmm-tests.c b/tools/testing/selftests/mm/hmm-tests.c
> index 4adaad1b822f..20294553a5dd 100644
> --- a/tools/testing/selftests/mm/hmm-tests.c
> +++ b/tools/testing/selftests/mm/hmm-tests.c
> @@ -57,9 +57,14 @@ enum {
>
> #define ALIGN(x, a) (((x) + (a - 1)) & (~((a) - 1)))
> /* Just the flags we need, copied from mm.h: */
> +
> +#ifndef FOLL_WRITE
> #define FOLL_WRITE 0x01 /* check pte is writable */
> -#define FOLL_LONGTERM 0x10000 /* mapping lifetime is indefinite */
> +#endif
>
> +#ifndef FOLL_LONGTERM
> +#define FOLL_LONGTERM 0x100 /* mapping lifetime is indefinite */
> +#endif
> FIXTURE(hmm)
> {
> int fd;
Yes, it's unfortunate that this selftest framework prevents easily
including those FOLL_* flags directly.
Anyway, thanks for fixing this,
Reviewed-by: John Hubbard <jhubbard@nvidia.com>
thanks,
--
John Hubbard
NVIDIA
next prev parent reply other threads:[~2023-08-09 2:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-08 12:43 Ayush Jain
2023-08-09 2:31 ` John Hubbard [this message]
2023-08-09 7:40 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18ed929a-ab19-4bcc-a871-1c74c8b2d559@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=ayush.jain3@amd.com \
--cc=bharata@amd.com \
--cc=jglisse@redhat.com \
--cc=kalpana.shetty@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=raghavendra.kt@amd.com \
--cc=santosh.shukla@amd.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox