From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08532C282C5 for ; Mon, 3 Mar 2025 10:18:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 95105280006; Mon, 3 Mar 2025 05:18:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8FEFE280004; Mon, 3 Mar 2025 05:18:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7EE4C280006; Mon, 3 Mar 2025 05:18:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 5F66A280004 for ; Mon, 3 Mar 2025 05:18:47 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id E118F1C7DA5 for ; Mon, 3 Mar 2025 10:18:46 +0000 (UTC) X-FDA: 83179841052.27.EC8DBF7 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf02.hostedemail.com (Postfix) with ESMTP id 08BDB80002 for ; Mon, 3 Mar 2025 10:18:44 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf02.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740997125; a=rsa-sha256; cv=none; b=Cm9J7K+5hW/o/XOO06XS6Cq4Fs+wtePJEEjvkuOvd3FM0xLu1YbcIi71TrRYRbaGQvZ/pU qSJzAUpjisPZMYnMORqlfL30+twn2szdDglXU/oA12HVobE2bCq8z0x0k1/4aXaa8AyHIq AR8dZgHDVKAfsCzO6T5r1pSaXy2b5ms= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf02.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740997125; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/wVsAHLwIWncArngeWc6UhJDZ6z+QNbPaB4p73MrFH4=; b=5TYaNzA9Q7r4DsN3H1rTGvUHIDnqbVhH7qcJJNm6uk1UfLUUY3qRMVnQnh5jPavx8voCmV j7YBMyHm85gZu0UfgahRP5atWQbpzoAp9jxSS1MHYCk46waygv8xXlPjGfOs7YF1PQ73mC jGIz1fsUg2lvfww1/UC7FmrK2zNtQaM= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4F2E812FC; Mon, 3 Mar 2025 02:18:58 -0800 (PST) Received: from [10.163.38.109] (unknown [10.163.38.109]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C17CC3F66E; Mon, 3 Mar 2025 02:18:41 -0800 (PST) Message-ID: <18ea9794-3901-4802-875c-b0327984a9d6@arm.com> Date: Mon, 3 Mar 2025 15:48:38 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 04/10] selftests/mm/uffd: Rename nr_cpus -> nr_threads To: Brendan Jackman Cc: Lorenzo Stoakes , Andrew Morton , Shuah Khan , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250228-mm-selftests-v3-0-958e3b6f0203@google.com> <20250228-mm-selftests-v3-4-958e3b6f0203@google.com> Content-Language: en-US From: Dev Jain In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 08BDB80002 X-Stat-Signature: g9kbtngdzixkuh5urj1cdyhg17u1tdcw X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1740997124-330339 X-HE-Meta: U2FsdGVkX18tjbpRQNEyN+0FwyT8Ev16medWbYPfrYT85IrX7IAoZ2AruNTJPSkAwm8Xce3eLHQUOSdo7w92O+67qfFnGpvnSZfoVeu86lD3AQ+ZYD88FqIEi1FqJi9NOTM2CWMHdaMqwH865J3J9IP3+yFxKaagMErOepvVAZQnhJL4urvjN4z8cusTljFZUCyc/wShOL2rsjHU9mEjSuKuLuaO13a0Bfr6x0rNsfg9qqksr2YnqcdiqzzF1DGWKzEFa24AF813RRcxldmxK6qleB6RC5lGuheEL8o2T8HcyH03+guiQtHfWyJX6BEBBNriI+kJyB8AbcG44ABjvVf9Zi+Ni2bFzvxykUSXh/Boy28PmH96OzW9MzFIk5VEwqUO1kdGzjmtc5YnkfgRceaYnFUkYvPpHIjaq1qM3rDouk+3rFt1lNoiz+xUyiTMC+75+1hSE+r8gCCf6VADduNROEgjM7m95ZV8HLajw9xkHUCGUMb7qliQ4lGG6AULBBY6dkM9c1V9UjB3PrvdEREu7xSHYY2DIcrbwIDmEJi6UPTaoHXwJ4HD+gAOmpHkrRB2HLNq1XCB7pK3gmmEIpwZDlA6Ie/bLrrzwARCQozqTFugGSD2J220AaqpRsx4/agJ0qVZWRZ6jmfKeXAWLPRjC6Mdbi4sbyBNvUTjDsq1gtZ7YPjfACKAf96IqyjHYNaKfFam/oPJTWmnsRcHbmrFZwiMR5nTT/YjaoL3fkghOss75y+Hx8D6cCH1cj+SBgPLHl63B/UvFUitU+RmgISFIKkTDkUg6iHZA7afXTaTMLg5c/L6hpxhXggpFm+RYvJ6HsbJrtX6B6dgR72RvjO93JhzPA+co5RTsR1bddrEqJiOCgL0tvhPK+htBqNN6Po43IkDwRUPovoOkqM52AI4UFSiVhw+YhtPGY1DR4a1fc7hHL6EkVK5LUZGpe4USkLAdUreY/cQK8sIwn/ 80RxMGc5 crzdUjS77yslbpE5SVQNFbEcnBS8tayZ8SJqQwZN6Qedy5c/SeACOj7C2pr7B7APYc94OemeJJssSt82e2wEbCOxc8Jmr1W12UI3VwKVuIVmrrzl7274igUdyV3nojc/8HMN/Fzbun1bdF/RA7I/ReAjEAs3J3BYMMQySJQkwuSogG1hl1ur2CtswSm0erxGH87X4 X-Bogosity: Ham, tests=bogofilter, spamicity=0.230326, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 03/03/25 3:17 pm, Brendan Jackman wrote: > On Fri, Feb 28, 2025 at 11:06:35PM +0530, Dev Jain wrote: >> Taking a cursory look at the test, it creates three threads for each cpu. >> The bounding of the variable is fine but that being the reason to rename the >> variable is not making sense to me. > > Hmm yeah the name needs to be more abstract. Do you think nr_workers > would be confusing? Or even just "parallelism" or nr_parallel? Or any > other ideas? > > FWIW I briefly looked at just cleaning this up to remove the global > variable but that's a bigger time investment than I can afford here I > think. (The local variable in stress() would still need a better name > anyway). > > Thanks for the review BTW! Your welcome. I personally prefer leaving it as is; unless someone comes up and completely cleans up the structure, let us save our collective brain cycles for more meaningful battles than renaming variables :)