From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D305C00140 for ; Tue, 26 Jul 2022 14:04:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EE1798E0002; Tue, 26 Jul 2022 09:45:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E902F8E0001; Tue, 26 Jul 2022 09:45:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D582F8E0002; Tue, 26 Jul 2022 09:45:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C6FE58E0001 for ; Tue, 26 Jul 2022 09:45:55 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 8B23012093A for ; Tue, 26 Jul 2022 13:45:55 +0000 (UTC) X-FDA: 79729374270.10.7EBC229 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf20.hostedemail.com (Postfix) with ESMTP id BBB781C00C8 for ; Tue, 26 Jul 2022 13:45:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1658843154; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U0RbgNeCMWGTLl5NaMw002w/avfS4HhxBQ3/PBLMnCQ=; b=GhS2dtlG1FtdNJ8K8BU2hlzHCxxcdiQN3Eov1nzkCZgN8JeskT6rV9A/SlqWogMiutdqPv 7WTViMDVjpYX8UIlEwFi3IN1dzGj5bIfrY5H4WPQsSfFZUKYyl2Et3YPZURmWmDP8qj3yN G/TPFkIuNIZEnUmUiCkWYK4Bj3xM858= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-553-3akAAvoBNm-JDFgAarjcHA-1; Tue, 26 Jul 2022 09:45:52 -0400 X-MC-Unique: 3akAAvoBNm-JDFgAarjcHA-1 Received: by mail-wr1-f69.google.com with SMTP id e3-20020adf9bc3000000b0021e50518071so2115592wrc.2 for ; Tue, 26 Jul 2022 06:45:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=U0RbgNeCMWGTLl5NaMw002w/avfS4HhxBQ3/PBLMnCQ=; b=xM578MPWgxqwZ5fJS0eBSGNatrdbPLKTZ/mEIzL42YWRfYESIyGRrAKYZ6zWnAtZnX LV1i4c9aHy77CTL8xnGQNbjlw+7pjNCV3fEWkxoOgYjlnv3k/sVYAoDN5xmiJ+DJOhOP 6IaiSpUSuTkMSQWfX3p8zUdYT9PMU2IFWw/tukJ+ckx0TRLI1LcwuummnA7uRpGrW3hd xTgRXGbrs0PHJejlArLOYCoG16B3DO8Irioelb975a4CONP5HajI6xbNI2XWbNO3juv1 VHeVbVAUZI6LqxvCBzaJw82mN2TjCxNnvlDaKeAb6zAt2o29HxAr+ZjXjjmmL33fhgYy AEKg== X-Gm-Message-State: AJIora/vjBticAHD7bAt+4JyPwZmNqM4INKZmNhfZLnAIBpSHc5xFYsR XZPvjN/fxz/sJlwifxQ+DaHXpYZ088FpXz1Q0YCcVia1RpRRk6o2LvO93m2xDBigrKxuxUrtscX byGduoS/r+r8= X-Received: by 2002:a05:600c:6002:b0:3a3:5453:bcbe with SMTP id az2-20020a05600c600200b003a35453bcbemr9010628wmb.190.1658843151694; Tue, 26 Jul 2022 06:45:51 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uEdYS/8GD2rKXrwKi1xsxaGrPurKtjlF+VbooQh/DnQoNo/7sFgoDFG+enrLLNF4k9hzJrTg== X-Received: by 2002:a05:600c:6002:b0:3a3:5453:bcbe with SMTP id az2-20020a05600c600200b003a35453bcbemr9010611wmb.190.1658843151474; Tue, 26 Jul 2022 06:45:51 -0700 (PDT) Received: from ?IPV6:2003:cb:c708:fe00:8ba4:5871:abc3:8a75? (p200300cbc708fe008ba45871abc38a75.dip0.t-ipconnect.de. [2003:cb:c708:fe00:8ba4:5871:abc3:8a75]) by smtp.gmail.com with ESMTPSA id l35-20020a05600c1d2300b003a2fc754313sm19918457wms.10.2022.07.26.06.45.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Jul 2022 06:45:51 -0700 (PDT) Message-ID: <18dc0807-5596-3aad-350d-3673a033bca8@redhat.com> Date: Tue, 26 Jul 2022 15:45:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] mm: add warning if __vm_enough_memory fails To: Kefeng Wang , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Yongqiang Liu References: <20220726072451.142427-1-wangkefeng.wang@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220726072451.142427-1-wangkefeng.wang@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1658843155; a=rsa-sha256; cv=none; b=4gzMJ53aEWIjx/bUg7MS928KP5rVUCyykhQ2gH0kQcUuOyJBGpQ9tF2//ZLdRPUi68eZkR aInx3OqDZE0orxrMfdFt3sfQgrUzqucDSHnWYh3gqE8WpeWwXOXBetMszqQ/tHB/eovkf2 DXWX1iIcZmfGZRHNBjZa1CX0BI6H1lQ= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GhS2dtlG; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf20.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1658843155; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=U0RbgNeCMWGTLl5NaMw002w/avfS4HhxBQ3/PBLMnCQ=; b=dB+cqAfcNmWdnEn6PG95gP8Oy9E9+4B50efu3IGmme+RUh3KMIOi+3sIHsaFgSEQtsRq1W p8JQqlivlf1ttGLgLolX5Qvu7GJg8BFg58wc0NcDM4k/4hyTGzfbFz/RhZShoBjOj366wA WxEGV/3ZBnHqscdv7VdZEqquPMFBdXg= X-Stat-Signature: 7dnd9mqksoed8t579uazgf3bu6stwh57 X-Rspamd-Queue-Id: BBB781C00C8 X-Rspam-User: Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GhS2dtlG; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf20.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com X-Rspamd-Server: rspam07 X-HE-Tag: 1658843154-189592 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 26.07.22 09:24, Kefeng Wang wrote: > If a process has no enough memory to allocate a new virtual mapping, we > may meet kinds of error, eg, fork cannot allocate memory, SIGBUS error > in shmem, but it is difficult to confirm them, let's add some debug > information to easy to check this scenario if __vm_enough_memory fails. > > Reported-by: Yongqiang Liu > Signed-off-by: Kefeng Wang > --- > mm/util.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/mm/util.c b/mm/util.c > index 1266a33a49ea..19bfff8a0ad6 100644 > --- a/mm/util.c > +++ b/mm/util.c > @@ -1020,6 +1020,8 @@ int __vm_enough_memory(struct mm_struct *mm, long pages, int cap_sys_admin) > if (percpu_counter_read_positive(&vm_committed_as) < allowed) > return 0; > error: > + pr_warn("%s: pid: %d, comm: %s, no enough memory for the allocation\n", > + __func__, current->pid, current->comm); > vm_unacct_memory(pages); > > return -ENOMEM; Users can easily spam the kernel log, no? Maybe at least ratelimit. -- Thanks, David / dhildenb