From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF886C54755 for ; Wed, 14 May 2025 17:53:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D533F6B01FF; Wed, 14 May 2025 13:53:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D00DF6B0201; Wed, 14 May 2025 13:53:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BA0DD6B0202; Wed, 14 May 2025 13:53:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 9B7BA6B01FF for ; Wed, 14 May 2025 13:53:13 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id B7096E287C for ; Wed, 14 May 2025 17:53:14 +0000 (UTC) X-FDA: 83442259908.17.21BD15E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf04.hostedemail.com (Postfix) with ESMTP id 3AFEC40003 for ; Wed, 14 May 2025 17:53:12 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="hY/Afple"; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747245192; a=rsa-sha256; cv=none; b=ucMHFV4hO1sLRkqQU9j/OWRHh7y1pE635i/HKK1yJSnEKNPx7C14PNUglgQrsAfR9r+dtp ncDBG4QSNq5Kpph1ZEkiHE0VqAprllVzbGxGHZAUSY1nGUJ4b9uNVO3QQqLSw1lk+xZhnP SxB8wSqCGz78XDKXqV/738juoqxG/nE= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="hY/Afple"; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747245192; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=T9gEkHcNNRGwG4zKAICU/T3iGmVhFST3CjssIJGy95U=; b=OqnYPtAtJ/UqpWn2mvCFPpbzpBKzarZA7ptDa78lG6nuGEqmfmvvssYOHKt7ZdG+H9qirw OhZ869nUejcZRLaDJeFwl+2iufHWwxc6QtcZbuPgGALd8ofXDjCg6ZmC4WZgRqhnU7qZE2 T+eMBn+y0Y5z6DDrNi5QSAw8bHXGnnM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747245191; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=T9gEkHcNNRGwG4zKAICU/T3iGmVhFST3CjssIJGy95U=; b=hY/AfpleGBmzzzapay73c0gYRGc/n6ejVyTCR5p0xXuwweBVxDQZooxypvpINM4LbM1WvL QI2kzS+kt2XPZ3dhW9iZl0/z9nTDZCxtnqUhf5EfW8oZqISz/AnvmPQxpByM7/Qb2ObjSc HLvfq5O/JwuGAmntV5D1mSWyqblpPsI= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-433-U16V8XS5MyGwWC18T6fACw-1; Wed, 14 May 2025 13:53:08 -0400 X-MC-Unique: U16V8XS5MyGwWC18T6fACw-1 X-Mimecast-MFC-AGG-ID: U16V8XS5MyGwWC18T6fACw_1747245187 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3a1f7204d72so27833f8f.0 for ; Wed, 14 May 2025 10:53:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747245187; x=1747849987; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=T9gEkHcNNRGwG4zKAICU/T3iGmVhFST3CjssIJGy95U=; b=c0oKqOvbiYfO3W3ZFWzdK+0RnFBK+Kc7wgcByxoemwORJp3M1JljA17/SEL/QZZQgR wwpXUnwg3CK4aiDVkxM8opu0GMJbHlTvNNahhQrMg0XY8EaJDzeMm9Ec8q0d+lbC5emG NdJjS3cZ/UoLcnauT8c1ZbHwDAXXKH0rg2vd4ivnSC47EToh++psIh5SVZzVy10iJq+I Xa0bzPPXKVEDxW/QwYfP0cS1xprkdPKl7mcHqcc0LTUcQvdE55ta7nCru5Ey4M1JBwkL 0wLEz7Dm2B7oJkXqZZuIEBdUCq4E81Z0yqbNosws3kwkfTPC/tYxzjXCMqUN4gq72lkn L1HQ== X-Forwarded-Encrypted: i=1; AJvYcCXPbnDhSX2bBu/0PopiGEHAQP2mb9SoAKgxgKJSYGwYa5f7StCizQBHvSywsSVKt1OzHTvpbXpBZQ==@kvack.org X-Gm-Message-State: AOJu0Yy3bzuM2LF5+LJEZOmCZm/oArnTlt1e0UmlsJJH3iLC/d3P+YNV P1ty1O+Jw8aHZ6+4FjeMJ6ODD8aYCZVjLNvS5dkMGtrKSWrTJjeUPGE8cFTvz1/7T8I7medcPj8 m66B640Ovah2J5GVCeHnjNo9GBrKp6THJTp5L7kFufNBFSDaa X-Gm-Gg: ASbGncuav5G6Q8JpRPk1RhYsO6YZLu4GdK8BOhaoqIbjH+ahst2DtdFNGOk4g1ubpvf ETdS3la8F+CdsNTg5PJkHTQSPeKrU7XAKgIiN8twk7E2Vg4LQirqoR7Uz7K5uhLUhSBG0ybFiYG 1VaTRC/z25iHJaMC366J3AfOcgOgGTEsTvvazVG3kpKh6sWrW0E4g5qs49tnxurd7devKBfScwO 8EeLKOQcxR4gazoxP32F/cdgBGBkf2xcb3z3zkoBUcul/pVQGFkHxYjsmUYaereqfYJONbW1xp3 ew7w0rYVRaiYOBoedJTmA1+7C+M+UfDV5Nz5qqA0Xx1TEjRI60V+cH0m7xgWBSIGh4/6o5PQ6rH DfaOGCtKSEVSl3nQ48m7BLxS5Z0aDQTcaYO8JnGI= X-Received: by 2002:adf:f7cc:0:b0:3a2:2d6:4205 with SMTP id ffacd0b85a97d-3a349921da8mr3561083f8f.47.1747245187408; Wed, 14 May 2025 10:53:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHI/rQoUNdarqySB6UGfLmR7K5cvW1c5VoY82rTRIWoLyPgqKa4z52Sz2Zo6d+MLUSeBgWoLg== X-Received: by 2002:adf:f7cc:0:b0:3a2:2d6:4205 with SMTP id ffacd0b85a97d-3a349921da8mr3561064f8f.47.1747245187062; Wed, 14 May 2025 10:53:07 -0700 (PDT) Received: from ?IPV6:2003:d8:2f15:6200:d485:1bcd:d708:f5df? (p200300d82f156200d4851bcdd708f5df.dip0.t-ipconnect.de. [2003:d8:2f15:6200:d485:1bcd:d708:f5df]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a1f58ecccbsm20532621f8f.32.2025.05.14.10.53.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 May 2025 10:53:06 -0700 (PDT) Message-ID: <18d502c8-7bbe-470e-863c-7c2f42ea2487@redhat.com> Date: Wed, 14 May 2025 19:53:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 08/11] x86/mm/pat: remove MEMTYPE_*_MATCH To: "Liam R. Howlett" , linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-trace-kernel@vger.kernel.org, Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Andrew Morton , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Lorenzo Stoakes , Vlastimil Babka , Jann Horn , Pedro Falcato , Peter Xu , Ingo Molnar References: <20250512123424.637989-1-david@redhat.com> <20250512123424.637989-9-david@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: YeYn-9R-JU4F_D2aasiWGGeLOBlk9zvbNbq-zXMd-i4_1747245187 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 3AFEC40003 X-Rspam-User: X-Stat-Signature: k8fbcqmasducbbppkk14d5f96rh5g9wa X-HE-Tag: 1747245192-608138 X-HE-Meta: U2FsdGVkX18FoYuMBERlt+XgVy766D+CLy9xl0uX5wjBAmQXGm+Ilr1Usp6Wl5+zJci88ayr1e4BKFM1Xfw2PxfrEtZSb6tPE6qZJbkIBjoc8TDfJA+mWIefHBUxpnJlXa8+/BomGR5CAPsH70T0D5jmi0VKKcSEyriDlAnWkJ/gv/7mfvH8n7y00lh4TWNvQBfLLq8pFCG8n6sZrv3OXVZLTXMtIE+bm7Lfq4YdyH3w/fmj0dLul7bI7ZbDB6DNfNoHWtgTbvbMz5+Clm7EzvLp49bMyoLptCvOOE1MOnRq/O7vz8ufVvbZzB2dUaYXBoeB7AWzj13vRhcHQ7c6XIhFyxxzXuaT0cFs06UWKzcZgZdcARlnjo4g8+Y++RC6Ekre/3MHgTHV468VpQ0QPlYlxxZtTAjZNQIO5KqnBpboFhtcWi1W75gPFPieNzatQmGyNVmH8/DFZVuBFrXt4Z21N0iyuEmLrZKIHDxuz4exHYLiB5HnPiYA/j7umS3rWyoa6TpkCbEKPI8kUZ/c+Tz/3mqAl0Ko0gK0R0njTP7npQDr52l923E99SBfXpGPw4MR82O6ZemIioJUsBcoXaagd23aIsP84rMXXbscuzCh+on+pxYljo/ScTssOUw/FA2fUJrkXF+/KFnjv9pnCAefmCap7IwwxPlbphAtTBYMNUkofokSrqYKUYPhyAoGQQn0iDhZgeqOxgLYY7nBWXjxG9vLuUNuookO8VQMcfdsBeq08dKHwhp+FOBMMXTpgslsYqsmA1/SsY/GF99sxV7ewYHUBo8fYg9+R7/Brihb4g5UUEyJYOIjpZZObUUpRHih/0jggXkBjazar718IZxu90lLVOZ+/Zs6CxRsug9mvTKadogKhQWNomTtdtmVohrrU9ZO/upx+B1xAKRxukCXTo1sYFnP4EacAct8ytu56sSgOTqYmkM3b6QmnAbY1rLVgF3vhjVqGTSjmc7 H+0IrlWo s0qZcRNkKq4lTRz/5Mj+bS0Ou6xSFDXzGSvyM9+4uxDWvmTNAn9Yjih1/a3uAJKT2G6FtIPnj0n5oDVLsfTKsvbEmXPOBXrBcQ0vek5/O2LM9yytuiVwxzw+iEAuRFHngg4WDAkD6T1pdi4xHIKAXbuzBCY4QbCV1f1iHjMVoyJe7kXlhySSaLAGJZ6oU8V8A1b4HKAoEcd4aBNp7dPiEC0MNvN2tnpfuhp2lyCrd29J9sosxJA1a74Ej6aFCxxx4oq0qPW1h6rmatK6D4OVwqX6krpTTXqVBbKivp7eee7B/XNLyz++ruD10Ujda/O5hC/BVbmuzUXL5MbXQ3VnGheFijflW5jMOIbxKE7RudaLjo8UthOedYDjhsC3ULq5OMinC7orzP9Qevaqovz7ur4DB3iElOARbRUD5Om2dV3Q+gngEEXcU2/wONI+Tv+naEJB8kHDFtCUXNIm8LZjVNR1Eo7pYMKVIJgcSgiDtGzdYukHd5fCL+t6d6LxdvC3EUz676L7uL2UMxpA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 13.05.25 19:48, Liam R. Howlett wrote: > * David Hildenbrand [250512 08:34]: >> The "memramp() shrinking" scenario no longer applies, so let's remove >> that now-unnecessary handling. >> >> Reviewed-by: Lorenzo Stoakes >> Acked-by: Ingo Molnar # x86 bits >> Signed-off-by: David Hildenbrand > > small comment, but this looks good. > > Reviewed-by: Liam R. Howlett Thanks! > >> --- >> arch/x86/mm/pat/memtype_interval.c | 44 ++++-------------------------- >> 1 file changed, 6 insertions(+), 38 deletions(-) >> >> diff --git a/arch/x86/mm/pat/memtype_interval.c b/arch/x86/mm/pat/memtype_interval.c >> index 645613d59942a..9d03f0dbc4715 100644 >> --- a/arch/x86/mm/pat/memtype_interval.c >> +++ b/arch/x86/mm/pat/memtype_interval.c >> @@ -49,26 +49,15 @@ INTERVAL_TREE_DEFINE(struct memtype, rb, u64, subtree_max_end, >> >> static struct rb_root_cached memtype_rbroot = RB_ROOT_CACHED; >> >> -enum { >> - MEMTYPE_EXACT_MATCH = 0, >> - MEMTYPE_END_MATCH = 1 >> -}; >> - >> -static struct memtype *memtype_match(u64 start, u64 end, int match_type) >> +static struct memtype *memtype_match(u64 start, u64 end) >> { >> struct memtype *entry_match; >> >> entry_match = interval_iter_first(&memtype_rbroot, start, end-1); >> >> while (entry_match != NULL && entry_match->start < end) { > > I think this could use interval_tree_for_each_span() instead. Fancy, let me look at this. Probably I'll send another patch on top of this series to do that conversion. (as you found, patch #9 moves that code) -- Cheers, David / dhildenb