From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A511C4332F for ; Mon, 6 Nov 2023 16:23:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8BFEB8D0024; Mon, 6 Nov 2023 11:23:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 86FF78D0002; Mon, 6 Nov 2023 11:23:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 737758D0024; Mon, 6 Nov 2023 11:23:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 618888D0002 for ; Mon, 6 Nov 2023 11:23:55 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 363EDA07C0 for ; Mon, 6 Nov 2023 16:23:55 +0000 (UTC) X-FDA: 81428050830.01.E359F3B Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) by imf10.hostedemail.com (Postfix) with ESMTP id B6A45C0023 for ; Mon, 6 Nov 2023 16:23:51 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=F7fetzsJ; spf=pass (imf10.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.208.42 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699287831; a=rsa-sha256; cv=none; b=PzazVRzzyBjMcS1JH8hKIHcy5+IRnD090So1Pu6R6KGV35hF21z1ORLm0k17i5eJInULUq kacDpTh8VegrhpZx7XLOojnOGAKSobhUHWEt3COoTq5qcmGf/uAAZUzR6HrxIiiOHaL5eo kZESwrs2EsNkHiNDxxdcCpl7NPKnt8M= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=F7fetzsJ; spf=pass (imf10.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.208.42 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699287831; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=X/OUAVDeDW1FGUoOSfZFrOaeiTbPIasE84BelZaNPzo=; b=QTrFFFl3SexwiD/lOLhhQuglRRKyV5waO7360e51ZZOkAIGFI7ll7p5348YXjKDLQtfT6w dy68s5XZ+PcEBVJK0orqpqbFbGNf3Fl/P6sKw1RQSiVzIhGrDcIK9F/XkJjIt7eFvzi/lL TaxGV64Gz5qFb3VMf+pj3K0dCjlEuFI= Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-52bd9ddb741so7826183a12.0 for ; Mon, 06 Nov 2023 08:23:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1699287830; x=1699892630; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=X/OUAVDeDW1FGUoOSfZFrOaeiTbPIasE84BelZaNPzo=; b=F7fetzsJyP2oYJrJ2R9zFk6qHo56qy26S2SpYpM4dggKFIYhbqzzoceS1C7n27KXWm YU9nNNnkC6Vb5Nd6kYLWnhg3PtCWMoosDZx0j0E8tfnPIGvroHozbEh7koSxK4U2zySd 9h1llyPj/v548sJVk7S143Ox+Bch2RVji943X4hMTwG3ClGjn1dqIaU4aIUe/XUQm0b5 43YKRSqGCgvkKs732GRN54pav9n+7GN0udAtE/D+7vIJxRBCchoNmhlmUEHhHUj0ZcT9 CzJ+8z8gNh54t1GohxMbrC6QArGJ7NHJPsmw+crElt2XO85GAWCluEFEpKUacFT+Cs+X jb0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699287830; x=1699892630; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=X/OUAVDeDW1FGUoOSfZFrOaeiTbPIasE84BelZaNPzo=; b=UWtOLXk623QU1xeCDsL32hKzqKM1yDRfP/PxdzHEtLLfEQStyDAbOSjQ4q4GAmLH9w 5A432xrTQbTETQs+N6ayBYux2nQivWsJ/+PBH/y/4FQwZEwwWGE7i3c7q9akZnI0NSHe PrqBt8ENHing9TQTPjAm33IxmelzLf0vExbu2OfDj5a+amamnVo9h5uY1Cq14Jv2Umlf Zi4iQherYhOw0Jnm0Yl7z5iKvbWyYtmHU4T0dWnx8Z1ImBl6ZUt+C2s3Z4n/1CeccdyT cPkESEBtoZFwsA4eiB2YuP+Q/sNT8S3j5RUoHeOa+DiTU1fWbRUYh/7+/9V9w0uMe00x l2dQ== X-Gm-Message-State: AOJu0YwRsxZ47DI/WQ1g0Mt7rbWjFKrDMrGC0ATCo9gzFr1VfHcozVPq hRR3IDaW3YYjcK6saP4Pzfo6Y2K0Q3LDv2QxDNs= X-Google-Smtp-Source: AGHT+IG/uWw3t03bxC6ITNHK1stt5SDvYXWCBLutQwdEau303Xm9GJiqyFC6IuLXZUC9vBhJ+bwSYg== X-Received: by 2002:a50:d781:0:b0:543:cc90:cb8b with SMTP id w1-20020a50d781000000b00543cc90cb8bmr10520995edi.2.1699287830185; Mon, 06 Nov 2023 08:23:50 -0800 (PST) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id eo12-20020a056402530c00b00530a9488623sm4463765edb.46.2023.11.06.08.23.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Nov 2023 08:23:49 -0800 (PST) Date: Mon, 6 Nov 2023 19:23:47 +0300 From: Dan Carpenter To: SeongJae Park Cc: Andrew Morton , damon@lists.linux.dev, linux-mm@kvack.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] mm/damon/sysfs: eliminate potential uninitialized variable warning Message-ID: <18d2f41d-e442-4f73-89f1-50bf20cd85f2@kadam.mountain> References: <739e6aaf-a634-4e33-98a8-16546379ec9f@moroto.mountain> <20231106144137.9772-1-sj@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231106144137.9772-1-sj@kernel.org> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: B6A45C0023 X-Stat-Signature: dayjwix8gki1ztt4ydgxz6mfyyh5cnen X-Rspam-User: X-HE-Tag: 1699287831-746494 X-HE-Meta: U2FsdGVkX19Uo6O6knLhyAssDMdjh745qaZlAjnvKJ6TnuxnVs1NexTd9qdBFy6DiOLnI2qPkYKC1+Axw9DBmKugt87uVKe+pckcj43PBqsjw2Mc3Stc9OX0VU+MsuWIQ4rm6Opr0/QFC+2uWoutOl+V/KZSaoSfF54ia4lFYCXg7dSc3gvEGhzjsAiE8Gbx6Xu/hXK/pxca1fb5sSV6TRZ4xlpK46P4V72YsMNLImzaSA/HiOUP1EzsKnisOZ3DgUAqEHmy3zi0IeA2bDkAfpUy+Sb3+sj93nrsp8RbeHiCXWZIo2VxP9xGE1Pg4qVTMNB+iBETF+nOOxgCEhAh4D0QUqMEtdLO1BE/E6wJ2xwktA6sFM6gCp8pJ8crVUI0KR51scHabRfF6/U7Mca5498vbvnjzY3Dp19ssnDM2eAR2hORQ3QNaH9YhNYeh5StVWs0WsHBNw4otVsmuloCx2yZXIo9eLP6V9FmaiXWmeGEE9dOdzt4nDb86vqxsxExTK/SnRvLJsAX64hZDwgoNVaJuhy50FIsL0suphWMezrUf1uwsTjgIMcuqWJ7PHvWYZxan8MKXwai8S7SXUTKg+u7TtXHV54UablkLMI2sRgUYg/7M9eooFmzmyVoabtHYuPn4CjoBi6BcMUVxpONowcLDxpQ1E+Pn3BJe0mATLLjJXVoFX9/vFCqaG4TL7zldqwfAcHJQ+xcDRCv9A+h8UKOTnFlEM5tOJyT8C4ZyyVCsQNImJ3fFoGMFEIyWlcmOf6bQgw/0WZ2OSgoMckp/rxdTUq+morKC/nBUmnReAh8UObTvAGIbfx33E2N+r6xVlflN29uen0PhmaqQB3Xes/Qb57SP2mEv7JLIjxHLfwA7/wJ4/oZ9M0qQrEy6Ih6K3O6Y8GU24l1xBVYhQJRaPC/izVk/WWdl0GUJAx6uOv+6WkAst8mOr9/hF4dnhy8oYAWg+T9+7QdrDwcqNh 7g/43AFK 0kLAkDZR+VOwhJS319ipwEyo5QZNBn0XSbAEdiTwS8AF+WDLaCEwnPPnlVj/e4yTaCq4Q+k8KJnLhizFdyB3jrig79n6Ndtv2wRDoXjJkDCYmHn3nr0eUSMHUvOctAIu/2xt8k4R2GxjTSB3cRcLyRwHJY/yfkRFO5BxGeXiAbSZ7wh/v3I8pN1pQOmhWV8OwMptBRF5E5u0/a2ATFTGpFqlcjAHd8Ebb6847f9kdUhd9eK/AsQYQj/sseF2b+WbVMcUpBnjEO5s9i9mA6lVyumY0Px/EVhpVD0rTDN4JutaeCf+ejfq1YS3XAgvFi0pSmm3mA8rqTjna62oN1eewYTcWhnSjgZJsQWhdmbMN3bpv9B0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000473, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 06, 2023 at 06:41:37AM -0800, SeongJae Park wrote: > Hi Dan, > > On Mon, 6 Nov 2023 17:07:40 +0300 Dan Carpenter wrote: > > > The "err" variable is not initialized if damon_target_has_pid(ctx) is > > false and sys_target->regions->nr is zero. > > Thank you for fixing this. I actually noticed this issue from Coverity Weekly > Scan of -next tree (CID 1570878), and was about to send very same fix, but you > were faster :) > > > > > Fixes: 0bcd216c4741 ("mm/damon/sysfs: update monitoring target regions for online input commit") > > Cc stable? > The fixes tag is from last week so I assumed it wasn't in stable yet. Also to be honest, I wasn't totally positive this bug could occur in real life. regards, dan carpenter