From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DC30C369D5 for ; Mon, 28 Apr 2025 16:48:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D10426B0026; Mon, 28 Apr 2025 12:48:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C98686B00A2; Mon, 28 Apr 2025 12:48:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AEB646B00A3; Mon, 28 Apr 2025 12:48:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 886E16B00A2 for ; Mon, 28 Apr 2025 12:48:04 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id E8BAB140C0B for ; Mon, 28 Apr 2025 16:48:04 +0000 (UTC) X-FDA: 83384034888.14.3BA5DF7 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf16.hostedemail.com (Postfix) with ESMTP id 79BF4180012 for ; Mon, 28 Apr 2025 16:48:02 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=PtHukaKq; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf16.hostedemail.com: domain of venkat88@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=venkat88@linux.ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745858882; a=rsa-sha256; cv=none; b=8km7NiKz36K2A+QMsTDEapnA0oDJu82FiwryzdMS8Pv7JhnhUrxNyBg1scY1ohuusBC/Ym B90Hl0RNTnhIpB8DplDPJpza0SlXsOPySDuwnmaO02tjKtPb69/Aha4GqafMVbLeOWXThs H3mBoMaE6ISjbvdRR6jjsfAeMQRmxnw= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=PtHukaKq; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf16.hostedemail.com: domain of venkat88@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=venkat88@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745858882; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IE11iFGkxt6+d8e7SYO/zW7y+SDZ0cXPl/ZiULcYduk=; b=S+twF5D0A/SqaSY3XxH5u8yf6huHxCwqiZnc/2IfkEKlBsbCMYThTqYqOV+Ai/JGRxICz2 UWNO1qanTGEeJpVq1gY0kMfUvL/pduZYgkC4/xBMaC9xHnk219RzohPP3Lb072Ok48vqiS hE93wfnQRbY/35RS5r/Tf9XYQDSZijE= Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 53SAFSlS006000; Mon, 28 Apr 2025 16:47:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=IE11iF Gkxt6+d8e7SYO/zW7y+SDZ0cXPl/ZiULcYduk=; b=PtHukaKqw4z3BRk+B46UNG Ke+9X8l5eYf0aoPsBt+Uk9ACnVbnvn6m0lL1lGo44heDEScW3B9dRdT+pfECO3O0 d/HGKBgh0r3uktO4g9IqVW2SLy75rSNXPdZGj40V9O7RfKmXEfwT/N122AcNTKW/ NndMU5y0LfW5Z8JpTDrg33TKZjSGcCfY5zIsXlYXhwcsqWb8hxxKDU6kZp1SyZgL ELU/f+cRBstkTBf+2aZdcxSAOhHo60tr1df0PfuKfF1JUwDhbyjS1WH2QOTK9m0H 6xaZqn2c6a8wZY3yhDHP3EmQ7AEZ+MeXEYglgymDDr446RbUEA61DrIdzdXv9SiA == Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 469vqvmbgr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 28 Apr 2025 16:47:47 +0000 (GMT) Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 53SF55iB016122; Mon, 28 Apr 2025 16:47:46 GMT Received: from smtprelay05.wdc07v.mail.ibm.com ([172.16.1.72]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 469a707fjn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 28 Apr 2025 16:47:46 +0000 Received: from smtpav05.wdc07v.mail.ibm.com (smtpav05.wdc07v.mail.ibm.com [10.39.53.232]) by smtprelay05.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 53SGlj7u54722914 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 28 Apr 2025 16:47:45 GMT Received: from smtpav05.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9E7FE58063; Mon, 28 Apr 2025 16:47:45 +0000 (GMT) Received: from smtpav05.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0593A58043; Mon, 28 Apr 2025 16:47:42 +0000 (GMT) Received: from [9.61.244.200] (unknown [9.61.244.200]) by smtpav05.wdc07v.mail.ibm.com (Postfix) with ESMTP; Mon, 28 Apr 2025 16:47:41 +0000 (GMT) Message-ID: <18c375a5-9d0c-49ca-995c-efaec95aa3a7@linux.ibm.com> Date: Mon, 28 Apr 2025 22:17:40 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] selftests/mm: Fix build break when compiling pkey_util.c To: "Nysal Jan K.A." , Andrew Morton , Shuah Khan Cc: Madhavan Srinivasan , Michael Ellerman , Segher Boessenkool , linuxppc-dev@lists.ozlabs.org, Kevin Brodsky , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250428131937.641989-1-nysal@linux.ibm.com> Content-Language: en-GB From: Venkat Rao Bagalkote In-Reply-To: <20250428131937.641989-1-nysal@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNDI4MDEzNiBTYWx0ZWRfX6tEt5s6HzDTO RfUexhfTtbx+K1wfhc6nWOrEuEJ1oXns+O/kf43gZ/qNe2Gli8r7OUu2q8TSFDCbqdRyxYjpuzM BPHRjqXSpM24km4euNMRfKgVFwVjJT5CPrrfOyDpRE3lKIXnLcNhVoSg3B8FUvdJgjz2mYelT/T M6UFXT2OpYbCAoUiMVQIzX/fcD0FFOADvouaftclRCLfmR4VoONP0X+MTZV0l4Hs3SWU0yKB+oG /SnZVR77Dqr30oH7hQofIByrZ1V+cxFy8j97Ngp6nsTAIZUgJx1LO//DJOLt/CqHRYCnFySSaRS qOmpqEkCNMB4Ka5gmJKQq/Pmm3CRcQ4t/2vaGGhXCwUNKZEFUsXcsBSuZuwV3CeL2gI4yRtQpXu AsSdYxQxQr3IeFMSgcmlv+iXPjmDNbXtCn/rv3/AHSZuW+s1cMzFHcIycXvuHL/S+y7PbQvj X-Authority-Analysis: v=2.4 cv=AP4PelLR c=1 sm=1 tr=0 ts=680fb133 cx=c_pps a=5BHTudwdYE3Te8bg5FgnPg==:117 a=5BHTudwdYE3Te8bg5FgnPg==:17 a=IkcTkHD0fZMA:10 a=XR8D0OoHHMoA:10 a=VnNF1IyMAAAA:8 a=yfRTT-X1xsbtue6_pAMA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 X-Proofpoint-ORIG-GUID: pIOnp1wWl2vCrNGN-I0LjbyS1booz0fH X-Proofpoint-GUID: pIOnp1wWl2vCrNGN-I0LjbyS1booz0fH X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-04-28_06,2025-04-24_02,2025-02-21_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 clxscore=1011 malwarescore=0 mlxscore=0 mlxlogscore=999 phishscore=0 spamscore=0 impostorscore=0 suspectscore=0 priorityscore=1501 bulkscore=0 adultscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2504070000 definitions=main-2504280136 X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 79BF4180012 X-Stat-Signature: wpf1kkdtw3d51msxaa89io9pigtaww4u X-Rspam-User: X-HE-Tag: 1745858882-281411 X-HE-Meta: U2FsdGVkX1+EEoR7YDKkzsSKWaYt3T8uotrvdQQ3iPWoY+sSE0oN+U0cXZCr8dA5hGJiCykW3f5UcLfnb7JE/bjaoXI4sPAZjmdmev5J7dYNlkHe9pQl2mtWLBEDfQj2SU8piXqu/C42tzgiVEVf98X316JxSr8o0ImLWo/KtDjVUiE8CdOo9mVu7YRxGpJrl2WNOd0wUoHRavofL1h39l1uwZpIwpOrWdS4YDoUQBNqn+KnjZAGEGXBPEaeXbQumrwjZ4MXdQYn86fOYsXj2wnlQVgmIMbTUdWfcf6LjuwdQ+VV7h5E+nktdbjv48e0FilWyjQQXH4Hon+0P8E3p+DfozmmKxGob8vmhUUX4783sBYwDDZ9Dpbn7NW19JYyOTPS0vQVTFiwt9bFLrYR2jbvWgboFClkHxPxrtTmTFKWU7ow9QWDfx4tkNURidIy+t6H0Xan8LjJDW8C5957D65sHTLWrCAJvC2/66UV/XuxCPKCTKIPQePWI9vDV5uMeTAfsnfIW+mfKQsU5Kqup0NVy2BcmK/Up2iqR77BNoGCLmSjB5vk2M/MXDJ70hj3r01+hntcnuhB9G69VJ0UqPJNUpR6dvcA0ecrfIzMN6rGjLn4lFT8cHc7iULX7VI5fha/OFCQLXTr/nysw76E3Qj9dhG39xJozug+JEUWwvVN+pZvoWx5JUBWrIiRmd4yF79DAHTwHeII4rB4Z4L5fHzIKQFrfl/IspUtyPrrlWeOj22kDKo25RSVd9Zb//rJ69QJFAHMvQ3HqtJB+GbGbG9QdxlKXBGIm2xYw9OQweUYxEWjf/14Bz4BF2F13ErFj1CxkmK/J/guDxjabkeaGUZkNPg19vbrN2c1ivWDK7Vngp32Pd+OB2ouMvfOi8fjHM4E+PkhR922rFGj7WGBfk3ErAjRgnG/q/pCtmASSuQvlC4DD66PCsI5xdARm1cCJ6YuQEOMWFSMkntwHPe i4WfdgVI s9q/lUPVp5berg/TQ1SXJcnKaXzwhRML9WGnTNYDC4d+YHgEQN0j22708EHqFcvTFsdQQRpO6OGy/BqSx0GXC3Ga7T2EElL9IiDV//+BHueteVm6OzhhuOac6SHJ28wJyDC3EPevhttqcuzOK0+X6u+bWIoKiI1FKrVSlGZy1RVxgpWMb1po8s6nPcLlO3h8RNVfcZfvcOn1Jou8V9vEA7glRvEZZgE+JIyvlhJNzZVBmWz2prJZ+En+E9LEOpFUdNjfwFtsfdzBhOMvH4ehCxE/fmfXhCwRMFw+3P2p+T89iOyuw1YvNekTBFMcXehnbxJEM5J5vGBw5ctG8g9Dwt4tR2PvSoCWwVblMza0VDh4v0zs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 28/04/25 6:49 pm, Nysal Jan K.A. wrote: > From: Madhavan Srinivasan > > Commit 50910acd6f615 ("selftests/mm: use sys_pkey helpers consistently") > added a pkey_util.c to refactor some of the protection_keys functions accessible > by other tests. But this broken the build in powerpc in two ways, > > pkey-powerpc.h: In function ‘arch_is_powervm’: > pkey-powerpc.h:73:21: error: storage size of ‘buf’ isn’t known > 73 | struct stat buf; > | ^~~ > pkey-powerpc.h:75:14: error: implicit declaration of function ‘stat’; did you mean ‘strcat’? [-Wimplicit-function-declaration] > 75 | if ((stat("/sys/firmware/devicetree/base/ibm,partition-name", &buf) == 0) && > | ^~~~ > | strcat > > Since pkey_util.c includes pkeys-helper.h, which in turn includes pkeys-powerpc.h, > stat.h including is missing for "struct stat". This is fixed by adding "sys/stat.h" > in pkeys-powerpc.h > > Secondly, > > pkey-powerpc.h:55:18: warning: format ‘%llx’ expects argument of type ‘long long unsigned int’, but argument 3 has type ‘u64’ {aka ‘long unsigned int’} [-Wformat=] > 55 | dprintf4("%s() changing %016llx to %016llx\n", > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 56 | __func__, __read_pkey_reg(), pkey_reg); > | ~~~~~~~~~~~~~~~~~ > | | > | u64 {aka long unsigned int} > pkey-helpers.h:63:32: note: in definition of macro ‘dprintf_level’ > 63 | sigsafe_printf(args); \ > | ^~~~ > > These format specifier related warning are removed by adding > "__SANE_USERSPACE_TYPES__" to pkeys_utils.c. > > Fixes: 50910acd6f615 ("selftests/mm: use sys_pkey helpers consistently") > Signed-off-by: Madhavan Srinivasan > Signed-off-by: Nysal Jan K.A. > --- > tools/testing/selftests/mm/pkey-powerpc.h | 2 ++ > tools/testing/selftests/mm/pkey_util.c | 1 + > 2 files changed, 3 insertions(+) > > diff --git a/tools/testing/selftests/mm/pkey-powerpc.h b/tools/testing/selftests/mm/pkey-powerpc.h > index 1bad310d282a..d8ec906b8120 100644 > --- a/tools/testing/selftests/mm/pkey-powerpc.h > +++ b/tools/testing/selftests/mm/pkey-powerpc.h > @@ -3,6 +3,8 @@ > #ifndef _PKEYS_POWERPC_H > #define _PKEYS_POWERPC_H > > +#include > + > #ifndef SYS_pkey_alloc > # define SYS_pkey_alloc 384 > # define SYS_pkey_free 385 > diff --git a/tools/testing/selftests/mm/pkey_util.c b/tools/testing/selftests/mm/pkey_util.c > index ca4ad0d44ab2..255b332f7a08 100644 > --- a/tools/testing/selftests/mm/pkey_util.c > +++ b/tools/testing/selftests/mm/pkey_util.c > @@ -1,4 +1,5 @@ > // SPDX-License-Identifier: GPL-2.0-only > +#define __SANE_USERSPACE_TYPES__ > #include > #include > Tested this patch by applying on top of mainline kernel v6.15-rc4, and it fixes the build issue. Hence, Tested-by: Venkat Rao Bagalkote Without this Patch: pkey-powerpc.h: In function ‘arch_is_powervm’: pkey-powerpc.h:73:21: error: storage size of ‘buf’ isn’t known    73 |         struct stat buf;       |                     ^~~ pkey-powerpc.h:75:14: warning: implicit declaration of function ‘stat’; did you mean ‘strcat’? [-Wimplicit-function-declaration]    75 |         if ((stat("/sys/firmware/devicetree/base/ibm,partition-name", &buf) == 0) &&       |              ^~~~       |              strcat With this patch: make -j 33 /bin/sh ./check_config.sh gcc   CC       cow   CC       compaction_test   CC       gup_longterm   CC       gup_test   CC       hmm-tests   CC       hugetlb-madvise   CC       hugetlb-read-hwpoison   CC       hugetlb-soft-offline   CC       hugepage-mmap   CC       hugepage-mremap   CC       hugepage-shm   CC       hugepage-vmemmap   CC       khugepaged   CC       madv_populate   CC       map_fixed_noreplace   CC       map_hugetlb   CC       map_populate   CC       migration   CC       mkdirty   CC       mlock-random-test   CC       mlock2-tests   CC       mrelease_test   CC       mremap_dontunmap   CC       mremap_test   CC       mseal_test   CC       on-fault-limit   CC       pagemap_ioctl   CC       thuge-gen   CC       transhuge-stress   CC       uffd-stress   CC       uffd-unit-tests   CC       uffd-wp-mremap   CC       split_huge_page_test   CC       ksm_tests   CC       ksm_functional_tests   CC       hugetlb_fault_after_madv   CC       hugetlb_madv_vs_map   CC       mdwe_test   CC       hugetlb_dio   CC       droppable   CC       guard-regions   CC       soft-dirty   CC       protection_keys   CC       va_high_addr_switch   CC       virtual_address_range   CC       write_to_hugetlbfs   CC [M]  page_frag_test.o   MODPOST Module.symvers   CC [M]  page_frag_test.mod.o   CC [M]  .module-common.o   LD [M]  page_frag_test.ko Regards, Venkat.