From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4E90E7716A for ; Sun, 15 Dec 2024 06:30:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2EE0A6B0085; Sun, 15 Dec 2024 01:30:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2771D6B0088; Sun, 15 Dec 2024 01:30:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0F0F96B0089; Sun, 15 Dec 2024 01:30:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E01BD6B0085 for ; Sun, 15 Dec 2024 01:30:05 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 3F40B122E75 for ; Sun, 15 Dec 2024 06:30:05 +0000 (UTC) X-FDA: 82896217530.22.8B28795 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by imf19.hostedemail.com (Postfix) with ESMTP id 151EA1A0012 for ; Sun, 15 Dec 2024 06:29:33 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b="A/1TnT6F"; spf=pass (imf19.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.169 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734244177; a=rsa-sha256; cv=none; b=17momc+uBHZzelU8KDRe4tPitsKJj1kftYu1OCTs29WuybdeN169T9WoOCvqb6/fSDqYx3 QtJtUnzkvvkQ10Yv8s6+Ok8H0Y99WLgb1nbd9Xps7rN36A+u9AKSEBHZ3QSkY2K3cySlgb V7jrcQm8X9GUvJi6mDffssnVt9DGbRg= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b="A/1TnT6F"; spf=pass (imf19.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.169 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734244177; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rwNYe1XDDHCxQqM+OnwDDhWm8Wr5Z1XvjowB1bcfSd0=; b=YmtrOIxMZa9BftiHz+E1sriOwV9esuu+/eS9XtuQNhFx+86CXWcWWhHsaMsvVgzAC0ZBzB ZUYRgUGuWrWVsIz0SOKE9Ql2M4xmKnArArUqQkgXG2sK9A8jBXW7NGfqHTZNy9M29ZrEzc X0scOumG4zSmiXhbr/uWJOf4yPcPysY= Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-21628b3fe7dso24077455ad.3 for ; Sat, 14 Dec 2024 22:30:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1734244202; x=1734849002; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=rwNYe1XDDHCxQqM+OnwDDhWm8Wr5Z1XvjowB1bcfSd0=; b=A/1TnT6FTsOv4km326zvvtaxAn4JTcbzdNYRS8oljdk/K0WyP5bKTdvtB/Aubtknxi oqos2VFVLjzln0QYoMinHyaFKlbtABvGiPkAtFV3wquttuWJWspJ4iUCCWhjXTKVuLFY psp3QyywcavnHaVcaevBdKO2WrOJ6dZpHM9C6/nIB1rF6bS6ZOK6F9fcO5iCe40js2+v GUkqZbJqShfwS0mw2WF7Pbj5fmj1uB1LFxtzwKhnpe59DUXG0DcdPdow5+t4xSFMZpJv ciEEsbzSLfo56ZhlOTmujAs7dm3ZB/Iqpx2KxEPx73alUX+/u3YjXdMi/EIq7Jepn7e9 +PJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734244202; x=1734849002; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rwNYe1XDDHCxQqM+OnwDDhWm8Wr5Z1XvjowB1bcfSd0=; b=BxK5ImkMGX4BXMJKEyfZtslqq2yGGfYdeqDJ0tc1bFPfl71CBpNrmocGckhg6C3nb/ Smi0EQ/g+CyPLUyk3PKW0EuA0tIM1T/8gNGwWQL5ycC+M0UwbGU6giMgSqzmn9AUtOR6 +yUdhXcuznAJv9cjn1ZsCxjpKrJssGVcdTto57h7ddDUKBA0ynfR3kNw4E4A2oP0MmOX d1bBwfpiiRlNpzh6eRabcVREHcBwrqTYZpeScutKcXeaokqecM+pY6l2CpIIG7XMprW1 RE/HhjAx+qvGNoQerwCo8rdpYJtbQH4F4Jh+/987JLWXIHn/Y2AKDs97xA3SyeNTfAVb 9Jfw== X-Forwarded-Encrypted: i=1; AJvYcCVjb6B0Lb2z1deA8+MGbkHiqAjAD4N6V868EOoP2tJTFZRAican1THSsafptx1zfBMtcjY6d//1Vg==@kvack.org X-Gm-Message-State: AOJu0YwGZwhbBWxghZKHdu1hYPFDJiB6VmkIWX2p8Oe1ggYRiUWCXBHN bd7Cbq10UBJye9Ut+NwsFN/Rmd8zan5M2wW8bceVhPzAx8O7rXIVwZExGxjbvuA= X-Gm-Gg: ASbGncsySMaBXgLlyL8TwDd79STKcMNgPgxCnmJSXJ1IGCjgMyqOIn9tHt7+xJeKIOC ndyGAmDxtV/kbhPnOFCT84hQwxlLbVgu6sPvOYUuE7hLYQBNHbe2KWtvBFUOUnNhNmS95ScgmQU Z2/3CImXn6LPozMuacsenaZf4j0BuPrjweEMmeZaDuf6Ni6dYLQBMFRBx7ZBjeRBl4OjS626yyb 1zMZU8akIAq7u5V0plzHNwWnPpp9DRKW5aY1PL2BZSYO13NSj/oERgIyN5jUSieVrnkMn4n1lEG AjeTGfuEhh7zPmCaPBafkv8td17BBCKteEPV/AoITBAsnuYvvWeVLf8= X-Google-Smtp-Source: AGHT+IEyhC05pRlCoG7uiWXEq03tySPT5h+dGj8fQf3nkjF7E7tyWGU0NclNvArd44iS5Pxk6GDf5A== X-Received: by 2002:a17:903:32cd:b0:215:cbbf:8926 with SMTP id d9443c01a7336-21892a543f6mr128401865ad.35.1734244202084; Sat, 14 Dec 2024 22:30:02 -0800 (PST) Received: from ?IPV6:2409:8a28:f4f:a9a4:11bc:4825:e7fe:2e0e? ([2409:8a28:f4f:a9a4:11bc:4825:e7fe:2e0e]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-218a1e4ffd9sm21702895ad.142.2024.12.14.22.29.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 14 Dec 2024 22:30:01 -0800 (PST) Message-ID: <18bc52f4-ab02-495f-8f8f-87f69ea5b914@bytedance.com> Date: Sun, 15 Dec 2024 14:29:38 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 01/12] Revert "mm: pgtable: make ptlock be freed by RCU" Content-Language: en-US To: Yu Zhao Cc: peterz@infradead.org, tglx@linutronix.de, david@redhat.com, jannh@google.com, hughd@google.com, willy@infradead.org, muchun.song@linux.dev, vbabka@kernel.org, lorenzo.stoakes@oracle.com, akpm@linux-foundation.org, rientjes@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <1fdb3ee32e6958ad82229941b2213ef76b7c4705.1734164094.git.zhengqi.arch@bytedance.com> From: Qi Zheng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 151EA1A0012 X-Stat-Signature: ftoxcz6aiyd1pjzaduspfxj75abtopxm X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1734244173-353521 X-HE-Meta: U2FsdGVkX19iIeAME687wEXmu0Rem6iipOXSsP1XlaPd1KTH6kjOkl8eFp+ThUdg0LV3dFAlgV/6LCT5UVFBa36M3R6CY0YsIM537rG/MsgJKuYHTAT/DVumVo6AkFFf8Bsc99Uo/qUqGJrhYE4G5KhWh+YkoWj0X0BM2YGg69SXaYT/3sDho4Qotrh9JhcV8OerATaOKDMZ1UacFgwJtRHkTXhzLGnaE67wZCLTzwMZ1F9FDnNKBZ7/Hr8wgT5pcuaVz+swEGFYm1a1U7tfvorhBmCkrxVKdNM10nOO0NAUqUx3ZbGW1RIOmP4OvWl0yjrL3v6awE9+lBlq4nmGqWYkTTzb+RMeVQ6AS4Aqe71lQgX3VM4s31gk5QB8f/9a9GTB3dfhum72SQkOP8a4D0rtcwDhGyK15xixTO913AjglD4biDmEP4ApYKAsgrXSxNHZNqqDC7WJVjt1sCa6OPY11ZFU0SpENP1qFy//PvbHEa6LrIBIqBmriDVicbH25YqFbuwPv6Ey33IYqmg859igky/nov8DJpX8oKhqCVLYKbbesXEWENW9dnUVRsz8IqvESMkiPsGVtic1c1z0DobUtKGhQPmdJUjZKUYcOUd84un0mFoaVqNoq1b0VQ7FSyZK3wbuSxqdL0AGqdrW5u2b4G4jxzyrMF6AhkN9R9GOmJGewBUNxRH0WdqnRrgEcgotRwMbfWWruEWC+RqbGc0j17n56tY3LnqPREE66KnBQ8qB70RI8Vvtr+6CctmpJ4G7riJVVPLEHV99soerrfIhk6dvzaQy9WepoEWlDKm3Ba2Dq8T4eF1q97hTsTo+hd7/kuZCmgkhWvQe9MTZYfXGg6kwTLF9jqerZJ0WsryT/tobe/bNKqXVO1W4BULYYflHPydWG4IMYNrSSxVSYdOJOSy0rcMISJ+DzyzPgeLNIuVESFR6DLu1g5ay/UHjebCVTxqqNOryWR6y/OI 2xaeHkNe eJa1mAo7QTp6VAHs+wysXE/JEF/KZ99e4lqlw/5pOkcnA7fxqtQSftu0W7GfJTfO7ZjNMx7dkEcJqe8hVnwm5Ko+8gUxpgelUyr0qsDh8vlJE/QVUs/WwYTqRV3AXG+fY2Ma9UEumXs/9VATbky+cz+WnUJyaS+xObugjoyNb9q18kcwuVCDwH4t7idY6/k3zV16d/5JiqrFWgQ2GTpeQ7BNAyeNgn7cjck399/zinffShBwjBCBmUn2EUof0ohEffUw8Z58ouyXKySe7lfjfRDw1ccv04Q6OzQFT6BCF+8NPXasmD9w4SmshIYrAEiK2rw5DlCEijUBx5TMoJOhYLsps57AeUkI5zCFQW9OzuUh5f2ts+9KS16IPJEnYMq4Mo6GmIcCC98qqdFQqVLIzXNMGMiF1awb1NVNK X-Bogosity: Ham, tests=bogofilter, spamicity=0.044812, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/12/15 02:29, Yu Zhao wrote: > On Sat, Dec 14, 2024 at 2:03 AM Qi Zheng wrote: >> >> This reverts commit 2f3443770437e49abc39af26962d293851cbab6d. >> >> Signed-off-by: Qi Zheng > > Bloating struct pt_lock is unnecessary. Glad to see it's reverted. Indeed! > > Acked-by: Yu Zhao Thanks! Once the review of this patch series is completed, we can simply drop "mm: pgtable: make ptlock be freed by RCU" from mm tree. > > >> --- >> include/linux/mm.h | 2 +- >> include/linux/mm_types.h | 9 +-------- >> mm/memory.c | 22 ++++++---------------- >> 3 files changed, 8 insertions(+), 25 deletions(-) >> >> diff --git a/include/linux/mm.h b/include/linux/mm.h >> index e7902980439cc..5e73e53c34e9e 100644 >> --- a/include/linux/mm.h >> +++ b/include/linux/mm.h >> @@ -2988,7 +2988,7 @@ void ptlock_free(struct ptdesc *ptdesc); >> >> static inline spinlock_t *ptlock_ptr(struct ptdesc *ptdesc) >> { >> - return &(ptdesc->ptl->ptl); >> + return ptdesc->ptl; >> } >> #else /* ALLOC_SPLIT_PTLOCKS */ >> static inline void ptlock_cache_init(void) >> diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h >> index df8f5152644ec..5d8779997266e 100644 >> --- a/include/linux/mm_types.h >> +++ b/include/linux/mm_types.h >> @@ -434,13 +434,6 @@ FOLIO_MATCH(flags, _flags_2a); >> FOLIO_MATCH(compound_head, _head_2a); >> #undef FOLIO_MATCH >> >> -#if ALLOC_SPLIT_PTLOCKS >> -struct pt_lock { >> - spinlock_t ptl; >> - struct rcu_head rcu; >> -}; >> -#endif >> - >> /** >> * struct ptdesc - Memory descriptor for page tables. >> * @__page_flags: Same as page flags. Powerpc only. >> @@ -485,7 +478,7 @@ struct ptdesc { >> union { >> unsigned long _pt_pad_2; >> #if ALLOC_SPLIT_PTLOCKS >> - struct pt_lock *ptl; >> + spinlock_t *ptl; >> #else >> spinlock_t ptl; >> #endif >> diff --git a/mm/memory.c b/mm/memory.c >> index d9af83dd86bbf..83765632e20b0 100644 >> --- a/mm/memory.c >> +++ b/mm/memory.c >> @@ -7041,34 +7041,24 @@ static struct kmem_cache *page_ptl_cachep; >> >> void __init ptlock_cache_init(void) >> { >> - page_ptl_cachep = kmem_cache_create("page->ptl", sizeof(struct pt_lock), 0, >> + page_ptl_cachep = kmem_cache_create("page->ptl", sizeof(spinlock_t), 0, >> SLAB_PANIC, NULL); >> } >> >> bool ptlock_alloc(struct ptdesc *ptdesc) >> { >> - struct pt_lock *pt_lock; >> + spinlock_t *ptl; >> >> - pt_lock = kmem_cache_alloc(page_ptl_cachep, GFP_KERNEL); >> - if (!pt_lock) >> + ptl = kmem_cache_alloc(page_ptl_cachep, GFP_KERNEL); >> + if (!ptl) >> return false; >> - ptdesc->ptl = pt_lock; >> + ptdesc->ptl = ptl; >> return true; >> } >> >> -static void ptlock_free_rcu(struct rcu_head *head) >> -{ >> - struct pt_lock *pt_lock; >> - >> - pt_lock = container_of(head, struct pt_lock, rcu); >> - kmem_cache_free(page_ptl_cachep, pt_lock); >> -} >> - >> void ptlock_free(struct ptdesc *ptdesc) >> { >> - struct pt_lock *pt_lock = ptdesc->ptl; >> - >> - call_rcu(&pt_lock->rcu, ptlock_free_rcu); >> + kmem_cache_free(page_ptl_cachep, ptdesc->ptl); >> } >> #endif >> >> -- >> 2.20.1 >>