From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72988D64077 for ; Fri, 8 Nov 2024 18:33:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0A1286B00CA; Fri, 8 Nov 2024 13:33:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 050E46B00CB; Fri, 8 Nov 2024 13:33:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E5AD56B00CC; Fri, 8 Nov 2024 13:33:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C8B336B00CA for ; Fri, 8 Nov 2024 13:33:33 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 414AE809DE for ; Fri, 8 Nov 2024 18:33:33 +0000 (UTC) X-FDA: 82763774016.07.5EF54A2 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf18.hostedemail.com (Postfix) with ESMTP id 289171C000C for ; Fri, 8 Nov 2024 18:33:15 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=MVJPPh5j; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf18.hostedemail.com: domain of "SRS0=eyrL=SD=paulmck-ThinkPad-P17-Gen-1.home=paulmck@kernel.org" designates 147.75.193.91 as permitted sender) smtp.mailfrom="SRS0=eyrL=SD=paulmck-ThinkPad-P17-Gen-1.home=paulmck@kernel.org" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731090686; a=rsa-sha256; cv=none; b=c6bkxTWzasCcRZ/r0KoyEKOVZgZNHQbwvF2dnhUKLENBxzWx+fthfeC96j53kHYXJB2YB5 Acty+9/M/8sUcG4mUuAXPwOYrtdIqCK6ejXvl5e7eOmeJSZp3+mJoT0Dfgf+pWQJ+LXnU9 7rcVW13ZjnY6iESpGpjmT2iYIVNPc3s= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=MVJPPh5j; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf18.hostedemail.com: domain of "SRS0=eyrL=SD=paulmck-ThinkPad-P17-Gen-1.home=paulmck@kernel.org" designates 147.75.193.91 as permitted sender) smtp.mailfrom="SRS0=eyrL=SD=paulmck-ThinkPad-P17-Gen-1.home=paulmck@kernel.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731090686; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lPlUwcdL7Ch242337sgJ/C09io7ClBZTStTAH91hGxU=; b=LlJ9hUHVwcsKCabVZOLOEeXy/76amfeIUmcYvPGV31S/n/8hG8MXBnp4eik/Z8sTcSkpzm S41cxWUtWaloA6M+l282CwnXv5jkdgA5Wb7RYF7o6z6uLnVZpuy72+L7KbYgRpbuyurEx3 U99IqDMThCdouGAjosT8iBVjKLV3Cfs= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 08472A44909; Fri, 8 Nov 2024 18:31:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 58A23C4CECD; Fri, 8 Nov 2024 18:33:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1731090810; bh=ZnnP3TJUy8XOOKGAyDmqnCFgzbiZaQ2OFC3bYeXIWjM=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=MVJPPh5jUl5T+CC0kBAxzzbwEq+GSYJrd/YPTDf19DxGNKFkpWnFa67JXNTWboi2W DJx6DIMGkf7pOAWlczoG9OA957+F+/W3smtklIrOYpTUY6OUBDbT9SVj7zNqb8SyZd fqN/UAOQn+Ao2prEDjgyOIdvg6LzQCDUxG2AN5VUIQoX7mKnnuoq26FfmC2LBbaf04 XvVntHjjPWKbUg4YYo3tBj7F+X56eYu/O7cCxuaTs3sWeknV7f1A/7EzE9pF3NzUdy q9HZDWaIHF/is5Gp7+maz9rfTsECbbTREy8HXoLDbXKfAWkPFW0/B55yQX0oBOK/jx Bu5L/6o4HL4Lw== Received: by paulmck-ThinkPad-P17-Gen-1.home (Postfix, from userid 1000) id 00191CE09E4; Fri, 8 Nov 2024 10:33:29 -0800 (PST) Date: Fri, 8 Nov 2024 10:33:29 -0800 From: "Paul E. McKenney" To: Boqun Feng Cc: Sebastian Andrzej Siewior , kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Marco Elver , Peter Zijlstra , Tomas Gleixner , Vlastimil Babka , akpm@linux-foundation.org, cl@linux.com, iamjoonsoo.kim@lge.com, longman@redhat.com, penberg@kernel.org, rientjes@google.com, sfr@canb.auug.org.au Subject: Re: [PATCH v3 0/4] scftorture: Avoid kfree from IRQ context. Message-ID: <18b237cf-d510-49bf-b21b-78f9cebd1e3d@paulmck-laptop> Reply-To: paulmck@kernel.org References: <20241108104217.3759904-1-bigeasy@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 289171C000C X-Stat-Signature: ebaphkrjquf6kre67tkmiaqmxsbqjrbn X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1731090795-669556 X-HE-Meta: U2FsdGVkX19BoIotSYxmRhZRum+F4WMDzhHgv/qXEQzOOM3gyOLsLf2cbRKYS5qa1UufPsGO7S5oJgw+9EgYzi00pwVQnksoYDIH8uGmk4u/iQMjQwzM4SFFBC4YYetQTUudQLzTOs89S7dTZuQWmGDWgJHJCWMMRVb1IZbazrbwHZl7mfU85CmCzq8ZnaF/0kG4B+NCKXdlksjJvLQkjKrAUhg7XUPkJyoo5qk8wWSszz9AuEeQCrizMr0G0Tzzgz0x2fEMp4KKGLSFZTWzME9kDSchsgttUdrrGGZOdOPhKresQDfj77zO4F4mwdfzeaHKJ151x3sT2c7lWpfBIdrleHwu9G3tZHDJCV+TmttE9wmgL6fnL0YkCYgC9pikddTckdggueB+XYfD0+BYz5n443I5nCHqZrxAmS1Z25sVVCzO0hS4os9t9gE8l1hRKKNiAjPgkKr81dV6etolSuz0m9MXfHkB7iyKNBFB8JGd3qp7P0O/AgkxkZ0C14dkRwZYI/K9/VdEnO6YacscMWiKNYrxmxraQscFItU1Auhl+JXRvp1u9R/mOra7zMRPQWDvh86aN2lObLgBHfVLJD2UWOXBwPIV4goDJTN7ZLDMl2J1ho8OdW6dIitvn9cODlW1djMF3L+xnU0WFd3RSarnmceWvMbB78/B3m1IG80PAOaMObbhKM0UNVsOHvLj5lTCGBeUgWekQ+aDbm5oaaD6/nPGgBpLcn483IKKB37loeDBxXkGE5QL/pnyCCryUz2Nccs4h5AqLIHtQVwQbV/PMjbZM1JVgW5HxZdhEUKpHkH4S+Qd2YS+JMBkn6gIF/9Dh9szLtZssW2kxQjj7F4YOigSSdznU+amd5YnsMUNybe9nqBTTo6XgQD0WMK1useJfajqTrKQSSS2uItQYIkx4ecT+ZwR4Jk+TIhAxNh+NKj/FUlPL50D3ruyryQ5dkCKHsuFP5+PKdUgT5c wXR7xSXd maBkvikK4hbo1v5vk1Ame0d7IZBwmd7pxHBFjbgCTm5lqdsjGbBOOTBHbYFk3xtL1Z0lPqqsOkvNJ3+WZ1WXBIYDEWLkN2VS6CnZNpJcJQ9MHNevIftvyLkRc7k54Ev7poRQ5wd8UOvpxoPffGi9nwYuOgga5U+hkz3D/NbkTo483B9MJP5v4VNZwK3wPwx6X9oiRWx5L568o/MQ2HI6YnYw9Fjs095ZnosHsS6XSJxo9RkNa1QUYZpN3nujVga4NUt1bhp/AISZCP42im3jSh1z9l5cV0heLp6RIruEy4+MPFWV8PAQd3kecO6TERNH9HI4DQT+rq9M1KXmFJ069DZI/bhGeuX9oxdCfVn7ZLpSOjtJs6nI7/UdGEbyaTQ2wpN5oUVgAY2GNI8K3XZf79DhkS01lt9oid4JOHLHMI7Fk5ifPr2DHLH653gZmuI/kIkAWUIdLi97vkVFVPv9StaxYRxrjWQki2zqAWoyeCErhCfDXc3jKf0gIQ0FiiKp9bdjx8wAghHhfvjFI+pYju5p931dbFB/VWSxf8NUC100Ypt1RK9UFtASijjv3RDKP7e1IVbStx0O3aRbOJ2KhoElpAsUmPEiu67ym2mJZSlQjC+JXA8wy+j1wHOYni2QRtiWbfW2pNRewU4A5eLDIuRqKV4c57NB6kfSZO3Fhbqd3cohw0uGnlx57IW8ybrcFcNoC X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Nov 08, 2024 at 09:46:07AM -0800, Boqun Feng wrote: > On Fri, Nov 08, 2024 at 11:39:30AM +0100, Sebastian Andrzej Siewior wrote: > > Hi, > > > > Paul reported kfree from IRQ context in scftorture which is noticed by > > lockdep since the recent PROVE_RAW_LOCK_NESTING switch. > > > > The last patch in this series adresses the issues, the other things > > happened on the way. > > > > v2...v3: > > - The clean up on module exit must not be done with thread numbers. > > Reported by Boqun Feng. > > - Move the clean up on module exit prior to torture_cleanup_end(). > > Reported by Paul. > > > > v1...v2: > > - Remove kfree_bulk(). I get more invocations per report without it. > > - Pass `cpu' to scf_cleanup_free_list in scftorture_invoker() instead > > of scfp->cpu. The latter is the thread number which can be larger > > than the number CPUs leading to a crash in such a case. Reported by > > Boqun Feng. > > - Clean up the per-CPU lists on module exit. Reported by Boqun Feng. > > > > Sebastian > > > > For the whole series: > > Reviewed-by: Boqun Feng > Tested-by: Boqun Feng Thank you both! Sebastian, I am guessing that the Kconfig change exposing the bugs fixed by your series is headed to mainline for the upcoming merge window? If so, I should of course push these in as well. Thanx, Paul