From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16998C25B7C for ; Thu, 23 May 2024 01:38:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 73A086B0082; Wed, 22 May 2024 21:38:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6EA3E6B0088; Wed, 22 May 2024 21:38:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B1A26B0089; Wed, 22 May 2024 21:38:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 3C3306B0082 for ; Wed, 22 May 2024 21:38:05 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id D17AAA05D6 for ; Thu, 23 May 2024 01:38:04 +0000 (UTC) X-FDA: 82147949688.25.5E2EC6F Received: from out30-97.freemail.mail.aliyun.com (out30-97.freemail.mail.aliyun.com [115.124.30.97]) by imf07.hostedemail.com (Postfix) with ESMTP id 493EF4000D for ; Thu, 23 May 2024 01:38:00 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=jBxKL3cT; spf=pass (imf07.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.97 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716428283; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=09MSV1/3zxYWr14W2ElPhQ9LPPVHhGubVkw27PQ/8ls=; b=cREUlFAl+lRSTdds/kWnsejSucpp26Z2PkF/HTPCeB78g50uGdWa+sXqnGX9N/q7Z08x3C stqHhROkSQX/hXn53ANySYIPG5nNGfEeedr5h+o3Qt/p8pJX06FcSlAOjLqyiwE7/b6B6G /aKo+bs3sMIXzDpNVsxCnxEKRIHK8Dc= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=jBxKL3cT; spf=pass (imf07.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.97 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716428283; a=rsa-sha256; cv=none; b=wgO6UjoTthbPGtekJJPh/OAx1pYomQkYwZudoGdOf1xBGTMjCeGZ0HypSqMVOZJ9cTEjMY QqV3dCd5DxTDnQ8tR0gA9TyPDNU0Zwru824HuifGHJyHo/eda9Y2mHhXk4kTGvlwBf5MEi RBVgq+I7z0i/ZAncOmsVBgeRTHVsKKY= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1716428278; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=09MSV1/3zxYWr14W2ElPhQ9LPPVHhGubVkw27PQ/8ls=; b=jBxKL3cT/A8428fgxUmIN+iLvUTv27iSfRMdZOH3AA28ozN7SP2qpXh17TGlu+YwOp0qATJdHYJRIeqtt93AzUt2rh5AGE6zhnQti0zoFSsXSIBKImiqLP2OzsfF3EiqjI71IcGdN2HdmHUNyV5cJdnG08A5aYMAQZ919XCf1OM= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R171e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=maildocker-contentspam033022160150;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=9;SR=0;TI=SMTPD_---0W70hHJ9_1716428275; Received: from 30.97.56.57(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0W70hHJ9_1716428275) by smtp.aliyun-inc.com; Thu, 23 May 2024 09:37:56 +0800 Message-ID: <18aa865a-6d4a-4dcf-99ce-bcfbc0c92f19@linux.alibaba.com> Date: Thu, 23 May 2024 09:37:54 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: drop the 'anon_' prefix for swap-out mTHP counters To: "Huang, Ying" , Barry Song <21cnbao@gmail.com> Cc: David Hildenbrand , akpm@linux-foundation.org, willy@infradead.org, ryan.roberts@arm.com, ziy@nvidia.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <0e2a6f232e7579a2e4407ecf075531980d97f286.1716367360.git.baolin.wang@linux.alibaba.com> <22ac01a3-ddbb-4114-88cd-ad1a31982dad@redhat.com> <51ba1fc1-fd77-4601-8d27-459162fd008c@linux.alibaba.com> <875xv5ba8t.fsf@yhuang6-desk2.ccr.corp.intel.com> From: Baolin Wang In-Reply-To: <875xv5ba8t.fsf@yhuang6-desk2.ccr.corp.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: w9dbhw6ixaognh7uy8qmpus61gqbiy6i X-Rspamd-Queue-Id: 493EF4000D X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1716428280-540651 X-HE-Meta: U2FsdGVkX1+GbitC49KqMvSTm2iIgZ1BeLWjual6h/scknCuunojxKVdTw2Z9ticMtBjWqfkyLHWWxPnOoU6y/GEUL0dDXXmpHJgI2SEM+Z6aF6rAj17RPRd1ldMGLZJV1BEPXKhCWuoxOrR7vd7YufPfC+Hwi1LI1FvH2ydcVlzl6aYlqykxCnLbJU2105XuH+0qB/nkTy9yNybBOpWr/i1aJBnZkCO9IUx92/762excJQQlms8J0KFeFRRx3ZuhR5nVLA1fR/i6rD8m0TV7OV7GN7stu++L/yeoS40rtZ0LWLsXZG3VDmzp1LLKDkAFG9j3eYEgQb8qhtH1CSDpoe+MNZVaFufywHvaHxc0KfFmtiT/HH9wcjINRv7LsHQUUHkyTgjvbgS+OBwq/it1lHJYX4drQNvgL1xgeR9AOus5n9KvMBxAnbyHCqaCjpvf3gRxZ+/WLO569NuVo2mTrzpyfUGcn8O5T7KjcKgmroikGHaura6myBv9mANBPcDb7+N4nrHWwmrL4dw71C29MAO2IWRjx7S1sHqW7HYGnEFEAFITePA5lruwtUTXs4hrCQ1YA8xIwdo3om221uLng2r1oznnZRuf6JKLFWcrJktouhup03jwmLQVT+4a3QSfJvUZoRk3I43e/YhflZ97Cy3ntX+yJdPcvHVsXNL1QzV8l1JOqDuCp1T/jh53MVRGwfrUYaoy1ez9qLE8GOl3txQoioXaUw35PpN0llWMcFOJ9W4LuB+LwiPxEok+nN/fxO/P0MZR6hHB96qzWb1eGfudP2XdGrpeFZ8U9XU8myxkYbhwFIqhMfBkB4FeshGWep/tiWYhoEjBDSIr4xq04BgDyotdSQwK25KoDneDFf+u7D2WtkdZp6p89ixOnEsjB2VJXEbnjJytTLPWeL3QmIo7WMelrYEwwJsmZZiGx0tQjJOjsam5L1yvC4qa8T3kOwLNT6AVaU8jYwHknt 6MARD0QU y1L6A6PQdAVeMeumBEA/MYfSMU2ghU1xld1D3HSrmZGJoOrAj3sm00DVJuP3/sxoxY+5IZEnE2jm6OamxFYuPjjDcEhVk0vs9lkkJ2ZfzkTPjBnqkJKbMh5qt0W5+hvbsUu70ZWL2qw1L0Vs108TZXAgnZTnWzzM7xb0cBwDkhQcJlZpTe9qQDxJSYOcsU0zyLJrWrLW2rq/Q/9rSFOeaHKNniRaCCgyj5Pg8iqMHsrVz/wk8njZ3Xf2nJQTSTXG2xVtoJEvWjb1yDexZkbm9m/Tr+ND039Bmy0LiwqPOV1VAInzGmSocrFXiIE4oqlJbHq3WSbeMwoNkKyKyteG4HLyO629pAmsz3FJyxI1efDV4CZFHwf30/0CfMSQrWqjbszvsa7TQR64G0MVv932iIBdCGfTLX+XrnFRYrqCHaTkgLmFoyE9xtmyjYjN7JWsGkkqQKrOkvDJWb2sCGWVPWbkKTAbGlfluoP582hol6Um5WF3oz5ypEuTt0x6zUjzu97lG3lmXBN8bPl/LTzvCuHzMayXR26oU4VLabGImNlKioDg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/5/23 09:14, Huang, Ying wrote: > Barry Song <21cnbao@gmail.com> writes: > >> On Wed, May 22, 2024 at 9:38 PM Baolin Wang >> wrote: >>> >>> >>> >>> On 2024/5/22 16:58, David Hildenbrand wrote: >>>> On 22.05.24 10:51, Baolin Wang wrote: >>>>> The mTHP swap related counters: 'anon_swpout' and >>>>> 'anon_swpout_fallback' are >>>>> confusing with an 'anon_' prefix, since the shmem can swap out >>>>> non-anonymous >>>>> pages. So drop the 'anon_' prefix to keep consistent with the old swap >>>>> counter >>>>> names. >>>>> >>>>> Suggested-by: "Huang, Ying" >>>>> Signed-off-by: Baolin Wang >>>>> --- >>>> >>>> Am I daydreaming or did we add the anon_ for a reason and discussed the >>>> interaction with shmem? At least I remember some discussion around that. >>> >>> Do you mean the shmem mTHP allocation counters in previous >>> discussion[1]? But for 'anon_swpout' and 'anon_swpout_fallback', I can >>> not find previous discussions that provided a reason for adding the >>> ‘anon_’ prefix. Barry, any comments? Thanks. >> >> HI Baolin, >> We had tons of emails discussing about namin and I found this email, >> >> https://lore.kernel.org/all/bca6d142-15fd-4af5-9f71-821f891e8305@redhat.com/ >> >> David had this comment, >> "I'm wondering if these should be ANON specific for now. We might want to >> add others (shmem, file) in the future." >> >> This is likely how the 'anon_' prefix started being added, although it >> wasn't specifically >> targeting swapout. >> >> I sense your patch slightly alters the behavior of thp_swpout_fallback >> in /proc/vmstat. >> Previously, we didn't classify them as THP_SWPOUT_FALLBACK, even though we >> always split them. > > IIUC, "fallback" means you try to do something, but fail, so try > something else as fallback. If so, then we don't need to count > splitting shmem large folio as fallback. Agree. In additon, IIUC we have never counted splitting shmem large folio as THP_SWPOUT_FALLBACK before or after this patch. > For example, before commit 5ed890ce5147 ("mm: vmscan: avoid split during > shrink_folio_list()"), if folio_entire_mapcount() == 0, we will split > the THP. But we will not count it as "fallback" because we haven't > tried to swap it out as a whole.