From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33387C27C79 for ; Mon, 17 Jun 2024 10:04:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B31266B0169; Mon, 17 Jun 2024 06:04:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ABA266B016A; Mon, 17 Jun 2024 06:04:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8F0AD6B016B; Mon, 17 Jun 2024 06:04:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 6FB856B0169 for ; Mon, 17 Jun 2024 06:04:33 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 296E7A0F02 for ; Mon, 17 Jun 2024 10:04:33 +0000 (UTC) X-FDA: 82239946026.14.2862CD3 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf15.hostedemail.com (Postfix) with ESMTP id 927B2A0020 for ; Mon, 17 Jun 2024 10:04:30 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="T/wWlncg"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Boph06D0; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="T/wWlncg"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Boph06D0; spf=pass (imf15.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718618667; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2CXi0BTLwxFoo/bkUlEw4sVrubcxsdawRIzl9TVs1D8=; b=rmPLgZ987Ry0fBDLzxZfT/VGVJK/8NDoYua1tX3Zwbm+gl9ppXF5bbO92T2j3a15O2DN+P cqqFoFwkW2ZO9C7mtqSudMJbdFA/0jOxWzP1w4MwPVkk2AGS0N4ydGwwTVYQHGuQHpekBt e36XfFarBhzNI0LDNZES3W9jK3ybqiw= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="T/wWlncg"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Boph06D0; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="T/wWlncg"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Boph06D0; spf=pass (imf15.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718618667; a=rsa-sha256; cv=none; b=HKPuPCesUTryIdQpuhPaebqajEjMTFLCt/C0RQYANeNhThrXa5tC1GZwHv2fLZwSQLLhCh XZ+3uJcNNM7h8ppd5THn6cccGWdFwRqzUOOMCCkxwAtNwlcxEWjaTi8XiznOo/4/uW5iWY vObqM/9Spr3KyhRRXWTmoirsyzdi7Gs= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 0D82D5FE69; Mon, 17 Jun 2024 10:04:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1718618669; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=2CXi0BTLwxFoo/bkUlEw4sVrubcxsdawRIzl9TVs1D8=; b=T/wWlncgQ3bfz2IeBG9+PiEIRRBa8yisa13+TaiXAPhJ+mgijLysl3xWSXxI20VvNal6Ro tkK30b7LTLdZOzIMxGcraJF9N2XZkT4IYTfxQ05Ia6w+p8ioCVTwawzm/BYZIFf/pjLujA IlUurOWUtEY3FDso1hpT2oi3otc+tEU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1718618669; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=2CXi0BTLwxFoo/bkUlEw4sVrubcxsdawRIzl9TVs1D8=; b=Boph06D0ouhYwucGExInaYmzSx2L/VWJOjQys2uYw8ufRhTXJrweO4Pkdm5/qHjJPOXDXq OCU7W1dtFSUhszBw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1718618669; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=2CXi0BTLwxFoo/bkUlEw4sVrubcxsdawRIzl9TVs1D8=; b=T/wWlncgQ3bfz2IeBG9+PiEIRRBa8yisa13+TaiXAPhJ+mgijLysl3xWSXxI20VvNal6Ro tkK30b7LTLdZOzIMxGcraJF9N2XZkT4IYTfxQ05Ia6w+p8ioCVTwawzm/BYZIFf/pjLujA IlUurOWUtEY3FDso1hpT2oi3otc+tEU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1718618669; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=2CXi0BTLwxFoo/bkUlEw4sVrubcxsdawRIzl9TVs1D8=; b=Boph06D0ouhYwucGExInaYmzSx2L/VWJOjQys2uYw8ufRhTXJrweO4Pkdm5/qHjJPOXDXq OCU7W1dtFSUhszBw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id EB355139AB; Mon, 17 Jun 2024 10:04:28 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id QMUKOSwKcGbfAQAAD6G6ig (envelope-from ); Mon, 17 Jun 2024 10:04:28 +0000 Message-ID: <18a30d5c-abf3-4ceb-a7fd-2edfd8bee2a8@suse.cz> Date: Mon, 17 Jun 2024 12:04:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] mm/slab: fix 'variable obj_exts set but not used' warning Content-Language: en-US To: Suren Baghdasaryan , akpm@linux-foundation.org Cc: kent.overstreet@linux.dev, pasha.tatashin@soleen.com, souravpanda@google.com, keescook@chromium.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel test robot References: <20240614225951.3845577-1-surenb@google.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20240614225951.3845577-1-surenb@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 927B2A0020 X-Stat-Signature: yxwyridodtwdi5on9hxitwzj9ss4x7iu X-Rspam-User: X-HE-Tag: 1718618670-634294 X-HE-Meta: U2FsdGVkX19D4TUenYAOKnauaDKaVOOnCsFuNHDFDUpY4IzHZzQbHzSvO8yqwyD7Jwt50sL0y/D1cNOtgfI3RElaHVsk0+NcRCjqKwb535y3PFHbwdW2Y+JLBWdHhDBy8R0jTh9Gb8loo41P63aLsKDE/MBVVqeh+iOwOd1GIJrphCngWUzigshW9vcNoFbGJKBxoid6YH3/kyERdAwp2J2EFKHuO16/fJQU6H59sWS9YrAQqNJa/BcDlDRRfOZ0AaDxj9Sy9YqsP/tpF6tJhx8TcxQmVeS9lTfGRXmnMc/+GXkhfQvb57cQgaIH8GQKMIlVpVqAwCKkW4nWkhQIxEe+aYej+XTtKnaIgAUg/bZSpITWPmMgY2twAsVonuN4VnM7T4rPTLa3WrVLd+/HDV0CMX8hq5XxxjWM1SaDkpDx5X0WGtSjaPQ1F4WoT3oF3qwCNIkAMrgZ/idvZ0nucEWA93NQmG4gbAMO5izAccoGeOsa9Xw14DvrGLkFKOdyODLoDEr43CEaFU3V7p71GdYaztCl7fzi1duQe3Po0hq5euZvnolmJVgvO+Sppu8W8g1D0sm21sFC0LTabCaN3kzl2eRKLJanMsYmjDKvSTAl83GS+jiBI6nx/F7+YccnQdqqMJEpezHY0HxQ8CfzHbnqYM/hA8WEjfBYodeMUVjxAUuikTBNkY6yCVYW4ln9F8jfYNGMRCASqtkJ3oKQdkho9DWwgLDKcpO99SynRxEfs8kB2GDXovD5cWCGqhNDH0soqNr5lbTGcTRVCTr6psSRuGiX/L9rZOSRzR28o3SnB8LnI0gx+O4LvIoNeKBBjAG1X46Z/kKl8I0U5EdH96Vz5V0uAIfd44/Qs/IJgyD5hYiORkcgbL4Rrq53r3tl0tq5cUJkd9K8Nb/KXwXQxKqHamNmVro4D5ULiVsgZLUvsRa12kKPyICpUnZWzsrQid+Elhvpt/qub/0XOQF h2PfZLLW U5GfLDlFtMV/Ey+pQ/1sQeOR9KVsZWS1jCKHpMTNW2M9bwS5+4Jj49RjotVrOQ6MboQqc4YsKZDm5OH5RKFn06B+hufL0ZhTPW0Y4QEPVaTLxWP6Oa8/pwGqYc0+gq1we9QpdR3p1avXk8MEs0AM6pG35kli+F/0NgvrOmkgHIAWSIQIhkgFO+TMgav0w3Bne/MPRyLY08nUOW1mqBc6PGizAAzqyLbUEYAMO1yyIOFXcKPmQCm9dQojfeZJDJ3SFSrBX1sIe2ewFX7irtfUsRqGrMj95UqSmPx2cbQOYbY0vhn2/pcuXcr5nwQJ1sBujpy13mL3ioZ0Em92GdZN8iVV5TTDp1Ja9S9jjq5TRacdh76y9u0ncUg2vInN4rO+jIg3YBWGaI6tzV7ORl0J1SjSpEq6lFTDYzxnr X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/15/24 12:59 AM, Suren Baghdasaryan wrote: > slab_post_alloc_hook() uses prepare_slab_obj_exts_hook() to obtain > slabobj_ext object. Currently the only user of slabobj_ext object in > this path is memory allocation profiling, therefore when it's not enabled > this object is not needed. This also generates a warning when compiling > with CONFIG_MEM_ALLOC_PROFILING=n. Move the code under this configuration > to fix the warning. If more slabobj_ext users appear in the future, the > code will have to be changed back to call prepare_slab_obj_exts_hook(). > > Fixes: 4b8736964640 ("mm/slab: add allocation accounting into slab allocation and free paths") > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202406150444.F6neSaiy-lkp@intel.com/ > Signed-off-by: Suren Baghdasaryan Acked-by: Vlastimil Babka But it seems to me we could remove the whole #ifdef if current->alloc_tag (which doesn't exist with !MEM_ALLOC_PROFILING) had an access helper, or there was a alloc_tag_add_current() variant? > --- > mm/slub.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/mm/slub.c b/mm/slub.c > index 1373ac365a46..4927edec6a8c 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -3902,7 +3902,6 @@ bool slab_post_alloc_hook(struct kmem_cache *s, struct list_lru *lru, > unsigned int orig_size) > { > unsigned int zero_size = s->object_size; > - struct slabobj_ext *obj_exts; > bool kasan_init = init; > size_t i; > gfp_t init_flags = flags & gfp_allowed_mask; > @@ -3945,9 +3944,11 @@ bool slab_post_alloc_hook(struct kmem_cache *s, struct list_lru *lru, > kmemleak_alloc_recursive(p[i], s->object_size, 1, > s->flags, init_flags); > kmsan_slab_alloc(s, p[i], init_flags); > +#ifdef CONFIG_MEM_ALLOC_PROFILING > if (need_slab_obj_ext()) { > + struct slabobj_ext *obj_exts; > + > obj_exts = prepare_slab_obj_exts_hook(s, flags, p[i]); > -#ifdef CONFIG_MEM_ALLOC_PROFILING > /* > * Currently obj_exts is used only for allocation profiling. > * If other users appear then mem_alloc_profiling_enabled() > @@ -3955,8 +3956,8 @@ bool slab_post_alloc_hook(struct kmem_cache *s, struct list_lru *lru, > */ > if (likely(obj_exts)) > alloc_tag_add(&obj_exts->ref, current->alloc_tag, s->size); > -#endif > } > +#endif > } > > return memcg_slab_post_alloc_hook(s, lru, flags, size, p); > > base-commit: c286c21ff94252f778515b21b6bebe749454a852