From: Zi Yan <ziy@nvidia.com>
To: Pankaj Raghav <p.raghav@samsung.com>
Cc: Matthew Wilcox <willy@infradead.org>,
Suren Baghdasaryan <surenb@google.com>,
Mike Rapoport <rppt@kernel.org>,
David Hildenbrand <david@redhat.com>,
Ryan Roberts <ryan.roberts@arm.com>,
Michal Hocko <mhocko@suse.com>, Lance Yang <lance.yang@linux.dev>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Dev Jain <dev.jain@arm.com>, Barry Song <baohua@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Nico Pache <npache@redhat.com>, Vlastimil Babka <vbabka@suse.cz>,
"Liam R . Howlett" <Liam.Howlett@oracle.com>,
Jens Axboe <axboe@kernel.dk>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
mcgrof@kernel.org, gost.dev@samsung.com, kernel@pankajraghav.com,
tytso@mit.edu
Subject: Re: [RFC v2 0/3] Decoupling large folios dependency on THP
Date: Tue, 03 Mar 2026 11:44:21 -0500 [thread overview]
Message-ID: <18EA5A93-5D49-483C-A90D-D023F9116F37@nvidia.com> (raw)
In-Reply-To: <6e86c417-c410-4deb-9b47-08e3d5d9be71@samsung.com>
On 3 Mar 2026, at 9:17, Pankaj Raghav wrote:
> On 2/27/2026 6:31 AM, Matthew Wilcox wrote:
>> On Sat, Dec 06, 2025 at 04:08:55AM +0100, Pankaj Raghav wrote:
>>> There are multiple solutions to solve this problem and this is one of
>>> them with minimal changes. I plan on discussing possible other solutions
>>> at the talk.
>>
>> Here's an argument. The one remaining caller of add_to_page_cache_lru()
>> is ramfs_nommu_expand_for_mapping(). Attached is a patch which
>> eliminates it ... but it doesn't compile because folio_split() is
>> undefined on nommu.
>>
>> So either we need to reimplement all the good stuff that folio_split()
>> does for us, or we need to make folio_split() available on nommu.
>>
>
> I had a question, one conclusion I came to was: folio splitting depends on THP, so we either need to implement the split logic without THP dependency or just make sure we don't split a large folio at all when we use large folio (what I did in this RFC but not a great long term solution).
Why? What folio split does:
1. unmap pagecache folios or freeze anon folios with migration entries
2. split the folio to small ones and handle other related meta data like
page owner, pgalloc tags, swap, pagecache index info, or others
3. remove migration entries for anon folios, do nothing for pagecache folio.
Unless the large folio is PMD mapped, splitting other large folios should
work without THP.
>
> So even if we implement folio_split without any dependency on THP, do we need to re-implement or make folio_split available for nommu? I am also wondering how nommu code is related to removing large folios dependency on THP.
>
> --
> Pankaj
Best Regards,
Yan, Zi
prev parent reply other threads:[~2026-03-03 16:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-06 3:08 Pankaj Raghav
2025-12-06 3:08 ` [RFC v2 1/3] filemap: set max order to be min order if THP is disabled Pankaj Raghav
2025-12-09 7:45 ` Hannes Reinecke
2025-12-09 16:33 ` Pankaj Raghav
2025-12-10 0:38 ` Hannes Reinecke
2025-12-06 3:08 ` [RFC v2 2/3] huge_memory: skip warning if min order and folio order are same in split Pankaj Raghav
2025-12-06 3:08 ` [RFC v2 3/3] blkdev: remove CONFIG_TRANSPARENT_HUGEPAGES dependency for LBS devices Pankaj Raghav
2025-12-09 16:03 ` [RFC v2 0/3] Decoupling large folios dependency on THP Zi Yan
2025-12-10 4:27 ` Matthew Wilcox
2025-12-10 16:37 ` Zi Yan
2025-12-11 7:37 ` Matthew Wilcox
2026-02-27 5:31 ` Matthew Wilcox
2026-02-27 8:45 ` David Hildenbrand (Arm)
2026-02-27 15:19 ` Matthew Wilcox
2026-02-27 20:10 ` David Hildenbrand (Arm)
2026-02-27 20:16 ` Zi Yan
2026-02-27 20:19 ` David Hildenbrand (Arm)
2026-03-03 14:17 ` Pankaj Raghav
2026-03-03 16:44 ` Zi Yan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18EA5A93-5D49-483C-A90D-D023F9116F37@nvidia.com \
--to=ziy@nvidia.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@redhat.com \
--cc=dev.jain@arm.com \
--cc=gost.dev@samsung.com \
--cc=kernel@pankajraghav.com \
--cc=lance.yang@linux.dev \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mcgrof@kernel.org \
--cc=mhocko@suse.com \
--cc=npache@redhat.com \
--cc=p.raghav@samsung.com \
--cc=rppt@kernel.org \
--cc=ryan.roberts@arm.com \
--cc=surenb@google.com \
--cc=tytso@mit.edu \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox