From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CD74C369C2 for ; Mon, 5 May 2025 07:16:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8FB846B0082; Mon, 5 May 2025 03:16:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A7FA6B0092; Mon, 5 May 2025 03:16:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6FA706B0093; Mon, 5 May 2025 03:16:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 4DBF46B0082 for ; Mon, 5 May 2025 03:16:57 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 08484141B94 for ; Mon, 5 May 2025 07:16:58 +0000 (UTC) X-FDA: 83407997316.18.55AEF1C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf16.hostedemail.com (Postfix) with ESMTP id 86697180011 for ; Mon, 5 May 2025 07:16:55 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OsMLlfzw; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746429415; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=T+Y9CRSgdg+bLZFzKaq4Mjnbpe4YhoWgbwOQ4rWb/Aw=; b=2kltfZwfnLljegomImqCcpzajz+b0ZKdYkZ6hO9xeb/Y4X9qnbUrwnGpSq2rfIfGENQoWE D975JSQJPqTyetls+PA6MlSz+QikXACKZvk3Wd2aBbSaqxiAuFJxmsAmWn2XFMkMWI9RsA qePb7wGmnJY0sVvYaxcj7xD88s7hPiA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746429415; a=rsa-sha256; cv=none; b=6wafOE7S7SHzK0zKdWj7z5+O8Khb8lXmlfd6OIeS81BUmBQNewWKCjNOxiacQI1T/t4QVE cg7DTHsRQ99BjvVnK6jEkvIRWL4RNdIlczvuBWDRKO+kbb1jZ+rZWwekN5OPNcowPwMMyG EeQ87Zz5/S820iTIXcBVuAHupQLMB1I= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OsMLlfzw; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1746429414; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=T+Y9CRSgdg+bLZFzKaq4Mjnbpe4YhoWgbwOQ4rWb/Aw=; b=OsMLlfzwXFiWdh1A2V130rcaicooRtNyhdjwmjazQ2qfD6GhUZPQ+IAiNp3XnWa6ADrJxA Oj2oyO4XSK3oqfgkGlj3vch91nIj76MRorSGDCQP5Zn3C54DKw+xOaFkJZI1gDcQpfQ0g6 JD7CTzvx0HWMKyNo1RQlvATb+kcajgc= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-308-Z9ig8909PselUFCZMwKyoA-1; Mon, 05 May 2025 03:16:51 -0400 X-MC-Unique: Z9ig8909PselUFCZMwKyoA-1 X-Mimecast-MFC-AGG-ID: Z9ig8909PselUFCZMwKyoA_1746429410 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-43d01024089so26499875e9.1 for ; Mon, 05 May 2025 00:16:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746429410; x=1747034210; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=T+Y9CRSgdg+bLZFzKaq4Mjnbpe4YhoWgbwOQ4rWb/Aw=; b=dA3iOQcZiofMoRNK7qe7i2LQOilG7EiByLFZ1czfIBvmFBc5lvYyFgGdx54gqWFWxc kM0hFSk/XhKpFr935UI/im7vcTX1lmtenzMxfah3IzS5lB5W0FxIT9DEaf9+BlD49S/H M8w5C5fp7gvk1CfDqtXyRNHBvOPlOa8BlrYOckzF2GpEXAQhAbPNjOiT/b0XeR7mKR6j MDzNG1afHBqBThJurnOEh9Q5se6byrBRRXdHd8m8JazaeIKBRPFghXwe2N52j5BdcT2l jQqhsh/kLLFnjPEcmaT2AHgyU4Ec5n7uwRRJ9fPsHJ7xWspUI8yEza2mIKEfFKeo7OjS gkOA== X-Forwarded-Encrypted: i=1; AJvYcCUp4iUMge8wXXbCVA/BZZ5e0oyYMb6zDaooiIdtui8LBCJ+hmA5DT6aQl2AlCGd4Ywq7jrhxCt9pA==@kvack.org X-Gm-Message-State: AOJu0YyDA+XGKReaXv2SDGlP6qKb8Em3+yjHRdLuicbpjikwtc+CADqv tNilTymsAdttJJNIF984+R0pffWzFpQlquAMljX+aB9wv6wWwTzvZS63ggDqLt60YE/oSsvVkEM tD2ZDXLBLUucIACjKec/bQQxeH2ucy9rIts6hdxKmQq9Mebh6 X-Gm-Gg: ASbGncvCcPSpBbIHe3xmK1I38z7M9nfnVhJgDWSr2uFzBaqV6/cOkVdxeJrqvcMh9BS V3rD/1jzpU7RwH7p9m0oAV085IQOEymwx2YVHrld19Qwt9XlzKAly7Sx+hH98HUk4nLYI+nVkIN SHKV9wacp3rNDKA2A4B5ctPXVWGOeihrvy0grGQlpPkHM+xDFQTGscEBwH/IZLQFbVIQ54YI+Zv 4CWzNsZeMznv6M2yciIBgGYkTvA4HLD7r4K6GxCCqHZnmQQUxLbT5MMBSTjAX8zdQeZPRyg59HK cO/mTg5OIPhYOR/xT93TvzVKw6LejOz6giIeLM6f2uoWyFmq1GivfE8iFQOmNSL0NZyf/Bs9CnH SdW388JO+aWeEt3wGVcAvcBccTRdcvjr1s/6biAs= X-Received: by 2002:a5d:5f44:0:b0:39c:1429:fa57 with SMTP id ffacd0b85a97d-3a09fd6dcf7mr5242327f8f.3.1746429410433; Mon, 05 May 2025 00:16:50 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGXSED6oy1mYodyEZMeEJDutKTAvYwWGYE0ppzzZOWq9jPxT+2VT7UH9O/qNIZPl6snH8J1lw== X-Received: by 2002:a5d:5f44:0:b0:39c:1429:fa57 with SMTP id ffacd0b85a97d-3a09fd6dcf7mr5242305f8f.3.1746429410054; Mon, 05 May 2025 00:16:50 -0700 (PDT) Received: from ?IPV6:2003:cb:c73d:2400:3be1:a856:724c:fd29? (p200300cbc73d24003be1a856724cfd29.dip0.t-ipconnect.de. [2003:cb:c73d:2400:3be1:a856:724c:fd29]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a099b0fe92sm9613356f8f.68.2025.05.05.00.16.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 May 2025 00:16:49 -0700 (PDT) Message-ID: <188fbfba-afb4-4db7-bbba-7689a96be931@redhat.com> Date: Mon, 5 May 2025 09:16:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/3] driver/base: Optimize memory block registration to reduce boot time To: Donet Tom , Mike Rapoport Cc: Oscar Salvador , Zi Yan , Greg Kroah-Hartman , Andrew Morton , rafael@kernel.org, Danilo Krummrich , Ritesh Harjani , Jonathan Cameron , Alison Schofield , Yury Norov , Dave Jiang , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: lK-xXcndCK0UHLp8cuc18o7zb-qFOYNwxXye3umpctg_1746429410 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 86697180011 X-Rspam-User: X-Stat-Signature: ej8w35j8by79uirdxzgxdhkrz614oirc X-HE-Tag: 1746429415-256822 X-HE-Meta: U2FsdGVkX19aXCYAvfYrYeB7hGYsbsjNE8lnrFOBnTemIBFGWHUlnZTl/E1oDyOWgU5yDYKeQ3CUYiiX1cuk9tyjXsriYxyP8SLOJHNDXCNa/OEClS0InuWYgUl5DYuVUmRbgRFEuXKVI6vJ+n7xlDRUuYxWfPVcJr9p/4SmV7e2FycO36JWWhuqaXNiwkpdo7KWdFo6tub4N0dN0FjbD9KSQFwHN2W3wL3MMVGqpxUjotJ2zH7IhaikpW2CXS9wrC6SVoZAV5HydP0F86GdVnYt8fG7mU6LoHuVBM9ZKGk8XgkgDNXFOwFZ2gIL0qqxVWdhDjTDf39MNusn0GtKrcAxPSY75AK67Cv1ezoE+Eup/d68nTtDE3QoRg0oWL/uMgXKYrNnYHhX3+D/Epon0O46r3OPmiWK5k5uy2KNzqsR2hF5eRZZNhhtnESp+/LphA/J5cpbcpKWbSFccIz9CyvjYExq0J1+EiN5WWL7nHjoEDjG7s9FNGevP0MnkPMayuaf3bF4RUuP/sWEmGKOlqGSAv1m62fu3s/W/2JQQmqk03vAdUMmjNTCU0x3ErjvH0jS1ibj0r+JecumIj44lPpTMdRBo46eGKvDJjuEI8+JM55YH/3LCrbukL9GNAuIGyH/RYLNOQyzEDwk9Q1cs6h05Z3xddJLcRJ+aJo6jKiRJvtkwJYm1r+ORfDmVn6fZ0C1PlBHJIIw28TLAirnyroSHC48q9dVTB3vUzb5+NbPaLcE2v1+35n2UWdx+gRehnGH9C3YmV0uEr+NrIzWPMaik7JHR+ZHi9/uaHe3WdLU70fl6USwzULzMU/fwkC+DoxHYdj0Ck0m8owRPzqwbOVfEVq/B0lCAw4+MFjS/6AAV2SPNUjq7xgejI+RVvaX7+3ANub3gna9OyLNx7QyVKf1E9biIvqpTLAZgppvxMHV2PzVbMu8KW+A4iGD7+tq1fEP+yNtbRn1mmFW84s JenCq7kE /5rzK5ZvQdCX9DCyq0hetkh5+ZqR/tFrDDjFwnYCwS2XL7mBbK+rmE6bszQ9yC6Qy86gPFSdoMGPYhhQBTSe9mV5hH2M6r7Eh966f5eWCsmGrqRRIqRt1uOMbaqNZVqHcYS/S1zXzHrGrLUDowLtHFyAX/4dhbUkeYDR8ePZrnfGPlZxYxw2ijIXfdQhO5O1ECbXibJChFB1dYJ8vnGATT4PeIzHhrSQNH6pY+6+ti9GSDIYMgMfcJG2ycTJvXjTruNW2NQAdKEAgTE+iCD8DUkuPW385RG6el9boiqWW+gICVKIAGcnXRfE7KvaIJ41FAPrFMMY5rDd5L4w40b7m8Kr7vpeXB0O2YEvyFSGTitNifsOWWhUgAeUL7/0mRbAd6Eo6MVDU6bPuTSRBNyT/hslorsg+OErjOne9HntAjReAEEug6odsWEqzgSH3X0zdTgGFKuIUJxo8o9Gex0fvUx+KMH6H1kBR0RfJeOGJ+xkR1L/O/Vg/H5pUjUIyZ3yQETjl79FjgF3z97RLAKJcnDoIpsFQA1EwpI1xPd9Y97AkKkEoLfBOdqnulgubD6fro0W4 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 04.05.25 18:34, Donet Tom wrote: > > On 5/4/25 4:39 PM, Mike Rapoport wrote: >> On Sat, May 03, 2025 at 11:10:12AM +0530, Donet Tom wrote: >>> During node device initialization, `memory blocks` are registered under >>> each NUMA node. The `memory blocks` to be registered are identified using >>> the node’s start and end PFNs, which are obtained from the node's pg_data >>> >>> However, not all PFNs within this range necessarily belong to the same >>> node—some may belong to other nodes. Additionally, due to the >>> discontiguous nature of physical memory, certain sections within a >>> `memory block` may be absent. >>> >>> As a result, `memory blocks` that fall between a node’s start and end >>> PFNs may span across multiple nodes, and some sections within those blocks >>> may be missing. `Memory blocks` have a fixed size, which is architecture >>> dependent. >>> >>> Due to these considerations, the memory block registration is currently >>> performed as follows: >>> >>> for_each_online_node(nid): >>> start_pfn = pgdat->node_start_pfn; >>> end_pfn = pgdat->node_start_pfn + node_spanned_pages; >>> for_each_memory_block_between(PFN_PHYS(start_pfn), PFN_PHYS(end_pfn)) >>> mem_blk = memory_block_id(pfn_to_section_nr(pfn)); >>> pfn_mb_start=section_nr_to_pfn(mem_blk->start_section_nr) >>> pfn_mb_end = pfn_start + memory_block_pfns - 1 >>> for (pfn = pfn_mb_start; pfn < pfn_mb_end; pfn++): >>> if (get_nid_for_pfn(pfn) != nid): >>> continue; >>> else >>> do_register_memory_block_under_node(nid, mem_blk, >>> MEMINIT_EARLY); >>> >>> Here, we derive the start and end PFNs from the node's pg_data, then >>> determine the memory blocks that may belong to the node. For each >>> `memory block` in this range, we inspect all PFNs it contains and check >>> their associated NUMA node ID. If a PFN within the block matches the >>> current node, the memory block is registered under that node. >>> >>> If CONFIG_DEFERRED_STRUCT_PAGE_INIT is enabled, get_nid_for_pfn() performs >>> a binary search in the `memblock regions` to determine the NUMA node ID >>> for a given PFN. If it is not enabled, the node ID is retrieved directly >>> from the struct page. >>> >>> On large systems, this process can become time-consuming, especially since >>> we iterate over each `memory block` and all PFNs within it until a match is >>> found. When CONFIG_DEFERRED_STRUCT_PAGE_INIT is enabled, the additional >>> overhead of the binary search increases the execution time significantly, >>> potentially leading to soft lockups during boot. >>> >>> In this patch, we iterate over `memblock region` to identify the >>> `memory blocks` that belong to the current NUMA node. `memblock regions` >>> are contiguous memory ranges, each associated with a single NUMA node, and >>> they do not span across multiple nodes. >>> >>> for_each_online_node(nid): >>> for_each_memory_region(r): // r => region >>> if (r->nid != nid): >>> continue; >>> else >>> for_each_memory_block_between(r->base, r->base + r->size - 1): >>> do_register_memory_block_under_node(nid, mem_blk, MEMINIT_EARLY); >>> >>> We iterate over all `memblock regions` and identify those that belong to >>> the current NUMA node. For each `memblock region` associated with the >>> current node, we calculate the start and end `memory blocks` based on the >>> region's start and end PFNs. We then register all `memory blocks` within >>> that range under the current node. >>> >>> Test Results on My system with 32TB RAM >>> ======================================= >>> 1. Boot time with CONFIG_DEFERRED_STRUCT_PAGE_INIT enabled. >>> >>> Without this patch >>> ------------------ >>> Startup finished in 1min 16.528s (kernel) >>> >>> With this patch >>> --------------- >>> Startup finished in 17.236s (kernel) - 78% Improvement >>> >>> 2. Boot time with CONFIG_DEFERRED_STRUCT_PAGE_INIT disabled. >>> >>> Without this patch >>> ------------------ >>> Startup finished in 28.320s (kernel) >>> >>> With this patch >>> --------------- >>> Startup finished in 15.621s (kernel) - 46% Improvement >>> >>> Acked-by: David Hildenbrand >>> Signed-off-by: Donet Tom >>> >>> --- >>> v2 -> v3 >>> >>> Fixed indentation issues, made `start_block_id` and `end_block_id` constants, >>> and moved variable declarations to the places where they are needed. >>> >>> v2 - https://lore.kernel.org/all/fbe1e0c7d91bf3fa9a64ff5d84b53ded1d0d5ac7.1745852397.git.donettom@linux.ibm.com/ >>> v1 - https://lore.kernel.org/all/50142a29010463f436dc5c4feb540e5de3bb09df.1744175097.git.donettom@linux.ibm.com/ >>> --- >>> drivers/base/memory.c | 4 ++-- >>> drivers/base/node.c | 38 ++++++++++++++++++++++++++++++++++++++ >>> include/linux/memory.h | 2 ++ >>> include/linux/node.h | 11 +++++------ >>> 4 files changed, 47 insertions(+), 8 deletions(-) >>> >>> diff --git a/drivers/base/memory.c b/drivers/base/memory.c >>> index 19469e7f88c2..7f1d266ae593 100644 >>> --- a/drivers/base/memory.c >>> +++ b/drivers/base/memory.c >>> @@ -60,7 +60,7 @@ static inline unsigned long pfn_to_block_id(unsigned long pfn) >>> return memory_block_id(pfn_to_section_nr(pfn)); >>> } >>> >>> -static inline unsigned long phys_to_block_id(unsigned long phys) >>> +unsigned long phys_to_block_id(unsigned long phys) >>> { >>> return pfn_to_block_id(PFN_DOWN(phys)); >>> } >>> @@ -632,7 +632,7 @@ int __weak arch_get_memory_phys_device(unsigned long start_pfn) >>> * >>> * Called under device_hotplug_lock. >>> */ >>> -static struct memory_block *find_memory_block_by_id(unsigned long block_id) >>> +struct memory_block *find_memory_block_by_id(unsigned long block_id) >>> { >>> struct memory_block *mem; >>> >>> diff --git a/drivers/base/node.c b/drivers/base/node.c >>> index cd13ef287011..0f8a4645b26c 100644 >>> --- a/drivers/base/node.c >>> +++ b/drivers/base/node.c >>> @@ -20,6 +20,7 @@ >>> #include >>> #include >>> #include >>> +#include >>> >>> static const struct bus_type node_subsys = { >>> .name = "node", >>> @@ -850,6 +851,43 @@ void unregister_memory_block_under_nodes(struct memory_block *mem_blk) >>> kobject_name(&node_devices[mem_blk->nid]->dev.kobj)); >>> } >>> >>> +/* >>> + * register_memory_blocks_under_node_early : Register the memory >>> + * blocks under the current node. >>> + * @nid : Current node under registration >>> + * >>> + * This function iterates over all memblock regions and identifies the regions >>> + * that belong to the current node. For each region which belongs to current >>> + * node, it calculates the start and end memory blocks based on the region's >>> + * start and end PFNs. It then registers all memory blocks within that range >>> + * under the current node. >>> + */ >>> +void register_memory_blocks_under_node_early(int nid) >>> +{ >>> + struct memblock_region *r; >>> + >>> + for_each_mem_region(r) { >>> + if (r->nid != nid) >>> + continue; >>> + >>> + const unsigned long start_block_id = phys_to_block_id(r->base); >>> + const unsigned long end_block_id = phys_to_block_id(r->base + r->size - 1); >>> + unsigned long block_id; >>> + >>> + for (block_id = start_block_id; block_id <= end_block_id; block_id++) { >>> + struct memory_block *mem; >>> + >>> + mem = find_memory_block_by_id(block_id); >>> + if (!mem) >>> + continue; >>> + >>> + do_register_memory_block_under_node(nid, mem, MEMINIT_EARLY); >>> + put_device(&mem->dev); >>> + } >>> + >>> + } >>> +} >>> + >>> void register_memory_blocks_under_node(int nid, unsigned long start_pfn, >>> unsigned long end_pfn, >>> enum meminit_context context) >>> diff --git a/include/linux/memory.h b/include/linux/memory.h >>> index 12daa6ec7d09..cb8579226536 100644 >>> --- a/include/linux/memory.h >>> +++ b/include/linux/memory.h >>> @@ -171,6 +171,8 @@ struct memory_group *memory_group_find_by_id(int mgid); >>> typedef int (*walk_memory_groups_func_t)(struct memory_group *, void *); >>> int walk_dynamic_memory_groups(int nid, walk_memory_groups_func_t func, >>> struct memory_group *excluded, void *arg); >>> +unsigned long phys_to_block_id(unsigned long phys); >>> +struct memory_block *find_memory_block_by_id(unsigned long block_id); >>> #define hotplug_memory_notifier(fn, pri) ({ \ >>> static __meminitdata struct notifier_block fn##_mem_nb =\ >>> { .notifier_call = fn, .priority = pri };\ >>> diff --git a/include/linux/node.h b/include/linux/node.h >>> index 2b7517892230..93beefe8f179 100644 >>> --- a/include/linux/node.h >>> +++ b/include/linux/node.h >>> @@ -114,12 +114,16 @@ extern struct node *node_devices[]; >>> void register_memory_blocks_under_node(int nid, unsigned long start_pfn, >>> unsigned long end_pfn, >>> enum meminit_context context); >>> +void register_memory_blocks_under_node_early(int nid); >>> #else >>> static inline void register_memory_blocks_under_node(int nid, unsigned long start_pfn, >>> unsigned long end_pfn, >>> enum meminit_context context) >>> { >>> } >>> +static inline void register_memory_blocks_under_node_early(int nid) >>> +{ >>> +} >>> #endif >>> >>> extern void unregister_node(struct node *node); >>> @@ -134,15 +138,10 @@ static inline int register_one_node(int nid) >>> int error = 0; >>> >>> if (node_online(nid)) { >>> - struct pglist_data *pgdat = NODE_DATA(nid); >>> - unsigned long start_pfn = pgdat->node_start_pfn; >>> - unsigned long end_pfn = start_pfn + pgdat->node_spanned_pages; >>> - >>> error = __register_one_node(nid); >>> if (error) >>> return error; >>> - register_memory_blocks_under_node(nid, start_pfn, end_pfn, >>> - MEMINIT_EARLY); >>> + register_memory_blocks_under_node_early(nid); >> Does not that change mean that when register_one_node() is called from >> memory hotplug it will always try to iterate memblock regions? >> This would be a problem on architectures that don't keep memblock around >> after boot. > > > Hi Mike > > Apologies — I wasn’t aware about CONFIG_ARCH_KEEP_MEMBLOCK. > Thank you for pointing it out. > > If this configuration is disabled, the current patchset would not function > correctly, and node device initialization could fail during the hotplug path. memory hotplug code never calls register_one_node(), unless I am missing something. During add_memory_resource(), we call __try_online_node(nid, false), meaning we skip register_one_node(). The only caller of __try_online_node(nid, true) is try_online_node(), called from CPU hotplug code, and I *guess* that is not required. I think the reason is simple: memory hotplug onlines the node before it adds any memory. So, there is no memory yet, consequently nothing to walk / register. This whole code could deserve some cleanups. In particular, I am not sure if __try_online_node() must ever call register_one_node(). -- Cheers, David / dhildenb