From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68641C4345F for ; Fri, 12 Apr 2024 01:57:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 045186B0095; Thu, 11 Apr 2024 21:57:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F10B26B0096; Thu, 11 Apr 2024 21:57:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DB1266B0098; Thu, 11 Apr 2024 21:57:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id BB88E6B0095 for ; Thu, 11 Apr 2024 21:57:32 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 7464B1A03FE for ; Fri, 12 Apr 2024 01:57:32 +0000 (UTC) X-FDA: 81999217944.13.5511E13 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by imf13.hostedemail.com (Postfix) with ESMTP id 86B322000F for ; Fri, 12 Apr 2024 01:57:30 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="XR/WgXYi"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf13.hostedemail.com: domain of seakeel@gmail.com designates 209.85.214.175 as permitted sender) smtp.mailfrom=seakeel@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712887050; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RscDpb9G0I8cBHb7bwf0ABPoa7f16JNqm4+SxgWIQ40=; b=QwNIr3rFprH9l0QcDflV5atU/mMzJVwu8vw6rOfaTuJZlgEn8fR5068+ikVzwwT9HleAO8 7zzmHBmN4L7h8kTg9aWQLyQIJyOLBk1xX0c55nZ5ygnxBZp9Jvdc4GHg1K8WsTaPjCjY2F 8k610ZKdcsstaH4kgwb9ylNcXrdsuCA= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="XR/WgXYi"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf13.hostedemail.com: domain of seakeel@gmail.com designates 209.85.214.175 as permitted sender) smtp.mailfrom=seakeel@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712887050; a=rsa-sha256; cv=none; b=vBcwWw2/rW3x3VAVRFiTmsC04xbmCmnlvrYbOwWU9i19mfguWulLZ7UTV/5EjMoAIMgqc5 /NnfqbKadD/N+y95krt+jhxCS9/ZWYQEwCXx+nLClQTXtXAs0wK9Gyo5KS+7u7OpJakEt/ wW/MQbQjsdtODlPe+GxlVDdGX5+UNkI= Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-1e3dda73192so3415575ad.3 for ; Thu, 11 Apr 2024 18:57:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712887049; x=1713491849; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=RscDpb9G0I8cBHb7bwf0ABPoa7f16JNqm4+SxgWIQ40=; b=XR/WgXYisvlPsfIjMDfPjYLqKEkRVr9aXFqrmVnUYZy/IF4KR93umTlqXX1YBzjeXi /ogxOzZXfvEXAezvSz89ULJJFXmQ1UMmbD5+kgU0aAPfN81YF7upXKohwDPxQT24bQ/0 wQcdz4p73Yr46hf/zV2SmSeavGc5NvMSJgg34pjewOZUDnxQb5lTCkIX3/y0kwmIfP8u g0iwDWdzpTqz3JKY//vqWBvMrqEFOP1t83At/GmElWYRYQIGexeWKocprvhp1iU9Ec4w 0XAGrUEEKdX2uYn5X3zUPh9P8TsZwNvrhMwR2hPCNGcVh3xfs82cnpdZEB+akdwCqM83 pfAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712887049; x=1713491849; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RscDpb9G0I8cBHb7bwf0ABPoa7f16JNqm4+SxgWIQ40=; b=vYe9Z3nWBUUakSzyz/bUyRwZkXyHj+1YHVnrvRiMMyrZXl69wTco0SXspur9z+fR3u mwuD1Nji67lPbUs5coMdujYLuzuUDkTSKH+CL9eXwe1AalgM1QUfkgkbaIod+f1MAQBL zD4NZPDoZW2ROqA0Xj/8EPr0FxkfLc3nrnvpNglNOUQob/H89herSzKgWIC3eOglJmw4 CBhK9HtjRgoyF0E2BpnYh+njKCOuvOBlo3tB1KnYyEr0yDswB2ozSye276Y+fUNu6Js0 f+Y+CO5xPHTmYYJvh+7VOSj2fMnYPsJQERKxf0zw7oVqa+TrwrbvxO/9pVHqEfBGWzmE 8spg== X-Forwarded-Encrypted: i=1; AJvYcCXZOy5DIbtFvHw8Ka1Bb1KHRjlMKtFplli/RWH2RD+SNFuC6GKnyjVxkT1wPQAIgm4bpmU0MUl39/RpuMy5fBAkcg4= X-Gm-Message-State: AOJu0YyNWb1JB1JsNaRaC5OD1G+7kvM1Pzx0EVEmNe6eDkE0gcXJwj0v kv/jXmy8e1Es7sOVELiVgUdADXzY0glu2fH/3UR0YLv3ab7lm3LG X-Google-Smtp-Source: AGHT+IG/cVTcc5g/V1H4LJGCGotQD85d3VOuYVl+tn9EKYJaot57YCU98/euIfC/qnEI89Kins33LA== X-Received: by 2002:a17:902:6503:b0:1e5:8175:4968 with SMTP id b3-20020a170902650300b001e581754968mr1271474plk.9.1712887049369; Thu, 11 Apr 2024 18:57:29 -0700 (PDT) Received: from [192.168.255.10] ([43.132.141.21]) by smtp.gmail.com with ESMTPSA id l5-20020a170903120500b001e4458831afsm1833075plh.227.2024.04.11.18.57.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Apr 2024 18:57:28 -0700 (PDT) Message-ID: <188e492e-343e-4205-b768-132ddc5229e7@gmail.com> Date: Fri, 12 Apr 2024 09:57:25 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 09/10] mm/ksm: rename get_ksm_page_flags() to ksm_get_folio_flags To: Andrew Morton , David Hildenbrand Cc: alexs@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, zik.eidus@ravellosystems.com, willy@infradead.org, aarcange@redhat.com, hughd@google.com, chrisw@sous-sol.org References: <20240411061713.1847574-1-alexs@kernel.org> <20240411061713.1847574-10-alexs@kernel.org> <192aaa5c-3ff3-40c1-b12a-b674518bf5de@redhat.com> <47686d5e-efd3-4431-b72c-620f749faeaa@redhat.com> <20240411134234.09920cdb641b3aa001526284@linux-foundation.org> Content-Language: en-US From: Alex Shi In-Reply-To: <20240411134234.09920cdb641b3aa001526284@linux-foundation.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 86B322000F X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: s6t4bqnppiestybjsddaphpwn57wm5h5 X-HE-Tag: 1712887050-70106 X-HE-Meta: U2FsdGVkX18b5Jai5iaJlpRNH1xy/EV6OG7M2wQiwIz9+p71ky0enV6QMfQAp/mlNFtSats+VA7T71vHXzYwGPbVtdtdl8l95QqzQGjShtZTrPrKX8El3kDPJoMVkda84v5gBTUNZtlw33I0t36E+uFRsz5OkzfqRibFiyFKOK37nNn7OiM+AU7KRa1fglhEprIChWOSDCuxQ0H08FtmUsEHZwyXkxLwKzAK+DYcN6y9fkVDQMRYc8XEcuaaEZkgvMEVh/IvSvm0Ais80+Tp4IwgqLbxqkJuTOFfMDzJleMSRYFKaeZ+OBCQxtDHTFnsDi13BBWQifVm1nibqN4hkJWizmzWOASnhERVVjyCpCcWjIdQz3iUpqjHUh60ThFRTDsqj8etzkogCQeblkqgZpMJmWDj8CoweUVuEisLOQVojLRYHzHPasofhdoyP7SbZeyl0pBW1L7vH8o4CMakFoeJD7by0S4Do78WEt3/uhZjTK5XpwAOprk+2++NXgbqnDqHql8YMPbUCYfceF8diVQCB5B6DBmcKH1MyaIvyXPil7UwqnLNKbZxED6tnNGZ4YsvDJMyYD7aurarLdYIli+E+b6/3kqz+yvDEaRRGd7WtL9ggGKM21rVHAaw4tVKi9LusMrxCQPnNPLxTtjkgKmrTNTPZOedVY/4dfowW/IHCL1WAQ3sos6bRBnM0tstrbFmPbo8iF9Z1gsPS3ViX7rw6k0wOG8DoLjUj52USC5ZzMDaZUqSVO9d/nzxHSIpDt3x+3TBYOCHTDTFb2hfJmY9qfyEFRAiKWdsRI6dGorDgA+VBVBr4a2mkJkKe9MmRRbJkJRH2napF4fZ3pkW46GRy47YUvYjEKuHKt9/fDIsE3Q3JhtgHc81zyXLbNnLFWU5FDX0Pv0Fpo40J+0jETp0pEN64t8wUFBtE9vcDhbrVqi4HEAoKgOOMihfREGDVswhZtZjYA5m7EWCziG tF/Wz76d Cc02K5Vh847JwjPQFgfHfnCVF7t1dwIYvNQtRxh1CdDBzI6YLXD63EgHlIyFBBY0dNRGsboNi6NIc5ixRqwjZT5oCT83WNjyrIJ8lRizJ5TVCpX+lMblSbxRWpqG51NqJ/JJw3/vrUJzd5J2rN+s6wUyzZDtCWHUNla5rUDBxFR54cFTjP4UJMzjYj4em1WxmqqHEaXDGMi5F6Pq5rTG2fJQ6TcFtU8Y/ROW9J3Sts0MDJV3HNYDEC6wD0SCor8810muexVXGh6wh4xTV2+E/DhsbaPmgaaJiAnpwwpTHQjhqP2v9KFB8foIhqhzOfWZkp7v8vd6Jwahi2iTU0hA7i97WcCYawgmSmuQ4wfSJGA2i0ejhxv2D7bT2b8UfZAx/ceHrwz7u6DTJtoEUm8zg7oggHR00pvXS7dl8c3CkofkG9t/0N1f7KR2+ESI/Ogepq+Qh1HoFMypB6UDUL1IA4U5t9ScJzdGML4uF70aOxPEHKDr8aUlvKX8ee8FyPBORb0PAQbAyYrzKfQo3xpmjqZK/cl/id1V90ICYHZ14H7KxweFS8UPGRFcPXi4ox3A+BWMkk6eG8kEV1CMuuCW7QKicBq0CTj8CTr4R X-Bogosity: Ham, tests=bogofilter, spamicity=0.000009, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/12/24 4:42 AM, Andrew Morton wrote: > On Thu, 11 Apr 2024 13:46:23 +0200 David Hildenbrand wrote: > >> On 11.04.24 13:42, Alex Shi wrote: >>> >>> >>> On 4/11/24 3:51 PM, David Hildenbrand wrote: >>>> On 11.04.24 08:17, alexs@kernel.org wrote: >>>>> From: David Hildenbrand >>>>> >>>>> As we are removing get_ksm_page_flags(), make the flags match the new >>>>> function name. >>>>> >>>>> Signed-off-by: David Hildenbrand >>>>> Reviewed-by: Alex Shi >>>>> --- >>>> >>>> s/get_ksm_page_flags()/get_ksm_page_flags/ in title, otherwise LGTM. >>>> >>> >>> Uh, for this trivial issue, do I need to sent a new version? or left to maintainer for a quick fix? >> >> I'm sure Andrew can fix that up :) > > He indeed can. Although he prefers foo() to foo. Those two characters > have a good information-per-byte ratio. > > Also I added Alex's Signed-off-by to this. > > (c) The contribution was provided directly to me by some other > person who certified (a), (b) or (c) and I have not modified > it. > Thanks a lot for you and all the info! Best regards!