From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C016AC433E0 for ; Wed, 17 Feb 2021 06:25:40 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CCB6864DA8 for ; Wed, 17 Feb 2021 06:25:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CCB6864DA8 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=virtuozzo.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1BF3C6B0099; Wed, 17 Feb 2021 01:25:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 16DB86B009A; Wed, 17 Feb 2021 01:25:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0847B8D0019; Wed, 17 Feb 2021 01:25:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0229.hostedemail.com [216.40.44.229]) by kanga.kvack.org (Postfix) with ESMTP id E77CA6B0099 for ; Wed, 17 Feb 2021 01:25:38 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id B665C180ACF8F for ; Wed, 17 Feb 2021 06:25:38 +0000 (UTC) X-FDA: 77826773556.08.9B5721E Received: from relay.sw.ru (relay.sw.ru [185.231.240.75]) by imf14.hostedemail.com (Postfix) with ESMTP id 55E4EC0001FE for ; Wed, 17 Feb 2021 06:25:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Content-Type:MIME-Version:Date:Message-ID:From: Subject; bh=cAfBU/411PKRhiWpGgo9nN8pw3+CfaYQSsKUktdXIvU=; b=tvxBm0KEWZeyZRAKc 6dENRSaYqRAMmCwoRCUKyPfyVsc0liSO4EDgIUZxqq4aHMoEpa8+AKlAoEskXJii/yRYKmMT/Zt9e MuZ4hwZYXk1kANuZz9/bFiO5sFW7ED1Ms9ZYuvgsc+e/9wPkw/3JHKPY13DL29OINFKTOgQQwH6PQ =; Received: from [192.168.15.68] by relay.sw.ru with esmtp (Exim 4.94) (envelope-from ) id 1lCGGq-002GSa-W1; Wed, 17 Feb 2021 09:25:09 +0300 Subject: Re: [v8 PATCH 05/13] mm: vmscan: use kvfree_rcu instead of call_rcu To: Yang Shi , guro@fb.com, vbabka@suse.cz, shakeelb@google.com, david@fromorbit.com, hannes@cmpxchg.org, mhocko@suse.com, akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210217001322.2226796-1-shy828301@gmail.com> <20210217001322.2226796-6-shy828301@gmail.com> From: Kirill Tkhai Message-ID: <187b874c-91a8-58de-547e-3651e27bf702@virtuozzo.com> Date: Wed, 17 Feb 2021 09:25:18 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210217001322.2226796-6-shy828301@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Stat-Signature: ejetibjx5zysp1wnfjinjdr46nwk5bno X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 55E4EC0001FE Received-SPF: none (virtuozzo.com>: No applicable sender policy available) receiver=imf14; identity=mailfrom; envelope-from=""; helo=relay.sw.ru; client-ip=185.231.240.75 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1613543134-589452 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 17.02.2021 03:13, Yang Shi wrote: > Using kvfree_rcu() to free the old shrinker_maps instead of call_rcu(). > We don't have to define a dedicated callback for call_rcu() anymore. > > Signed-off-by: Yang Shi Acked-by: Kirill Tkhai > --- > mm/vmscan.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 2e753c2516fa..c2a309acd86b 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -192,11 +192,6 @@ static inline int shrinker_map_size(int nr_items) > return (DIV_ROUND_UP(nr_items, BITS_PER_LONG) * sizeof(unsigned long)); > } > > -static void free_shrinker_map_rcu(struct rcu_head *head) > -{ > - kvfree(container_of(head, struct memcg_shrinker_map, rcu)); > -} > - > static int expand_one_shrinker_map(struct mem_cgroup *memcg, > int size, int old_size) > { > @@ -219,7 +214,7 @@ static int expand_one_shrinker_map(struct mem_cgroup *memcg, > memset((void *)new->map + old_size, 0, size - old_size); > > rcu_assign_pointer(memcg->nodeinfo[nid]->shrinker_map, new); > - call_rcu(&old->rcu, free_shrinker_map_rcu); > + kvfree_rcu(old); > } > > return 0; >