From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13F8DC5472D for ; Wed, 28 Aug 2024 06:37:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7E9B56B009C; Wed, 28 Aug 2024 02:37:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 79A6B6B00A6; Wed, 28 Aug 2024 02:37:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 660E16B00AE; Wed, 28 Aug 2024 02:37:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 4775A6B009C for ; Wed, 28 Aug 2024 02:37:34 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id E3D8C1A1CD8 for ; Wed, 28 Aug 2024 06:37:33 +0000 (UTC) X-FDA: 82500697986.14.0BE667A Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by imf22.hostedemail.com (Postfix) with ESMTP id D7A55C0009 for ; Wed, 28 Aug 2024 06:37:30 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=none; spf=pass (imf22.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.190 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724826935; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oj5GHAiZi/hgabaHTFvQhfZLUEsMJKXBo30DH7Sq1vg=; b=bDIO2xClW1eFeCKzI4CmK2oF0DmYBxNzAN0X95ZUC+R7DXKk3B7Wle6v2Y0uiicoylrLym j5ZyTp6iCSfaHATQjIZwtQhJCgsVuoNuI2NVwAf5LLa/GoRdwwil4/YOlYqt49adQCmBrs XQAQkF+6P8JYOIX8iymNBmcXNhJf2f4= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=none; spf=pass (imf22.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.190 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724826935; a=rsa-sha256; cv=none; b=l1usdXzIUSNiVN+NEgV9uKeKp4aWUhbtAKTGJqZdOP97BRG+5+97nP7ZfsKdsWMY9Lwn7q vHBp+USlH3k+0uoNhcNrlOMuoLndCevH/NEkisizpX4Nleb2yjQA6O4XdB3nbrynEv69Z4 Ldc4X0/j0rCLGGXVL4wzYdco0WVOtD0= Received: from mail.maildlp.com (unknown [172.19.162.112]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4WtvjK1b5gz20mfv; Wed, 28 Aug 2024 14:32:37 +0800 (CST) Received: from dggpemf100008.china.huawei.com (unknown [7.185.36.138]) by mail.maildlp.com (Postfix) with ESMTPS id 6401014013B; Wed, 28 Aug 2024 14:37:26 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemf100008.china.huawei.com (7.185.36.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Wed, 28 Aug 2024 14:37:25 +0800 Message-ID: <1871f5f4-0dd0-4721-8cf1-ff54e44ee05c@huawei.com> Date: Wed, 28 Aug 2024 14:37:25 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] mm: migrate: add folio_isolate_movable() Content-Language: en-US To: Andrew Morton CC: David Hildenbrand , Matthew Wilcox , Baolin Wang , Zi Yan , References: <20240826040132.1202297-1-wangkefeng.wang@huawei.com> <20240826040132.1202297-2-wangkefeng.wang@huawei.com> <20240827181438.d8b7100c015306e5f2b19504@linux-foundation.org> From: Kefeng Wang In-Reply-To: <20240827181438.d8b7100c015306e5f2b19504@linux-foundation.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemf100008.china.huawei.com (7.185.36.138) X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: D7A55C0009 X-Stat-Signature: ghtgc8djwto8z3er7b56g9u16x7qj7cq X-Rspam-User: X-HE-Tag: 1724827050-492793 X-HE-Meta: U2FsdGVkX1+FGYq59oYUcFO1k7hebKuz/PcCkmGldut6QKW1yamkSeNizqWtTzQunSLmtAMPSq8s0bz1oFuWYgitLyosMsZlvDSjwxOwCf6N7yD/rXrlFMgipZ5xiyKCveJQuXgpobDS0CI6s/EKlMJJ5N0Wqf4wv5x+cnuVDWQXSsn50eFrNGFMbaxxyzaEzPmJNDKmpofCPjmGXtAqa/pLMTdJyBIxv5gu4OSN/kF5yoz8PCJw5YnUmOtPzGrTkAX6ScBc34cUBZByeXEynUvBmFgH5I63bFsfRvqIMTgvKyfUXVqj7lgPtlWqdF804pGmucScgcDwfDzlGTyX751sWjFBNG+z4BpmaALhYwG6o5ve0hIvgo+aQp080iMOY4M9z9afE6/jcmEC7p/7MjcjSF7/RfASV5Owev6qpOZQtzD2+7d+Od26/k2rsAu50olf+LQgkWRHHjvsmEs2iTmL1Asj9X++kMFd375DVwOVxCiISkhcJXqQb0tIsE15xO941LvgEIiorDw6yHcXLOVFUmm7fCM9N021bCRgzWk8U/Q9WNfptPN1z/Gu1QcyfZa3MdVsv791amQNtY6ouZasVcGMy3dpdfqZ67NRPzHBPNg9ngeMwF8o2AtgtATsSdupizRZH0xTpMNcByitb5CUegTB+p/6xLFrZQ/G9AqgSH1xTf86C7AlrB9e7FirsBQS5CZ5Wyej6krmSH1Sf35n1S5rRZiRD9dKPzIO9/HV78UZ1bJrhOxW6OuRENoxPI5LBKUYAg4U52+zAcHD+28YH2EHgAlzufNgbSx3GSJ6ovAcg+H6m+GKLKDiNOSM/E6quer7vVB3imRvne9kmW5QPDJrlUJNhr5mTo+/JUa7+GbUgN/nkUeNLjowwZU7Yj50lTkF7CxS2iHEVf8eMoUrmlDWrdGt6KYFZAUHYnj0jR+m2I9FGscY8rNsz9bRBhMUd/Gr6BG8GMCq2zt yT7qz56r Jl+VAZ86oy2ghgQpMhdFALeJ68/Oue2t0HNS7BYeW3dQ1sceWgyjm+O0WCojOiSRmgM/w5Oo8gfo5ofnDyT1DK5oPBXWVG3if07B0BCjV1ZcDPwWXwjVAm3pbbKhWf73VfvN+ZgSt1vsL2Dsf5Xdz+/gFjVKcjL2AJ4W80sn4+OCaxKq6RIUYiDcVgZTg90L9zXnx+IdV+6hXTdrnUgC2ZgvwPLBcgZQvBHD/TTIoadcEXgs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/8/28 9:14, Andrew Morton wrote: > On Mon, 26 Aug 2024 12:01:29 +0800 Kefeng Wang wrote: > >> Like isolate_lru_page(), make isolate_movable_page() as a wrapper >> around folio_isolate_movable(), since isolate_movable_page() always >> fails on a tail page, return immediately for a tail page in the warpper, >> and the wrapper will be removed once all callers are converted to >> folio_isolate_movable(). >> >> ... >> >> +bool isolate_movable_page(struct page *page, isolate_mode_t mode) >> +{ >> + if (PageTail(page)) >> + return false; >> + >> + return folio_isolate_movable((struct folio *)page, mode); >> +} > > Use page_folio() here? Page must head after above check, and this function will be killed in patch4 , so no need to use page_folio().