Re: [PATCH 1/4] mm: migrate: add folio_isolate_movable()

[Kefeng Wang <wangkefeng.wang@huawei.com>]

On 2024/8/28 9:14, Andrew Morton wrote:
> On Mon, 26 Aug 2024 12:01:29 +0800 Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
> 
>> Like isolate_lru_page(), make isolate_movable_page() as a wrapper
>> around folio_isolate_movable(), since isolate_movable_page() always
>> fails on a tail page, return immediately for a tail page in the warpper,
>> and the wrapper will be removed once all callers are converted to
>> folio_isolate_movable().
>>
>> ...
>>
>> +bool isolate_movable_page(struct page *page, isolate_mode_t mode)
>> +{
>> +	if (PageTail(page))
>> +		return false;
>> +
>> +	return folio_isolate_movable((struct folio *)page, mode);
>> +}
> 
> Use page_folio() here?

Page must head after above check, and this function will be killed in 
patch4 , so no need to use page_folio().