From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A334E77173 for ; Fri, 6 Dec 2024 20:31:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 071866B0142; Fri, 6 Dec 2024 15:31:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0211A6B0147; Fri, 6 Dec 2024 15:31:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E2ACB6B0149; Fri, 6 Dec 2024 15:31:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C4F506B0142 for ; Fri, 6 Dec 2024 15:31:36 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 6F3BF414D0 for ; Fri, 6 Dec 2024 20:31:36 +0000 (UTC) X-FDA: 82865678994.01.4E21BC1 Received: from eu-smtp-delivery-151.mimecast.com (eu-smtp-delivery-151.mimecast.com [185.58.86.151]) by imf28.hostedemail.com (Postfix) with ESMTP id E99E1C0025 for ; Fri, 6 Dec 2024 20:31:11 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=none; spf=pass (imf28.hostedemail.com: domain of david.laight@aculab.com designates 185.58.86.151 as permitted sender) smtp.mailfrom=david.laight@aculab.com; dmarc=pass (policy=none) header.from=aculab.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733517075; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4Q6aiBQuYeiFel3TmyNurQYusCtWecmwlEYRoIu48Gc=; b=yRFmsXuZ2pz5eHE+ihFXXtSB1N8WvUCQHTp+va9gS8Zwf7CY5oA+PUxcGu9MzhTBJEMmcL eKIgtgBtIJn8oI3LI1N4EBvzY5KSoRHkDHs4UTr2nMr+PNHZXGu0Og254anqHS/wJRwXWd VMkxo9+RZXU6SFDX1ZX5r75GDuveAQs= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=none; spf=pass (imf28.hostedemail.com: domain of david.laight@aculab.com designates 185.58.86.151 as permitted sender) smtp.mailfrom=david.laight@aculab.com; dmarc=pass (policy=none) header.from=aculab.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733517075; a=rsa-sha256; cv=none; b=Cf/1orE2ljKF5TysXk9jtHuvuyymmEtw4ooY2U5nQVIhuv+1tZ7lFDin5OGEjhDWz19U3W Gx2apTvUIHaG4Xt4eY+BXBNi+sdtGEW4ZvwqLZYTyx18+ImLxwVhfjBcAYcsCmV4xGp0jS iDQrdN1e0FaATarW38fFVELIFgXkaRk= Received: from AcuMS.aculab.com (156.67.243.121 [156.67.243.121]) by relay.mimecast.com with ESMTP with both STARTTLS and AUTH (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id uk-mtapsc-7-1sxFTS2yM0ytUm8cZogNgQ-1; Fri, 06 Dec 2024 20:31:27 +0000 X-MC-Unique: 1sxFTS2yM0ytUm8cZogNgQ-1 X-Mimecast-MFC-AGG-ID: 1sxFTS2yM0ytUm8cZogNgQ Received: from AcuMS.Aculab.com (10.202.163.6) by AcuMS.aculab.com (10.202.163.6) with Microsoft SMTP Server (TLS) id 15.0.1497.48; Fri, 6 Dec 2024 20:30:40 +0000 Received: from AcuMS.Aculab.com ([::1]) by AcuMS.aculab.com ([::1]) with mapi id 15.00.1497.048; Fri, 6 Dec 2024 20:30:40 +0000 From: David Laight To: 'SeongJae Park' , "stable@vger.kernel.org" CC: "damon@lists.linux.dev" , "linux-mm@kvack.org" , kernel test robot , Brendan Higgins , Shuah Khan , Andrew Morton , Linus Torvalds Subject: RE: [PATCH 5.15.y 1/2] mm/damon/vaddr-test: split a test function having >1024 bytes frame size Thread-Topic: [PATCH 5.15.y 1/2] mm/damon/vaddr-test: split a test function having >1024 bytes frame size Thread-Index: AQHbSArnkIl2VsLGyUyrnUDDHJF4R7LZqsOw Date: Fri, 6 Dec 2024 20:30:40 +0000 Message-ID: <1859ccaacd974b37a05b42371e57a061@AcuMS.aculab.com> References: <2024120625-recycling-till-0cca@gregkh> <20241206181620.91603-1-sj@kernel.org> <20241206181620.91603-2-sj@kernel.org> In-Reply-To: <20241206181620.91603-2-sj@kernel.org> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: u8WV7yx_IkyyZFf5t5Im9bxmegdiuwPQSp2kbpnfHoA_1733517086 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: E99E1C0025 X-Rspam-User: X-Stat-Signature: 39k7f7ncsdjuff6ceooinep9zn591ner X-HE-Tag: 1733517071-339687 X-HE-Meta: U2FsdGVkX18U2IWQP2ETIjczwlfdA9vg6cw8jCbd/X3+ZE7q+zi0czFpL2AVCgIAHUxAzZ4K+8EYmJ3oPojOTiZDfto8oYo+lJdQSLgZ634PHLO+7dKztMcWK6UJeIx5pNQvhmQASiDGdgVKoDTv1Vj3BeN7RrXcuHb+fAheeZGaj1QxAk8CNPu3fLsOHUwHVv7lh2YwrXL5K6ASttcRrrclYhaKcKl2gON0J+qkX+IlBX47Wzgl36TGFQezeIVryEcc7IW7VhzGvrvtslvABHmIdatxd6tQ8J4sgp1CccElR/7Yq7YeeJzcFSliQU9sQvAvGbjYEmb6mUVTfl0ggaB3Em2z98gcmeJj6XrDybNe15csPQCRI5twNhm4/eH82nc/GbrCxzU6eOj5yA1bfcIjAb/dyJZpRupymBvuZcdrYAS1YkvLShXJJelnhgTA6KkiIuvAX9eWCe04alSt82vmFzCljdmicHuoOiODID+SPGSiLNPwViR3mRXnBSWddEUTLfIPZovEIpQ3qtZTkPnP3WmIBSnAzLT1JQf9cwmrSfoGokUgw+JhO5nP3ubC+Xa7f7rugS7oGZw1zYf51RGLFVCtrNE0jRgxgFXt4fIiZL8MKnt8A1CQlIZ3yRKkrvr0OnqbcSqZsq7n8q5b4orL/HFjb2HErSJ/BarCmZ+CufOcDlpibMFCiw/vxRTOqL6uWsZdUMbuwFRWPyjNSLa4EPD4kvcmaWt8ewNYVJCGt9zBsd3t+410Dv/wWO24e8TFZU2bysUX+tS7l1Ge7mrpvreX0Nc6sVK5hkJx1pxHSNpmebDb1TjSGZ+YFaSNQhFlQ0zDg/SHQHZgWYCZ5kp+W8wQFDYKTMvI0Uw4bN8IYZF6QYwMGok91SSe5uOQN4wItkIl+lM/RQle+5Guk528++SEClstts12MBVPlRI1e8ExcarOXvo2BKCM4bAVr0jHRTxETGmNuqI0zzd IR2XyTwe dqHIyTSYRi6D7NJrM8F+MDycUt7IJoBaPX8SUG3IL7MQvCelLKYHuyPP/DHu1p4+nuIw5kIYkWoUBeY/M5U2pRxglf0Jgj/gtv7KPKPSOCBhpwBm+POtccOR+VTby4oKBdWNw5qUG1xENwpY9dHEwKkoQXtMl4hAdL1g8B/GGezv080rZ9Dpev5siYF17mvoMRSqwUTTr/aqWYlH5/v2iSwi32LZFS7gIH9nvOZrDvznV9Hice9NNvKESfjYePp3g3DUvC5/oSxiHJPxhjwcytx+i/59jSMVBMztPb03N3tsCK+1KEWviDy3gC+c0bYSV9UV+zW3Xws/2Xqz9AiGT+D8916UfAED3sawzxKb/sAjx9THFo7pIo2x3nZfILnaJYl2FeYXiS4s2l483H9RXzr17Bdk4qxh9pv30hQU7WQtEgpK/zekOzkIViNCDvwPbk5Qu X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: SeongJae Park > Sent: 06 December 2024 18:16 >=20 > On some configuration[1], 'damon_test_split_evenly()' kunit test > function has >1024 bytes frame size, so below build warning is > triggered: >=20 > CC mm/damon/vaddr.o > In file included from mm/damon/vaddr.c:672: > mm/damon/vaddr-test.h: In function 'damon_test_split_evenly': > mm/damon/vaddr-test.h:309:1: warning: the frame size of 1064 bytes is= larger than 1024 bytes [- > Wframe-larger-than=3D] > 309 | } > | ^ >=20 > This commit fixes the warning by separating the common logic in the > function. In that guaranteed to make any difference without some noinline_for_stack attributes? Not that I can see exactly where the stack was used. But it tends to be clang that doesn't re-use stack space. =09David >=20 > [1] https://lore.kernel.org/linux-mm/202111182146.OV3C4uGr-lkp@intel.com/ >=20 > Link: https://lkml.kernel.org/r/20211201150440.1088-6-sj@kernel.org > Fixes: 17ccae8bb5c9 ("mm/damon: add kunit tests") > Signed-off-by: SeongJae Park > Reported-by: kernel test robot > Cc: Brendan Higgins > Cc: Shuah Khan > Signed-off-by: Andrew Morton > Signed-off-by: Linus Torvalds > (cherry picked from commit 044cd9750fe010170f5dc812e4824d98f5ea928c) > --- > mm/damon/vaddr-test.h | 77 ++++++++++++++++++++++--------------------- > 1 file changed, 40 insertions(+), 37 deletions(-) >=20 > diff --git a/mm/damon/vaddr-test.h b/mm/damon/vaddr-test.h > index 1f5c13257dba..95ec362cdc37 100644 > --- a/mm/damon/vaddr-test.h > +++ b/mm/damon/vaddr-test.h > @@ -252,59 +252,62 @@ static void damon_test_apply_three_regions4(struct = kunit *test) > =09=09=09new_three_regions, expected, ARRAY_SIZE(expected)); > } >=20 > -static void damon_test_split_evenly(struct kunit *test) > +static void damon_test_split_evenly_fail(struct kunit *test, > +=09=09unsigned long start, unsigned long end, unsigned int nr_pieces) > { > -=09struct damon_ctx *c =3D damon_new_ctx(); > -=09struct damon_target *t; > -=09struct damon_region *r; > -=09unsigned long i; > - > -=09KUNIT_EXPECT_EQ(test, damon_va_evenly_split_region(NULL, NULL, 5), > -=09=09=09-EINVAL); > - > -=09t =3D damon_new_target(42); > -=09r =3D damon_new_region(0, 100); > -=09KUNIT_EXPECT_EQ(test, damon_va_evenly_split_region(t, r, 0), -EINVAL)= ; > +=09struct damon_target *t =3D damon_new_target(42); > +=09struct damon_region *r =3D damon_new_region(start, end); >=20 > =09damon_add_region(r, t); > -=09KUNIT_EXPECT_EQ(test, damon_va_evenly_split_region(t, r, 10), 0); > -=09KUNIT_EXPECT_EQ(test, damon_nr_regions(t), 10u); > +=09KUNIT_EXPECT_EQ(test, > +=09=09=09damon_va_evenly_split_region(t, r, nr_pieces), -EINVAL); > +=09KUNIT_EXPECT_EQ(test, damon_nr_regions(t), 1u); >=20 > -=09i =3D 0; > =09damon_for_each_region(r, t) { > -=09=09KUNIT_EXPECT_EQ(test, r->ar.start, i++ * 10); > -=09=09KUNIT_EXPECT_EQ(test, r->ar.end, i * 10); > +=09=09KUNIT_EXPECT_EQ(test, r->ar.start, start); > +=09=09KUNIT_EXPECT_EQ(test, r->ar.end, end); > =09} > + > =09damon_free_target(t); > +} > + > +static void damon_test_split_evenly_succ(struct kunit *test, > +=09unsigned long start, unsigned long end, unsigned int nr_pieces) > +{ > +=09struct damon_target *t =3D damon_new_target(42); > +=09struct damon_region *r =3D damon_new_region(start, end); > +=09unsigned long expected_width =3D (end - start) / nr_pieces; > +=09unsigned long i =3D 0; >=20 > -=09t =3D damon_new_target(42); > -=09r =3D damon_new_region(5, 59); > =09damon_add_region(r, t); > -=09KUNIT_EXPECT_EQ(test, damon_va_evenly_split_region(t, r, 5), 0); > -=09KUNIT_EXPECT_EQ(test, damon_nr_regions(t), 5u); > +=09KUNIT_EXPECT_EQ(test, > +=09=09=09damon_va_evenly_split_region(t, r, nr_pieces), 0); > +=09KUNIT_EXPECT_EQ(test, damon_nr_regions(t), nr_pieces); >=20 > -=09i =3D 0; > =09damon_for_each_region(r, t) { > -=09=09if (i =3D=3D 4) > +=09=09if (i =3D=3D nr_pieces - 1) > =09=09=09break; > -=09=09KUNIT_EXPECT_EQ(test, r->ar.start, 5 + 10 * i++); > -=09=09KUNIT_EXPECT_EQ(test, r->ar.end, 5 + 10 * i); > +=09=09KUNIT_EXPECT_EQ(test, > +=09=09=09=09r->ar.start, start + i++ * expected_width); > +=09=09KUNIT_EXPECT_EQ(test, r->ar.end, start + i * expected_width); > =09} > -=09KUNIT_EXPECT_EQ(test, r->ar.start, 5 + 10 * i); > -=09KUNIT_EXPECT_EQ(test, r->ar.end, 59ul); > +=09KUNIT_EXPECT_EQ(test, r->ar.start, start + i * expected_width); > +=09KUNIT_EXPECT_EQ(test, r->ar.end, end); > =09damon_free_target(t); > +} >=20 > -=09t =3D damon_new_target(42); > -=09r =3D damon_new_region(5, 6); > -=09damon_add_region(r, t); > -=09KUNIT_EXPECT_EQ(test, damon_va_evenly_split_region(t, r, 2), -EINVAL)= ; > -=09KUNIT_EXPECT_EQ(test, damon_nr_regions(t), 1u); > +static void damon_test_split_evenly(struct kunit *test) > +{ > +=09struct damon_ctx *c =3D damon_new_ctx(); > + > +=09KUNIT_EXPECT_EQ(test, damon_va_evenly_split_region(NULL, NULL, 5), > +=09=09=09-EINVAL); > + > +=09damon_test_split_evenly_fail(test, 0, 100, 0); > +=09damon_test_split_evenly_succ(test, 0, 100, 10); > +=09damon_test_split_evenly_succ(test, 5, 59, 5); > +=09damon_test_split_evenly_fail(test, 5, 6, 2); >=20 > -=09damon_for_each_region(r, t) { > -=09=09KUNIT_EXPECT_EQ(test, r->ar.start, 5ul); > -=09=09KUNIT_EXPECT_EQ(test, r->ar.end, 6ul); > -=09} > -=09damon_free_target(t); > =09damon_destroy_ctx(c); > } >=20 > -- > 2.39.5 >=20 - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1= PT, UK Registration No: 1397386 (Wales)