From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DAB6C0219B for ; Sun, 9 Feb 2025 20:49:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 906A26B0082; Sun, 9 Feb 2025 15:49:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8B65D6B0083; Sun, 9 Feb 2025 15:49:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 72F406B0085; Sun, 9 Feb 2025 15:49:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 556A56B0082 for ; Sun, 9 Feb 2025 15:49:19 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id CB5B91618E9 for ; Sun, 9 Feb 2025 20:49:18 +0000 (UTC) X-FDA: 83101596396.09.38ECE3B Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf04.hostedemail.com (Postfix) with ESMTP id 1DBB140006 for ; Sun, 9 Feb 2025 20:49:16 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=td1o8i1d; spf=pass (imf04.hostedemail.com: domain of krzk@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=krzk@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739134157; a=rsa-sha256; cv=none; b=nm1K2yAuMT7fb3VM6fHal3WYnF0r1ITsoDzpzDg9tbbrbv6xWzPKme6ceS1YHfqBYYxqAn xxq0+pDP4k3Icxg9IOTvGgTewrRjegcifRXaJYXIMNoxO40SXgaTdr9EOFdOqc+B9hikTD v2RC0mAMZx/IAtAWPGQve+7MlT2amJs= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=td1o8i1d; spf=pass (imf04.hostedemail.com: domain of krzk@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=krzk@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739134157; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=T4XI6KY47as1N45bv4Ev0oILzF7aIcawHi0wG5bvPZc=; b=yut1bU5O1J4MLSAvkc2He8/8PFvyIICLE30n5VT5I4ypaSUUNI65oVLNWREsHt4aPkFk6J cxJ6VDNZpAHYMlo/3y7uQivt9nPXtNX8vbsh6FfU4GeidHU6a2sZtkn3u+gOSLXLRzpZcB WDIaf393DdxlUqhl0TTh7n0xlzKGyPw= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 1CC035C4C4C; Sun, 9 Feb 2025 20:48:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B313AC4CEDD; Sun, 9 Feb 2025 20:49:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1739134155; bh=ZCgyxHnXwX1+L0OpeiCMIc5P7zZnwd0jnK8As2IYQsI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=td1o8i1dG6F6XmAFV/ccbA6KITfEt+tyXN08N32jvXLFrWvmb4LcL1OOKjxu3jHUb 2/kzC9rwiXEGSWn+6CxM/1GieW/MIkuw+Fkql6LD5+qypuim8L2UB8rCbSd0/0P15g n/xwPhXooI6Mnp+xdDeDElsiw4n8enIJnAH2PfKmiuQPNPLY+HLZmcvOaZBEnPI+y1 Oc5uZ7fdPrefYu/1q4mDwhQXazRwgx6rgwbNu3TIEfiG02rFpWzTMaOAjTcGmxSV7C fJIEIk0dbtxffKOsrlAbbJSWUCPLIyS86HFP5Maylwx9a6jQ4OXt5Uusm52zfpw6M3 M3Y9rhC2WDW0Q== Message-ID: <18529b1f-dc79-4c85-a485-a0a2cdd48670@kernel.org> Date: Sun, 9 Feb 2025 21:49:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 14/14] Documentation: KHO: Add memblock bindings To: Mike Rapoport Cc: linux-kernel@vger.kernel.org, Alexander Graf , Andrew Morton , Andy Lutomirski , Anthony Yznaga , Arnd Bergmann , Ashish Kalra , Benjamin Herrenschmidt , Borislav Petkov , Catalin Marinas , Dave Hansen , David Woodhouse , Eric Biederman , Ingo Molnar , James Gowans , Jonathan Corbet , Mark Rutland , Paolo Bonzini , Pasha Tatashin , "H. Peter Anvin" , Peter Zijlstra , Pratyush Yadav , Rob Herring , Rob Herring , Saravana Kannan , Stanislav Kinsburskii , Steven Rostedt , Thomas Gleixner , Tom Lendacky , Usama Arif , Will Deacon , devicetree@vger.kernel.org, kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org References: <20250206132754.2596694-1-rppt@kernel.org> <20250206132754.2596694-15-rppt@kernel.org> <45df0d7a-622a-4268-9683-c5c6067483c3@kernel.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: 3hm7nzcphbo8nprhwxzmftj4pdddfqiu X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 1DBB140006 X-Rspam-User: X-HE-Tag: 1739134156-626790 X-HE-Meta: U2FsdGVkX1+E3kpe2rVNfp9rmEPKDxnrvFyWr++Zll7FxBkMZwbDgPqmy5lcrDwRzeqFhT5xYFUKwo0pE2vDTXaxoIEZOUilSBWZSne6jKKnE77TGk576os180oboj+vQXJJ6KPhzkOXtItgnn8KSKWNO/jy3B+6J4vEuurrW2eg6vPcgBJEfEM8hrL3Z2RHXV84fSozksRVd9/7lGmI97jbJvdTTfTuFlEbf4PgIw9qYqVlTFb1n9Bs43tlVIL2QXouoh6nvQCzXV84viJvhDQFmIxxoECT51MdLSXIc9vYcGx0z3tNAMqfp2feXImlG5K/d2vVCfyx4DpxHJFZL7Zse8MShbPbBsKJJs85LOxFn+CO4UBW6Mgss5P8j+sOprOO6WJu0R7fkjSfpCYDQ1nD9vxyU8pUour24BL6I7hCh59VwB3Ha3zjl6J0tBayX9SqlTRC6qTSWVH0jhWbYE0kkdh4B94/FS5hStVSYoKQOllZTLSIxrpnq2fHPl5JfSbaq+FBrO0JlUk7Fk3sixACxOcUBy2QsJ+N7Q0JPc3ESXc/0S/E9pewLGGHTUUfaxh9X1nkl2gyIPMXZYo6SOsyDbYJZQjgjlgEjLP4gcefSqda65ZkcJZejlplI8ZEMV3dIYQG0mtwTY8tNGvNldhe/I/YDIx+ru45H5GIR61OdkOMol7/yMaghSuxmaaxHfIBqv1deXuOzX8h2ABcwr2wP3+aqEH+MgZjHJ9Z47KfT8d6bWo72ZhkC0h1GVdsrZT09DPbiXHh64FiwIn3D/4SAfMv0GZW0+yzAK5Djdl5Aob0GfCyp2cfYv7mYW3Qej31wMfnQbtKBjLBFp3SRx3tAYITb7g+J3GdhCd4BPYbHfDtA8gHZLCx6tTuIq1+mYgOvJSwY5tu+BUPG9LLI7hVbSgioBSWtqAFAZpMcA5s2qpeIGzHf/BqYG7J11DpeeWCv2u/x5MfGkidmID 0LW9I//A 0yupsaMAbhUBc8uLltkG6exywp3i+Fzo179QWDf/vA6574kMaviRaOy2m4d6SA/JFHP8kgVv3TZVTVJWX/ZQ4LjP+0GrJV6RWT9ijD4tEgbkXds6GYV063wfY1JdqaV9fs1UGpR67T5L5qhsE+bRKOHSz6Eicey7HAVvwlL+WRnoTnmB8n2VBNlxLGfQc6ADGNzy0SR968icBnNGyh5PQ+Oo71ykT3zl7YpOWdcFZH8VxUpMjDpd0CzAvVPnvoTULOAVvPE2AmUFeXbPuuVvt6Qzm0to4UeIPxeGBGJr1UlcTcXNcdWvwhPlRPbLsR1pi1AS9lKily1qqPcvJ1qzSY2iMbcXeVyXkRLlKw6iCOri6NyMdjXGNrDgTTKHNYQoe6jcdOKk1oj2aSQDVt/YSn9i74JfxOtRsEisJxHyeTwnb8jFvOS1GG2HSSIz1XNDvgdiwq0W9PsWWezD/b1uT06fM/WcfFgFE7hQ9SBG3bfPdbGE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 09/02/2025 21:41, Mike Rapoport wrote: > On Sun, Feb 09, 2025 at 04:23:09PM +0100, Krzysztof Kozlowski wrote: >> On 09/02/2025 16:10, Mike Rapoport wrote: >>> On Sun, Feb 09, 2025 at 11:29:41AM +0100, Krzysztof Kozlowski wrote: >>>> On 06/02/2025 14:27, Mike Rapoport wrote: >>>>> From: "Mike Rapoport (Microsoft)" >>>>> >>>>> We introduced KHO into Linux: A framework that allows Linux to pass >>>>> metadata and memory across kexec from Linux to Linux. KHO reuses fdt >>>>> as file format and shares a lot of the same properties of firmware-to- >>>>> Linux boot formats: It needs a stable, documented ABI that allows for >>>>> forward and backward compatibility as well as versioning. >>>> >>>> Please use subject prefixes matching the subsystem. You can get them for >>>> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory >>>> your patch is touching. For bindings, the preferred subjects are >>>> explained here: >>>> https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters >>> >>> These are not devicetree binding for communicating data from firmware to >>> the kernel. These bindings are specific to KHO which is perfectly >>> reflected by the subject. >> >> No, it is not. None of the bindings use above subject prefix. >> >>> >>> Just a brief reminder from v2 discussion: >>> (https://lore.kernel.org/linux-mm/20231222193607.15474-1-graf@amazon.com/) >>> >>> "For quick reference: KHO is a new mechanism this patch set introduces >>> which allows Linux to pass arbitrary memory and metadata between kernels >>> on kexec. I'm reusing FDTs to implement the hand over protocol, as >>> Linux-to-Linux boot communication holds very similar properties to >>> firmware-to-Linux boot communication. So this binding is not about >>> hardware; it's about preserving Linux subsystem state across kexec. >> >> does not matter. You added file to ABI documentation so you must follow >> that ABI documentation rules. One rule is proper subject prefix. > > No, it does not. It's a different ABI. > > FDT is a _data structure_ that provides cross platform unified, versioned, > introspectable data format. > > Documentation/devicetree/bindings standardizes it's use for describing > hardware, but KHO uses FDT _data structure_ to describe state of the kernel > components that will be reused by the kexec'ed kernel. > > KHO is a different namespace from Open Firmware Device Tree, with different > requirements and different stakeholders. Putting descriptions of KHO data > formats in Documentation/kho rather than in > Documentation/devicetree/bindings was not done to evade review of Open > Firmware Device Tree maintainers, but rather to emphasize that KHO FDT _is > not_ Open Firmware Device Tree. Ah, neat, that would almost solve the problem but you wrote: +$id: http://devicetree.org/schemas/memblock/reserve_mem.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# so no, this does not work like that. You use devicetree here namespace and ignore its rules. You cannot pretend this is not devicetree if you put it into devicetree schemas. Best regards, Krzysztof