From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EA5DC77B7A for ; Tue, 16 May 2023 08:28:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 086C3280001; Tue, 16 May 2023 04:28:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 03694900002; Tue, 16 May 2023 04:28:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E4A8D280001; Tue, 16 May 2023 04:28:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D3C7E900002 for ; Tue, 16 May 2023 04:28:24 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A4723C014C for ; Tue, 16 May 2023 08:28:24 +0000 (UTC) X-FDA: 80795441328.20.9A51BE0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf18.hostedemail.com (Postfix) with ESMTP id E269D1C0002 for ; Tue, 16 May 2023 08:28:21 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hZGB0nKM; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684225702; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4LrwsQpkNzKQ73ySEswNaQqCDWSvOkZL+SFTwTYbhpM=; b=Il3WN4wy6D7vFuHBw8+FhAm9CGrVHrsyc65kKARtGJIuCu/+bV2+y/fDB8zuYesgBNQova s6kakCaBl2Oc4TAotIQf76zDLRr6ZBLRem0Vhi5d7okKy18WvKyY6GroGZBvxRybyASTox UQ9GUyED/b5cz27fF656JPOGvHgVNwI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684225702; a=rsa-sha256; cv=none; b=4bMGbALSFcLs15Tj/L7i3xL/6CbDWSRMeBAGaX6XXFkS39jRG2ETWSVCAgJ+nIQkmZ8WCs FTCFsDi1CWVNNGCMfY87gVeIBEC0XpNMdMWiJ++c/wY5HIyHhYXWjhfB5ySX6gF2dbYQwk tEcb2COVkYSDiflrrk5N8G7mQ9tKhkc= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hZGB0nKM; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684225701; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4LrwsQpkNzKQ73ySEswNaQqCDWSvOkZL+SFTwTYbhpM=; b=hZGB0nKM+nPJYQBGiPMkbQUBSioYbOV6vXt18f1TCmRGl8QlFQoK1XDgtaMPgcPHC7TNuY ItV3Lang8ZTcjXRbwbY9rNLDx69Xj78ZWl4tJ1i2VfKOo8Hf/CKB2U/mhZGRvV4GeCBRUH XCjhmJORbB//UQO+iKlcD1NC2mBDYUY= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-673-VIGsuWXAOxi6ps2m0EjveA-1; Tue, 16 May 2023 04:28:19 -0400 X-MC-Unique: VIGsuWXAOxi6ps2m0EjveA-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-3f4245ffbb4so55004035e9.3 for ; Tue, 16 May 2023 01:28:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684225698; x=1686817698; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4LrwsQpkNzKQ73ySEswNaQqCDWSvOkZL+SFTwTYbhpM=; b=U5aRhYz7dc21mOWW6eZyUQol2ptf3jL6vsFHwpNXxlWlYyRfJwKzJIcrZVIjBXY62L sr0PhpS34uBZdz/A8EDYDdTfICIcbIlaiv8s2zYIRLzWw9imEDZqP+Vj6LwdR8u5E5Be 8JFzPVMPZm+JKvoNdHVVmc9CLHC5TgyU2bcd686QwiVaFo4zdc411g6ELVTbVSem2MSL RFMPQ1/KP6r0/H57KacvQ5I/kagn6Q2bQ35RRf8AHYHGWJ7VeDKDg1wJw1ffJUkAMuSM 0mwfPtkqshZ+F2xQ9Fgu3ly81Xg+E9ACgGYPJYBDNXK6ZnkRa4apGp5ckWuPq2Qab8Cu wsHg== X-Gm-Message-State: AC+VfDwiY2S61SNuh4gjevL2cVf98QHCK16YRp69J6d5ujbr8mr9SCJX fW9fgpzSbD39kNARQ2F4HNRBJcx71A4nty4q2FUGIZ7BRMqDF6OYz9TNkiKlBaaAJxm5UdQTkFu /5gqXBWx4I4Q= X-Received: by 2002:a7b:cb97:0:b0:3f4:2c71:b9ad with SMTP id m23-20020a7bcb97000000b003f42c71b9admr19670882wmi.30.1684225698386; Tue, 16 May 2023 01:28:18 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5u32JaX9DoCvDoS+J6br6qwyFtkIX97b4yVh+uAVQvAOm++RWuF2owUBJbfmhSh0S5nzEg/g== X-Received: by 2002:a7b:cb97:0:b0:3f4:2c71:b9ad with SMTP id m23-20020a7bcb97000000b003f42c71b9admr19670863wmi.30.1684225697971; Tue, 16 May 2023 01:28:17 -0700 (PDT) Received: from ?IPV6:2003:cb:c74f:2500:1e3a:9ee0:5180:cc13? (p200300cbc74f25001e3a9ee05180cc13.dip0.t-ipconnect.de. [2003:cb:c74f:2500:1e3a:9ee0:5180:cc13]) by smtp.gmail.com with ESMTPSA id v10-20020a05600c214a00b003f50e88ffb5sm1494416wml.24.2023.05.16.01.28.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 May 2023 01:28:17 -0700 (PDT) Message-ID: <184c0b11-4f97-5872-5b25-ffd99eb6185d@redhat.com> Date: Tue, 16 May 2023 10:28:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v5 4/6] io_uring: rsrc: delegate VMA file-backed check to GUP To: Lorenzo Stoakes , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton Cc: Matthew Wilcox , Jens Axboe , Pavel Begunkov , io-uring@vger.kernel.org, Jason Gunthorpe , John Hubbard References: <642128d50f5423b3331e3108f8faf6b8ac0d957e.1684097002.git.lstoakes@gmail.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <642128d50f5423b3331e3108f8faf6b8ac0d957e.1684097002.git.lstoakes@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: 4s99d7u6om9s4yh4otyfs1pyw85tz4wy X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: E269D1C0002 X-Rspam-User: X-HE-Tag: 1684225701-912051 X-HE-Meta: U2FsdGVkX1+NSbL0WbtFzBM41Ix/EsAF2eKihuLwhFPKMFcB23gvSvyRzXFjY+/HQl5DZYIDw5/gtjSHmsEKN8V2n9wAs8fGxYb5GXS96RW8Osi209Abi/OKh7JDBDnLOk0g4nDcvcKpEHyoGpkjHL3EURpGvlneDCSuFtkadP/MCEN7j4huMoQGiOq6vYr8wcWk0dMJBIR81r/mIybOvObincuXj+LcwbjxnSyRxE10h6c182AxP3cfgVk8R8YOxe3JRIuKCFxh2LFfTe7Yw0IvVjZc+1aVj1eJR78eF2CrbAFrwUq+XgSHrC0rwxjQwYGF9C34IiLM0v1kTFvVTL0uN62KR4f02a/hNQpR6vokLCJaLlXFwl0PcAR2thVH78yz5W6pAnssAUz/MjyvUs0NrrcOxnMHUWyVzWX8JEusRxaa0sB7Hkvc3IfdX+FMT9XthhjZvUByQxKqwO0hlX4W0NSGhECHhPE6bdtFQMuk8i8btNQfr0sX7Y8s6HDJotd1NoUTGLkq8hZHo5NEGVT2VDj5ozykB//6CkB8QhD6EtCsnx4VQ1v2ZW+GVURI29vdh4yzuIBwEQDKP6t+EBpD05m1EoPKCGRq6G2XrhN4ceV1YL07DPvuUQ5pDMw+t+EZLYyqHlbqvDcAzmuarQ1ksx8KXqlhe91omESpRse+bom5ux6dS2yhvd73Nen7TPND5iitPDwsFnTXEgJT0gjRvZyhlvo82fg+3ElrURYLhk9sKeaDyI52/RM+7zPie4Va1ZCOzIrZVnVXfi6TBhYJC9RQ2dwh3iBWntSdoyaiUuAH4Xo+VzBNXvFu0pn2inqe3/Wie+QGpttxgNLXf9EO1aFf8E5pDtUWUcKJa4kRv3jA2TWNrc0uIFQjJB4Wiw6a3G377OkFbnVQ2XNCfgYeAdNQcf0Puz2u5sn0F8mgdThiRBRWZRE7R5dDW1tWbY8VVA1hk9InwBcX847 bM+bXWSV Jrvx5zgfq0Ggp4UoUA0LWDwlurBxhYQQXt5ZzTbWXmKuyAaxLZqYY+NCRwksiTklxoh+R/Mu8hGUG7xlSzafZnhM5DGeyJP5HyRoZ8BKCB/BqUQoEAxl3qK5x1mjC7gIeB/+WNPlgtPZDJS4mgXtqjjnjtQbdD7Pd0X6vdSHnGTmDMnxbwKmDIJ/tFfxAxoG94PT5QUMK35PmEM8qy5EsalV4FKKtN1uNhgeKfIoc1DYxarof2r8hH3BYDokxX9C9N/CU4QZFRPcK2cB3n94UBfLwryt6Q7DsEfnOE78K/uQIyJemzUJVBNTo6cUo5VwjtojmHMSpcGPyxb2KRDRdQ8i3A4V0iI4KdVhGElGT2Z5wDc3rAkDtohp3RQSe9bhyHF4SxJOmPoLmlF/L6RCSZBhysKUOvVzDMetDVXoKwklAnaTomaT4dj3NKpDxnOiq2mkK55UX8Le7wupoY9IGcL7wifwXvHxXF5Dt5J5mEdNEHOs8bbvuPVuuotpecEoGEkfgJfTfcau7TmNFCevBgLrY4Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 14.05.23 23:26, Lorenzo Stoakes wrote: > Now that the GUP explicitly checks FOLL_LONGTERM pin_user_pages() for > broken file-backed mappings in "mm/gup: disallow FOLL_LONGTERM GUP-nonfast > writing to file-backed mappings", there is no need to explicitly check VMAs > for this condition, so simply remove this logic from io_uring altogether. > Worth adding "Note that this change will make iouring fixed buffers work on MAP_PRIVATE file mappings." I'll run my test cases with this series and expect no surprises :) Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb