From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46FEDC433F5 for ; Tue, 30 Nov 2021 14:52:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9E7376B0072; Tue, 30 Nov 2021 09:51:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 99A806B0074; Tue, 30 Nov 2021 09:51:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 85DAE6B0075; Tue, 30 Nov 2021 09:51:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0078.hostedemail.com [216.40.44.78]) by kanga.kvack.org (Postfix) with ESMTP id 73BC46B0072 for ; Tue, 30 Nov 2021 09:51:54 -0500 (EST) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 36C268476A for ; Tue, 30 Nov 2021 14:51:44 +0000 (UTC) X-FDA: 78865885686.02.CF533FA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 8125B400209D for ; Tue, 30 Nov 2021 14:51:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1638283903; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E9Lx9TJJBXg2rHTFjd4QMdkDXGIXIvnZzimFPOne8Kw=; b=Re0j07cEVm++Oj9WFLoquFPIoNAfIL7/fvOexGBLywYfg23sBFdm2lqnWm5FLorsdrdQ0P Kk0tuFBUslp9ZrDN/Tombxq27KrgEfB7Gl/5vcEQXdXBu8ZcUSngDNZNsxbPGzmxpA1bee 0gx9nc3bImfmjN4yfHiO7r+/TDWxp+o= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-475-ht-qRhSfPIq2SC3EJUHEgA-1; Tue, 30 Nov 2021 09:51:39 -0500 X-MC-Unique: ht-qRhSfPIq2SC3EJUHEgA-1 Received: by mail-wm1-f69.google.com with SMTP id z138-20020a1c7e90000000b003319c5f9164so13887471wmc.7 for ; Tue, 30 Nov 2021 06:51:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=E9Lx9TJJBXg2rHTFjd4QMdkDXGIXIvnZzimFPOne8Kw=; b=636CiQPq0ELx125No3uAHxuDneeRao+W/lPmFe4Bxfxja0TyYld3ee3TxRoYtFjBu0 OaSAzhi0oYZfekr89Z0ldCHkG6uk65jw+48HFvV1txIGi0vne3ya3LqVMuv6pcvEvjJa JufS7OmxR1iCH9zYR3Ss+JA9lyzMNirgKCQZL74yhuQI0elsQqNx6HJmo3LfWkS+zVy/ PU6yYJIAaE0Cgn3p2gVufCXbwKOKlapMm50b7WzmHx+KSYXHqg23E3qEPnyECWPQQ4Go tK1bsVtncXw7ECNn5M0xSCn7+J416pkhKoRmFVYhuiBI5qwTvSuxvF/qcajBCHekhGED qAHQ== X-Gm-Message-State: AOAM533THt9rNnbzsY7PdK86P264rBMcLXIqOP1+LLTjlHERKT+uqMxS 9PGfvb3ChpOE9HQkwz2T9EnyoighNdFGZgxjaYeL0XmBWJy3NZeEybfZNdX7PZdymjDswY6X9V5 hPzPm/YFbnt4= X-Received: by 2002:a05:600c:b43:: with SMTP id k3mr5511853wmr.159.1638283898585; Tue, 30 Nov 2021 06:51:38 -0800 (PST) X-Google-Smtp-Source: ABdhPJyKgqfybofwM4ev+7p0oQTgMUxgl8EpmgO9OSaeiHHO8/ElEuvqxrQdaFyWneC5jrZs7Om0zw== X-Received: by 2002:a05:600c:b43:: with SMTP id k3mr5511825wmr.159.1638283898421; Tue, 30 Nov 2021 06:51:38 -0800 (PST) Received: from [192.168.3.132] (p5b0c68ec.dip0.t-ipconnect.de. [91.12.104.236]) by smtp.gmail.com with ESMTPSA id f15sm3295403wmg.30.2021.11.30.06.51.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Nov 2021 06:51:37 -0800 (PST) Message-ID: <18472b72-c64f-59b5-f767-d965f0264ef0@redhat.com> Date: Tue, 30 Nov 2021 15:51:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH v1 0/2] virtio-mem: prepare for granularity smaller than MAX_ORDER - 1 To: Zi Yan Cc: linux-kernel@vger.kernel.org, "Michael S. Tsirkin" , Jason Wang , Gavin Shan , Hui Zhu , Eric Ren , Sebastien Boeuf , Pankaj Gupta , Wei Yang , virtualization@lists.linux-foundation.org, linux-mm@kvack.org References: <20211126134209.17332-1-david@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 8125B400209D X-Stat-Signature: 7xw1moxyyt5mfhc6o6cw69as63f1s974 Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Re0j07cE; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf18.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com X-HE-Tag: 1638283898-261809 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 29.11.21 17:47, Zi Yan wrote: > On 26 Nov 2021, at 8:42, David Hildenbrand wrote: > >> The virtio-mem driver currently supports logical hot(un)plug in >> MAX_ORDER - 1 granularity (4MiB on x86-64) or bigger. We want to support >> pageblock granularity (2MiB on x86-64), to make hot(un)plug even more >> flexible, and to improve hotunplug when using ZONE_NORMAL. >> >> With pageblock granularity, we then have a granularity comparable to >> hugepage ballooning. Further, there are ideas to increase MAX_ORDER, so >> we really want to decouple it from MAX_ORDER. >> >> While ZONE_MOVABLE should mostly work already, alloc_contig_range() still >> needs work to be able to properly handle pageblock granularity on >> ZONE_NORMAL. This support is in the works [1], so let's prepare >> virtio-mem for supporting smaller granularity than MAX_ORDER - 1. >> >> Tested with ZONE_MOVABLE after removing the MAX_ORDER - 1 granularity >> limitation in virtio-mem, and using different device block sizes (2MiB, >> 4MiB, 8MiB). >> >> [1] https://lkml.kernel.org/r/20211115193725.737539-1-zi.yan@sent.com > > The patchset looks good to me. Thanks. Reviewed-by: Zi Yan Thanks a lot! -- Thanks, David / dhildenb