From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B627C77B73 for ; Wed, 19 Apr 2023 13:01:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A891F8E0002; Wed, 19 Apr 2023 09:01:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A393D8E0001; Wed, 19 Apr 2023 09:01:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9282B8E0002; Wed, 19 Apr 2023 09:01:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 84B758E0001 for ; Wed, 19 Apr 2023 09:01:30 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 3D179160234 for ; Wed, 19 Apr 2023 13:01:30 +0000 (UTC) X-FDA: 80698151940.26.717BF60 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf02.hostedemail.com (Postfix) with ESMTP id D623E8004C for ; Wed, 19 Apr 2023 13:01:27 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="GCSFOUC/"; spf=pass (imf02.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681909288; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=f16w+eV0+2Sr0OvGkfcho9W3kJDfX6onkCcXskuyqPs=; b=L9g5hsvza9gn6rdmkTgtj8EeDGfgo7WQK5OdfhvYaMcaBc/bsQ2LtmK4R6w4YhIrHHc4Zb NKQQtNZx4yvZMAUBfW+WoN8oIvWglkq4F89t4B3vZkbVXdPSV2RIvxU45JdBmmit+DBzZh 68COahye++DmbzwAAi52+qdDRMdgX2E= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="GCSFOUC/"; spf=pass (imf02.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681909288; a=rsa-sha256; cv=none; b=VMbxjQVCUh6Nh2dHOFUo7IFMq+k+qAsoQaTHTHE8Qp7n6cusxqWYEBs25TLFAD1TT+P/89 FHbUQhAziFvf0KJRTvFlZJ3WtftIdpDOjs1p6YdF8yT2g1tVexn7JqLHG/ezsHUPOqgSnF dIG0Rp3s3C1OwARafaK+UHEFEurmvQA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681909286; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=f16w+eV0+2Sr0OvGkfcho9W3kJDfX6onkCcXskuyqPs=; b=GCSFOUC/NigrVrHuR5Cu/fhpGrSDqYdlaGVRh4LJl1rBGuqKX5xW41r2tBOw7OsUsM7ShM TnMMtS4SZhnj9qLt4uH7FIpZHPhxkc1NLmRH8F89zhYmm7mRHCrkMGVRAx2s+NgxgBDrE8 WqmeaMpo+UoHfIdJdFbr33VHJbxJiqM= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-99--ci2SF8-NGKZHk1uBniPUg-1; Wed, 19 Apr 2023 09:01:23 -0400 X-MC-Unique: -ci2SF8-NGKZHk1uBniPUg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 58F453815EF4; Wed, 19 Apr 2023 13:01:22 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.67]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1937C1121314; Wed, 19 Apr 2023 13:01:21 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <168190833944.417103.14222689199936898089.b4-ty@kernel.dk> References: <168190833944.417103.14222689199936898089.b4-ty@kernel.dk> <1770755.1681894451@warthog.procyon.org.uk> To: Jens Axboe Cc: dhowells@redhat.com, Ayush Jain , Christoph Hellwig , Al Viro , David Hildenbrand , John Hubbard , Steve French , linux-mm@kvack.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] splice: Fix filemap of a blockdev MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1842477.1681909280.1@warthog.procyon.org.uk> Date: Wed, 19 Apr 2023 14:01:20 +0100 Message-ID: <1842478.1681909280@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Rspamd-Queue-Id: D623E8004C X-Stat-Signature: 6im8j45otakf6z3c8xce9kewbfiugzkd X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1681909287-175207 X-HE-Meta: U2FsdGVkX1/p+GJhwkfh8vbS1toYtO4yIEJVqEVQ/f6GBB+0qvsMZmMsdVrZz2y8GSQaoGYbGoD23FX38s98vADn0EAFlvnDrswTxtluOs9+kg3nVG4SmXnhZtNNhMaCovbyjgEsj9TFIwfCmscXMvdBPemQsE8AVxmpObT1UbHDxXgtIfVUX9J4D3ko7I+q+qxfXo5EMqNgmLiQ+ZCDE+oAMmc66gLQ2cV2KdzSdz4ifvRIseYShkfE73ibJyjvUARKkdZYG+UfL+0Gsp7qLRn7E/LAfiVEwYqFtKjuS+Cux7A9IusjhNwHkXlWfxsoD0KoOTrM4SBl+V+zaoPGQIHi2hKCt0Ck0QLeiZ/L3WF/SiMfFLVL4DGT9XaIE1iHKurB5vQonk1OfS1PNf5jNHJsjMSzxp1zHSwC5wjDx3h6z4gQr0q9hzaA1ACewnt2FE6OEujQQC+bhsPrjH3A+DP8kIQtLoXPnBx9Z6uDzGyhocKQVBU1EjSyHAPUxgwfmFcYkxkUHp45GUfU00xX1/+VDRHma+oHgdw2G2d1/Xf6zgXUOGKx4ASiPEYlIqzl9BBx2N3pD1cNT0zgleVMNtnZNFTK6wOJFpKh675ZwfaxGi1FNhnoztcpH59o7nfoDnVg2WDz2mLpEzWKbOdkW/mM94z82kJZ5MYolnfDafOKTQMJku++duve1MRi6JzZ7snYWcj10BtpbtOCAFqq5SKVncOeK+Df0kvCNEWMp+CEFZ75XNOXw7jCjxGgUkyjmEfuLsnM5GUYwHqF5PUq1AtrmD1x8mwAVGqJdiK1xcwola6ZxuE2idRrwTsu0hOt45HPC9pkkWpjBLUQ+gXrlNoMJ53g6ONLNeSNCZKGxvCjv4KGRcsG43/ZSdRk9ZgHL1f0p3kzYnPI+RFzSibViX9pqmiT1k+o9gIyBjyhc9zLoozP23LX2uCMT8YtuPwNjstYbm8pgMR/NvmZ4yB bd5RD+HJ zHzV7V7zEsxVLo4qY5jFJFrtZt5dNDTK7k2UZGLGRiTKyyVL8QsqNAUKnBzbjQrwxBdnB8Gdpr0GeM89y3z/eMv1rLTDURe09cr6qyF4C7JnxlCkVKVXT5+8cwgUCm3cybpxeQVwTYvArq0xfrAj6HiZ+q21MbZX2WHixcCEhY0uvfQRui08YrrCNmIC6Mfcgu5KY1HQeU66qZok= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Note that this shouldn't affect direct_splice_read() as that doesn't look at the size of the file, but rather just keeps reading from it until the requested amount is read, the pipe is full or ->read_iter() indicates EOF by returning 0 (so it could work for copy-splicing from a pipe/socket/chardev too). David