From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73ABFC369AB for ; Thu, 24 Apr 2025 21:15:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D6A3C6B00C6; Thu, 24 Apr 2025 17:15:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D1A466B00C8; Thu, 24 Apr 2025 17:15:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B464F6B00C9; Thu, 24 Apr 2025 17:15:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 923356B00C6 for ; Thu, 24 Apr 2025 17:15:14 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 4483E162060 for ; Thu, 24 Apr 2025 21:15:15 +0000 (UTC) X-FDA: 83370192990.15.91FD620 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf14.hostedemail.com (Postfix) with ESMTP id C41D910000B for ; Thu, 24 Apr 2025 21:15:12 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ROetm4a0; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745529312; a=rsa-sha256; cv=none; b=Kse+tkCptvIqjygKBW0w5ULgqNrfEwxWqWYOwKDFn74wSCs3uEzE8XBTJ/nzqHN2/cX1a1 eYG1CRWMnrF0yY0r7vGFZl7cS4hQrU+Am1+rxaV44h7DQrX5ucs7cU/aEOBw2TrbxuYSW5 G2vFa3ubVwzXMSHziVDvNFadWz/B5mk= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ROetm4a0; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745529312; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0atQVDH0XvpcRUPqJkcf4AWQNWnOP+JsltT1upRf5sI=; b=F03r4UoMHFTVOLlRNfQ45fUagcM0JtA7FpthMFAGn6lsa0oknSE8daDHCgYE7ma9Bgcurk lLLVBnRXkst9AIZXRF/M9EByEVIoWLGmhayB9+gzKvwZ4QpFJKLPlr44fOYBUONlvzaJ9l vp/df1Tfq16vuvHrqLpWsVnE4IoPLR0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745529312; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=0atQVDH0XvpcRUPqJkcf4AWQNWnOP+JsltT1upRf5sI=; b=ROetm4a0knuaBxK7zj5LSKM1W/Zs+I4YwR/Kyg/CcDQT1ombLPW6Auv/j3d9BDhbrnrneA ABpl1KdUh6XBnig/l055G/CGkz49bzGFs3ZCGndoNdPD6zY0MgUgLWgo+6aICecU497B/V mJ+9afSr44xgG6HoouW7AwubTY0oxc0= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-561-UbCnKQ8GNWGKMA01ftw-jg-1; Thu, 24 Apr 2025 17:15:10 -0400 X-MC-Unique: UbCnKQ8GNWGKMA01ftw-jg-1 X-Mimecast-MFC-AGG-ID: UbCnKQ8GNWGKMA01ftw-jg_1745529309 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3912539665cso1101987f8f.1 for ; Thu, 24 Apr 2025 14:15:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745529309; x=1746134109; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=0atQVDH0XvpcRUPqJkcf4AWQNWnOP+JsltT1upRf5sI=; b=Syl4wnuFur9yh9DwZwue8JmrbjI1oPTfcctZ8iBR8U15yZW4MkKxLFB2cjbn1RePxI Nhzi/TcutgrwhdRKrji1RytmSf1B3bMH1ckjzqcynpwod8fJDYXa3qf6Y/l4RLZ58bi+ 08rU7tDcmAgjaYH1Lm0Hji3gABh3pp8OjdDxewH6tWTKIcER40/xdRPdhLjHWsZvuAJl LnUgs/vU9/Xchadekn+pAAjLv/WweBYPJe6rS3+JxmchayFxbyS0aOuQjoRfBC/2xHhj 5NTIUqrNmMCww04DZV7xC5YnbwbT1KXf97R/vQCq/5hnyXSZRTYzb9jVBbjfLn0QNgje w4Rg== X-Forwarded-Encrypted: i=1; AJvYcCWNStmFvqUVTf4qeOhkTRc19cBaBflOQ8pifBsw5+44U4jJJI1/s28Ed6y8tkY5S9e32Gs324LvpQ==@kvack.org X-Gm-Message-State: AOJu0YxpWZPRXvtzUrX2AukmKFDFNp4SVCdzgZKPL6lMh0X6NPV9hoGa n+FIhvKwB/G9shidoTsJLYHvRDPTawwnBI8dMC4U+17ieyHKQSUUueU24xBGbd007IUUAjSmzH9 XA+mGRy+vj+9mEvf2A7cmIKk914I7OxBZGwfgkB8szF7yLliw X-Gm-Gg: ASbGncsAgtt5DRkPBNySaT/PKHIdZVrrehVJ1z/6nkk31G1dviS4UC/vOAupTRwgtN6 L7/FHAMu5Nz0CNxGk4kYH2wxjSODBnjH6nwZMGVXkd/L+7J2y5xeOpw1vrU6gQxXAWXxL6ngcW2 11qUOY3UwRQyS2/v/7ptW9eWeVul+vGHKhojnTKq5C42nn53HJL9x3JV4kNLLH2YY/jYVT5Omf3 2qzbfd2PNU3eYp+vVxX129vUoGAq2GI8Hqnovh5MTw9QVfH+iwycSjQcC0r9TMOjsXeXXvZuMvk QL2oJrfBB0mPOvXq2q8gvL4+7HPD2ut1azCKATeMDh8QOjf2rKfEnQhAM0VGmW7wdacOeCJvznE +gH1+27m+USkSWYKwCp0N46fjXoS694joPEKs X-Received: by 2002:a05:600c:450a:b0:43d:16a0:d98d with SMTP id 5b1f17b1804b1-4409c4ddbbamr31013585e9.15.1745529309466; Thu, 24 Apr 2025 14:15:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGT7y3gX6fJnA7SugEtZIcpQd8krrY3RV3TcuqMt0VhvZW5tlI9puDVvH0e/UJAxRgT/uTzZg== X-Received: by 2002:a05:600c:450a:b0:43d:16a0:d98d with SMTP id 5b1f17b1804b1-4409c4ddbbamr31013415e9.15.1745529309144; Thu, 24 Apr 2025 14:15:09 -0700 (PDT) Received: from ?IPV6:2003:cb:c74e:ff00:f734:227:6936:cdab? (p200300cbc74eff00f73402276936cdab.dip0.t-ipconnect.de. [2003:cb:c74e:ff00:f734:227:6936:cdab]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-440a536a021sm1708575e9.29.2025.04.24.14.15.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Apr 2025 14:15:08 -0700 (PDT) Message-ID: <1838f050-b4d0-4bbe-b76e-86c718f24162@redhat.com> Date: Thu, 24 Apr 2025 23:15:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 6/7] mm: Use for_each_valid_pfn() in memory_hotplug To: David Woodhouse , Mike Rapoport Cc: Andrew Morton , "Sauerwein, David" , Anshuman Khandual , Ard Biesheuvel , Catalin Marinas , Marc Zyngier , Mark Rutland , Mike Rapoport , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Ruihan Li References: <20250423133821.789413-1-dwmw2@infradead.org> <20250423133821.789413-7-dwmw2@infradead.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250423133821.789413-7-dwmw2@infradead.org> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: uqz5VZtFV7WF1YPUHobkDcQxZyCrrQQDwjKB2o4MKec_1745529309 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: C41D910000B X-Stat-Signature: 3j167awhqsiiuccjk5k433eptq1ufbja X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1745529312-914454 X-HE-Meta: U2FsdGVkX1/vupVcWJXvnHWlYibZAgp7aik7dvIqjskfISz04rlIGeLa4TVJj3GoXe7mLvYQxQGKM0xxKdLiLUU1/zfM0ahiLIm10zoGE6XvEEG1KYUgFSXi9lGe5NQX5YNa2+rZq3yNJY2IbxefqeJuihAbT//VJEAcaDeHzcgDTf1ZAe0JoXdz8lozY1JKEVH1XRdTg4B+gj7Du5DsDJ9QXUB++cVzZjwIJkBGm29nPWXjfyeZkoGnW5woo1X4Qbj4zov6qGqnt0W/szMmofTBAGuMHgh/KLFnMdyI1euR6eEOZgZ7jg8TR4pzHxKn3/pzs8tOwb52HSvPv0asdUoKomY2FlWclsaRj+3Q0i2i6ya1o4IpggcXWkfXUuTUQIM5EhS2FGi2QUtquzcG5KvHPbsZBM1RnTh7nAF3rSVckYizKJseOF3OuLor0o7qnjwylI4NLMtTxjtU1pGJR+6tm87oLY1VLuuwLquNaUgBV5CuMsICXJih1rxnOeKRAzq7sEeSNmMefTNikCllnGD8hvXqfdmR75Wv/DQmxIsEasXbgIfuM5cV5B7yM1GY5gU6t+AVQRmtdFI4/6DpMmqffol1Lhs/i+1jBlLrc5CDneqdZNLijCljF8aFKjyP8jaCDyoQQXizgtJTZAtnbtxJ16km6jxTkFQo10hm1j5n3ETwjMxNsT0oJ1Ko6zOQf+9ZJUvfVmRV8oJ2KLTPgHidleckkHbdRsMrLSzNJ2lTJPHlegs1Hpyms7JXj16qwGxATkbJNo2YxhwOA5esvrjIEmljaQLbm3oJyw7SgJgdcgWzs3onn6SwApI/9mdHjVuXPmhv3p71m+f/3aiYrexXMjOEAQT+RC7OIOAZE9W9hENFy5POOx5dLcdoesltn73MeKLpUDTDlH+aZJ969ik4xcVPWis62/XeONmtYsbO/FnY1kDZkiy0frThzwTS2MEgCwU+Y5sYMNP6amR 7eywb30/ 7GUT7+CGKPQk2KDcFgbpVP3qSfkZB8wHEaMOSe17ry0qn3d9DPicloYNDStqs7yhDfBBJ5i359AcRA5aDNbMbHaXHPcKS7wykDM2kJWQE3TgPYTzJfrUwbXcNH2hcSZLghdEyNvY5KvFOhRTVVDhmHNVueqF7/Aw0qo4UIqBa48fMwj/KqCOaNdR2g2xSg0H0U+JmXNtbIbzdchmQHhKBaZtMhO5Wwl4HfvVqZz6tkihGNLwI7F4zfUuVQl530Kq1bAuaVmpEY+RJsMDUYDfzw+aX6j35VkBcMHg9m8dh20Z3cj//O4MZ8MAvx0K1qCzcllPNGC1F2kWrZ4AVp5EPFO3dhi+oSrvYdyy8lZ/7pjWOZr69A/LB9O1HoZ9o3JTXwiB5ffcUv75wqR/YuU9kRSlLgsVT+0IVwPAJWrIr8QhGzfHByFb4m98fuFnoOE3xcJ9Pj4V2l++LMhBBwu6Z1hBbzeRXtVy3jazNtQ4bvjc4JhoA5WtzpX2IegoOxHTO8cvxoJhaNiYdpCQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 23.04.25 15:33, David Woodhouse wrote: > From: David Woodhouse > > Signed-off-by: David Woodhouse > Acked-by: Mike Rapoport (Microsoft) > --- > mm/memory_hotplug.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 8305483de38b..8f74c55137bf 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -1756,12 +1756,10 @@ static int scan_movable_pages(unsigned long start, unsigned long end, > { > unsigned long pfn; > > - for (pfn = start; pfn < end; pfn++) { > + for_each_valid_pfn (pfn, start, end) { ^ > struct page *page; > struct folio *folio; > > - if (!pfn_valid(pfn)) > - continue; > page = pfn_to_page(pfn); > if (PageLRU(page)) > goto found; > @@ -1805,11 +1803,9 @@ static void do_migrate_range(unsigned long start_pfn, unsigned long end_pfn) > static DEFINE_RATELIMIT_STATE(migrate_rs, DEFAULT_RATELIMIT_INTERVAL, > DEFAULT_RATELIMIT_BURST); > > - for (pfn = start_pfn; pfn < end_pfn; pfn++) { > + for_each_valid_pfn (pfn, start_pfn, end_pfn) { ^ Is there a reason for this space that I am unaware of? :) Acked-by: David Hildenbrand -- Cheers, David / dhildenb