From: 苏辉 <sh_def@163.com>
To: "David Hildenbrand" <david@redhat.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re:Re: [PATCH] mm: remove the redundancy code
Date: Tue, 30 Jun 2020 21:49:54 +0800 (CST) [thread overview]
Message-ID: <18371c7c.63d6.173057dc2c8.Coremail.sh_def@163.com> (raw)
In-Reply-To: <bd8ea243-e00c-a72a-ac80-cd2ec08db4b9@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 519 bytes --]
I had noticed that.
Thanks.
At 2020-06-30 20:39:27, "David Hildenbrand" <david@redhat.com> wrote:
>On 29.06.20 19:30, Su Hui wrote:
>> remove the redundancy code, the zone_start_pfn
>> is assigned from zone->zone_start_pfn
>> Signed-off-by: Su Hui <sh_def@163.com>
>> ---
>
>Side note: You should really work on better patch subjects/descriptions.
>+ casing, punctuation, empty line before Signed-off-by ...
>
>"mm: remove the redundancy code" is as expressive as "mm: fix the bug"
>
>--
>Thanks,
>
>David / dhildenb
[-- Attachment #2: Type: text/html, Size: 801 bytes --]
prev parent reply other threads:[~2020-06-30 13:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 17:30 Su Hui
2020-06-29 18:50 ` David Rientjes
2020-06-29 20:24 ` Mike Rapoport
2020-06-30 2:02 ` 苏辉
2020-06-30 2:06 ` David Rientjes
2020-06-30 10:28 ` kernel test robot
2020-06-30 11:52 ` kernel test robot
2020-06-30 12:39 ` David Hildenbrand
2020-06-30 13:49 ` 苏辉 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18371c7c.63d6.173057dc2c8.Coremail.sh_def@163.com \
--to=sh_def@163.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox