From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F49CC636CC for ; Mon, 13 Feb 2023 11:15:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A46486B0073; Mon, 13 Feb 2023 06:15:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9F71F6B0074; Mon, 13 Feb 2023 06:15:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8BE336B0075; Mon, 13 Feb 2023 06:15:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 7D4596B0073 for ; Mon, 13 Feb 2023 06:15:49 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 37AA741683 for ; Mon, 13 Feb 2023 11:15:49 +0000 (UTC) X-FDA: 80462013618.05.082AA62 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf27.hostedemail.com (Postfix) with ESMTP id ADD2240017 for ; Mon, 13 Feb 2023 11:15:46 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=K37AcGxe; spf=pass (imf27.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676286947; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=I9EmbCIQfylwGelzNLd9AZZbwXGcom6ymeHxaQr8/bA=; b=oIpDvr4N72uQHX9OiBDAJVGdOWY3jzAQdW98ce8nHHSqhd2pj3/AZjqwBQ+E/1F6CtAyUg 593Z3TlFO5LeN7hdnA3havaO2CIXB7U2k2pzPE6ukL7G9vDrzzNCp/gtXun0JxA7syQscc hnQXzuA1DwCaoEpxCOeuNz1PK46grT8= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=K37AcGxe; spf=pass (imf27.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676286947; a=rsa-sha256; cv=none; b=eKpR57clo8FCWTG50iJJSAVL+aMRLcSF5xCIX4c7TKNcUh4wnzVhWlfto3lsotmVack6FZ byBrmJINOdTVQPLer+FkeV0rPkc8hoLwYT60NAFDmULRyjwOkiqJa2ECt2kPGn75lv+OCA FJqPmFU8sql4oj71YoWmhJsYl80zxyw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676286945; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=I9EmbCIQfylwGelzNLd9AZZbwXGcom6ymeHxaQr8/bA=; b=K37AcGxeKYnthAQOcVN+pEPrvD6MSZqrfEHdLtECDx6BkNmz0xsN0+F6lUB6502xewU+mZ Js7lmg/1MBiSUenBP6Rc/6z3my5vgk668ezftsCvByTjLFQzjJ9z0+fws7y2uBtjSUzOVA 7fyKHgM99xTgm5VfB/9zCI5SeTRpAag= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-175--PrZZsNwMnSPcZWbh6Nu3Q-1; Mon, 13 Feb 2023 06:15:41 -0500 X-MC-Unique: -PrZZsNwMnSPcZWbh6Nu3Q-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AB65185CCE0; Mon, 13 Feb 2023 11:15:40 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.24]) by smtp.corp.redhat.com (Postfix) with ESMTP id 94145492B03; Mon, 13 Feb 2023 11:15:38 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20230209102954.528942-1-dhowells@redhat.com> <20230209102954.528942-4-dhowells@redhat.com> <1753989.1676283061@warthog.procyon.org.uk> To: Christoph Hellwig Cc: dhowells@redhat.com, Jens Axboe , Al Viro , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , John Hubbard Subject: Re: [PATCH v13 03/12] splice: Do splice read from a buffered file without using ITER_PIPE MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1830952.1676286937.1@warthog.procyon.org.uk> Date: Mon, 13 Feb 2023 11:15:37 +0000 Message-ID: <1830953.1676286937@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Stat-Signature: ibap64p8whk4groqcbkafxxdbsxk1c3g X-Rspam-User: X-Rspamd-Queue-Id: ADD2240017 X-Rspamd-Server: rspam06 X-HE-Tag: 1676286946-481377 X-HE-Meta: U2FsdGVkX1+CIOt1M9jLv/B8DFVlju3y66RKrEgkb5o0iIdw2UDZ7w/OJF30TiBEb7nYYSGm133J5KkLOqZJjm6yHDW+tTsBJEV6Yuxs2UWfQkdWXeW/uHXlMks34bYD7+hmkaj9kiZEmaOHMpE6l+gqlq11TObLOWgGcNxVlVjkhA3fbi6MhdiA9DF2oV/uBq/c+S2jdxOGZGUsirIXWebtdCwJ7Mq6n3NqmihmvK+8ceqQGmBz3/3X5YBpkM01imKqlWQMKzbJ6yyo37wEYACKeFvJ64PxO9EPcP0kD55UShWE2HSM7W4/s8iUSb/OTCdnqqCi8wIT+F1B3DdLIOQCNTOuxX1HvOt61JTQr/uwIGDsUerY/8Hk3Ce0iRDI5MeAO3HThKGM0QC8S0oNlNdelt4dFjcRxhSQU03P0KdSPIzHBt7nLz/KeEIAFFoy2PqZU/efjnRVMcvmYM1POv1mVxfwoC7ymAeYleGYUxrpJsXLvMNFljC0ND1QwGS/WpFXZA3q0spkZiePwO02D5i9rh5SKwIdWBtGxO2UFHMcBCbdRmzohUr92myv2MnB1dFgp20RxYYIe7Zd1IyvE680VsR+S+ASN8cTFvSSCrPvk257D4xfjGV8U9tDLa/gwnjNJNH5V15ihlvl0zg6D15DQnRWx53BM/n97uzREWqkDCxzJXwiqEObaEczYlo6xPSu1n2aJag2eE7C8BSVm6zz9nNIFCQ0mxOZb+Q9sHWKV4giR55NFPFBxm1KnCHiWwg8Lj+llzEQjBYtZrUeqlJifUBV5xfFFLg3qw0EzjdG0ieDgfnQhR0SkEqjgPVW7rfpbBEapsDywBTYDIPDZQOlYfPM2QNCb0c4nsyTH6iUZP/Kv26ZlN7QuaFDz+tQ+wZUOTU4cQtFJ63NFYKh2132pdO2WpbKmM5biftj3KYDRpqYIMpTlA7eGZyHD1K/U6SAD71G4lGCQ/L4Cd2 smMbChEP HQy4j0Ts4k078dHeDftC9MSslCEjDkFOT9e2VANRCGW2zSnCbAZPHIBVFK1OSlRiBCMEec8/90bhasdQ/FcjZlsuDR56l4fYPjKA4DACI2mCzayKSaBjtPkGiD/NL8fr0lA5VGqvxVZdYUfp2/ukrMObfu93kM5Swvp6/kVX8xCH4f0WHE50BoGLWlcLl0tCPOGvAjZQmBzPzLh1TwPhufQk56gYeL36v7A0l0j+sQfEGO2Gnez+6XxXtXawkAfcv8XpcYcAV+/rjrctgpWRt/t2U2Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Christoph Hellwig wrote: > > > Also why doesn't this use init_sync_kiocb? > > > > I'm not sure I want ki_flags. > > Why? I'm not sure I want ki_flags setting from f_iocb_flags I should've said. I'm not sure how the IOCB_* flags that I import from there will affect the operation of the synchronous read splice. IOCB_NOWAIT, for example, or, for that matter, IOCB_APPEND. David