From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4337C25B74 for ; Fri, 24 May 2024 15:13:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 19CF16B0092; Fri, 24 May 2024 11:13:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 14C616B0095; Fri, 24 May 2024 11:13:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F07ED6B0096; Fri, 24 May 2024 11:13:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D34936B0092 for ; Fri, 24 May 2024 11:13:04 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 826CC1C186D for ; Fri, 24 May 2024 15:13:04 +0000 (UTC) X-FDA: 82153632288.18.514D21E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf30.hostedemail.com (Postfix) with ESMTP id D6F5E80010 for ; Fri, 24 May 2024 15:13:01 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Ha0IML8+; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716563582; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uB01d66pZUieIsqTZ3UHRU/AROTNpNxlGZSWTOYJbfE=; b=mj9+cp9/HMh2UBMzkuRRJ3ItgJsZI/2o9BTZp8L47lNckDlpmNzFyYuMlE/8LlslpRTmem V/3rHtbRhzAF+JN1Ovl+HGBqYGgdPsPO86TPzJNNjXSXLZYi32289dth7wcFY/YZvtXj8d U0HS1aV6kmh2abTTx6P1Kujx8anE6Tg= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Ha0IML8+; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716563582; a=rsa-sha256; cv=none; b=EtpUrVP2F+0mmWPoEVLEFF1gPnYqul0aJESXOwBQdD2ge5Mg+PP1FZ8h32wHI2BHcWYHOy YglkIHYLvdX9cPjwY1Wp0kE65HD2WFQECEgXwIa1KI9yH6+ytgjUYYTQ+Cd88QHZzUX0vi gzqV4wBVL4uZzO4LQEin96FElszB0nY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1716563581; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=uB01d66pZUieIsqTZ3UHRU/AROTNpNxlGZSWTOYJbfE=; b=Ha0IML8+LVZMfesG8cgAr0qjtO5hmqneVc7XWFxeXcKaPITMKXjfd4STRkA/+IswzQrK0O Bb8VR7ZixHZXNZcH2yTbWqGcIDMZf4aqCiUP8FGSYgWZ7vQybDQt25CgeibHx3iYc2m8bf DjTPpXKni29ZIUMqIbmhFQuekWbs/ss= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-196-k9958qYOPOOaxZrdYJSNEQ-1; Fri, 24 May 2024 11:12:59 -0400 X-MC-Unique: k9958qYOPOOaxZrdYJSNEQ-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2e95a6565a8so7396321fa.1 for ; Fri, 24 May 2024 08:12:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716563577; x=1717168377; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=uB01d66pZUieIsqTZ3UHRU/AROTNpNxlGZSWTOYJbfE=; b=vL2lrgC7qpj0ROlgm6pMcx9uIC7ButKu1QrBIxHfrMc29yTgT+LTvdTeN1BF4on1sq TrJ0p+1K2PGhOgsq1Gszz/42TtTbkLNn/UKM5HrFb6WiOFxAnYgJ+9qfueg3+GwPbyFT IQx09WnMLiTb8mV5oJeju/lfXxgl0MvyOhosHCohCj8GBVunTOFOPZn3ddUI/6wSak4O 2b1CYPOMvsS68Quh/8kKrn07xKcY/OuZUXidHKXc7wu5zihXTnTfQZaL98HzFUXPvXlt TX6LWKbp81aSsX98oSOwUC/+l5Xk6cY/78AJ/0h4IkYxtgC+slGqFWozO1JmKknwLUjh HCcg== X-Gm-Message-State: AOJu0YxA/lx/B/yU6oetxT3fNDf7k2Iu+pJ/YxG/2k/6Mf6EXhFrqrg/ egjncrE7lwfID/kEHKCvuPhq9M1F0Ux7JD2+64wKM2LiDrxSRS/vpm+rRpCrWONZo2n9Zdrd6PR 1aKIyx5OjYRvt+kGiGffHaPiHthc74IApi1BjvwUhzv5VEkz9 X-Received: by 2002:a2e:9842:0:b0:2e8:1999:ad35 with SMTP id 38308e7fff4ca-2e95b1cd5f4mr14348961fa.24.1716563577514; Fri, 24 May 2024 08:12:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEZidOSXNGhkbOLkJOC44dWKydIsRAz8H9dGay9x48Y6QAdMCGRXN7Oaq1Smwj5jC3NTsi/gw== X-Received: by 2002:a2e:9842:0:b0:2e8:1999:ad35 with SMTP id 38308e7fff4ca-2e95b1cd5f4mr14348721fa.24.1716563576941; Fri, 24 May 2024 08:12:56 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-420fd37d5c0sm36123065e9.1.2024.05.24.08.12.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 May 2024 08:12:55 -0700 (PDT) Message-ID: <18259f7c-d57e-4504-91ec-90b7c87aad01@redhat.com> Date: Fri, 24 May 2024 17:12:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] mm/ksm: refactor out try_to_merge_with_zero_page() To: Chengming Zhou , Andrew Morton , aarcange@redhat.com, hughd@google.com, shr@devkernel.io Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, zhouchengming@bytedance.com References: <20240524-b4-ksm-scan-optimize-v1-0-053b31bd7ab4@linux.dev> <20240524-b4-ksm-scan-optimize-v1-1-053b31bd7ab4@linux.dev> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240524-b4-ksm-scan-optimize-v1-1-053b31bd7ab4@linux.dev> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: D6F5E80010 X-Stat-Signature: aoxgqnkw1oisn7nidchn9uixco8kabor X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1716563581-88326 X-HE-Meta: U2FsdGVkX1+Sk+GTV52ksS2WTV3q6vWgdOAV69/ZovQlrWF25mXbmBmCb++NWUz8uA7GhXBifdDlho6zXblNTVF3TYifoHqKBuhduf2OD0QXWXGbU4cOgxhh4AvtRrEGle8pW2OH006avxRAsBTyXnDvPfcoi9n849+0KpZ084BWW9ZHaWvcMj9eMEiG4tf5R+cH6qJ37PwqcTOB3hndy6rfvxtL8LNnxueJ7NIqOBLa3rfQ6Jb4JHFKHoS87UfuUWoyi7NcYTLe1IAfTyTS9vCXeo/ne6FJeFizQs+eZYCMtnyguqPZWdYGejMBOD1vudglbNnDZewxXecgGVtdeHIjHvjypPPcpfklL+LDFO5Oq/MhXxPetlYpvXKHmagAbLQbCGQmidNA4FvtzaqathSgtgwbWEe4+Y5GKhfyAbHA8aQe9mh9zFBwCby9T4v6WUVQMOOHafFTot5m0r1SnWtPVahibuEGIZpilq9v//vRXGLQqVwgXer59vOfjiWLQtDjxyK30IZu5szsYMAuxZ8HH6Z17AWpBF+oUwP/tgjPQE0rh0ifjW3lm0nskkp7nk1NGm6E65h8iVYoLprqdCKQ5NtJAtdc47H9pn/eSuIGOO257etRFfTZFMg4smFe6WRUq65ZKPSHhs1GyatubZ7bLgJdd91DKBRr0zIx0jA+HX24RK6H1foDXT97nscqBwKjVkZVCPYdgGx/0zFdO+VMpgKevbe7i7cmz/ADrAIoaSo9thCqhs3jeCpXPGOfOQni5ry+dXt+jRvGdo0L3kdUrw9T7HRhSPi0iMrFIf5/uCW0zoUuh/JiQsoLLSq1I+B1FMwaYzxG7Qocz42mFa3L7NL6G5GmwOzvoDN6ES/0v9DpElMF7g0ArqTiRtTomo/WWwUsTDliS27FWXQgQ5Dd6yrvpi2JJcIZipE6/7lr0ebmb3q8Lz0RIEu9nETTIiyDMG+qhk+uVhYtqSf C5X01nxZ bub3ZPcaCn7sczLudlwu5nC4zRiKAHuP6tucBlqMp+OUp5Ux4P+ay63gEGF2PY0MAIGVglbxPesuTUYIIXm3XXf68NVAT0xMojyU6ns5/I+muLwwQxId68CljWt5eOrJYSUmE8V0OF1J5/uRjJyG5zf+Q+QCP0X22rrV7a/S5n46RVyxYcZtVjgU4zQRSCeF7HAndj4dqSdMDG7I+/zl7hUqDxrPFd+zNrH2x4yZk5khXE27d/Klufv5XX5RIa5tXeaVx8VtG0mkgDahZVytGtJI8v+r5vocabXqxB8KZokm2M45XWO+Liu98LvizqeT9dJHwJYjnME+H6PpCHsfo904mafv3ARg0qnhiT+ESypYxgu8B+fqR6lNeJ7XIgwSeZTWbfQ8NZwA0zvKJxFU33WaQ7gVN9pm1Wm8wLLg6gPnaqBced9hzgHc1Jp7xT3RO64He2G/Eze481WFkQea6YIaTjs53QPRKU8FVTaMC8yB7eVNP+Kpi51W3QQqN4e0tjtqR3MUtRyR7f/+b+iclJzBVrDUsAb3lYBcrGb9fS7MurS0G725PXGIN4Ovu9irq8R5w X-Bogosity: Ham, tests=bogofilter, spamicity=0.000375, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 24.05.24 10:56, Chengming Zhou wrote: > In preparation for later changes, refactor out a new function called > try_to_merge_with_zero_page(), which tries to merge with zero page. > > Signed-off-by: Chengming Zhou > --- > mm/ksm.c | 67 +++++++++++++++++++++++++++++++++++----------------------------- > 1 file changed, 37 insertions(+), 30 deletions(-) > > diff --git a/mm/ksm.c b/mm/ksm.c > index 4dc707d175fa..cbd4ba7ea974 100644 > --- a/mm/ksm.c > +++ b/mm/ksm.c > @@ -1531,6 +1531,41 @@ static int try_to_merge_one_page(struct vm_area_struct *vma, > return err; > } > > +/* This function returns 0 if the pages were merged, -EFAULT otherwise. */ No it doesn't. Check the "err = 0" case. -- Cheers, David / dhildenb