From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 736C9C6FD18 for ; Tue, 18 Apr 2023 12:42:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E59DA8E0001; Tue, 18 Apr 2023 08:42:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E09E46B0072; Tue, 18 Apr 2023 08:42:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CD1468E0001; Tue, 18 Apr 2023 08:42:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id BF4226B0071 for ; Tue, 18 Apr 2023 08:42:35 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 91ACB14025B for ; Tue, 18 Apr 2023 12:42:35 +0000 (UTC) X-FDA: 80694475470.15.9CDA907 Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by imf06.hostedemail.com (Postfix) with ESMTP id CF31D180007 for ; Tue, 18 Apr 2023 12:42:31 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf06.hostedemail.com: domain of hal.feng@starfivetech.com designates 61.152.239.75 as permitted sender) smtp.mailfrom=hal.feng@starfivetech.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681821752; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yJ9Rm+KU2vQE1lcscVfvdJXwC7xmYvggeLx4l72O3ME=; b=dMzkds3vbFNKT5Z1i3mLuM7CR6QGQYAOQLKKo4bO2ZL28nrfWrOuowjg1yK9CQnHhgZJIh qk3HoMmzMQ/ZDYOzStfbXxusebWOZdWrUgHT+JXQ1WWy3UEqEKHjiLcPB7fn97rQSHSVHj 4jclBKUPlbrh0YTmwdTpYTqCmyeRfqQ= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf06.hostedemail.com: domain of hal.feng@starfivetech.com designates 61.152.239.75 as permitted sender) smtp.mailfrom=hal.feng@starfivetech.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681821752; a=rsa-sha256; cv=none; b=1LEkWp1g3XROT1KSWHnb1WfOmq2Di6atQ30Zvn6SEG4tEonYHv/6J25Vz0FDG7d/umloZB QYoKLTYZR9dDAcwGfEOY6LdDoySxf4tuYv5AJw+DNSOSPxMDjZAr7AeLAzQFeOM4gIb/0g pJXMCSYa7+qxcO7eERPUk6uDbISfNdU= Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id 9A27B24E31D; Tue, 18 Apr 2023 20:42:26 +0800 (CST) Received: from EXMBX172.cuchost.com (172.16.6.92) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 18 Apr 2023 20:42:26 +0800 Received: from [192.168.125.87] (113.72.144.253) by EXMBX172.cuchost.com (172.16.6.92) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 18 Apr 2023 20:42:25 +0800 Message-ID: <18211b73-346d-d6ca-6d34-bc84184f8f55@starfivetech.com> Date: Tue, 18 Apr 2023 20:42:24 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH v1 1/2] clk: starfive: Fix RESET_STARFIVE_JH7110 can't be selected in a specified case Content-Language: en-US To: Conor Dooley CC: Stephen Boyd , , , , Michael Turquette , Paul Gazzillo , "Necip Fazil Yildiran" , Emil Renner Berthing , Xingyu Wu , References: <20230417074115.30786-1-hal.feng@starfivetech.com> <20230417074115.30786-2-hal.feng@starfivetech.com> <20230417-buckwheat-wilt-92a4e85a5ca0@wendy> <83c5a35a-c646-cbc7-83f9-c02fcb24e069@starfivetech.com> <20230417-bolster-vitality-89d279146497@wendy> <0fe42faa3b34f82cc2fb73ae61460bf2.sboyd@kernel.org> <20230418-caliber-clavicle-e8c1beb3fb75@wendy> From: Hal Feng In-Reply-To: <20230418-caliber-clavicle-e8c1beb3fb75@wendy> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [113.72.144.253] X-ClientProxiedBy: EXCAS066.cuchost.com (172.16.6.26) To EXMBX172.cuchost.com (172.16.6.92) X-YovoleRuleAgent: yovoleflag X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: CF31D180007 X-Stat-Signature: ykb5iridjkyscinp7xbf5xcsn69xpu3k X-Rspam-User: X-HE-Tag: 1681821751-731320 X-HE-Meta: U2FsdGVkX18tfoWtd2+vvuS5DI6HThnMxlT3w7eYdqDZo9ultIBgaPUky3qbnW9xzMGVRhA8oN3Kn52kck0BTJpzTnDZOG0aq1CFJapVrZP+9bebIgmLX6eBttCivvwjcqi/B6xeM9FvjiDOpb45COhGJs7fY4vOfuWqXbNCaLwRMkd23x0Sox0K5nTaUGUESKE7+Gb8r9hpS7ZSKSmdJ8Wuazah3Z46obEN+tHeEKjIO+oAj5wTcmYv7wmf7YqGo6CzkI0vj0iEUzwgtJ0QrwEYJE7J173HabcFtYHNNZRLdNOFJeOvIVim4MjF7tl6dKKdVC4Ff2IL+LLEqSR8+JKepZ1CJatC5rA10WhbXqCtn+NBw9q/t0Q3cVUrLDfm85cTwbpA5/N0PCoC0Ix/eLmhWld0nLrGpfChIquBcrGUysfhYVp5bJVLHGDGVswm8LpHkwyMssud11D+S5CfzHF78djiN5luN0P+jahsaavRJUh2BO9AYxMX6LjxAV9Nt/7HKOhWXd9J7rsF8uDavxc2whiUSL9rI1qXJICSH7F3HZHaBAOar7Ar7/UdRnNo2q83+Kxghk80H58nyhNY2ZTyu8+aQbLYLo13jFRrWDJmlqSxc/s7uCsR2XJ3xWWd8t90U/Yq/g1vAsRdN2yAl28P01Av4gZkxs0Lk0o8T1483uPK4y9dxMrJzFj9DMVBU2KpAsCP0ErcHS8SQNzBkDtMup9Fyr0L7Y7adse/nLFQPBrJlFBmKjDVnqORg7maeYO30at6Jg4GMsKtq1N4+ODHKk7DjuhlUW3TrzcUnj87S+8HsY0AI76CSWj7XoUbWSNBdt0mqd0gpTkcgjo1N+rzJw+eK0GqP7pRLdQ8Ub877n3ioa19nTF+oMn0Ckga033PKcoPNd6MkaPg129myDwRNCiZE9NG+k+XQNnqRnjctN/pgYcgnru3Ff0Weh8aCgZI1bA7H/czO0JGZi0 dsLRCIgj 1JZGdw3ChcsoLQjVf+W3qGcSBJTdzMDWyaL7Tj+6Y6wfggpY030PSnQi//VE90Ifu6+SnBAkl0JYTRRC5Pcp2Mh/huxGgN1rvfeBpkgRKiXU48h/M+UZfp9dqvgZ+BytUqlSzjPy13z3khqAe4bfWWQUxG63Ock9bQgri9I88/RK+QEg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 18 Apr 2023 07:31:47 +0100, Conor Dooley wrote: > On Tue, Apr 18, 2023 at 10:14:06AM +0800, Hal Feng wrote: >> On Mon, 17 Apr 2023 17:22:01 -0700, Stephen Boyd wrote: >> > Quoting Conor Dooley (2023-04-17 03:18:35) > >> >> Aye, just the explicit dependency seems like it'd be less fragile and >> >> more obvious in the future. >> > >> > Agreed. Be explicit so we don't have to hunt down select dependencies. >> >> With further consideration, on the other hand, if we set `if ARCH_STARFIVE` >> here, it can point out that we need the reset driver to boot up JH7110 >> besides the clock drivers, and the reset driver is not a necessary option >> for compilation test. So the reset driver is independent to the clock >> drivers when you doing a compilation test. > > If ARCH_STARFIVE is enabled, both options (RESET_CONTROLLER & > RESET_STARFIVE_JH7110) will be selected & you don't need to worry about > people not realising this. Try it out & look at the option in > menuconfig. > >> If we set `if RESET_CONTROLLER` here, the reset driver will be compiled >> automatically when (ARCH_STARFIVE [=n] && COMPILE_TEST [=y] && >> RESET_CONTROLLER [=y] && CLK_STARFIVE_JH7110_SYS [=y]). > > This is what we want, right? The more often it gets built by randconfig > etc the better, especially for archs that are not RISC-V. OK, will fix it in v2. Best regards, Hal