From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE138C433EF for ; Tue, 12 Jul 2022 03:14:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 32D6E940039; Mon, 11 Jul 2022 23:14:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B692940033; Mon, 11 Jul 2022 23:14:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1583B940039; Mon, 11 Jul 2022 23:14:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 02E55940033 for ; Mon, 11 Jul 2022 23:14:03 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C08BF20870 for ; Tue, 12 Jul 2022 03:14:02 +0000 (UTC) X-FDA: 79676978724.21.35F8698 Received: from sender4-op-o14.zoho.com (sender4-op-o14.zoho.com [136.143.188.14]) by imf16.hostedemail.com (Postfix) with ESMTP id C33CD180061 for ; Tue, 12 Jul 2022 03:14:01 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; t=1657595632; cv=none; d=zohomail.com; s=zohoarc; b=bacQR/baKY0de56t2Uz3txqbdVyIoP6DWYZrIoy1Q4/jVg5bL3cv7JoHeubtWOLvzocZLqsS5bChMSJLJlROhcLSAqXxoydHeENDAXBg1u2decIfrBKQHyzOdwj+6Ql2l+IsOxa1tDYuKp97HUj+cUtrGNW3r2rOOlcRdSaIxYA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1657595632; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=EA5z6YjBCuOgn0sSNEge40fBG5QIZgwF8W8bHwuDa5Q=; b=cl4PFB9eFqNSyqGTaqG6Ks2KzI3B1Jdc9XhReMcesusDSIB/KSHr1zI4cKZXPk0tghaONd3gT4NC8m6zPq/zEtHpGf2y7ApU/XOdMrzg98ribw5kox2WlRwLHyWbhhICmJh/QbeGLuIuJQY3tbuJqC4YhLHsCJUaKRx/hAO2d38= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=linux.beauty; spf=pass smtp.mailfrom=me@linux.beauty; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1657595632; s=zmail; d=linux.beauty; i=me@linux.beauty; h=Date:Date:From:From:To:To:Cc:Cc:Message-ID:In-Reply-To:References:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=EA5z6YjBCuOgn0sSNEge40fBG5QIZgwF8W8bHwuDa5Q=; b=qGDdDUbYkpvCDN/2Mh3vrijp6vYPV5Tn/Op1KrK1gTiiKppw/KPJIq89Am5yUKvf WVWAfBxiMqo69k1PbRnGiG8iiotI42QAfcmHjhLC4Lvw2HbASgQNnJfieP4jzsA4JEf Bey9WPctTFb1vwtZYDeA8/D13wRDj2v7NqvihNYY= Received: from mail.zoho.com by mx.zohomail.com with SMTP id 1657595631492858.3699768117431; Mon, 11 Jul 2022 20:13:51 -0700 (PDT) Date: Tue, 12 Jul 2022 11:13:51 +0800 From: Li Chen To: "Arnd Bergmann" Cc: "Catalin Marinas" , "Will Deacon" , "Rob Herring" , "Frank Rowand" , "Andrew Morton" , "Li Chen" , "Linux ARM" , "Linux Kernel Mailing List" , "DTML" , "Linux-MM" Message-ID: <181f0661719.f70e29d3505822.5974565955538700441@linux.beauty> In-Reply-To: References: <20220711122459.13773-1-me@linux.beauty> <20220711122459.13773-2-me@linux.beauty> <181edbe0f3d.e1336ef3387914.4730240512950880256@linux.beauty> Subject: Re: [PATCH 1/4] of: add struct page support to rmem MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Importance: Medium User-Agent: Zoho Mail X-Mailer: Zoho Mail ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1657595642; a=rsa-sha256; cv=pass; b=IExDAvlk4P0ekUtCzJ9J6z7zypLypU9Hm6kHUMHaJ4PQCeqfr1h/B3By4qV3IWwARYHrYq NtszCWeluLFxSQJkN6hkboBDBEFBK+VDJT3k7XQLZF9ouF4H+gq2FT5yBbT7jDiwI6RWyF dnbOs+y2pEgTHHIaXcxTecLmA+NBbmo= ARC-Authentication-Results: i=2; imf16.hostedemail.com; dkim=pass header.d=linux.beauty header.s=zmail header.b=qGDdDUbY; dmarc=none; spf=pass (imf16.hostedemail.com: domain of me@linux.beauty designates 136.143.188.14 as permitted sender) smtp.mailfrom=me@linux.beauty; arc=pass ("zohomail.com:s=zohoarc:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657595642; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EA5z6YjBCuOgn0sSNEge40fBG5QIZgwF8W8bHwuDa5Q=; b=XALC3f+f1EHhw5LlT3NDybnVhiWLs6swm/97yVzK7TiOvguGVVnVCvVBujOl/dRxoVP+yf sETywV8aZlsiwJWCbgOyznbn3MEZlos5jAeT6mVvWMsKr6zDz12gLB3sjWKA8coSxKrf3H 2K9LTNY0lS0vhfh/w74bHKSQGX0DI8c= Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=linux.beauty header.s=zmail header.b=qGDdDUbY; dmarc=none; spf=pass (imf16.hostedemail.com: domain of me@linux.beauty designates 136.143.188.14 as permitted sender) smtp.mailfrom=me@linux.beauty; arc=pass ("zohomail.com:s=zohoarc:i=1") X-Stat-Signature: rt55md9hng5jsa5cueahzjrmi1541975 X-Rspamd-Queue-Id: C33CD180061 X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1657595641-292080 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Arnd, ---- On Mon, 11 Jul 2022 23:06:50 +0800 Arnd Bergmann wrote --- > On Mon, Jul 11, 2022 at 4:51 PM Li Chen wrote: > > ---- On Mon, 11 Jul 2022 21:36:12 +0800 Arnd Bergmann wrote --- > > > On Mon, Jul 11, 2022 at 2:24 PM Li Chen wrote: > > > > > > > +config OF_RESERVED_MEM_DIO_SUPPORT > > > > + bool "add Direct I/O support to reserved_mem" > > > > + depends on ZONE_DEVICE && ARCH_KEEP_MEMBLOCK > > > > + help > > > > + By default, reserved memory don't get struct page support, which > > > > + means you cannot do Direct I/O from this region. This config takes > > > > + uses of ZONE_DEVICE and treats rmem as hotplug mem to get struct > > > > + page and DIO support. > > > > > > This probably does not need to be user visible, it's enough to select it from > > > the drivers that need it. > > > > When you say "user visible", do you mean the config can be dropped or something else like Kconfig type other than bool? > > I mean this can be a hidden option, which you can do by leaving out the > one-line description after the 'bool' keyword. The option will still > be selectable > in Kconfig files from other options, but not shown in 'make menuconfig'. > > Arnd > Roger that. I will do it in v2. Regards, Li