From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17BDFC4167B for ; Tue, 5 Dec 2023 13:40:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9C10E6B0093; Tue, 5 Dec 2023 08:40:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 949A06B0095; Tue, 5 Dec 2023 08:40:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C51F6B0096; Tue, 5 Dec 2023 08:40:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 64D7F6B0093 for ; Tue, 5 Dec 2023 08:40:26 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 34FA140119 for ; Tue, 5 Dec 2023 13:40:26 +0000 (UTC) X-FDA: 81532874052.25.FAD17CE Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf21.hostedemail.com (Postfix) with ESMTP id 778271C000E for ; Tue, 5 Dec 2023 13:40:24 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=none; spf=pass (imf21.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701783624; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dynIkdHN+Emasb5kQcs7SfUmgfOjTkWT0O52R12xz58=; b=luJq24a6thmvlL7SFbgzqPrcadfME/Dr4rBaZqnhPlF9hSZgFxM6C4bZ1T1broxE/RJ0/U NvEXX9JfW5mpcpwg4ceivDXMrWOgSgFcD1zPIktVVd9doobTAe43r/YcmpHvZyWSj03xTp 2u79KnN6caRejNonOuSUXoJXHG21Ofs= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=none; spf=pass (imf21.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701783624; a=rsa-sha256; cv=none; b=4QFtFrYhSx0LmYtrWUJEGEsbz5P4bmZsHRegNSNIkBNzfs5MExGoeoxlu/ORsrr+RnSoAk S9fyi4b4EdC53AsrjXRgXG9YxYNjLbY9usUN6QUJorevK0OZjnuxU3nu6MdEtbnMDdBEkA kOOsmLg+A6lNJMzMH4rSCh29GusdpaY= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2DCD42F4; Tue, 5 Dec 2023 05:41:10 -0800 (PST) Received: from [10.57.73.130] (unknown [10.57.73.130]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2DBA93F5A1; Tue, 5 Dec 2023 05:40:22 -0800 (PST) Message-ID: <181a1623-9285-415e-9ec6-6b6548ca7487@arm.com> Date: Tue, 5 Dec 2023 13:40:20 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 34/39] mm/rmap: introduce folio_try_dup_anon_rmap_[pte|ptes|pmd]() Content-Language: en-GB To: David Hildenbrand , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, Andrew Morton , "Matthew Wilcox (Oracle)" , Hugh Dickins , Yin Fengwei , Mike Kravetz , Muchun Song , Peter Xu References: <20231204142146.91437-1-david@redhat.com> <20231204142146.91437-35-david@redhat.com> <88a341bf-0b6a-454a-aeb1-0699233eb37c@redhat.com> From: Ryan Roberts In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 778271C000E X-Rspam-User: X-Stat-Signature: npjsy6yrpn9wb9kkthxnybu61jszj1i6 X-Rspamd-Server: rspam01 X-HE-Tag: 1701783624-499957 X-HE-Meta: U2FsdGVkX1/5eDqPKJHYl9uX0DyU2wVnb43dtDQIiUZlW7vHvPew6ANup7wwPqe7t2I8uwdYHU5rb2NvEfM/2U/IE/YHAxtVm01snwWWDGHbAmS60QeOTFshHWUC9agovdx1epDll3xcoPrb6JiuPNSE9NuHbvutgEg8gODH6PhQq+ghaT/kR6VlT1YeFAJS6i5gALdxp+fxbqJlWJc4fP9PCRBQMmhR/KlJ34JopUfmm9kuuM/fT/0fJvyVJ9bqSH/A+rEZ6ulbRPPluFFEeRtrm/pthQ4iJbyIF6WV5KfFAQLUuBDMk/CZH4j25i1RGmJGWtkZJQIX9SsaH6/7DztxC28r73YrdMVVGglMCkWg/jZk4Z7bOm93SZ1IXngRMbISudXeft+HCJmYuSb4o1KxEib0gPH0B6ZTkmG2pCOHaFRu1fIe7rzuGpC/QW1s3/iz6PEBlqvN5LOSLYqnYftXjFz+LAm7wikn09euMzph1o0jrlJp7J1MuVf9V4UbA1A9NfUuBBOL6Ok/6cxF9poAYJWJ7EuKyyxhVT3EWbsNH+E49IcLILBcjsGboktJZt+gHSbsrOl4hpdcjAwJY6NvTQAQUkXX6j/k6EKLonIn8T8YuYGHDERv/CAvcnX+FlKZvGn5KKtg+PCWbr8y91La5iXg78Bzb+jyrfiW1rutIxIMuRtUxw3/KMCvFv2XGEz6g1yewWVc7dQb+f1Sd5aE74eAkITvIB0jdLfj88nupXVqqeXEHtZ+xynFAf6+JQCO4qmq04qDwv7+jLXSSXhtfhCwWeMyhXkoRmh7AadcRNezoxWsd2G4sn5keJrHXRfoYPnDV8hcJRXiYl+I8s+dS2pVr3/l+oO5aYkwNmlVnlWLoBPM8/CM21rpCup07El96ABnXNt3twVjwkzjvGsNpZnOUFMl1gxwR41SsLpMfcxLrA3Y+IavWzxddJOeCh+rrk6IyEEVrLDBW3L AfJBdyw5 shKP1Sk3I2qFwPvjWp21G8hJykgpgs74KTBx9WTLXMN/1scOnyVAK8PorE0X3YoKP3z5mCb4CkXXtl2p5VCpz5ePXqbKAM3GIPfrPP/OZ03sa98R+0FJzUgU4vblDo3wDJMZAsDs0NXybJkZUsySdlmL/KYrbwarUD8trady60PEbTwuytxomaraodlp4o/2qQuCJj0qBz81WeqgCVzDGMZAfRw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 05/12/2023 13:18, David Hildenbrand wrote: > On 05.12.23 14:17, David Hildenbrand wrote: >> On 05.12.23 14:12, Ryan Roberts wrote: >>> On 04/12/2023 14:21, David Hildenbrand wrote: >>>> The last user of page_needs_cow_for_dma() and __page_dup_rmap() are gone, >>>> remove them. >>>> >>>> Add folio_try_dup_anon_rmap_ptes() right away, we want to perform rmap >>>> baching during fork() soon. >>>> >>>> Signed-off-by: David Hildenbrand >>>> --- >>>>    include/linux/mm.h   |   6 -- >>>>    include/linux/rmap.h | 145 +++++++++++++++++++++++++++++-------------- >>>>    2 files changed, 100 insertions(+), 51 deletions(-) >>>> >>>> diff --git a/include/linux/mm.h b/include/linux/mm.h >>>> index 24c1c7c5a99c0..f7565b35ae931 100644 >>>> --- a/include/linux/mm.h >>>> +++ b/include/linux/mm.h >>>> @@ -1964,12 +1964,6 @@ static inline bool folio_needs_cow_for_dma(struct >>>> vm_area_struct *vma, >>>>        return folio_maybe_dma_pinned(folio); >>>>    } >>>>    -static inline bool page_needs_cow_for_dma(struct vm_area_struct *vma, >>>> -                      struct page *page) >>>> -{ >>>> -    return folio_needs_cow_for_dma(vma, page_folio(page)); >>>> -} >>>> - >>>>    /** >>>>     * is_zero_page - Query if a page is a zero page >>>>     * @page: The page to query >>>> diff --git a/include/linux/rmap.h b/include/linux/rmap.h >>>> index 21d72cc602adc..84439f7720c62 100644 >>>> --- a/include/linux/rmap.h >>>> +++ b/include/linux/rmap.h >>>> @@ -354,68 +354,123 @@ static inline void folio_dup_file_rmap_pmd(struct >>>> folio *folio, >>>>    #endif >>>>    } >>>>    -static inline void __page_dup_rmap(struct page *page, bool compound) >>>> +static inline int __folio_try_dup_anon_rmap(struct folio *folio, >>> >>> __always_inline? >> >> Yes. > > Ah, no, I did this for a reason. This function lives in a header, so it will > always be inlined. > Really? It will certainly be duplicated across every compilation unit, but that's separate from being inlined - if the optimizer is off, won't it just end up as an out-of-line function in every compilation unit?