From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6998DC4338F for ; Tue, 10 Aug 2021 22:07:29 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 08DB861076 for ; Tue, 10 Aug 2021 22:07:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 08DB861076 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 7DC4A8D0001; Tue, 10 Aug 2021 18:07:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 78B806B0073; Tue, 10 Aug 2021 18:07:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6A0F08D0001; Tue, 10 Aug 2021 18:07:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0056.hostedemail.com [216.40.44.56]) by kanga.kvack.org (Postfix) with ESMTP id 4DC2C6B0072 for ; Tue, 10 Aug 2021 18:07:28 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id EEDEA1837E01D for ; Tue, 10 Aug 2021 22:07:27 +0000 (UTC) X-FDA: 78460558134.04.C4BBB39 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf20.hostedemail.com (Postfix) with ESMTP id 8AE23D006483 for ; Tue, 10 Aug 2021 22:07:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628633247; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hmzm8caQt3TdVyNzd3tgJRC0GlnTJtY3kcYH2J6COrc=; b=Rfw2fKZGJAa9+CpfnrmbMZyDMXWq6lrYriQcXIPjYp8i94s6+s2uEDuyshR8iz0Qq1jQds 0J9+8r9+isPXArdNaGdb5tKWmbJlaY3COub2YS1avJrWopdTtVCi5jrnc6jxqv2CDq4e70 /0qlhUnWCeBCGcfjQxVUqk7QBJQ9aSw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-509-YUI6OfTyOci4zi2LL-OQ9A-1; Tue, 10 Aug 2021 18:07:25 -0400 X-MC-Unique: YUI6OfTyOci4zi2LL-OQ9A-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9D1B62E74; Tue, 10 Aug 2021 22:07:24 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.22.32.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8894E10016FB; Tue, 10 Aug 2021 22:07:23 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20210715033704.692967-90-willy@infradead.org> References: <20210715033704.692967-90-willy@infradead.org> <20210715033704.692967-1-willy@infradead.org> To: "Matthew Wilcox (Oracle)" Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v14 089/138] mm/filemap: Add FGP_STABLE MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1815219.1628633242.1@warthog.procyon.org.uk> Date: Tue, 10 Aug 2021 23:07:22 +0100 Message-ID: <1815220.1628633242@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Rfw2fKZG; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf20.hostedemail.com: domain of dhowells@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=dhowells@redhat.com X-Stat-Signature: ju8gzyqyhm1s75e99g1iij3fj9jkfbee X-Rspamd-Queue-Id: 8AE23D006483 X-Rspamd-Server: rspam01 X-HE-Tag: 1628633247-385135 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Matthew Wilcox (Oracle) wrote: > Allow filemap_get_folio() to wait for writeback to complete (if the > filesystem wants that behaviour). This is the folio equivalent of > grab_cache_page_write_begin(), which is moved into the folio-compat > file as a reminder to migrate all the code using it. This paves the > way for getting rid of AOP_FLAG_NOFS once grab_cache_page_write_begin() > is removed. > > Kernel grows by 11 bytes. filemap_get_folio() grows by 33 bytes but > grab_cache_page_write_begin() shrinks by 22 bytes to make up for it. > > Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: David Howells