From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAC5BC4345F for ; Thu, 18 Apr 2024 09:31:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3C5326B0088; Thu, 18 Apr 2024 05:31:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 326DE6B008C; Thu, 18 Apr 2024 05:31:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1C7F76B0098; Thu, 18 Apr 2024 05:31:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id F168A6B0088 for ; Thu, 18 Apr 2024 05:31:09 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B8D0F40EB5 for ; Thu, 18 Apr 2024 09:31:09 +0000 (UTC) X-FDA: 82022133858.30.B979777 Received: from szxga06-in.huawei.com (szxga06-in.huawei.com [45.249.212.32]) by imf13.hostedemail.com (Postfix) with ESMTP id 55D9620011 for ; Thu, 18 Apr 2024 09:31:06 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf13.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.32 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713432667; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YmRNGVFVk34QAkFSvj8I3sRjl5hhCZo6zkUhJJJ2cDs=; b=hMZY2l9R0cXQ9sKqAgK1wGPgNdalMc2snLu62k8T3ZuPuPRL22brdL2+2YDXIt5myY59DK t0p2vyOWwbpDfks2O3qNV7DsVi+PzqDpIfaXh8zY+r14tybb3GrCGe6rpQpWd1nrcBralk UrzzD6Lv8+Jxktwnz+FkfoRCQ6L/WC4= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf13.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.32 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713432667; a=rsa-sha256; cv=none; b=ODDiefsPNcC1c9gh+rNCD5ViNv0RP39JLsHI5e/Eqhf1YmhZVairZw+T6+ag/b9w9Jw3Wj +6Hyr47DN/GlhhVrC9aGCHcjU7bje5FwyUHYgm4eTO5PwcVRUdaYY4+pKNbRXVZmhF9t8p 5Td+usKlKDpywg6i6Mi+UsQA5Igf6EU= Received: from mail.maildlp.com (unknown [172.19.88.234]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4VKsv112WKz1wrk4; Thu, 18 Apr 2024 17:30:05 +0800 (CST) Received: from canpemm500002.china.huawei.com (unknown [7.192.104.244]) by mail.maildlp.com (Postfix) with ESMTPS id 1ABF71404F6; Thu, 18 Apr 2024 17:31:04 +0800 (CST) Received: from [10.173.135.154] (10.173.135.154) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 18 Apr 2024 17:31:03 +0800 Subject: Re: [PATCH v3 10/11] mm/memory-failure: Use folio functions throughout collect_procs() To: "Matthew Wilcox (Oracle)" CC: , Jane Chu References: <20240412193510.2356957-1-willy@infradead.org> <20240412193510.2356957-11-willy@infradead.org> From: Miaohe Lin Message-ID: <180c1fd5-486b-b1e2-93af-95f9c2725a26@huawei.com> Date: Thu, 18 Apr 2024 17:31:03 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20240412193510.2356957-11-willy@infradead.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.173.135.154] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To canpemm500002.china.huawei.com (7.192.104.244) X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 55D9620011 X-Rspam-User: X-Stat-Signature: 9k383hirrzo41xh6borewu4fqoafx6hw X-HE-Tag: 1713432666-325655 X-HE-Meta: U2FsdGVkX18WMo/v+nPG6HEHE+M4CXExbkknCXjc3IhPF88TV5GAfns3uXZ4ips8jR5KJd2uq0n45O8xf/wlx57ifcRnuEhFsleIXiy5iFEqxqVEYFdtq8QSZU8A+i2np3VS4z9wK68eUWHO0ZvzB5iMxHGflXbrzjU43qlm7P/qlHHCVWpKuDxm2/alUBF/hyoS+EAUP1htrvxmeDls0AK8tBIQf4NcajHqMi2ZaLMQjecdrPE+rUFHehhp892oXjQaTIwOXIVKJiCQCZAODRzytJoN40Au8ZZ8IcJXE+/5pjLWaFfXMuXyHuOzyqH6D+k9EDvPuGqzZ4RXadigoSN1fCnIZBSIuuH/hwfMVvGIjuxZC/1glVDcPocaRb94wdVOgXhQNc1WeFmrVssex6dYzF3lHVZjNcAajhSVWXKdpqDywI6pYdJjTZ0WS+D+4BNhiVeSNQppiUhsHKk7vjTOns0Pnk5kyNCTe+jYGcRXtmiJrL1Uz8imdJQwRQ8LHVbybHKXqV/FKMGTENiCGAsxPBbf0/XQEOdJkLQacaZOjzJ/otlvbeGgiUbcMxhZUIsnho/SvTchn3HyLhSPQ23agcpGZs9cVBiLhIlMzHUSDFbF07jOV7YMyo3w+PAZMxQPGQBHS1iD8jYTwytgx9s7PeBOr7KlKpFRn08OBMWz+BellRjv90D+AK8nOjr9jRTnvTjeD8xRcQeyLa679qR8U8FnwNErQFLBPAZ7jz84FB0T1ALFbx+1VvJRjzlcNe6YaSnydjvf/3sLbq7TX61MEBZ3xCSmEvPZ8c7lrGNxfWc36q02AHhPKOEPDgsd1t4aHWdCJQ3tixQ8tpVWY2akLY3EcEC7GkkP/59Xdgl7jyb5cIUPkcLSR8psqCcnYDJGsGJhEs6oj5lPNhM4GNxtRP+zIzioOoNaTr/Toa8wDIeUjAnNs4n80wAlufOpcHP/8hTijMlVlrjc3Jy Zv7mZCkW c236uXo7yfP5YCcBa6AqGFGxKDp9z1iiugJLL3wDQ7sYx2YHdYyUJ4SjGvQTlOlwCryiPwt+9qGTGkKF/SVQjAKIvsu5ZEW+EQr41/K+A4U1JetPfqIQ3YKkHzie6joBC2jPTAXBmlD0xzFXhfPNAMvdRezMV5aaDrftd3p+PLMsayO9ZyMyYitMrElUmDWgnBrgEJ4W6RDf0he0EA54khHz92r3voACbIJEhm+oF+DIlctqzlnOqQSMBEm3z/J23YXL3l80mbv8niODMQQx2Sm1wow== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/4/13 3:35, Matthew Wilcox (Oracle) wrote: > Saves a couple of calls to compound_head(). > > Signed-off-by: Matthew Wilcox (Oracle) > Reviewed-by: Jane Chu Acked-by: Miaohe Lin Thanks. . > --- > mm/memory-failure.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index e42c5f2179dc..a9fa5901b48c 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -722,9 +722,9 @@ static void collect_procs(struct folio *folio, struct page *page, > { > if (!folio->mapping) > return; > - if (unlikely(PageKsm(page))) > + if (unlikely(folio_test_ksm(folio))) > collect_procs_ksm(page, tokill, force_early); > - else if (PageAnon(page)) > + else if (folio_test_anon(folio)) > collect_procs_anon(folio, page, tokill, force_early); > else > collect_procs_file(folio, page, tokill, force_early); >