From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 741DEE784AF for ; Mon, 2 Oct 2023 09:26:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E701D8D0012; Mon, 2 Oct 2023 05:26:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E1EB68D0001; Mon, 2 Oct 2023 05:26:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CC0318D0012; Mon, 2 Oct 2023 05:26:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B78778D0001 for ; Mon, 2 Oct 2023 05:26:04 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 7A951A01AC for ; Mon, 2 Oct 2023 09:26:04 +0000 (UTC) X-FDA: 81299989848.14.D91F617 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf19.hostedemail.com (Postfix) with ESMTP id A8AF41A0008 for ; Mon, 2 Oct 2023 09:26:01 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="HogZ+Ul/"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf19.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696238761; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=u0PdD95eQa7pRzI20cGWxgLJ0k+Wv+3imJtntajjlHo=; b=uhRB3XVNOc2HiXxk2joCvMUtrOBbog8dpf0LbQN00mKHrtqzbiXNQ7uQt5tVDZBeTshl01 15cbMxaODCqhakPK5X7UgPKkOqAFdRPcUfYeMg57t+fSxrWQZ8nDrwLEXG8qmZ9DbpAOHG MhX7luAfsVPmBBKiiyJKo+rrm/tpCHY= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="HogZ+Ul/"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf19.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696238761; a=rsa-sha256; cv=none; b=8efkJ3bxs5tyeZKkavNgPjYjVcl4Bet1WkQCs6ixwEaAbfcCf5u3b6MqCanL8eE2Qc0I2g 5a/IWocqaJLC4ivDZ0FS+ySnje0xBXM13L3cPWotswzVybwnxuMHbhUiYSXkAP6oCXp6Fz CIFacxaS2SyXvPeuHq4zzuZf4QmRIik= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696238761; h=from:from:reply-to:subject:subject:date:date:message-id:message-id:to: cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=u0PdD95eQa7pRzI20cGWxgLJ0k+Wv+3imJtntajjlHo=; b=HogZ+Ul//XYWmuYrd6qdCNdtWKZgXkxqQL9iD+Psp+yN+5mi9I9NQzOe6hwFJAYUKUjsRb sDEMi+rlMrXvXdES7gPv2kAtaHrI+Td/cxGjML+NlQ9mWJB62+Kef+6u2MTNlc2jGy6J0w Jw1JHQPPia0vhIGWGfbPMtmda+IchwY= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-329-PQBTnD6gOOy2ZO4-BcF33g-1; Mon, 02 Oct 2023 05:25:55 -0400 X-MC-Unique: PQBTnD6gOOy2ZO4-BcF33g-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2035D811E7D; Mon, 2 Oct 2023 09:25:55 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.226]) by smtp.corp.redhat.com (Postfix) with ESMTP id 638B951E3; Mon, 2 Oct 2023 09:25:52 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20230925120309.1731676-9-dhowells@redhat.com> References: <20230925120309.1731676-9-dhowells@redhat.com> <20230925120309.1731676-1-dhowells@redhat.com> Cc: dhowells@redhat.com, Jens Axboe , Al Viro , Linus Torvalds , Christoph Hellwig , Christian Brauner , David Laight , Matthew Wilcox , Jeff Layton , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 08/12] iov_iter: Don't deal with iter->copy_mc in memcpy_from_iter_mc() MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1809397.1696238751.1@warthog.procyon.org.uk> Content-Transfer-Encoding: quoted-printable Date: Mon, 02 Oct 2023 10:25:51 +0100 Message-ID: <1809398.1696238751@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Rspamd-Queue-Id: A8AF41A0008 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: kkwewoyr7erahtnd4uy7g4464y6nmort X-HE-Tag: 1696238761-368088 X-HE-Meta: U2FsdGVkX18WXluclSSKpDNDN/atK6BxSn8Ca8Sl7NctPYBgbMMyYyTlBae46hFdkrZCvwPlT+56uuDIwZIboQTDcTfDpbVueFsmWXJ7boZdVsKQyqHVVKnrTQESyBZ/F+Llod3iSxBxG2ZtCGN1XNgPyZKNskSNOTccKgoe7qe8AiMzHgLn7HJJLcMC0cd7BCF4qF7EiOJ/OVbGzjFx3HahrOsaA66lRyKdXdwPdmcCFCE/s3ldTsz+fwWn0HWHPHdZL3CSgmp2B8VTNGpR/YlbhThCfgRS++4dyqjlOW4oRWLdLzX8yaYEisF1Vf0KqPbm8HHQYUZ4uHjJ3hbzmhamVq5udaIddoBqV2RPrmvvvJc3OXAPKQNr6CPROSa2nnqQKujiZxL0b8ADsHCCAkR20RXl4/RklwS2AJS9KYx0TabxsSRFoK6BMfRMA729vLKvwkIf6yos+c4Cy4dj8DiMeRO9jZChohAh6li0kDrnXSgBqFTxDX1+6GfAQdwniNbdwjGeyaqcnAz412Wlg8ITwrnh/lvuZlCqHeo1gJCYD3Ls0qFGeXYPDISvqo3Z9VIpxlzYz6/+yUT5Ygrq9FvY1T49/ImqJUHv3vhzk9sSF0NIcMrnuFvxoZYijDCs540kbE4Q9FzKB/CcLKPYij8oz37oTZdxkORzEN55PEhPtQjSOw4VMqPiHpuK1iiLR6waXVrafYjgltMOW097EbM9Rf96+MwgqBsjovMCyeC6yfMoxXLiy1i/bVCqUkiRUByf8czMW7ghcwsSxGdpJIQflTrlviY5/Cvvup19Niqx9+G3zdAJv6MooJfrXbgEPcze9ZniF1uAFZJnHAR0y3gqkRWFQIDqLLjThu3l3F1hz8NWQhXYDcE0hb+HJ5TH59CsCGCcQ4tLERkra20M9pXpSlevU2qc59KWAzgl3WNDNs1r/tEZNyzP9aNT9dyg2VJ3+FEJt50O8MUAhUj ES6NZOrf 59YqJmV5iBtF6lb5NlPnlzOppVpXLcN8SaOeTubu8iZDHCjccaVBQpJyvKHF+YdiWexNkpj520Be0ZUKIxBWgv4uYeN+p3q0F0iSBo8umNLrTj/d43ovM0JfkcqpRYTmLkNvq/IwlYAMqdT+4AFSVmMLKuj88O3tsifE1Rc0MGDCIfQBW7cEZbzfwOZMvQjZtBSCQq1s4F0DqM4qOVRzb7O64LLO+gL7brLZFsNx3rlEab5IUVlbWXGLXZvMV747IYvE+y0P5dybGGVBu+Stv+s5Gqg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: David Howells wrote: > +static size_t __copy_from_iter_mc(void *addr, size_t bytes, struct iov_= iter *i) > { > - struct iov_iter *iter =3D priv2; > + size_t progress; > = > - if (iov_iter_is_copy_mc(iter)) > - return copy_mc_to_kernel(to + progress, iter_from, len); > - return memcpy_from_iter(iter_from, progress, len, to, priv2); > + if (unlikely(i->count < bytes)) > + bytes =3D i->count; > + if (unlikely(!bytes)) > + return 0; > + progress =3D iterate_bvec(i, bytes, addr, NULL, memcpy_from_iter_mc); > + i->count -=3D progress; i->count shouldn't be decreased here as iterate_bvec() now does that. This causes the LTP abort01 test to log a warning under KASAN (see below). I'll remove the line and repush the patches. David LTP: starting abort01 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D BUG: KASAN: stack-out-of-bounds in __copy_from_iter_mc+0x2e6/0x480 Read of size 4 at addr ffffc90004777594 by task abort01/708 CPU: 4 PID: 708 Comm: abort01 Not tainted 99.6.0-rc3-ged6251886a1d #46 Hardware name: QEMU Standard PC (Q35 + ICH9, 2009)/Incus, BIOS unknown= 2/2/2022 Call Trace: dump_stack_lvl+0x3d/0x70 print_report+0xce/0x650 ? lock_acquire+0x1b1/0x330 kasan_report+0xda/0x110 ? __copy_from_iter_mc+0x2e6/0x480 ? __copy_from_iter_mc+0x2e6/0x480 __copy_from_iter_mc+0x2e6/0x480 copy_page_from_iter_atomic+0x517/0x1350 ? __pfx_copy_page_from_iter_atomic+0x10/0x10 ? __filemap_get_folio+0x281/0x6c0 ? folio_wait_writeback+0x53/0x1e0 ? prepare_pages.constprop.0+0x40b/0x6c0 btrfs_copy_from_user+0xc6/0x290 btrfs_buffered_write+0x8c9/0x1190 ? __pfx_btrfs_buffered_write+0x10/0x10 ? _raw_spin_unlock+0x2d/0x50 ? btrfs_file_llseek+0x100/0xf00 ? follow_page_mask+0x69f/0x1e10 btrfs_do_write_iter+0x859/0xff0 ? __pfx_btrfs_file_llseek+0x10/0x10 ? find_held_lock+0x2d/0x110 ? __pfx_btrfs_do_write_iter+0x10/0x10 ? __up_read+0x211/0x790 ? __pfx___get_user_pages+0x10/0x10 ? __pfx___up_read+0x10/0x10 ? __kernel_write_iter+0x3be/0x6d0 __kernel_write_iter+0x226/0x6d0 ? __pfx___kernel_write_iter+0x10/0x10 dump_user_range+0x25d/0x650 ? __pfx_dump_user_range+0x10/0x10 ? __pfx_writenote+0x10/0x10 elf_core_dump+0x231f/0x2e90 ? __pfx_elf_core_dump+0x10/0x10 ? do_coredump+0x12a9/0x38c0 ? kasan_set_track+0x25/0x30 ? __kasan_kmalloc+0xaa/0xb0 ? __kmalloc_node+0x6c/0x1b0 ? do_coredump+0x12a9/0x38c0 ? get_signal+0x1e7d/0x20f0 ? 0xffffffffff600000 ? mas_next_slot+0x328/0x1dd0 ? lock_acquire+0x162/0x330 ? do_coredump+0x2537/0x38c0 do_coredump+0x2537/0x38c0 ? __pfx_do_coredump+0x10/0x10 ? kmem_cache_free+0x114/0x520 ? find_held_lock+0x2d/0x110 get_signal+0x1e7d/0x20f0 ? __pfx_get_signal+0x10/0x10 ? do_send_specific+0xf1/0x1c0 ? __pfx_do_send_specific+0x10/0x10 arch_do_signal_or_restart+0x8b/0x4b0 ? __pfx_arch_do_signal_or_restart+0x10/0x10 exit_to_user_mode_prepare+0xde/0x210 syscall_exit_to_user_mode+0x16/0x50 do_syscall_64+0x53/0x90 entry_SYSCALL_64_after_hwframe+0x6e/0xd8