From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8B2BC2D0DA for ; Wed, 25 Dec 2019 13:53:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6616A20722 for ; Wed, 25 Dec 2019 13:53:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="mZit9suz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6616A20722 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lca.pw Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id F37968E0005; Wed, 25 Dec 2019 08:53:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EE8768E0001; Wed, 25 Dec 2019 08:53:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DD7D08E0005; Wed, 25 Dec 2019 08:53:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0057.hostedemail.com [216.40.44.57]) by kanga.kvack.org (Postfix) with ESMTP id C74178E0001 for ; Wed, 25 Dec 2019 08:53:15 -0500 (EST) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id 486168249980 for ; Wed, 25 Dec 2019 13:53:15 +0000 (UTC) X-FDA: 76303805550.25.fly48_90c5d6ca9845d X-HE-Tag: fly48_90c5d6ca9845d X-Filterd-Recvd-Size: 4065 Received: from mail-qt1-f193.google.com (mail-qt1-f193.google.com [209.85.160.193]) by imf01.hostedemail.com (Postfix) with ESMTP for ; Wed, 25 Dec 2019 13:53:14 +0000 (UTC) Received: by mail-qt1-f193.google.com with SMTP id t3so20298811qtr.11 for ; Wed, 25 Dec 2019 05:53:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=content-transfer-encoding:from:mime-version:subject:date:message-id :references:cc:in-reply-to:to; bh=KUrCa6xAYjppP+kYyaFb1kK7z66EPpyNc7GyOaqtVdk=; b=mZit9suzmem/cS/gpTcNGVlvF3wGKIXuNs61u7kNov92m4+hdxWzR7feJ21VbWW7Cw UjcRkz5+CqAocHebwCuhi9iMarvn2JU1/its/7R0LLOdi7KiXXKlPNcI1EFsbsi3VnyO WOtUWv/y3a5h1qkyugjDmpvkvUXu6BVzL8ZmZ0EEZzMyGxDC0LfOYQt3DQ63p9Mw3be+ 7vGssLfKj8RXnuajMHWSN77Pm50+9DgrqtfxqpAe+JSUMfDyWNzFI8fR1IpGqa+Xg1h4 1TIbCplYVDsctABJqD/m/ELpHGAg7ufzgpu5c8dzgdb+sp2HSZVSqxU0x6CKI2boQlBP UOzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:date:message-id:references:cc:in-reply-to:to; bh=KUrCa6xAYjppP+kYyaFb1kK7z66EPpyNc7GyOaqtVdk=; b=F4h9jfVWWxZlOZKEmH9HL4RMcg/7wUJAAToQ73Fl61tuDI3OnlVRtT5kP9tH58hcpw 5JOg/ArxIkLJxzmkswqHjBgTvR8CHwxUE0hxwyN5oA+mxc4Ym4llm1DUGQuJaS5COdVV vym+aMTsQP4o8n7Yecax9BJH9d25ZjDItAy0ZgAaHVb0VgVFFxvdbnG4PXIEKnB6W89o ixb/IFG5jLBn6TzGHyXyn1PPBLS/NU9b68pxLK+F4yfczGg9rE33oa95FXSDaTog859+ xhFSMToRfk4xmKuXa20mtcwT2POg/n/zfIog5Z4VRbD+uKkUoRwsja5CmXxZwguwkTCc 3s8Q== X-Gm-Message-State: APjAAAW2bzG8cvUjIhxMlyO60mRaow1zBzjyNARzZFL5i8mAoCKYRd1b pu399RVXE1+qtAuDCX8Ivx7SS3ZHJWI= X-Google-Smtp-Source: APXvYqyYd1Qrn+cNoCtdF1a9JXv2sOcUEywIf7eukL77EDLmSZ8iElk8z29HZl+sFgCMnO7hAsELsw== X-Received: by 2002:ac8:5313:: with SMTP id t19mr31565483qtn.375.1577281993999; Wed, 25 Dec 2019 05:53:13 -0800 (PST) Received: from [192.168.1.183] (pool-71-184-117-43.bstnma.fios.verizon.net. [71.184.117.43]) by smtp.gmail.com with ESMTPSA id e3sm7057253qtj.30.2019.12.25.05.53.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Dec 2019 05:53:13 -0800 (PST) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Qian Cai Mime-Version: 1.0 (1.0) Subject: Re: [PATCH] mm/page_owner: print largest memory consumer when OOM panic occurs Date: Wed, 25 Dec 2019 08:53:12 -0500 Message-Id: <1806FE86-9508-43BC-8E2F-3620CD243B14@lca.pw> References: <1577266145.31907.4.camel@mtkswgap22> Cc: Andrew Morton , Michal Hocko , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-mediatek@lists.infradead.org, wsd_upstream@mediatek.com In-Reply-To: <1577266145.31907.4.camel@mtkswgap22> To: Miles Chen X-Mailer: iPhone Mail (17C54) X-Bogosity: Ham, tests=bogofilter, spamicity=0.047641, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Dec 25, 2019, at 4:29 AM, Miles Chen wrote: >=20 > For example, we're implementing our iommu driver and there are many > alloc_pages() in drivers/iommu. > This approach helps us located some memory leakages in our > implementation. Not sure if you have code that can share but I can=E2=80=99t imagine there a= re many places that would have a single call site in the driver doing alloc_= pages() over and over again. For example, there is only two alloc_pages() in= intel-iommu.c with one is only in the cold path, so even if alloc_pgtable_p= age() one do leaking, it is still up to there air if your patch will catch i= t because it may not a single call site and it needs to leak significant amo= unt of memory to be the greatest consumer where it is just not so realistic.= For debugging point of view, IMO it is better to annotate this one alloc_pa= ges() call when in doubt, so that kmemleak would catch it instead.=