From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD5C8C636D6 for ; Wed, 8 Feb 2023 18:15:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7B7AC6B0075; Wed, 8 Feb 2023 13:15:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 767EA6B0078; Wed, 8 Feb 2023 13:15:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 62FBA6B007B; Wed, 8 Feb 2023 13:15:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 544016B0075 for ; Wed, 8 Feb 2023 13:15:13 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 07B8D4142D for ; Wed, 8 Feb 2023 18:15:13 +0000 (UTC) X-FDA: 80444926506.23.5282CF5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf10.hostedemail.com (Postfix) with ESMTP id 27819C0026 for ; Wed, 8 Feb 2023 18:15:10 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Zr4K30Kd; spf=pass (imf10.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675880110; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PTjtXDgu2q/FuBRhvL58Zww1kvuwz26nkJJzavvqz6o=; b=IdZXIz7EGZHp5luoFUssyRb4Cy0EeJeGNrjgBbu04P/IfVokbOYr4GJsGn2zNRS8/gkuKh v2tJSI+kGFP+o8Nwuu0IiJQ9w/kXY8L9F3bvmAl3R9l9ygkOj7ER7pnBUX5QE/gDu1+j1d 4xeiLwXRBlyPwQ9ElgP2ol/aS/gjczI= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Zr4K30Kd; spf=pass (imf10.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675880110; a=rsa-sha256; cv=none; b=Hw6Qp/bNdeNZZICfiKwpc1/FpsyVKr48WW7EZZbByjhM/pqQvoEPmdMaJIJqyd3ODDgb+C pmpypzdubW6ruvUhLAtbUL9uu5dbhwJZsMGxWGAf3j4xj5uJcU4J5pAIpQ5d+wvUoFgwWj IWql/reQgMvPcLhwkaJKpqY46HZS2zE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675880109; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PTjtXDgu2q/FuBRhvL58Zww1kvuwz26nkJJzavvqz6o=; b=Zr4K30KdXP13tM/sbbC+z2GzAEBnnwl8t6rqkYaZ2RoeBXUB9m94JSBOieneKbfwjxX63l BptSUZBnKZInMKz8gn1duck5eXZGxtaX4cGV1vXFUctUgNAdwhx0qnQ2ZYNScCZqFJ2m4e 9dOwy6tjj9wDlhihYT54uTsWxJwXNrM= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-586-fst53555NBqSVP3pMESD2g-1; Wed, 08 Feb 2023 13:15:06 -0500 X-MC-Unique: fst53555NBqSVP3pMESD2g-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3FB95857A89; Wed, 8 Feb 2023 18:15:05 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.24]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2155735454; Wed, 8 Feb 2023 18:15:03 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20230207171305.3716974-1-dhowells@redhat.com> <20230207171305.3716974-2-dhowells@redhat.com> <176199.1675872591@warthog.procyon.org.uk> To: Matthew Wilcox Cc: dhowells@redhat.com, Christoph Hellwig , Jens Axboe , Al Viro , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, syzbot+a440341a59e3b7142895@syzkaller.appspotmail.com, Christoph Hellwig , John Hubbard Subject: Re: [PATCH v12 01/10] vfs, iomap: Fix generic_file_splice_read() to avoid reversion of ITER_PIPE MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <180258.1675880102.1@warthog.procyon.org.uk> Date: Wed, 08 Feb 2023 18:15:02 +0000 Message-ID: <180259.1675880102@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 27819C0026 X-Stat-Signature: gyngcpnjt9sowrxiwza95fnnzd4ds8tu X-Rspam-User: X-HE-Tag: 1675880110-80148 X-HE-Meta: U2FsdGVkX1+/MlKOmI44VMomZ3MYIe819i+mDNF+0lFZ3XUQe8rb3LszdpLChAx24tFKwL3Oj+m/jMkOkjunA+RkMAa5reDCxjeUIuOJVZbmAF9I/gs3CFaGgHFth1eVaUU+FYIQjqYPqGfBoAcihRKUtW/J+EarD+ptm8/CD6wI4Jplm1DfTmCBznm2RZnqqUHG0lEeVaW+dK+mrqfTcXyZl/QAZbrAOphBPV41IwvTZKNQVz3/wc11+MgcW+As9zlsv1HK0CNXC1j6EuJS0Qj9WxVuCy9HM5r1NDyWSjEQ7FJbbuCetSmwJPRXXOYvl8QF01pqMKJlXBZu8FURvp9HuEU2TdnCRd4jF5wE0of36jIkLD76raz48bofX6NSdTnOt4R8qFppU4oFzat4auQ6BddaOXa/4dOUFkxPoTZbryZuXLftDYh0hWA4ci9A+8hjf2+C8Ha5EZpwYF0eBKtrrqASCO0fVSrDVaQ3CNbJ/2ZiYmbg42LQiDINfoDhJ7d3OgGodx1bZVkc/zyCJRsasvAGAiOfEy1V8pdBFDP61JO3HZn03Td5QHZ0qxaKs1kgGPvuXs/Aw3IRrpzVWjfYXCNCPdzzduEim4LavI7wHY/ElNr3UMXajVEE0Hci+eH7J1K60joffrFkykUwfU+D3P1lGoYQfA466UjNRiDVi6wkX389NgCNZ7rB7WoWMWE0IcETC/vgK1iEHG2aUzkywHdscslScQ8N3wFWZvzr73lPIe+yXs5jEn25wO4DEOrT9ixK039XrJ73ykAFb/2KFxpdxTI9/IHWqh9M9pbYVR5DT2TmPovrnF5XWh8OhRf9J9Ze11J8lAoYLrcDSU/f+Jj29cbh0rHaRhUQkU0xxr58UdEMSwTLHxGFGhTMdLjJXBl7NUqlRbkkFqdldptHwx0v0qZMGVWKhgk+NK1sfgpZ2XOTRqVGEgPsRngh3vqeRB4Gqf8kOk/Yc+p v4xXFulA UW6y05YY4GOh3pJpxrdeuzk0LAl8EwunMdWca1v+tyqvUsn0Xdy8MaNFRIyCQViXSeZ+irE+hkcivgExMtaAgjJaJ4uhHZrC92qSPRb4hB0dM5hF0R0qY/uFBdPATrd1ZCxUCs8nv+YuYm/6cuCmyTEx7nZ5x3zMvgVafmVSQ1dKK1mMqlC++0Q5Jf2X+B1YbshIIgE502NkeukP1d+nSWWCsvozKus0SqRxibvAgO48umrT91bB3os3ibfEGpWbQLpXRPKuU33JvZM7nTXqFBj6i60AQHhhiBAQ1HqIWVClfMUaId2GsM4aqvHAPL9sCHWExcUoOqDGEwl/CYZspvWLLlUX10tC7G7QVLQnpoYqM1xBup+0BLuQ0+gObb6n0UJtyBq1Dhf5giLJtKLCOlwN/rg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Matthew Wilcox wrote: > What's the point in iov_iter_count() anyway? It's more characters > than iter->count, so why not use it directly? I presume it got added for a reason and should be used in preference to direct access. David