From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f69.google.com (mail-pg0-f69.google.com [74.125.83.69]) by kanga.kvack.org (Postfix) with ESMTP id 0D7696B0033 for ; Mon, 27 Nov 2017 07:28:37 -0500 (EST) Received: by mail-pg0-f69.google.com with SMTP id r12so28892623pgu.9 for ; Mon, 27 Nov 2017 04:28:37 -0800 (PST) Received: from huawei.com (szxga05-in.huawei.com. [45.249.212.191]) by mx.google.com with ESMTPS id o2si22673207plk.250.2017.11.27.04.28.35 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 Nov 2017 04:28:35 -0800 (PST) Subject: Re: [PATCH] mm,madvise: bugfix of madvise systemcall infinite loop under special circumstances. References: <20171127115318.911-1-guoxuenan@huawei.com> <20171127115847.7b65btmfl762552d@dhcp22.suse.cz> From: guoxuenan Message-ID: <17f3cb98-ec34-8761-2508-acff72d41feb@huawei.com> Date: Mon, 27 Nov 2017 20:28:01 +0800 MIME-Version: 1.0 In-Reply-To: <20171127115847.7b65btmfl762552d@dhcp22.suse.cz> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko Cc: akpm@linux-foundation.org, minchan@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, yi.zhang@huawei.com, miaoxie@huawei.com, rppt@linux.vnet.ibm.com, shli@fb.com, aarcange@redhat.com, mgorman@techsingularity.net, kirill.shutemov@linux.intel.com, rientjes@google.com, khandual@linux.vnet.ibm.com, riel@redhat.com Of course! Thank you, you save my poor english :). a?? 2017/11/27 19:58, Michal Hocko a??e??: > On Mon 27-11-17 19:53:18, guoxuenan wrote: >> From: chenjie >> >> The madvise() system call supported a set of "conventional" advice values, >> the MADV_WILLNEED parameter has possibility of triggering an infinite loop under >> direct access mode(DAX). >> >> Infinite loop situation: >> 1a??initial state [ start = vam->vm_start < vam->vm_end < end ]. >> 2a??madvise_vma() using MADV_WILLNEED parameter; >> madvise_vma() -> madvise_willneed() -> return 0 && the value of [prev] is not updated. >> >> In function SYSCALL_DEFINE3(madvise,...) >> When [start = vam->vm_start] the program enters "for" loop, >> find_vma_prev() will set the pointer vma and the pointer prev(prev = vam->vm_prev). >> Normally ,madvise_vma() will always move the pointer prev ,but when use DAX mode, >> it will never update the value of [prev]. >> >> ======================================================================= >> SYSCALL_DEFINE3(madvise,...) >> { >> [...] >> //start = vam->start => prev=vma->prev >> vma = find_vma_prev(current->mm, start, &prev); >> [...] >> for(;;) >> { >> update [start = vma->vm_start] >> >> con0: if (start >= end) //false always; >> goto out; >> tmp = vma->vm_end; >> >> //do not update [prev] and always return 0; >> error = madvise_willneed(); >> >> con1: if (error) //false always; >> goto out; >> >> //[ vam->vm_start < start = vam->vm_end > update [start = tmp ] >> >> con2: if (start >= end) //false always ; >> goto out; >> >> //because of pointer [prev] did not change,[vma] keep as it was; >> update [ vma = prev->vm_next ] >> } >> [...] >> } >> ======================================================================= >> After the first cycle ;it will always keep >> vam->vm_start < start = vam->vm_end < end && vma = prev->vm_next; >> since Circulation exit conditions (con{0,1,2}) will never meet ,the >> program stuck in infinite loop. > > I find your changelog a bit hard to parse. What would you think about > the following: > " > MADVISE_WILLNEED has always been a noop for DAX (formerly XIP) mappings. > Unfortunatelly madvise_willneed doesn't communicate this information > properly to the generic madvise syscall implementation. The calling > converion is quite subtle there. madvise_vma is supposed to either > return an error or update &prev otherwise the main loop will never > advance to the next vma and it will keep looping for ever without a way > to get out of the kernel. > > It seems this has been broken since introduced. Nobody has noticed > because nobody seems to be using MADVISE_WILLNEED on these DAX mappings. > > Fixes: fe77ba6f4f97 ("[PATCH] xip: madvice/fadvice: execute in place") > Cc: stable > " > >> Signed-off-by: chenjie >> Signed-off-by: guoxuenan > > Other than that > Acked-by: Michal Hocko > >> --- >> mm/madvise.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/mm/madvise.c b/mm/madvise.c >> index 375cf32..751e97a 100644 >> --- a/mm/madvise.c >> +++ b/mm/madvise.c >> @@ -276,15 +276,14 @@ static long madvise_willneed(struct vm_area_struct *vma, >> { >> struct file *file = vma->vm_file; >> >> + *prev = vma; >> #ifdef CONFIG_SWAP >> if (!file) { >> - *prev = vma; >> force_swapin_readahead(vma, start, end); >> return 0; >> } >> >> if (shmem_mapping(file->f_mapping)) { >> - *prev = vma; >> force_shm_swapin_readahead(vma, start, end, >> file->f_mapping); >> return 0; >> @@ -299,7 +298,6 @@ static long madvise_willneed(struct vm_area_struct *vma, >> return 0; >> } >> >> - *prev = vma; >> start = ((start - vma->vm_start) >> PAGE_SHIFT) + vma->vm_pgoff; >> if (end > vma->vm_end) >> end = vma->vm_end; >> -- >> 2.9.5 >> > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org