From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6538C61DA4 for ; Thu, 9 Mar 2023 09:47:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3BB91280002; Thu, 9 Mar 2023 04:47:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 36BA26B0075; Thu, 9 Mar 2023 04:47:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 20BEA280002; Thu, 9 Mar 2023 04:47:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0EB946B0072 for ; Thu, 9 Mar 2023 04:47:50 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id CE8EDA0569 for ; Thu, 9 Mar 2023 09:47:49 +0000 (UTC) X-FDA: 80548883058.03.83C4195 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf23.hostedemail.com (Postfix) with ESMTP id CEE0D140003 for ; Thu, 9 Mar 2023 09:47:47 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=pMLfsmab; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="Ep2QN6M/"; spf=pass (imf23.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678355268; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mfyXvrHWZozVXtRW0kcNSJ66/sHe/spEA4DDBYt+QOg=; b=alCFDAFQcDO1f3GWy55JdF0Ar8nqk4RnxLOSWbY11bL9+Z1se0wfxXk68CGiyTcQIuuzh/ cN3o7ANeD0Mqh7ewgTjy1/IZ5zSdMPWxXi8m5SvsFlQHmDAsgD9Vh0/i+ZZB6aWnjZtDNz /rPJgESmHuFpTJ+XCczhZYBvJb+om+Q= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=pMLfsmab; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="Ep2QN6M/"; spf=pass (imf23.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678355268; a=rsa-sha256; cv=none; b=Hn8FYggThAYiPYY7doEDNWuQrTMN4CfnzPck4RrSH93A7GrYSW2faCYAYaoy89T4t9Xlkn jdQ7rxovOD3QItJa7OO2O4xJva6zpwmA4nBH+qbLkvxy61QVhT7iEsMGdjlkWQaWAvwNTt pBF1a0Up0mDV1mbz4RNPjp8qe+l9Qrc= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B08A221AA7; Thu, 9 Mar 2023 09:47:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1678355266; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mfyXvrHWZozVXtRW0kcNSJ66/sHe/spEA4DDBYt+QOg=; b=pMLfsmabn9VFam7HtxAw/YV2w/Qw9WzeVtGGvxnUxmy9E2KYf4oPXDucX+sqaQqA8Inztj Q+KwuCIGTmH+BRqKOzNP/cfUs3nO83nt79EwBnQOYAmvwudRwQYNJ8j2BRG1+s8KKCxKrq 3hzjopitpuhjTk7bqAsj2EwQmuGYaNA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1678355266; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mfyXvrHWZozVXtRW0kcNSJ66/sHe/spEA4DDBYt+QOg=; b=Ep2QN6M/Uyuq1BU6aBkDHZF3C4YJCVLDAbouu6f/cjWapkjZOZjzIb1u7HqnpRZzgNIPkr R6l73cuSfXIBkhDA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 858941391B; Thu, 9 Mar 2023 09:47:46 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id FbowH0KrCWTKGAAAMHmgww (envelope-from ); Thu, 09 Mar 2023 09:47:46 +0000 Message-ID: <17e2a143-37eb-fb4e-d8a9-2d6dc20f9499@suse.cz> Date: Thu, 9 Mar 2023 10:47:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH V3 1/2] mm: compaction: move compact_memory sysctl to its own file Content-Language: en-US To: ye.xingchen@zte.com.cn, mcgrof@kernel.org Cc: keescook@chromium.org, yzaikin@google.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, chi.minghao@zte.com.cn References: <202303091144483856804@zte.com.cn> From: Vlastimil Babka In-Reply-To: <202303091144483856804@zte.com.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: CEE0D140003 X-Rspam-User: X-Stat-Signature: t5sywttqxd6ra6ym78ebrspuwz81zwb9 X-HE-Tag: 1678355267-58859 X-HE-Meta: U2FsdGVkX1/wRClWC0LHxkoYWOAChkSQanOW4u9WSYwJ8R4zLTwTZrUKnrPWC5rE+QfVfUYaIQYZVM9//RVCq/q3YoHihXpiTys7yV1mNuz2UslVK+eLj4YPDtbWj6MJLuXtT8B+dPjI249OC/PT84cA1NAdAVdb1wkhBI1dMnnWgfuGkA7UhppX6KYppgAqbNDifJbzAwiDHHiYC0rs9/udL3zzWc5PAHcyNDoxZu+L2uQHHNPdjJ1HGyQTdzPEri7HcFAe++W1NG8/4cu5eGNgV0afH1dSS7S6302MoiEoHdXzN78jX0fXNx16L5vktb5a2fZz5V1+yKlHQAz1fvySuyRz6q/lY1YihzGd0g5oaMDC+5qTF6LjAPDOE987WNo7SOwMTKgst8kPawyQm3c3FqHPXl/FbI8ZNPREqZR56L4hth8wJ3tyKBifHwzo0VNXD+VDws5lf7rQZkWeL5sZxqt/KkVQWO951iJ/1k5zRnxbngJf0PZ4thPqm0OX/8Rh3+hfMuVijkvAt39BKnKhpikxbhTrBuVUlooGqq5uq+sp1DAwU8FJW63dmFtcf7Th+jGLxN1ONf+Vz2wwesWZLorFYgko52DLY3JAaAM0xp+cR9kVv5xIZD0FfT0HE+I//p1INw1z8aWbYfykpyJiXSmbOQc5K7qBMdeZfBq06gq0zIoDSu+FELvv6ObiHJVdmgGk2yNTwl2lwqXl3ef5cRxmK9DOHPEDnhF36XU3lXN+ICOsoCIf+Jt4dw6fxMTxbdiRl4AMwjXUzaFUH08ZfXsrOduEgFOrI9/5ZBGsZVyMbqnLsA/4ONjr9rIjayIIbkKLnwT6r2jZ56yT1Kf3mBYsYXIz5945eBiBWHEpgipzayiB5elbcKbx7IJnyLZqcuKLtVVjoShb1MvviRilEtU3ih7Zxqj3+AZDdyoTWWdpxJDgl9iPl7Nrkg2x9Ax7LVhD6bN7G7goGls JT1jWtBS mgjIkLuqFBoxE28PLi+DDkfvJU045rFbadhKY8yDVc6OVZ1BekdJ6LodH8HJAiIwXAp/akHk6TaBxngDH+SjFFmn4PHaZWHY1ebblzd68XRfSDuxA7s8kxJVn/3kfAi0NUXEr7RaeTd24mYMR+IRKe5Gwxr3w1y1aOnaY0p+ORFozQss1bsrRq9gjdf3YwU73jpXTurejHJ6VR0DfVXa+9CIHPjgteod/eHm/+NTViUnUl0GrXMKzEeiJKTxeDax85QxjVs6f562/putyNpZVWwpjy0f3yHHL67uGKcDlQeNA+N6BsD61SkgdjrC+ptNg+2i+AcoOYtSDjCIxxDEqh7NjgmzonQB+qPht8stKfPrc+2u7XK9izVl7JxfUgusk8wqjctY08ItrL9biJ8dxx+fZK4LSvOIPd1tPTxZPtjTGe967y/tAy2jxBw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/9/23 04:44, ye.xingchen@zte.com.cn wrote: > From: Minghao Chi > > The compact_memory is part of compaction, move it to its own file. > > Link: https://lore.kernel.org/all/ZAJwoXJCzfk1WIBx@bombadil.infradead.org/ > Signed-off-by: Minghao Chi > Signed-off-by: Ye Xingchen > --- > kernel/sysctl.c | 7 ------- > mm/compaction.c | 15 +++++++++++++++ > 2 files changed, 15 insertions(+), 7 deletions(-) > > diff --git a/kernel/sysctl.c b/kernel/sysctl.c > index c14552a662ae..f574f9985df4 100644 > --- a/kernel/sysctl.c > +++ b/kernel/sysctl.c > @@ -2190,13 +2190,6 @@ static struct ctl_table vm_table[] = { > .extra2 = SYSCTL_FOUR, > }, > #ifdef CONFIG_COMPACTION > - { > - .procname = "compact_memory", > - .data = NULL, > - .maxlen = sizeof(int), > - .mode = 0200, > - .proc_handler = sysctl_compaction_handler, > - }, > { > .procname = "compaction_proactiveness", > .data = &sysctl_compaction_proactiveness, There's also this one, and two more, please move all of them at once? > diff --git a/mm/compaction.c b/mm/compaction.c > index 5a9501e0ae01..acbda28c11f4 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -2763,6 +2763,18 @@ int compaction_proactiveness_sysctl_handler(struct ctl_table *table, int write, > return 0; > } > > +#ifdef CONFIG_SYSCTL > +static struct ctl_table vm_compact_memory[] = { > + { > + .procname = "compact_memory", > + .data = NULL, > + .maxlen = sizeof(int), > + .mode = 0200, > + .proc_handler = sysctl_compaction_handler, > + }, > + { } > +}; > +#endif > /* > * This is the entry point for compacting all nodes via > * /proc/sys/vm/compact_memory > @@ -3078,6 +3090,9 @@ static int __init kcompactd_init(void) > > for_each_node_state(nid, N_MEMORY) > kcompactd_run(nid); > +#ifdef CONFIG_SYSCTL > + register_sysctl_init("vm", vm_compact_memory); > +#endif > return 0; > } > subsys_initcall(kcompactd_init)