From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D570C433EF for ; Sun, 3 Jul 2022 14:06:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 859276B0072; Sun, 3 Jul 2022 10:06:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7E2436B0073; Sun, 3 Jul 2022 10:06:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 683446B0074; Sun, 3 Jul 2022 10:06:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 519186B0072 for ; Sun, 3 Jul 2022 10:06:36 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 1E10780527 for ; Sun, 3 Jul 2022 14:06:36 +0000 (UTC) X-FDA: 79645963992.06.EE32AB4 Received: from out30-54.freemail.mail.aliyun.com (out30-54.freemail.mail.aliyun.com [115.124.30.54]) by imf10.hostedemail.com (Postfix) with ESMTP id 8A1E4C0061 for ; Sun, 3 Jul 2022 14:06:34 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R141e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045168;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=5;SR=0;TI=SMTPD_---0VIBhorZ_1656857188; Received: from 30.0.187.160(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0VIBhorZ_1656857188) by smtp.aliyun-inc.com; Sun, 03 Jul 2022 22:06:28 +0800 Message-ID: <17df0d3c-caaf-ee34-f702-1d4e7674887f@linux.alibaba.com> Date: Sun, 3 Jul 2022 22:06:32 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [RFC PATCH v3 2/3] mm: Add PUD level pagetable account To: Matthew Wilcox Cc: Mike Rapoport , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <6a6a768634b9ce8537154264e35e6a66a79b6ca8.1656586863.git.baolin.wang@linux.alibaba.com> <1234a28a-dca0-5836-9066-4ab2d4fbcc95@linux.alibaba.com> From: Baolin Wang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656857195; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MfLE4wxR1mBhBThEkpsXrNTHeBzxh8aFOwYSOM4aiT0=; b=hATc5NGLoCJ0yM7Z93/xG34z49RI3hoVxsC9y2noaDowJhQLDPJdPWRb7gnYRvd4JHGSgr RYhNbSlQcQCrsekmaZa3vu3b5vJfmeH6Ebc49lwKaDy7RF9vFtlG9m7VPGQxRU6uNha/G4 PhNx1Ay/FhPxAMTNPPKyOyu0FjsBaLo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656857195; a=rsa-sha256; cv=none; b=jybDCrcKZr98lVKd1wmPceFqfRtb4iZg2JL6z4xlILFlgVL9jJHG7iYXKJSPove6WpFjjC JA0iMoAIEpTmzkjySSuhKRsLks0RGS+HFc5mfVIVZbgsCATH6+Um53HiLqsncFfywAnMTm EzsiZ64Y2x7XN+wZL2KykemfqihC6sg= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=none; spf=pass (imf10.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.54 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com X-Stat-Signature: dyik1jpc1ezj3onw61oxwejha4b3mgpt X-Rspam-User: Authentication-Results: imf10.hostedemail.com; dkim=none; spf=pass (imf10.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.54 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 8A1E4C0061 X-HE-Tag: 1656857194-531007 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/3/2022 11:40 AM, Matthew Wilcox wrote: > On Fri, Jul 01, 2022 at 04:04:21PM +0800, Baolin Wang wrote: >>> Using pgtable_pud_page_ctor() and pgtable_pud_page_dtor() would be >>> consistent with what we currently have for PTEs and PMDs. >>> >>> This applies to all the additions of pgtable_page_dec() and >>> pgtable_page_inc(). >> >> OK. I can add pgtable_pud_page_ctor() and pgtable_pud_page_dtor() helpers to >> keep consistent, which are just wrappers of pgtable_page_inc() and >> pgtable_page_dec(). > > I think you misunderstand Mike. > > Don't add pgtable_page_inc() and pgtable_page_dec(). Just add > pgtable_pud_page_ctor() and pgtable_pud_page_dtor(). At least, that > was what I said last time yo uposted these patches. My concern is that I need another helpers for kernel page table allocation helpers, if only adding pgtable_pud_page_ctor() and pgtable_pud_page_dtor() like below: static inline void pgtable_pud_page_ctor(struct page *page) { __SetPageTable(page); inc_lruvec_page_state(page, NR_PAGETABLE); } static inline void pgtable_pud_page_dtor(struct page *page) { __ClearPageTable(page); dec_lruvec_page_state(page, NR_PAGETABLE); } So for kernel pte page table allocation, I need another similar helpers like below. However they do the samething with pgtable_pud_page_ctor/pgtable_pud_page_dtor, so I am not sure this is good for adding these duplicate code. static inline void pgtable_kernel_pte_page_ctor(struct page *page) { __SetPageTable(page); inc_lruvec_page_state(page, NR_PAGETABLE); } static inline void pgtable_kernel_pte_page_dtor(struct page *page) { __ClearPageTable(page); dec_lruvec_page_state(page, NR_PAGETABLE); } Instead adding a common helpers seems more readable to me, which can also simplify original pgtable_pmd_page_dtor()/pgtable_pmd_page_ctor(). Something like below. static inline void pgtable_page_inc(struct page *page) { __SetPageTable(page); inc_lruvec_page_state(page, NR_PAGETABLE); } static inline void pgtable_page_dec(struct page *page) { __ClearPageTable(page); dec_lruvec_page_state(page, NR_PAGETABLE); } static inline void pgtable_pud_page_ctor(struct page *page) { pgtable_page_inc(page); } static inline void pgtable_pud_page_dtor(struct page *page) { pgtable_page_dec(page); } For kernel pte page table, we can just use pgtable_page_inc/pgtable_page_dec(), or adding pgtable_kernel_pte_page_ctor/pgtable_kernel_pte_page_dtor, which just wrappers of pgtable_page_inc() and pgtable_page_dec(). Matthew and Mike, how do you think? Thanks.