From: Johannes Berg <johannes@sipsolutions.net>
To: Kees Cook <keescook@chromium.org>, Kalle Valo <kvalo@kernel.org>
Cc: kernel test robot <lkp@intel.com>,
kbuild-all@lists.01.org,
Linux Memory Management List <linux-mm@kvack.org>,
linux-wireless@vger.kernel.org
Subject: Re: [linux-next:master 3615/4301] include/linux/compiler_types.h:335:45: error: call to '__compiletime_assert_314' declared with attribute error: BUILD_BUG_ON failed: sizeof(txpd->tx_dest_addr) != ETH_ALEN
Date: Wed, 01 Dec 2021 18:29:49 +0100 [thread overview]
Message-ID: <17ccfc4f9f9e74e1d6b48366a87cbcf887521dab.camel@sipsolutions.net> (raw)
In-Reply-To: <202112010840.0AD4D41162@keescook>
On Wed, 2021-12-01 at 08:41 -0800, Kees Cook wrote:
>
> > > drivers/net/wireless/marvell/libertas/tx.c:116:9: note: in expansion of macro 'BUILD_BUG_ON'
> > > 116 | BUILD_BUG_ON(sizeof(txpd->tx_dest_addr) != ETH_ALEN);
> > > | ^~~~~~~~~~~~
> >
> > Kees, can you take a look at this build error? You added the
> > BUILD_BUG_ON(), right?
>
> I will investigate! Given this doesn't happen on allmodconfig but
> a randconfig trips it, this might be finding a legit issue, but I'll
> report back more details.
>
It's probably some alignment thing - note it happened on a specific ARM
with a specific compiler?
But there's not really a good reason to even have the struct_group here,
we only use it as if it was
u8 tx_dest_addr[ETH_ALEN];
anyway?
johannes
next prev parent reply other threads:[~2021-12-01 17:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-30 13:21 kernel test robot
2021-12-01 7:43 ` Kalle Valo
2021-12-01 16:41 ` Kees Cook
2021-12-01 17:29 ` Johannes Berg [this message]
2021-12-01 19:04 ` Kees Cook
2021-12-01 19:37 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17ccfc4f9f9e74e1d6b48366a87cbcf887521dab.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=kbuild-all@lists.01.org \
--cc=keescook@chromium.org \
--cc=kvalo@kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox