From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 36CC4CA1013 for ; Fri, 19 Sep 2025 05:10:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8F7258E0068; Fri, 19 Sep 2025 01:10:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 880858E0008; Fri, 19 Sep 2025 01:10:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6D3068E0068; Fri, 19 Sep 2025 01:10:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 53DCD8E0008 for ; Fri, 19 Sep 2025 01:10:47 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id E393E140415 for ; Fri, 19 Sep 2025 05:10:46 +0000 (UTC) X-FDA: 83904824892.28.652046F Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf29.hostedemail.com (Postfix) with ESMTP id 68330120006 for ; Fri, 19 Sep 2025 05:10:43 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2025-04-25 header.b=rlXXHpSP; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=PjDVnyqJ; spf=pass (imf29.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1758258643; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aWfh/j1hhKwhq2JXagnZPhERwMR1IqTqWOMO9u+TSDg=; b=BMLF3pT0TuvslzQ6x2F9jLBI7STCNLjYriy9HdJxb8YQSCJak2y3j/C9oWYAtW3Q+KCmAV NGuJ0Io2/f1aNnmbGVkw3L2MhS5X7UxaA8LgIVkSXYHkM4DQYEy52DaxRfvP+t93AeS8kU XkTd6eJsJwLP5MVliaksx2V5kEhKXoQ= ARC-Authentication-Results: i=2; imf29.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2025-04-25 header.b=rlXXHpSP; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=PjDVnyqJ; spf=pass (imf29.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1758258643; a=rsa-sha256; cv=pass; b=SNGI5GFjhdx4BsFhH4sqBjkStCRHYpXrhgPxIUJXOKbIzw4l0MnqJtizXU/oievZcsD8oz JNAiLeL0KKPQoPAe2n+Ewal788njUdRRlNZ+DmYypIMVoL++/htsuf0FIaG5dCrO9H3G1J OOEH6E17k9Avlqtq4CfMq3XzbCMKd5U= Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 58ILFVRZ004759; Fri, 19 Sep 2025 05:10:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2025-04-25; bh=aWfh/j1hhKwhq2JXag nZPhERwMR1IqTqWOMO9u+TSDg=; b=rlXXHpSPkkBtXr8gOSmYzMY4Oqd1ki/+Nw rYTNS5svyr+/jUL5KMyO9SVOKRsoiA+mr6flXctDKCJ1DLloZVjDmB3JqRexLsUI A80basghfFjS3n7SJ6D1fW9Z3LHDmoGuvW1cpuGq2TL2wnT2uznqHGNhQEOxd1lo I34VX3gKdO7rcxy3H98HbCJZ9VnwBxHWjmpXWcfdJmScMIrctWgt72kXmloKnl+r 4xaG9Y4b3MFGLdBFB7OGUvR1KfS+c4DG2I4AyxLOikyLrTIAdw2wY/6gVjcbXNif XoB3UIauAx906kOoma7budsiC+mwlpq9gicbLQdvIsMz/auNwwWg== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 497fxd4u12-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 19 Sep 2025 05:10:20 +0000 (GMT) Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 58J31PUV035255; Fri, 19 Sep 2025 05:10:19 GMT Received: from co1pr03cu002.outbound.protection.outlook.com (mail-westus2azon11010068.outbound.protection.outlook.com [52.101.46.68]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 494y2pbsm7-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 19 Sep 2025 05:10:19 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=lJjhttsveew9lXZV5CERZ+KffX5FMz9cQxyAJdiTOUDwowCZrmDEpkpvxMmh679Ea0x5yiYeUrRCky6xYyZ3ZgSW1rhs0rLjTEArpMeoy64pmoJFvTXkFFT0uUKNZJq8g41N5Rm4QxZXXi1hft9zrDDwvbm3nqI3domzeXaiHyDRye28Ds+a6C5LMc8SNuSkgfzxJhkUH1H820695Jr9/irl6P2+NToqbxiageeat8eDHTJaKklxanNWsTL5ZmOue5JUe3qHJVdlFsFCTHKre9jXjL6EzSnxj4+bNDG9EiF34OxEdmiES9SYyq9lxCXMTQxQu2Akzjb3Cl/KpX7vfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aWfh/j1hhKwhq2JXagnZPhERwMR1IqTqWOMO9u+TSDg=; b=tvCdkN2gh+bpnVJ7QrlAhrOwEfglOnmfBLIVbIxX5BvepvBPKm5OBye5tBBWssMG0xzzcWF3M1ocvgQN02S33GKaf7RwbXrE1So2sH6/dmUL49o3c9VtyHjmMGsA9LDN/jjdxZ/Ma0568Ng5Nq11vveVDDuD22NsqucNOBlpKsR7131uwCak8U5YdyLC/ijppwbNCcH/xWNpMjg14HCJVp8RbaAu8gUYfifwj534Xju8jBGib3pMdObLZHbBg1jL4igCAwzYPkmfvGGR++cW/lA0dvx3kWb/pgKQHtMzGDRU3V75CrTC91iRcsCePcBAL0vltdkjlaogpf0AxWfCFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aWfh/j1hhKwhq2JXagnZPhERwMR1IqTqWOMO9u+TSDg=; b=PjDVnyqJgVy/ZUZOQr/nK+hOVawxdcCs8O4whut8kqHkq/K6qbD4tiXTrhtP3ABqx4T1GiMtFegn2Ei5hEry8J4QRRdvZd6V0JGuE3upu0wIYWFDJC/D9mAipsQNgKXLFTq8t/V7+PdRKIG9QUMjMD8u7Tb4KIA/K3XXR/tKx9s= Received: from DM4PR10MB8218.namprd10.prod.outlook.com (2603:10b6:8:1cc::16) by MN2PR10MB4333.namprd10.prod.outlook.com (2603:10b6:208:199::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9137.13; Fri, 19 Sep 2025 05:10:14 +0000 Received: from DM4PR10MB8218.namprd10.prod.outlook.com ([fe80::2650:55cf:2816:5f2]) by DM4PR10MB8218.namprd10.prod.outlook.com ([fe80::2650:55cf:2816:5f2%2]) with mapi id 15.20.9137.012; Fri, 19 Sep 2025 05:10:14 +0000 Date: Fri, 19 Sep 2025 06:10:12 +0100 From: Lorenzo Stoakes To: Chris Mason Cc: Andrew Morton , Matthew Wilcox , Guo Ren , Thomas Bogendoerfer , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , "David S . Miller" , Andreas Larsson , Arnd Bergmann , Greg Kroah-Hartman , Dan Williams , Vishal Verma , Dave Jiang , Nicolas Pitre , Muchun Song , Oscar Salvador , David Hildenbrand , Konstantin Komarov , Baoquan He , Vivek Goyal , Dave Young , Tony Luck , Reinette Chatre , Dave Martin , James Morse , Alexander Viro , Christian Brauner , Jan Kara , "Liam R . Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Hugh Dickins , Baolin Wang , Uladzislau Rezki , Dmitry Vyukov , Andrey Konovalov , Jann Horn , Pedro Falcato , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-csky@vger.kernel.org, linux-mips@vger.kernel.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-mm@kvack.org, ntfs3@lists.linux.dev, kexec@lists.infradead.org, kasan-dev@googlegroups.com, Jason Gunthorpe Subject: Re: [PATCH v2 16/16] kcov: update kcov to use mmap_prepare Message-ID: <17bef9e0-575f-4ced-9884-3fd5a8f77067@lucifer.local> References: <5b1ab8ef7065093884fc9af15364b48c0a02599a.1757534913.git.lorenzo.stoakes@oracle.com> <20250918194556.3814405-1-clm@meta.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250918194556.3814405-1-clm@meta.com> X-ClientProxiedBy: LO4P123CA0685.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:37b::8) To DM4PR10MB8218.namprd10.prod.outlook.com (2603:10b6:8:1cc::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR10MB8218:EE_|MN2PR10MB4333:EE_ X-MS-Office365-Filtering-Correlation-Id: 337628fc-9ef8-4431-b493-08ddf73ad134 X-LD-Processed: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|7416014|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?/iIi/0qLwcmovAoZZ/f8BF+lliI56VQnYyS90qR/hr+tVloEtE3A0lTZE1IA?= =?us-ascii?Q?gT+ZKE6NJd7aj98zmGkYdlbsgOsnTT81qrE4blzLG10pYSzd2fkmqtndzLXu?= =?us-ascii?Q?nXHZ5gRBCoz+Too/mu2wsS6JISlt1Owq7LjYZU9I9t4GNZ8EKty7sku+L5dK?= =?us-ascii?Q?eoRXkqrl5aR54NpYcTlLW8EEHtB+sLmSDlT5izosJh30gP8wQab29G/F9hv9?= =?us-ascii?Q?n33ex8Pvnvo08vM5f/jG7L+9kpQ3KadJKs1aisu7oHDGx2UXp65vgCZv0XxG?= =?us-ascii?Q?GPcN8OsLWzLluUGVFQWjsA7QFfKLudC8H2NJ+uKiN/HQr+hVrrm6ic9vEb3s?= =?us-ascii?Q?IhqLrEBsoyrYMAFAIQG/ZUneMldSSZYHOf1aqSTMuB0AwHMtQg+heSwZBJxY?= =?us-ascii?Q?c6jKQd26FDfJiuRNlk3WyRLlKdlVzQ3eEtS8i2iiaVjHbOw2LSPtNIsTwrRU?= =?us-ascii?Q?u3BNFKBZrrzTCds6dUKRv11IbHf5cQV+HAU20OEtuVafv1ZrR0ky+jU3ccbz?= =?us-ascii?Q?/0/eHaJ7/fAO2bbuv/ZPyqnzWvgWoPZ/AEib6U5mqINrGYmTJRfTX/ujfV1T?= =?us-ascii?Q?6ri2JtcEejZkEqzTUsPeLVS10REhAKD3kpbJyuVWQRh2FyBYULMFlwb8uV7C?= =?us-ascii?Q?qo+2GE0tooytm6nLPOZBTxtqQYSgTJ217KffhxAwIuBn8TAxDonMuRliOm+W?= =?us-ascii?Q?KSM6ryOI0joaBmlUEFx/jdBdMQCs8EU4WOzRTofU7OShmCwqkxKBFOTmq6OG?= =?us-ascii?Q?kGANaUbQDCI4e0cEmYIYUqgc6BaRCQaPlKUAdyMS4q7SZLKUdYqFuMWDpPBM?= =?us-ascii?Q?dbHigjGqkAbwIA+HTmyBcgbaGwRC8xO+m+GA7wOOWQ9f9exb8nIukenZ93UC?= =?us-ascii?Q?9M0Ar/ODq9/iK1hNjOU227C3E3PAry+E6aP79tY1nXGLWKjpS3hFnxeANhoe?= =?us-ascii?Q?nyGy9zdnUIG1/4Pe7nq5XcuPc++LMtuut7PNbr50KsyP9NNytWn/C8MstnOB?= =?us-ascii?Q?amFTWtvsuO7Xw9hKZMFl1AjJY+k+citmyEKXwRxt+0JXajYgM2RQ4myN0MF9?= =?us-ascii?Q?BANXtFLkE0N4FIXCK6gtNSjj3L7dUFsZcF//NVowH+MEtsJb88/eTlXKnmWu?= =?us-ascii?Q?VUJSrdJ2fh1eojMv/OkOg8uzZ+cn/x8tHcjMvheX10TVJjjpP+VstrZgTAMj?= =?us-ascii?Q?zK7cV8qi1HmMadqNM5cXKdXphn9eG6xuuesxB/ZtrxQiwfx+/W13nDpvc135?= =?us-ascii?Q?I+ZiBaOYZdjzf+iie4LqYGvDEKH4zZeFdMJ/RosSX5i4SqDW//mKshMC4pBh?= =?us-ascii?Q?ZZaMMzmLdxUzs9iW4rbIuFU5OgiMZL+YLoTuz8XwnJ0z37DlY3ZJjbdls99l?= =?us-ascii?Q?q3+kDOQ=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR10MB8218.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(7416014)(376014)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Usb3VIbr3ciiLKdOpT5HNGN9rHkXtBIE+07S66RxDIaHixPCqV7r1hnOcggp?= =?us-ascii?Q?21nMfOdf+tMnJiqiB2j1N3gX1dAc8V4HyVmCXbqJs7eTKm3YZ+1gylFkWXCS?= =?us-ascii?Q?2niko9Cd+O2IFXXDR0wnoPkZCncB/HM0bOE9ozMyLR/zFO/31YaHJRbxsWB2?= =?us-ascii?Q?jY9a0rPCvvOR6sF2pNexGc7Dw8vHbWqswyUkDTkyAZbG7caV5bfOKMqK4jL0?= =?us-ascii?Q?/3XA2IRCF8uEwT5AIb5/qU3QvZ/Jm+kfMqwo5vMmrWx5iwOJlyEbAAMmBzXS?= =?us-ascii?Q?KbCcPGqtfbzUsb9kYUFaNfLftt8xWoK75anH50f94NYNioSCgoHGIOm1jcV/?= =?us-ascii?Q?Tn9X3aZvAWhDMnlLg0Oh7/CWAi+3rUH1sGOHZkFs8FO+Mxd8zUhppuLV7Stp?= =?us-ascii?Q?bEBtpF14yZsqRItJ1BhWoExYY4bmyzO3AsbRZTCuCrfU+YzwiYSCgEy51XnR?= =?us-ascii?Q?MEGhyjFbWGahshI7vgkBTpSSLCgwwSEnqiZXo1iuVFP0XVOS6pwLwGUcrNkd?= =?us-ascii?Q?0KIFOqpXSQPNePE/JWDI/wq3OtAhqdtOlvFfRoA63JUkQTE2AcwX4iOOMime?= =?us-ascii?Q?ibzredJMra+sMqWW+neZx5SqFBKxyokhYpT3jEa0AfKupNukZ5jbNWmjEyTR?= =?us-ascii?Q?abUgunrgH9f899eZBBawS/QBW/YuvjviRh1xAxgy18FZBFTEcAoh9jNduhAv?= =?us-ascii?Q?MWyQQglmYbtMw8s7zpM+ns1vEoKUwhP4sUZb2sOGiVlg+niTuTbRRIAq8jV1?= =?us-ascii?Q?rd40o3m7cdYUhnaZeWqpoI1IZo81QKq8rr7KUlDBeFK4kKm+GlhG1Nfn3Dos?= =?us-ascii?Q?m1adKzl+Vbkfb8vLO2tCyv2AoG+2CSyJQ2IPHuiSCoeKBS/G/AeIxBfH+42j?= =?us-ascii?Q?xxgzeq9gzS/b3vmNABIROdW2QpeMam1HFogX+/tj/7eEKPzG/ks46Kt+tKE9?= =?us-ascii?Q?N3ZS8SAT2XCgs9N4u1/w2KGvIV/rtJ8FycpbVUODof2nZ0rLaeHdp6gk2LeX?= =?us-ascii?Q?AIolYGLYMKTqOxK7h4TZX6RAdUcfV2H76lt/KWidCZ0YljJ7BqNYPMdCfMks?= =?us-ascii?Q?YKab42BPdHddMBN/+XmO/EHcnNItJZef/U/BxiBVBdXtyXs1LslXGo+tYvN5?= =?us-ascii?Q?849qUWu6fQ/YI79X0l9QXnY7Rk/6TFrzD2og3e3fjo0tZn3zdhgR924MCYkf?= =?us-ascii?Q?SfIclPZLtRaVL+u26dK9o2Veq6XfSjv/j2oIOYrWAhfzAY6y910361PhIPjm?= =?us-ascii?Q?z7LgiKVL+kpX5fORvo9TFvcwoZr/Eo5CqEwdJRGjXszL7Ygsw5B820IdS0wp?= =?us-ascii?Q?k8FDlEO1He/gY7r9JJqnqJkQmp4VOIjP8iF1Obsnd8YJg87odUEFIJAKFFrE?= =?us-ascii?Q?AZiQtEA5T1ycUI7wmSiz8QShud6VQZ+A5aZEHvgMP9iXpmNag8jI2UQNDrP7?= =?us-ascii?Q?cWchCvTAGpnbbNUSuzax8A7k47BxZKtOYcGWvKJK8L9Q4RHc4G9cTKBsJEju?= =?us-ascii?Q?qi3r5AbVG/pmrg5MP5ORgPXiINAM1kTlZGE10WJsTRxDfmXL2Vig1k6Y6KQz?= =?us-ascii?Q?2uZ1gUIewknJlyCVjd8eMsdJRl2maVkZftJBPHt6iPQEuj8ySMJjnWVdckdF?= =?us-ascii?Q?gg=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: YtCEfLcHvs59JJpIjX0O4QJivziSZkKTQuKsAqt75ECQ6WI/dlQiFiFNxYtkTYIYak+jpOfSDcByUVpiwAKz9gTzROiykMXWp4LxcqjmZQIo5Koc9Hqg5DfRf9lXY6aoLACq5twU5gjtShSxniHELOrijuv63T5hPjM1gD1+hA5dw2fOXHrvMQsED8CStPnmlUS4B8P3kJtjDsEiePmHCkISzc1tJ5gB35A0x8cA5ulQCU+s6vbDzUsVrL5JUby1xeU54i7OXT1osoVWUaMZlNhceSoet21CI/BFQZIlgnPqh3wCLeEIZf9WoFYMN0SuNqAkQGkORweU/96xWsWg8I+KbjQ0ofTTsXG7CzhK2ya0L8UAdtE4WMswHOMeMWha2VF9JdLt2a8a+HmjAvsFl0LILixvJ1TdXxbG5a4WAVqQxiIsWZZFHJve0rtogCSSx0nGYsGiGPTk6YqCiNhOiftqaHyVw+7Tn8KsJMhqEFkH1HH7Hxs3r60cbe1fuxfYAvcKLqfsOfF/qyafgL60hnqV2PeLMyvmKO8cNIdU/EGWuqakIDJ7R5bCJlS3TuDMzHuA9D0/qivBOAbMLrVbraDil4G1PTIgMtTA1r0fa2Y= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 337628fc-9ef8-4431-b493-08ddf73ad134 X-MS-Exchange-CrossTenant-AuthSource: DM4PR10MB8218.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Sep 2025 05:10:14.7467 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XjG8PHHbB+lfNlLNwQKtsMl1VDQeHgG8u8GP78D8w/BGbLVwfEoKYfdVwarR85AxUaezHjZ2F35bBLL/huzp11MCW5fN6DrNzNmU34g3DyU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB4333 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-18_03,2025-09-18_02,2025-03-28_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 malwarescore=0 mlxscore=0 adultscore=0 bulkscore=0 suspectscore=0 mlxlogscore=999 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2508110000 definitions=main-2509190043 X-Proofpoint-GUID: yJSw5CDOWio5EANrUzoBrm0X4Zi-0BT0 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTE2MDIwMiBTYWx0ZWRfX9qCkfflg9yFz ODwnczr9G3Rb16QUuBEok5Nild8Wl1pEjVgbetb3w+I6T5NfGfwhHtPcZrro4hBYa4G41xszTZO epPDd9mTTmjlxprywB6AtOQw+zoUvjXa4vpqbTu4WX0ONa227TzCBF4NqnlEPKt8r7BPK4ej6ZE ck6Iz3N40YLgXwrn3gvh4L2Yqiqm0IzeBq23edFEubY5d+xT6WyNzKKtUiJUoSj04XwknKfFpaW PI82F+Vaiy1xwlT1BH5c55Ml0jFPjarD2KoZHobjHCT01LyC49EHZdT4BECgNGd1+FxWDft5FQk h0D6lybn9s4Ts+f4QuxDtt2/pTdOC4ZfbmPv+45orUnLcOYFMsXs+cTj+xzDgKbF+X7WU6VI2QP mMg/wc/QHkE2AyIic83nr4LAEbvmRA== X-Authority-Analysis: v=2.4 cv=cerSrmDM c=1 sm=1 tr=0 ts=68cce5bc b=1 cx=c_pps a=e1sVV491RgrpLwSTMOnk8w==:117 a=e1sVV491RgrpLwSTMOnk8w==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=kj9zAlcOel0A:10 a=yJojWOMRYYMA:10 a=GoEa3M9JfhUA:10 a=VwQbUJbxAAAA:8 a=yPCof4ZbAAAA:8 a=GBp2PlFQoT0y_MyTeIIA:9 a=CjuIK1q_8ugA:10 cc=ntf awl=host:13614 X-Proofpoint-ORIG-GUID: yJSw5CDOWio5EANrUzoBrm0X4Zi-0BT0 X-Stat-Signature: 1j883m96buz1ir63o6qoz9x57hu9oy6d X-Rspam-User: X-Rspamd-Queue-Id: 68330120006 X-Rspamd-Server: rspam04 X-HE-Tag: 1758258643-328546 X-HE-Meta: U2FsdGVkX1/ybOfVoDkOxfT+BqJnHclW14o+cfx4nHd1NCs6UsnSMkLnxcmLVcdFn7JDpMTJWuEFRPi5j2HNSd5uYMnQM5qqLh/w5CIhLfRpwAMw5ECt3+V3ba2mjEOOxe4khdKZPbU4qUQJiirnPS9rEwEYC62knV8MSH8/6xsdDzskcMC2WqJPuo4YwJINN/+dNTdqwI2yNupxXHJYBIMqK7BkorTea6CRdvbGEY341cbUeB/PY/tbSgn0TwEbHc+0z32ZLbVrIMHAtC8xL6LV4Vn/6lC3kVey2VYtAYu4iNhvIeqC/K4fknd7iPsqtki8nrFLBSW0NVXVgQDpHOd9UA1Rl3rPNfi8jB8ikEzK7m0IyxGpYI6SXeQ39SuAvvQ4jlmdfWbydL9ocuDFqLq5SF25Ua8/2dxgOo/32rJ69fqMVf1hL5DbgmQ9ovV2gM5ZpEwrN07TJzxP9tRlsCgz2Fk8S/pNQXKNkqfbrXTzM9GkSPWIptrQJ/QviOEtP5I7jZNV+hq7ZbUXyHAXTvuy0IoKVk5BoC4GhqDO3MlPBtf6EdeJqhUcHbH/DyJIWTUUTkddBynSJloMgTJsVNGLxByBcDl6W6SiyBuAsv7f35tWFYgfNBBYVQLZpgf44Ftu/AnmivZdk2wksrdGmHBd5/gi3tIRqRyG7OPU/6H1RHW97DmTjFozaaspLxsTjjSzA9uhJ/jvFBphol3p+gD8Jui0shHtnjU561eaWwGkJUij9rgIY8kO3cFipIPAgGC0a9kK1s6GMrjTulyr+whmng3fVz6K1LUWS+hp0pmDW/hssDAAz5xg3cAp+4vXaPt4fIYSB0dsLfjvdIx986oEsvK+cOP6ex9HXDU/n8gpQYw7xQQY+gczpj0mbycf21YlxfLQryXWXaQCxGtPY3q8RkmJnNbLgQ1P2CxRehWpONoOEEb1qrL+C99+pcyB6q8hCE26Z919FSmj4Es SB1uvjal MQ1kwTcJTOTThUtmwbvRjX9IBp0/sEnvQyxhHirUhdnjQhwNTNHA3aIk1L+HIk1UIfuPu4kYhPAbzgCU49yUHbrs6Bo4mCMt7b78GpElkYk4p7jurg+YvphV/hCO35mKqMK58n1n/zJX2FSeaT83Ti0uWC/VXJzquqAPHhgYxobGKvH99Xa9w4wVpcfQxcWAM89PBlnyA0IxE2TcAPOYlE2UVIo1cYzdeggsO6Q9aFkrVQ/+pR6iYwF0VUuEYEMmSiObHKdHOjpilaKc6LyAGRVpo1mAy62uTRiAaiSjHyMKhLi+GDV8l3ztEgQXmBoYxrHGeirdN6joWgvNsqVb4VzX6MlxJ+/hclgBVsDyfEtFkGYwWxukUMrSAqRTqm38zQtooLtnCk5UWwzEFPd/rDKgmp/PMRQKW5me5RKfOIQVQz4+iTBL6dfExO3/OdazHXtPTmaX7EC5MGXPp1Uh0o2NI2r3sXtTefcef6t/skVwUYXwNyFKRnHJ6ye8ig0SenhKosp+OIBqrjGFvHLxLBMCeTc5McggRW9fXMnPUykw99/6sVtOTrMc9/PZR4YVyLL5Hb0wvPK9KNs0C2lFzBxHTstZDsNDD0/Mg7og1Xz3uYJ928lGWegk+govC93qZmQeGI/1fh7+iP6GsHoUSMsBzwInsUNfJGzEZfx1qt/QjMA1pQkhqdnucubM+fgjTBya453cJ7vYuhGFKKLsuSfJMk0rYRuw+DvT0XZhnRhqRkualXyxOWPfwu9FRWrjTfkPweYJ1jfdBebwkRyxZN354UZ9VsbT3wzbfDEJm0qeVfJVppaghOl1tD4Xu++I6YYWltEEd2v6BOv5A8oQsZWaKsg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Sep 18, 2025 at 12:45:38PM -0700, Chris Mason wrote: > On Wed, 10 Sep 2025 21:22:11 +0100 Lorenzo Stoakes wrote: > > > We can use the mmap insert pages functionality provided for use in > > mmap_prepare to insert the kcov pages as required. > > > > This does necessitate an allocation, but since it's in the mmap path this > > doesn't seem egregious. The allocation/freeing of the pages array is > > handled automatically by vma_desc_set_mixedmap_pages() and the mapping > > logic. > > > > Signed-off-by: Lorenzo Stoakes > > --- > > kernel/kcov.c | 42 ++++++++++++++++++++++++++---------------- > > 1 file changed, 26 insertions(+), 16 deletions(-) > > > > diff --git a/kernel/kcov.c b/kernel/kcov.c > > index 1d85597057e1..2bcf403e5f6f 100644 > > --- a/kernel/kcov.c > > +++ b/kernel/kcov.c > > @@ -484,31 +484,41 @@ void kcov_task_exit(struct task_struct *t) > > kcov_put(kcov); > > } > > > > -static int kcov_mmap(struct file *filep, struct vm_area_struct *vma) > > +static int kcov_mmap_error(int err) > > +{ > > + pr_warn_once("kcov: vm_insert_page() failed\n"); > > + return err; > > +} > > + > > +static int kcov_mmap_prepare(struct vm_area_desc *desc) > > { > > int res = 0; > > - struct kcov *kcov = vma->vm_file->private_data; > > - unsigned long size, off; > > - struct page *page; > > + struct kcov *kcov = desc->file->private_data; > > + unsigned long size, nr_pages, i; > > + struct page **pages; > > unsigned long flags; > > > > spin_lock_irqsave(&kcov->lock, flags); > > size = kcov->size * sizeof(unsigned long); > > - if (kcov->area == NULL || vma->vm_pgoff != 0 || > > - vma->vm_end - vma->vm_start != size) { > > + if (kcov->area == NULL || desc->pgoff != 0 || > > + vma_desc_size(desc) != size) { > > res = -EINVAL; > > goto exit; > > } > > spin_unlock_irqrestore(&kcov->lock, flags); > > - vm_flags_set(vma, VM_DONTEXPAND); > > - for (off = 0; off < size; off += PAGE_SIZE) { > > - page = vmalloc_to_page(kcov->area + off); > > - res = vm_insert_page(vma, vma->vm_start + off, page); > > - if (res) { > > - pr_warn_once("kcov: vm_insert_page() failed\n"); > > - return res; > > - } > > - } > > + > > + desc->vm_flags |= VM_DONTEXPAND; > > + nr_pages = size >> PAGE_SHIFT; > > + > > + pages = mmap_action_mixedmap_pages(&desc->action, desc->start, > > + nr_pages); > > Hi Lorenzo, > > Not sure if it belongs here before the EINVAL tests, but it looks like > kcov->size doesn't have any page alignment. I think size could be > 4000 bytes other unaligned values, so nr_pages should round up. Thanks, you may well be right, but but this series has been respun and I no longer touch kcov. :) Am at v4 now - https://lore.kernel.org/linux-mm/cover.1758135681.git.lorenzo.stoakes@oracle.com/ - apologies for the quick turnaround but going to kernel recipes soon and then on vacation so wanted to get this wrapped up! > > -chris Cheers, Lorenzo