From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4271AC77B76 for ; Mon, 17 Apr 2023 19:02:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 958BC6B0071; Mon, 17 Apr 2023 15:02:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9083F6B0072; Mon, 17 Apr 2023 15:02:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7D0558E0001; Mon, 17 Apr 2023 15:02:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 7041A6B0071 for ; Mon, 17 Apr 2023 15:02:27 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 55B6A406F9 for ; Mon, 17 Apr 2023 19:02:27 +0000 (UTC) X-FDA: 80691803934.30.E691278 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf13.hostedemail.com (Postfix) with ESMTP id 9A4A820016 for ; Mon, 17 Apr 2023 19:02:24 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=VMALOtZo; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=GMsCwVu6; spf=pass (imf13.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681758145; a=rsa-sha256; cv=none; b=N2BtY+YlqYHdrKKsLZqHWvKjPI7qjLvLHwjEQOmLcS4odNAjUu9dJZgZhPgA9MMEweb9Qv MKGi7iK6cnmDbKMDp0pxRgXjM+qiecfAJujIheTeUNkSbFsDn2qQ805hYE77M2qnp2KQhu dtN+tg3ILf9HiYPGNHHHqbSozTksOak= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=VMALOtZo; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=GMsCwVu6; spf=pass (imf13.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681758145; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+Bm/TkpcMy6cuYGFixPMtHN6GQvyYrnWfVkOFEnqjaw=; b=Sb2cHUhyiPeBtEluco5D3t/v1qGlda2f98QJ0/ZIH7wcLHr8OAKRCqvRvrjN8qUBxrY8Fx RF19ut+bQgTbRkYzjx81ZSfX1N8E2coV2yI7ui1i3liWrdXa+b3DOT0Nn4G65z9ISyvx65 W5+8ga1F4l6ECTFjbyYT/7DKJTqG4+0= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 08A5B1F85D; Mon, 17 Apr 2023 19:02:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1681758143; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+Bm/TkpcMy6cuYGFixPMtHN6GQvyYrnWfVkOFEnqjaw=; b=VMALOtZopBgD/6l2GDTO7VzUHOBAFNMokUNAQT3o2i/7q+iRcJvNU1/wGkUHrBSH+vsG1c g3oX0FMqF8FQ4nmXN/26AQcAN/vKgHXLL9w9T/gYyXpnk/LSOKOqJld+dq7Yv8s10l01DZ S0utMIsut+u6oc9PfaTU9jQ3jswZ1F4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1681758143; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+Bm/TkpcMy6cuYGFixPMtHN6GQvyYrnWfVkOFEnqjaw=; b=GMsCwVu6HWh2dPz+S/L4pxzYt++4V7dmJTdQEF2RC7ffeASZHg5UUFOap5IwuJOyI7XJTU WfNRFCPcGSp4TfCQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E012013319; Mon, 17 Apr 2023 19:02:22 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id rB4YNr6XPWQxIwAAMHmgww (envelope-from ); Mon, 17 Apr 2023 19:02:22 +0000 Message-ID: <17bbab58-3cde-e980-bdeb-b9de65848b2e@suse.cz> Date: Mon, 17 Apr 2023 21:02:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v2 2/2] mm/slab: break up RCU readers on SLAB_TYPESAFE_BY_RCU example code Content-Language: en-US To: SeongJae Park , Matthew Wilcox Cc: akpm@linux-foundation.org, paulmck@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230417190129.1454-1-sj@kernel.org> From: Vlastimil Babka In-Reply-To: <20230417190129.1454-1-sj@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 9A4A820016 X-Rspamd-Server: rspam01 X-Stat-Signature: mzqojfffxd1i83yxmz76kb8i8xkyrcj1 X-HE-Tag: 1681758144-508618 X-HE-Meta: U2FsdGVkX1+34736nXJjQZOXcHcL4q+Lmd3AZB4z21xHIftm6XZ6fKej7fqO7eOe3iCmHvG0n05c89EgvWABjr7SdK4N/fAwDLPQV3JLzXEPIdTt3/o/42JBVaDeg3n9Wm2o7prj9ALe05foMP10v5q1cP9YtIkPWK7K5o30yDyfN6KhAuG5OciSCmXZ/AopdU8IxB7KTX7wK/5vo47tTbj5ASTfo2HP+G2Ops+Eo+8zBSwyLdb7GB5E4j1F1fApCTioB1L1reNS+dGZay8N8tW0c805S9BtEb6glSWC5kl3hi44q1PUXTtfm/3HiVPVjYy2iQie8fi0mlqdLl/uLdCBUG+QK2Y6oel1C8pywBllc53ADr4tLoNfK2X+SqE/ZcETzAnxEvRWjsOxfbk03Bi38Rgk8p3GdDMGMWqhJIY0Jv7I/BgMN8CgKKSuZ83TkuZCcVthNzyZ1Mn2ZEz9l01QDX6rE4DA/xVd/NB9Hbum4h8REdY2DLRoMmTNsE7Adxboqn3N8IEem3XsWTuOMq51vUtpXTBJ3EtxmDZZUXGr2toYk9eXvXeTl4OBxL1sLxCb8xCgnzp96YOAnEpDl5X8KiWHt04J5Sch495QvFdCxs/fRP0zDsKPMD8H82OgdQSq8DrkTJ5RpsQt6l7F3T+bOPkMj6PhVjmYdryQUJ8Bn/MUjN+kquvPuVgS53udNLrMt5WkC7H4ChUct3dE/Sg/Sj47ou7mwGRlerAsN/mqxNEANbUoHzAjQl+G4xEWxHr0Ydk6EA5Pw3wgWDVjLFvQ/YBGxFCsSmIwv1LNTYpN87Ge70saVlVzKG4v5cx69/xOc5oM5BFQvdrGVEn+pXjaNLze6WjtTjbAtUrP7xn8RhZwGf+sGppFA/CPqHEHOuf/pr/gaRywhHV24EkQvd/dnfOe00+ts19TZkOHo3IBw5+K8JKhkBXjIJD2giiDsd1PLs1TOizkl5VsoBW U0am2T3G 9oP6cJ0eI5/j0uz3svPzTURc2eD992bUek0y7cGf8CGG0X8GgTpHP7ryrMMrHcmA8ciNc2/kuV6SOfZYJeVgA/jgJx2DVxgfESGoUbxJGrPVhItgQnRknKRf/I8HZpRk6Xr5o+oiAY2l1OUknlQj1grhOVOpuMd+hMATDfE3Dp6RnhaEAY35jQ3uITHkINIgHfyA3qTy9fstMGJaPwLx9XAV7qMUftHiV7Z6Kxxi5UG6XKZvkg/N6v/1yi3mHu+Li78P3pzyOfL9aqhe28fSVyXGDotp2FPNGcbu9NAwZdV5k60XEthc6kmZZwpm88RkT8OCE X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 4/17/23 21:01, SeongJae Park wrote: > On Mon, 17 Apr 2023 18:53:24 +0100 Matthew Wilcox wrote: > >> On Mon, Apr 17, 2023 at 05:26:57PM +0000, SeongJae Park wrote: >> > Hi Vlastimil, >> > >> > On Mon, 17 Apr 2023 13:05:40 +0200 Vlastimil Babka wrote: >> > >> > > On 4/15/23 05:31, SeongJae Park wrote: >> > > > The SLAB_TYPESAFE_BY_RCU example code snippet is having not tiny RCU >> > > >> > > Since "tiny RCU" means something quite specific in the RCU world, it can be >> > > confusing to read it in this sense. We could say e.g. "... snippet uses a >> > > single RCU read-side critical section for retries"? >> > >> > Looks much better, thank you for this suggestion! >> > >> > > >> > > > read-side critical section. 'Documentation/RCU/rculist_nulls.rst' has >> > > > similar example code snippet, and commit da82af04352b ("doc: Update and >> > > > wordsmith rculist_nulls.rst") has broken it. >> > > >> > > "has broken it" has quite different meaning than "has broken it up" :) I >> > > guess we could just add the "up", unless someone has an even better wording. >> > >> > Good point, thank you for your suggestion! >> > >> > I will apply above suggestion on the next spin. >> >> For the last one, perhaps changing the tense would have more clarity: >> >> similar example code snippet, and commit da82af04352b ("doc: Update and >> wordsmith rculist_nulls.rst") broke it up. > > Thank you for this suggestion, Matthew! Will send a new version. It's ok, I can just use that when picking the patches up without a new resend. > Thanks, > SJ